danger-android_version_change 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 23ca31f593cedee62a2cf6022675f7edb4f60a80b65ba503bde17faa5a9bd3e1
-  data.tar.gz: cd6b3ba0136c8c766e681531ec0af6fdb6b6628f11d742b7a9868698a75cd2d0
+  metadata.gz: 7ae3cf66485d4fa93c348e916f35e406875d728179b7ffe399f02a0fd4829c30
+  data.tar.gz: 6f91ba3ae0906c7bdc9bf9da8177fedf112b822874b43063524061fb7c0ea7ca
 SHA512:
-  metadata.gz: 9b6c557b856fe751c15bd01a0b9b0fe342e5034fb9dbc12bdc25c7e8953173c29656a279465327f79dfec3336e7ed855cf876302b9c88fbd773d6d2caa68a526
-  data.tar.gz: 837f79b58cbe0a78ad9ea53a46ef77541524d6f4e9f47443fb0b14e99d1e9cfa025712a79666568c47030d30c8377b90a77e6b4a6ffa568a8a2e82ea3ceecfa4
+  metadata.gz: 2e89455a45a9768c4c29f66172d06a896762a0a8f7ca8f4ff9144e0e5fbe36e58d4131e40a3d2bb18f4f6e71daf45a0378b8dfdd398b2da440c4b4bc785ffd96
+  data.tar.gz: 8b81e38663b8fb4856d559006b5a6e3c950791dd4749652612fa057f6cc40f8ed7412683627e62543b254269d441845093b19194ebe6514cbaac68015a5e08df

data/.circleci/config.yml

@@ -23,7 +23,7 @@ jobs:
       - checkout
       - run: ./assert_danger_running_on_pr.sh
       - run: bundle install
-      - run: '[ ! -z $DANGER_GITHUB_API_TOKEN ] && danger || echo "Skipping Danger for External Contributor"'
+      - run: '[ ! -z $DANGER_GITHUB_API_TOKEN ] && danger --fail-on-errors=true || echo "Skipping Danger for External Contributor"'
   test-lint:
     working_directory: ~/code
     docker:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    danger-android_version_change (0.1.0)
+    danger-android_version_change (0.1.1)
       danger-plugin-api (~> 1.0)
 
 GEM
@@ -68,7 +68,7 @@ GEM
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.7.0)
+    octokit (4.8.0)
       sawyer (~> 0.8.0, >= 0.5.3)
     open4 (1.3.4)
     parallel (1.12.0)
@@ -132,7 +132,7 @@ DEPENDENCIES
   rspec (~> 3.4)
   rspec_junit_formatter (~> 0.3.0)
   rubocop (~> 0.49)
-  yard (~> 0.8)
+  yard (~> 0.9.11)
 
 BUNDLED WITH
    1.16.0

data/danger-android_version_change.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
 
   # Linting code and docs
   spec.add_development_dependency "rubocop", "~> 0.49"
-  spec.add_development_dependency "yard", "~> 0.8"
+  spec.add_development_dependency "yard", "~> 0.9.11"
 
   # Makes testing easy via `bundle exec guard`
   spec.add_development_dependency 'guard', '~> 2.14'

data/lib/android_version_change/gem_version.rb

@@ -1,3 +1,3 @@
 module AndroidVersionChange
-  VERSION = "0.1.0".freeze
+  VERSION = "0.1.1".freeze
 end

data/lib/android_version_change/plugin.rb

@@ -20,6 +20,8 @@ module Danger
       "android_version_change"
     end
 
+    DEFAULT_BUILD_GRADLE_FILE_PATH = "app/build.gradle".freeze
+
     def initialize(dangerfile)
       super(dangerfile)
     end
@@ -42,14 +44,12 @@ module Danger
     # (Internal use) Takes path to build.gradle as well as "versionName" or "versionCode" string to check for change.
     # @return [void]
     def assert_version_changed(override_build_gradle_file_path, name_or_code)
-      build_gradle_file_path = override_build_gradle_file_path || "app/build.gradle"
-
-      unless File.file?(build_gradle_file_path)
-        fail "build.gradle file at path " + build_gradle_file_path + " does not exist."
+      unless File.file?(override_build_gradle_file_path)
+        fail "build.gradle file at path " + override_build_gradle_file_path + " does not exist."
         return # rubocop:disable UnreachableCode
       end
 
-      unless git.diff_for_file(build_gradle_file_path) # No diff found for build.gradle file.
+      unless git.diff_for_file(override_build_gradle_file_path) # No diff found for build.gradle file.
         fail "You did not edit your build.gradle file at all. Therefore, you did not change the " + name_or_code + "."
         return # rubocop:disable UnreachableCode
       end
@@ -70,7 +70,7 @@ module Danger
     # @param [String] override_build_gradle_file_path
     #        (optional) Path to build.gradle file for Android project that versionName is located in.
     # @return [void]
-    def assert_version_name_changed(override_build_gradle_file_path)
+    def assert_version_name_changed(override_build_gradle_file_path = DEFAULT_BUILD_GRADLE_FILE_PATH)
       assert_version_changed(override_build_gradle_file_path, "versionName")
     end
 
@@ -86,7 +86,7 @@ module Danger
     # @param [String] override_build_gradle_file_path
     #        (optional) Path to build.gradle file for Android project that versionCode is located in.
     # @return [void]
-    def assert_version_code_changed(override_build_gradle_file_path)
+    def assert_version_code_changed(override_build_gradle_file_path = DEFAULT_BUILD_GRADLE_FILE_PATH)
       assert_version_changed(override_build_gradle_file_path, "versionCode")
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-android_version_change
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Levi Bostian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-19 00:00:00.000000000 Z
+date: 2017-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: 0.9.11
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement