danger-android_permissions_checker 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fdf24f242e47cdb8747df24c5bd11582e1d39fc796c9b69594dd8557f7422be0
-  data.tar.gz: c4613888afe9b9d5cd19cd01ad8f899473f79361f8c012f9cb27523e15bcbb75
+  metadata.gz: 26d593c45170d3f8e0d46bde541d8cefc81e5596c026cd58d6c1cf0c9254f930
+  data.tar.gz: a9f90f3673ba04bb47e51d3fdff462991fc0b375571520141ba4108764f8856a
 SHA512:
-  metadata.gz: fd9a62832f25f7e35ecacd1540ffeceae187dc088f94856581cb890bcfee70f947073bcd8a6ce8a4220cee1b7d88d00ca912fd7cdcf3104eb0b54d3891478f69
-  data.tar.gz: 28fb881a56412ecebe8d938440f917a3cca6c03a3ca0ea42accce1cb74fad5b63d255b8fcd36bff633478018541c35c80b37d4bb766b09413117c9d49a884c35
+  metadata.gz: 5803cd6d6f55c62f8767d8cf08e1ccc89f3344bce3b4228dd32b8e36bc8f34f923b5982a300a45252b68aaed156d19c49e42cd96adbb01a850a805d8b348a410
+  data.tar.gz: ef06d442a6631b0f73646e14874f4ad18b4743aa5df45aeb66ea27f210aeab56e8f3efb694b170c083804cc78ea5522c474b6e945488f73a08286e4e26881fe7

data/.travis.yml

@@ -2,11 +2,7 @@ language: ruby
 cache:
   directories:
     - bundle
-
 rvm:
-  - 2.0
-  - 2.1.3
-  - 2.3.1
-
+  - 2.5.1
 script:
-    - bundle exec rake spec
+    - bundle exec rspec spec

data/README.md

@@ -12,10 +12,10 @@ Check permissions between current permissions and apk generated on CI service. i
 
 ## Usage
 
-Create permission list file of your apk using aapt, like this.
+Create current permission list file of your apk using aapt, like this.
 
 ```bash
-$ aapt d permissions /path/to/release_apk > permissions.txt
+$ aapt d permissions /path/to/apk > permissions.txt
 ```
 
 Add this to Dangerfile. Specify apk generated by CI service and permission list file generated by above command.
@@ -23,7 +23,7 @@ Add this to Dangerfile. Specify apk generated by CI service and permission list
 ```
 android_permissions_checker.check(
   apk: '/path/to/generated_apk_by_CI',
-  permission_list_file: /path/to/generated_permission_list
+  permission_list_file: /path/to/permissions.txt
 )
 ```
 

data/lib/android_permissions_checker/gem_version.rb

@@ -1,3 +1,3 @@
 module AndroidPermissionsChecker
-  VERSION = "0.0.1".freeze
+  VERSION = "0.0.2".freeze
 end

data/lib/android_permissions_checker/plugin.rb

@@ -1,5 +1,3 @@
-require 'fileutils'
-
 module Danger
   class DangerAndroidPermissionsChecker < Plugin
     def check(apk: nil, permission_list_file: nil)
@@ -21,7 +19,7 @@ module Danger
       deleted = current_permissions - generated_permissions
       added = generated_permissions - current_permissions
       message = ""
-      
+
       if deleted.length > 0
         message += "### Deleted permissions\n"
         deleted.each do |v|
@@ -40,7 +38,7 @@ module Danger
 
       unless message.empty?
         markdown(message)
-        warn('APK permissions changed, see below.')
+        warn("APK permissions changed, see below. Should update `#{permission_list_file}` if it is intended change.")
       end
     end
   end

data/spec/android_permissions_checker_spec.rb

@@ -4,7 +4,7 @@ module Danger
   describe Danger::DangerAndroidPermissionsChecker do
     let(:dangerfile) { testing_dangerfile }
     let(:plugin) { dangerfile.android_permissions_checker }
-    
+
     it "should be a plugin" do
       expect(Danger::DangerAndroidPermissionsChecker.new(nil)).to be_a Danger::Plugin
     end
@@ -27,7 +27,7 @@ module Danger
       end
 
       before do
-        allow(current_permission_file).to receive(:nil?).and_return(false) 
+        allow(current_permission_file).to receive(:nil?).and_return(false)
         allow(apk).to receive(:nil?).and_return(false)
         allow(File).to receive(:exist?).with(current_permission_file).and_return(true)
         allow(File).to receive(:exist?).with(apk).and_return(true)
@@ -49,7 +49,7 @@ module Danger
         it do
           plugin.check(apk: apk, permission_list_file: current_permission_file)
           expect(dangerfile.status_report[:warnings].length).to eq(1)
-          expect(dangerfile.status_report[:warnings][0]).to eq('APK permissions changed, see below.')
+          expect(dangerfile.status_report[:warnings][0]).to eq("APK permissions changed, see below. Should update `#{current_permission_file}` if it is intended change.")
           expect(dangerfile.status_report[:markdowns][0].message).not_to include('Deleted')
           expect(dangerfile.status_report[:markdowns][0].message).to include('Added')
 
@@ -64,7 +64,7 @@ module Danger
         it do
           plugin.check(apk: apk, permission_list_file: current_permission_file)
           expect(dangerfile.status_report[:warnings].length).to eq(1)
-          expect(dangerfile.status_report[:warnings][0]).to eq('APK permissions changed, see below.')
+          expect(dangerfile.status_report[:warnings][0]).to include('APK permissions changed, see below.')
           expect(dangerfile.status_report[:markdowns][0].message).to include('Deleted')
           expect(dangerfile.status_report[:markdowns][0].message).not_to include('Added')
         end
@@ -78,7 +78,7 @@ module Danger
         it do
           plugin.check(apk: apk, permission_list_file: current_permission_file)
           expect(dangerfile.status_report[:warnings].length).to eq(1)
-          expect(dangerfile.status_report[:warnings][0]).to eq('APK permissions changed, see below.')
+          expect(dangerfile.status_report[:warnings][0]).to include('APK permissions changed, see below.')
           expect(dangerfile.status_report[:markdowns][0].message).to include('Deleted')
           expect(dangerfile.status_report[:markdowns][0].message).to include('Added')
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-android_permissions_checker
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - mataku
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-27 00:00:00.000000000 Z
+date: 2018-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger-plugin-api
@@ -122,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: A Danger plugin to check diff of android apk permissions.