danger-android_lint 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bc51ff27951c956c5534a2adc9219db6ef8b23ea
-  data.tar.gz: 162c31a66338d95c2d184864ad9cbbb02377668c
+  metadata.gz: 6b36a61666df12470b0fc5a17a3a913095481058
+  data.tar.gz: 03ac321fa2d92734fc70fb8f4b173f2a6a002433
 SHA512:
-  metadata.gz: e34ff70dab0f608b3bfd09aa5f3ec7e3a83812fa95f3597bbb88c67d6e3854991caf156f61ec652f7415509082731665c1bc8060dc912e98761e06f0a1728b6b
-  data.tar.gz: 53601dfb052fed83d66a369edfc6843759d47c9786f9bd477a65f84fb1208815f9c1a8cc66067b8de597755dfa3fb47848cff8f75ea08848737822f8d6e34374
+  metadata.gz: 8542399b5d4775d5c027c8947a3ed9b6391481a2ffc73a47d25a797c14eccec19ad9e54702a0bef64ebc84f13eaa6c80e5b5ad84716b56cf0bf70c70c0079c09
+  data.tar.gz: 73425c72e31d2cc71bc5d0eb314574f494e8f5e2856447c087ed843d98b66b5388e501bf06226b3047065c47b8413ca94033caeba44f657ee2abc7ae5e5328d4

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.0.5
+- Fix count number for issues ([@jettbow](https://github.com/jettbow))
+- Add option for skipping gradle task ([@litmon](https://github.com/litmon))
+
 # 0.0.4
 - Add `filtering` parameter, default to false, to run lint only on modified files ([@leonhartX](https://github.com/leonhartX))
 - Add support for GitHub's inline comments ([@leonhartX](https://github.com/leonhartX))

data/Gemfile.lock

@@ -1,48 +1,49 @@
 PATH
   remote: .
   specs:
-    danger-android_lint (0.0.1)
+    danger-android_lint (0.0.5)
       danger-plugin-api (~> 1.0)
       oga
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.5.0)
-      public_suffix (~> 2.0, >= 2.0.2)
+    addressable (2.5.2)
+      public_suffix (>= 2.0.2, < 4.0)
     ansi (1.5.0)
     ast (2.3.0)
-    claide (1.0.1)
+    claide (1.0.2)
     claide-plugins (0.9.2)
       cork
       nap
       open4 (~> 1.3)
-    coderay (1.1.1)
-    colored (1.2)
-    cork (0.2.0)
-      colored (~> 1.2)
-    danger (4.0.1)
+    coderay (1.1.2)
+    colored2 (3.1.2)
+    cork (0.3.0)
+      colored2 (~> 3.1)
+    danger (5.5.5)
       claide (~> 1.0)
       claide-plugins (>= 0.9.2)
-      colored (~> 1.2)
+      colored2 (~> 3.1)
       cork (~> 0.1)
       faraday (~> 0.9)
       faraday-http-cache (~> 1.0)
       git (~> 1)
       kramdown (~> 1.5)
-      octokit (~> 4.2)
+      no_proxy_fix
+      octokit (~> 4.7)
       terminal-table (~> 1)
     danger-plugin-api (1.0.0)
       danger (> 2.0)
-    diff-lcs (1.2.5)
-    faraday (0.10.0)
+    diff-lcs (1.3)
+    faraday (0.13.1)
       multipart-post (>= 1.2, < 3)
     faraday-http-cache (1.3.1)
       faraday (~> 0.8)
-    ffi (1.9.14)
+    ffi (1.9.18)
     formatador (0.2.5)
     git (1.3.0)
-    guard (2.14.0)
+    guard (2.14.1)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (~> 1.0)
@@ -56,70 +57,72 @@ GEM
       guard (~> 2.1)
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
-    kramdown (1.13.0)
+    kramdown (1.16.2)
     listen (3.0.7)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9.7)
-    lumberjack (1.0.10)
-    method_source (0.8.2)
+    lumberjack (1.0.12)
+    method_source (0.9.0)
     multipart-post (2.0.0)
     nap (1.1.0)
     nenv (0.3.0)
+    no_proxy_fix (0.1.2)
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    octokit (4.6.2)
+    octokit (4.7.0)
       sawyer (~> 0.8.0, >= 0.5.3)
-    oga (2.7)
+    oga (2.11)
       ast
       ruby-ll (~> 2.1)
     open4 (1.3.4)
-    parser (2.3.1.4)
-      ast (~> 2.2)
+    parallel (1.12.0)
+    parser (2.4.0.2)
+      ast (~> 2.3)
     powerpack (0.1.1)
-    pry (0.10.4)
+    pry (0.11.3)
       coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    public_suffix (2.0.4)
-    rainbow (2.1.0)
+      method_source (~> 0.9.0)
+    public_suffix (2.0.5)
+    rainbow (2.2.2)
+      rake
     rake (10.5.0)
-    rb-fsevent (0.9.8)
-    rb-inotify (0.9.7)
-      ffi (>= 0.5.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    rb-fsevent (0.10.2)
+    rb-inotify (0.9.10)
+      ffi (>= 0.5.0, < 2)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.0)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.45.0)
-      parser (>= 2.3.1.1, < 3.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    rubocop (0.50.0)
+      parallel (~> 1.10)
+      parser (>= 2.3.3.1, < 3.0)
       powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
+      rainbow (>= 2.2.2, < 3.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-ll (2.1.2)
       ansi
       ast
-    ruby-progressbar (1.8.1)
+    ruby-progressbar (1.9.0)
     sawyer (0.8.1)
       addressable (>= 2.3.5, < 2.6)
       faraday (~> 0.8, < 1.0)
     shellany (0.0.1)
-    slop (3.6.0)
-    terminal-table (1.7.3)
-      unicode-display_width (~> 1.1.1)
-    thor (0.19.1)
-    unicode-display_width (1.1.1)
-    yard (0.9.5)
+    terminal-table (1.8.0)
+      unicode-display_width (~> 1.1, >= 1.1.1)
+    thor (0.20.0)
+    unicode-display_width (1.3.0)
+    yard (0.9.12)
 
 PLATFORMS
   ruby
@@ -133,8 +136,8 @@ DEPENDENCIES
   pry
   rake (~> 10.0)
   rspec (~> 3.4)
-  rubocop (~> 0.41)
+  rubocop (~> 0.49)
   yard (~> 0.8)
 
 BUNDLED WITH
-   1.12.5
+   1.16.0

data/README.md

@@ -49,6 +49,13 @@ android_lint.gradle_task = "lintMyFlavorDebug"
 android_lint.lint
 ```
 
+If you want to skip gradle task, setting the `skip_gradle_task` parameter to `true`.
+
+```rb
+android_lint.skip_gradle_task = true
+android_lint.lint
+```
+
 #### Changing report's severity level
 
 If you want to filter lint issues based on their severity level, you can do that by setting a value to `severity`. Bear in mind that you are filtering issues by the severity level you've set **and up**. Possible values are `Warning`, `Error` and `Fatal`. Default is `Warning` (which is everything).

data/danger-android_lint.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.4'
 
   # Linting code and docs
-  spec.add_development_dependency "rubocop", "~> 0.41"
+  spec.add_development_dependency "rubocop", "~> 0.49"
   spec.add_development_dependency "yard", "~> 0.8"
 
   # Makes testing easy via `bundle exec guard`

data/lib/android_lint/gem_version.rb

@@ -1,3 +1,3 @@
 module AndroidLint
-  VERSION = "0.0.4".freeze
+  VERSION = "0.0.5".freeze
 end

data/lib/android_lint/plugin.rb

@@ -54,6 +54,9 @@ module Danger
     # Only show messages within changed files.
     attr_accessor :filtering
 
+    # Skip gradle task
+    attr_accessor :skip_gradle_task
+
     # Calls lint task of your gradle project.
     # It fails if `gradlew` cannot be found inside current directory.
     # It fails if `severity` level is not a valid option.
@@ -61,7 +64,7 @@ module Danger
     # @return [void]
     #
     def lint(inline_mode: false)
-      unless gradlew_exists?
+      if !skip_gradle_task && !gradlew_exists?
         fail("Could not find `gradlew` inside current directory")
         return
       end
@@ -71,7 +74,7 @@ module Danger
         return
       end
 
-      system "./gradlew #{gradle_task || 'lint'}"
+      system "./gradlew #{gradle_task || 'lint'}" unless skip_gradle_task
 
       unless File.exists?(report_file)
         fail("Lint report not found at `#{report_file}`. "\
@@ -86,7 +89,7 @@ module Danger
         send_inline_comment(filtered_issues)
       else
         message = message_for_issues(filtered_issues)
-        markdown(message) unless filtered_issues.empty?
+        markdown("### AndroidLint found issues\n\n" + message) unless message.to_s.empty?
       end
     end
 
@@ -118,7 +121,7 @@ module Danger
     end
 
     def message_for_issues(issues)
-      message = "### AndroidLint found issues\n\n"
+      message = ""
 
       SEVERITY_LEVELS.reverse.each do |level|
         filtered = issues.select{|issue| issue.get("severity") == level}
@@ -131,10 +134,8 @@ module Danger
     def parse_results(results, heading)
       target_files = (git.modified_files - git.deleted_files) + git.added_files
       dir = "#{Dir.pwd}/"
-      message = "#### #{heading} (#{results.count})\n\n"
-
-      message << "| File | Line | Reason |\n"
-      message << "| ---- | ---- | ------ |\n"
+      count = 0;
+      message = ""
 
       results.each do |r|
         location = r.xpath('location').first
@@ -142,9 +143,15 @@ module Danger
         next unless !filtering || (target_files.include? filename)
         line = location.get('line') || 'N/A'
         reason = r.get('message')
-
+        count = count + 1
         message << "`#{filename}` | #{line} | #{reason} \n"
       end
+      if count != 0
+        header = "#### #{heading} (#{count})\n\n"
+        header << "| File | Line | Reason |\n"
+        header << "| ---- | ---- | ------ |\n"
+        message = header + message
+      end
 
       message
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-android_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Gustavo Barbosa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-01 00:00:00.000000000 Z
+date: 2017-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oga
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: '0.49'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.41'
+        version: '0.49'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement