danger-android_lint 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6032c641b6bfe75156ded93357b0108d7f52cd37
-  data.tar.gz: 4e3a4911b701879fa141df99552cbaed3dee7da7
+  metadata.gz: 14a8b24ca402a1f8615991280e363bf0fe02eb9d
+  data.tar.gz: 4be292fab2a1db392f729bda485a831f1533c611
 SHA512:
-  metadata.gz: 30cdfffe72726c2ae90796f052cd330cf31dc4d336c5d57e59bf38ef57f5e22375faaf81704180c5f3d5399b54a899713d8575a29771aeeb754a65602baac75f
-  data.tar.gz: ae790c26a696b6331ae9e19f5c0000c2a572888d6a3f29931153b98ac6e844b32b2b0c281739c749a9546b16264df4cae680ed759e84e7dbbb4e1bfb03412b5c
+  metadata.gz: f5842a73db7eaac24acc5a704c582bbbcd690b95499392f57214e45fb6bd9eb71dbd510cc17456017922823a1544bda1bf8ee63dd62371cd1c47bdbc06c48301
+  data.tar.gz: 205b8756e1b4f3fdf34256b4baa551475fcec0e5ec239dc68fde22616856c6ae7052b44b66bd9898d6683c5aceeba93e44a7cef7d8427a715ef0f6d2fbada307

data/CHANGELOG.md

@@ -1,6 +1,9 @@
+# 0.0.3
+- Add `report_file` parameter, so users can set a custom path for their report xmls (@churowa)
+
 ## 0.0.2
-- Fix check for inexistent report file
-- Fix markdown message being printed without any issues reported
+- Fix check for inexistent report file (@barbosa)
+- Fix markdown message being printed without any issues reported (@barbosa)
 
 ## 0.0.1
-- Initial version
+- Initial version (@barbosa)

data/lib/android_lint/gem_version.rb

@@ -1,3 +1,3 @@
 module AndroidLint
-  VERSION = "0.0.2".freeze
+  VERSION = "0.0.3".freeze
 end

data/lib/android_lint/plugin.rb

@@ -25,7 +25,17 @@ module Danger
   class DangerAndroidLint < Plugin
 
     SEVERITY_LEVELS = ["Warning", "Error", "Fatal"]
-    REPORT_FILE = "app/build/reports/lint/lint-result.xml"
+
+    # Location of lint report file
+    # If your Android lint task outputs to a different location, you can specify it here.
+    # Defaults to "app/build/reports/lint/lint-result.xml".
+    # @return [String]
+    attr_accessor :report_file
+    # A getter for `report_file`.
+    # @return [String]
+    def report_file
+      return @report_file || 'app/build/reports/lint/lint-result.xml'
+    end
 
     # Custom gradle task to run.
     # This is useful when your project has different flavors.
@@ -59,8 +69,8 @@ module Danger
 
       system "./gradlew #{gradle_task || 'lint'}"
 
-      unless File.exists?(REPORT_FILE)
-        fail("Lint report not found at `#{REPORT_FILE}`. "\
+      unless File.exists?(report_file)
+        fail("Lint report not found at `#{report_file}`. "\
           "Have you forgot to add `xmlReport true` to your `build.gradle` file?")
       end
 
@@ -80,7 +90,7 @@ module Danger
     private
 
     def read_issues_from_report
-      file = File.open("app/build/reports/lint/lint-result.xml")
+      file = File.open(report_file)
 
       require 'oga'
       report = Oga.parse_xml(file)

data/spec/android_lint_spec.rb

@@ -21,6 +21,7 @@ module Danger
 
       it "Fails if severity is an unknown value" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
+        allow(File).to receive(:exists?).with(@android_lint.report_file()).and_return(true)
 
         @android_lint.severity = "Dummy"
         @android_lint.lint
@@ -30,21 +31,46 @@ module Danger
 
       it "Sets severity to 'Warning' if no severity param is provided" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
-        allow(File).to receive(:exists?).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(true)
+        allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(true)
 
         fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
-        allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
+        allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
 
         @android_lint.lint
         expect(@android_lint.severity).to eq("Warning")
       end
 
+      it "Sets the report file to a default location if no param is provided" do
+        allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
+        allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(true)
+        
+        fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
+        allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
+
+        @android_lint.lint
+        expect(@android_lint.report_file).to eq("app/build/reports/lint/lint-result.xml")
+      end
+
+      it "Sets the report_file to the user's preference in the Dangerfile'" do
+        allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
+
+        @android_lint.report_file = 'some/other/location/lint-result.xml'
+
+        fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
+        allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
+        allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(true)
+        
+        @android_lint.lint
+
+        expect(@android_lint.report_file).to eq('some/other/location/lint-result.xml')
+      end
+
       it "Fails if report file does not exist" do
         allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
-        allow(File).to receive(:exists?).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(false)
+        allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(false)
 
         fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
-        allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
+        allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
 
         @android_lint.lint
 
@@ -55,12 +81,12 @@ module Danger
       describe 'lint' do
         before do
           allow(@android_lint).to receive(:`).with("ls gradlew").and_return("gradlew")
-          allow(File).to receive(:exists?).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(false)
+          allow(File).to receive(:exists?).with(@android_lint.report_file).and_return(false)
         end
 
         it 'Prints markdown if issues were found' do
           fake_result = File.open("spec/fixtures/lint-result-with-everything.xml")
-          allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
+          allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
 
           @android_lint.lint
 
@@ -79,7 +105,7 @@ module Danger
 
         it 'Doesn`t print anything if no errors were found' do
           fake_result = File.open("spec/fixtures/lint-result-empty.xml")
-          allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
+          allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
 
           @android_lint.lint
 
@@ -89,7 +115,7 @@ module Danger
 
         it 'Doesn`t print anything if no errors were found' do
           fake_result = File.open("spec/fixtures/lint-result-without-fatal.xml")
-          allow(File).to receive(:open).with(Danger::DangerAndroidLint::REPORT_FILE).and_return(fake_result)
+          allow(File).to receive(:open).with(@android_lint.report_file).and_return(fake_result)
 
           @android_lint.severity = "Fatal"
           @android_lint.lint

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: danger-android_lint
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Gustavo Barbosa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-15 00:00:00.000000000 Z
+date: 2017-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oga