dagger 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 447d77e66ec69445f5040231d19c038279d4ec7de624461deda078c544423ca9
-  data.tar.gz: c5eb814e71fd6a37b3b4272f6f747654eeb157655dec65ae6ec6f0cf86d4e5ff
+  metadata.gz: 87d4e9c75ae13a7295e19686dd8064f08a9311d4271454f97ceeb8e14da46618
+  data.tar.gz: 84174088956cf7035c3a744be06900ca38ee011942d0bbca0cb68ae8ffd55a7d
 SHA512:
-  metadata.gz: 31108057fbc3cd1d2e0c319d4c64244c596cbbb90d8ae6067945caedb2f8f7ff5c0fd144b16be55ac24cd36bbd466f08659b995b47ecd67425d26224bd505ede
-  data.tar.gz: d996eaefa87c30682eb127d9f2f28cbb28363fcf2a2f758e32610d553937c05a35750316f043a6f4d2a9eb6727aad8f0351ca761ee62b326313b46e902764fd2
+  metadata.gz: 0d6aef88856f8a279c2540fc74cedb532d2fdbd287860bbd2458d30c20d34f37c84cd5c40578ce66238430233341a1eb86888f7248c3d5ba8023442a0a554582
+  data.tar.gz: b3debd2a802c83dbbafd69f06936c5ffbf2c73b0d62021bf02edd2ae1bc697a93c93a207b76dc9a15630342a71c8cf97acbab9826276076de3dfee7e2af8dc42

data/lib/dagger/connection_manager.rb

@@ -3,7 +3,7 @@ module Dagger
   class ConnectionManager
 
     def initialize(opts = {})
-      @opts = {}
+      @opts = opts
       @active_connections = {}
       @mutex = Mutex.new
     end

data/lib/dagger/version.rb

@@ -1,7 +1,7 @@
 module Dagger
   MAJOR = 2
   MINOR = 0
-  PATCH = 0
+  PATCH = 1
 
   VERSION = [MAJOR, MINOR, PATCH].join('.')
 end

data/lib/dagger.rb

@@ -40,7 +40,7 @@ module Dagger
     end
 
     def self.resolve_uri(uri, host = nil, query = nil)
-      uri = host + uri if uri[0] == '/' && host
+      uri = host + uri if uri.to_s[0] == '/' && host
       uri = parse_uri(uri.to_s)
       uri.path.sub!(/\?.*|$/, '?' + to_query_string(query)) if query and query.any?
       uri
@@ -91,7 +91,7 @@ module Dagger
     def self.init_connection(uri, opts = {})
       http = Net::HTTP.new(opts[:ip] || uri.host, uri.port)
 
-      if uri.port == 443
+      if uri.port == 443 || uri.scheme == 'https'
         http.use_ssl = true if http.respond_to?(:use_ssl=) # persistent does it automatically
         http.verify_mode = opts[:verify_ssl] === false ? OpenSSL::SSL::VERIFY_NONE : OpenSSL::SSL::VERIFY_PEER
       end

data/spec/retries_spec.rb

@@ -0,0 +1,61 @@
+require './lib/dagger'
+
+require 'rspec/mocks'
+require 'rspec/expectations'
+
+describe 'Retries' do
+
+  def send_request
+    Dagger.get('http://foobar.com/test', opts)
+  end
+
+  let(:fake_http) { double('Net::HTTP', started?: true, "keep_alive_timeout=": true, "open_timeout=": true, "read_timeout=": true) }
+  let(:fake_resp) { double('Net::HTTPResponse', code: 200, body: 'foo') }
+
+  before do
+    allow(Net::HTTP).to receive(:new).at_least(:once).and_return(fake_http)
+    allow(fake_http).to receive(:verify_mode=).and_return(true)
+  end
+
+  describe 'on ECONNREFUSED' do
+
+    context 'if no retries option passed' do
+
+      let(:opts) { {} }
+
+      it 'does not retry request, and raises error' do
+        expect(fake_http).to receive(:request).once.and_raise(Errno::ECONNREFUSED)
+        expect { send_request }.to raise_error(Errno::ECONNREFUSED)
+      end
+
+    end
+
+    context 'if retries is 1' do
+
+      let(:opts) { { retries: 1, retry_wait: 1 } }
+
+      context 'and it still fails' do
+
+        it 'sends a second request, and raises error' do
+          expect(fake_http).to receive(:request).twice.and_raise(Errno::ECONNREFUSED)
+          expect { send_request }.to raise_error(Errno::ECONNREFUSED)
+        end
+
+      end
+
+      context 'and then it works' do
+
+        it 'sends a second request, and does not raise error' do
+          expect(fake_http).to receive(:request).once.and_raise(Errno::ECONNREFUSED)
+          expect(fake_http).to receive(:request).once.and_return(fake_resp)
+          allow(fake_resp).to receive(:[]).with('Content-Type').and_return('text/plain')
+
+          expect(send_request.body).to eq('foo')
+        end
+
+      end
+
+    end
+
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dagger
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Tomás Pollak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-24 00:00:00.000000000 Z
+date: 2022-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -120,6 +120,7 @@ files:
 - spec/ip_connect_spec.rb
 - spec/parsers_spec.rb
 - spec/persistent_spec.rb
+- spec/retries_spec.rb
 - spec/sending_data_spec.rb
 homepage: https://github.com/tomas/dagger
 licenses: []