czech_post_b2b_client 1.2.7 → 1.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5dbbe20befb04e719073a9ebda4cf114d8e546eb90d92a7e08a49fcc270f65c1
-  data.tar.gz: 1de84b51f03160843a22541311f0dd410412bb64ca0cd6e5ef7410ed4d5790d1
+  metadata.gz: c3f8150daa70de566a1a90f4287c3bb29f1547e9269409e573b6e7521a446df5
+  data.tar.gz: 23a3271bcf33470fc45e85d4e1db58ee9ea192a864fc0266c887acc9a2d6b56b
 SHA512:
-  metadata.gz: a2af402dee3c7b80de93d86af58d9feccb459ebf05c4eb8f35e6d75195e580575eb458a51e5962d32d643414892f2b939a6483e7b04afd86ca12c7af1550ef33
-  data.tar.gz: cba547aac3305bcee6b7ac7e6d34557c8542fcafbfe46d5a746075593ae47dd097378c7cebd0d22c69dcd9dc33c3563ca56805c54a2b31e37f32c5887d42b258
+  metadata.gz: bbd09471e42a1af7f0f4bb7e8c6c34309e083dd224ad392ae11a84ec15c1aebedc178782f944a51d5be678a455daa769171dc02e2bf4d8cf50d18d0f98c9c643
+  data.tar.gz: 84bdfde9c41917ffa85c0f191123aca5a6d8b6373907c4969d3bf38c65b8782e6d4466e912a3a0db48c258cf089ca8ca74ea7d5b27f421b5f0ff7ae5c6615b85

data/.rubocop.yml

@@ -2,6 +2,7 @@ require:
 # rubocop-minitest
 
 AllCops:
+  NewCops: enable
   Include:
     - "**/Gemfile"
     - "**/Rakefile"

data/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 All changes to the gem are documented here.
 
+## [1.2.8] - 2022-03-22
+ - added new response codes
+
 ## [1.2.6] - 2020-10-27
 
  - fixed passing all errors from `parcelsServiceSync` response.

data/lib/czech_post_b2b_client/b2b_errors.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Style/AsciiComments, Layout/LineLength
+# rubocop:disable Layout/LineLength
 
 # response <B2BFaultMessage>
 # Chybový kód | Detail chyby            | Popis
@@ -36,10 +36,12 @@ module CzechPostB2bClient
       end
 
       def initialize(details = '')
+        super
         self.details = details
       end
 
       attr_accessor :details
+
       def code
         self.class.code
       end
@@ -108,4 +110,4 @@ module CzechPostB2bClient
   end
 end
 
-# rubocop:enable Style/AsciiComments, Layout/LineLength
+# rubocop:enable Layout/LineLength

data/lib/czech_post_b2b_client/configuration.rb

@@ -32,7 +32,7 @@ module CzechPostB2bClient
       }
 
       @language = :cs
-      @logger = defined?(Rails) ? ::Rails.logger : ::Logger.new(STDOUT)
+      @logger = defined?(Rails) ? ::Rails.logger : ::Logger.new($stdout)
       @b2b_api_base_uri = 'https://b2b.postaonline.cz/services/POLService/v1'
       @sending_post_office_location_number = 1
 

data/lib/czech_post_b2b_client/post_services.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Layout/LineLength, Style/AsciiComments
+# rubocop:disable Layout/LineLength
 
 # Hopefully complete list of services which can be assigned to parcels
 # It is hard to get list of current services and even harder to find out what does they mean (so You pick right name in English).
@@ -84,6 +84,7 @@ module CzechPostB2bClient
       @description = 'Cenný obsah'
       # ; Balík Do ruky (DR, DV, DE) ; Balík Na poštu (NP, NV) |
     end
+
     class EconomyDelivery < Base
       @code = '1K'
       @abbreviation = 'EK'
@@ -774,4 +775,4 @@ module CzechPostB2bClient
   end
 end
 
-# rubocop:enable Layout/LineLength, Style/AsciiComments
+# rubocop:enable Layout/LineLength

data/lib/czech_post_b2b_client/printing_templates.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Style/AsciiComments
-
 # Available printing templates, which can be used in AdressSheetsGenerator `options[:template_id]`
 #
 # Do not miss `CzechPostB2bClient::PrintingTemplates.all_classes` method,
@@ -261,5 +259,3 @@ module CzechPostB2bClient
     end
   end
 end
-
-# rubocop:enable Style/AsciiComments

data/lib/czech_post_b2b_client/request_builders/base_builder.rb

@@ -10,6 +10,7 @@ module CzechPostB2bClient
       TIME_FORMAT = '%FT%T.%L%:z' # '2014-03-12T13:33:34.573+01:00'
 
       def initialize(request_id: 1)
+        super()
         @request_id = request_id
       end
 

data/lib/czech_post_b2b_client/request_builders/get_parcel_state_builder.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :parcel_codes
 
       def initialize(parcel_codes:, request_id: 1)
+        super()
         @parcel_codes = parcel_codes
         @request_id = request_id
       end

data/lib/czech_post_b2b_client/request_builders/get_parcels_printing_builder.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :parcel_codes, :options
 
       def initialize(parcel_codes:, options:, request_id: 1)
+        super()
         @parcel_codes = parcel_codes
         @options = options
         @request_id = request_id

data/lib/czech_post_b2b_client/request_builders/get_result_parcels_builder.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :transaction_id
 
       def initialize(transaction_id:, request_id: 1)
+        super()
         @transaction_id = transaction_id
         @request_id = request_id
       end

data/lib/czech_post_b2b_client/request_builders/get_stats_builder.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :from_date, :to_date
 
       def initialize(from_date:, to_date:, request_id: 1)
+        super()
         @from_date = from_date.to_time
         @to_date = to_date.to_time
         @request_id = request_id

data/lib/czech_post_b2b_client/request_builders/parcel_service_sync_builder.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Layout/LineLength, Style/AsciiComments
+# rubocop:disable Layout/LineLength
 
 module CzechPostB2bClient
   module RequestBuilders
@@ -8,6 +8,7 @@ module CzechPostB2bClient
       attr_reader :common_data, :parcel
 
       def initialize(common_data:, parcel:, request_id: 1)
+        super()
         @common_data = common_data
         @parcel = parcel
         @request_id = request_id
@@ -207,7 +208,7 @@ module CzechPostB2bClient
           add_element_to(do_parcel_address, 'ns2:custCardNum', value: addressee_data[:custom_card_number]) # Nepovinne: cislo zakaznicke karty
 
           (addressee_data[:advice_informations] || []).each_with_index do |adv_info, index|
-            add_element_to(do_parcel_address, 'ns2:adviceInformation' + (index + 1).to_s, value: adv_info) # Nepovinne: Informace 1- 6 k dodejce
+            add_element_to(do_parcel_address, "ns2:adviceInformation#{index + 1}", value: adv_info) # Nepovinne: Informace 1- 6 k dodejce
           end
           add_element_to(do_parcel_address, 'ns2:adviceNote', value: addressee_data[:advice_note]) # Nepovinne: Poznamka k dodejce
         end
@@ -258,7 +259,7 @@ module CzechPostB2bClient
       def add_bank_elements(parent_element, bank_account)
         return if bank_account.to_s == ''
 
-        if (m = bank_account.match(%r{(?:(\d+)-)?(\d+)\/(\d+)}))
+        if (m = bank_account.match(%r{(?:(\d+)-)?(\d+)/(\d+)}))
           prefix = m[1]
           account = m[2]
           bank = m[3]
@@ -284,4 +285,4 @@ module CzechPostB2bClient
   end
 end
 
-# rubocop:enable Layout/LineLength, Style/AsciiComments
+# rubocop:enable Layout/LineLength

data/lib/czech_post_b2b_client/request_builders/send_parcels_builder.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# rubocop:disable Layout/LineLength, Style/AsciiComments
+# rubocop:disable Layout/LineLength
 
 module CzechPostB2bClient
   module RequestBuilders
@@ -8,6 +8,7 @@ module CzechPostB2bClient
       attr_reader :common_data, :parcels
 
       def initialize(common_data:, parcels:, request_id: 1)
+        super()
         @common_data = common_data
         @parcels = parcels
         @request_id = request_id
@@ -225,7 +226,7 @@ module CzechPostB2bClient
           add_element_to(do_parcel_address, 'ns2:custCardNum', value: addressee_data[:custom_card_number]) # Nepovinne: cislo zakaznicke karty
 
           (addressee_data[:advice_informations] || []).each_with_index do |adv_info, index|
-            add_element_to(do_parcel_address, 'ns2:adviceInformation' + (index + 1).to_s, value: adv_info) # Nepovinne: Informace 1- 6 k dodejce
+            add_element_to(do_parcel_address, "ns2:adviceInformation#{index + 1}", value: adv_info) # Nepovinne: Informace 1- 6 k dodejce
           end
           add_element_to(do_parcel_address, 'ns2:adviceNote', value: addressee_data[:advice_note]) # Nepovinne: Poznamka k dodejce
         end
@@ -263,9 +264,7 @@ module CzechPostB2bClient
         return if address_data.nil?
 
         address_tags_and_values(address_data).each_pair do |xml_tag, value|
-          unless without.include?(xml_tag)
-            add_element_to(parent_element, xml_tag, value: value) unless value.nil?
-          end
+          add_element_to(parent_element, xml_tag, value: value) if !without.include?(xml_tag) && !value.nil?
         end
       end
 
@@ -289,7 +288,7 @@ module CzechPostB2bClient
       def add_bank_elements(parent_element, bank_account)
         return if bank_account.to_s == ''
 
-        if (m = bank_account.match(%r{(?:(\d+)-)?(\d+)\/(\d+)}))
+        if (m = bank_account.match(%r{(?:(\d+)-)?(\d+)/(\d+)}))
           prefix = m[1]
           account = m[2]
           bank = m[3]
@@ -315,4 +314,4 @@ module CzechPostB2bClient
   end
 end
 
-# rubocop:enable Layout/LineLength, Style/AsciiComments
+# rubocop:enable Layout/LineLength

data/lib/czech_post_b2b_client/response_codes.rb

@@ -24,6 +24,7 @@ module CzechPostB2bClient
       end
 
       attr_reader :details
+
       def initialize(details = '')
         @details = details
       end
@@ -2001,10 +2002,45 @@ module CzechPostB2bClient
       @type = :info
     end
 
-    class InfoNonexistingZipCodeWasReplacedByConstant < CzechPostB2bClient::ResponseCodes::BaseCode
+    class InfoService40CanceledDueMissingContactToAddressee < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 424
+      @text = 'INFO_CANCEL_SERVICE_40'
+      @description = 'Zrušena služba 40 - neuveden kontaktní údaj adresáta'
+      @type = :info
+    end
+
+    class InfoService29CanceledDueMissingContactToAddressee < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 425
+      @text = 'INFO_CANCEL_SERVICE_29'
+      @description = 'Zrušena dopl. sl. 29 – neuveden kontaktní údaj'
+      @type = :info
+    end
+
+    class InfoService40CanceledNotAllowedTogetherWithService29 < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 426
+      @text = 'INFO_CANCEL_SERVICE_40'
+      @description = 'Zrušena služba 40 – nepovolena se sl. 29'
+      @type = :info
+    end
+
+    class InfoService40CanceledPackageIsPosteRestante < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 427
+      @text = 'INFO_CANCEL_SERVICE_40'
+      @description = 'Zrušena služba 40 – zásilka Poste restante'
+      @type = :info
+    end
+
+    class InfoService7KCancelledNotArrangedForClient < CzechPostB2bClient::ResponseCodes::BaseCode
+      @code = 428
+      @text = 'INFO_CANCEL_SERVICE_7K'
+      @description = 'Zrušena služba 7K - nesjednaná služba pro zákaznické řešení'
+      @type = :info
+    end
+
+    class InfoAvizoServiceAppended < CzechPostB2bClient::ResponseCodes::BaseCode
       @code = 429
       @text = 'INFO_NOTIFICIATON_WAS_MODIFIED'
-      @description = 'Zatím není text, dokumentace je zastaralá: INFO_NOTIFICIATON_WAS_MODIFIED'
+      @description = 'Služba avizování přiřazena dle kontaktních údajů'
       @type = :info
     end
 

data/lib/czech_post_b2b_client/response_parsers/base_parser.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
   module ResponseParsers
     class BaseParser < SteppedService::Base
       def initialize(xml:)
+        super()
         @response_xml = xml
       end
 
@@ -34,41 +35,41 @@ module CzechPostB2bClient
 
       def build_result
         @result = {
-          request: { created_at: request_data.time_stamp,
-                     contract_id: request_data.id_contract,
-                     request_id: request_data.id_ext_transaction },
+          request: { created_at: request_data[:time_stamp],
+                     contract_id: request_data[:id_contract],
+                     request_id: request_data[:id_ext_transaction] },
           response: { created_at: response_time }
         }
       end
 
       def response_service_data
-        b2b_response_hash.dig('serviceData')
+        b2b_response_hash['serviceData']
       end
 
       def response_header
-        b2b_response_hash.dig('header')
+        b2b_response_hash['header']
       end
 
       def response_root_node
-        return response_service_data.dig(response_root_node_name) if response_service_data.keys.include?(response_root_node_name)
+        return response_service_data[response_root_node_name] if response_service_data.keys.include?(response_root_node_name)
 
         errors.add(:xml, "Cannot find `#{response_root_node_name}` in `serviceData` node.")
         fail_on_structure_parsing
       end
 
       def b2b_response_hash
-        response_hash.dig('b2bSyncResponse') || response_hash.dig('b2bASyncResponse')
+        response_hash['b2bSyncResponse'] || response_hash['b2bASyncResponse']
       end
 
       def request_data
-        b2b_request_hash = response_header.dig('b2bRequestHeader')
-        OpenStruct.new(id_ext_transaction: b2b_request_hash.dig('idExtTransaction').to_s,
-                       time_stamp: Time.parse(b2b_request_hash.dig('timeStamp')),
-                       id_contract: b2b_request_hash.dig('idContract').to_s)
+        b2b_request_hash = response_header['b2bRequestHeader']
+        { id_ext_transaction: b2b_request_hash['idExtTransaction'].to_s,
+          time_stamp: Time.parse(b2b_request_hash['timeStamp']),
+          id_contract: b2b_request_hash['idContract'].to_s }
       end
 
       def response_time
-        Time.parse(response_header.dig('timeStamp'))
+        Time.parse(response_header['timeStamp'])
       rescue TypeError
         Time.now.utc
       end
@@ -87,7 +88,7 @@ module CzechPostB2bClient
       end
 
       def handle_result_building_error(error)
-        @result = { result_builder_error: error.message + ' at line: ' + error.backtrace.first,
+        @result = { result_builder_error: "#{error.message} at line: #{error.backtrace.first}",
                     response_hash: response_hash }
         fail_on_structure_parsing
       end

data/lib/czech_post_b2b_client/response_parsers/get_parcel_state_parser.rb

@@ -21,7 +21,7 @@ module CzechPostB2bClient
       def response_parcel_hashes
         return [] if response_root_node.nil?
 
-        [response_root_node.dig('parcel')].flatten.compact # to always get array of hash(es)
+        [response_root_node['parcel']].flatten.compact # to always get array of hash(es)
       end
 
       def parcel_data_from(rp_hash) # rubocop:disable Metrics/AbcSize

data/lib/czech_post_b2b_client/response_parsers/get_parcels_printing_parser.rb

@@ -7,20 +7,20 @@ module CzechPostB2bClient
     class GetParcelsPrintingParser < BaseParser
       def build_result
         super
-        @result[:response][:state] = state_hash_from(printing_response_header_result.dig('doPrintingStateResponse'))
+        @result[:response][:state] = state_hash_from(printing_response_header_result['doPrintingStateResponse'])
         @result[:printings] = { options: options_hash,
                                 pdf_content: pdf_content }
       end
 
       def options_hash
-        options_response = printing_response_header_result.dig('doPrintingHeader')
+        options_response = printing_response_header_result['doPrintingHeader']
         {
-          customer_id: options_response.dig('customerID'),
-          contract_number: options_response.dig('contractNumber'),
-          template_id: options_response.dig('idForm').to_i,
-          margin_in_mm: { top: options_response.dig('shiftVertical').to_i,
-                          left: options_response.dig('shiftHorizontal').to_i },
-          position_order: options_response.dig('position').to_i
+          customer_id: options_response['customerID'],
+          contract_number: options_response['contractNumber'],
+          template_id: options_response['idForm'].to_i,
+          margin_in_mm: { top: options_response['shiftVertical'].to_i,
+                          left: options_response['shiftHorizontal'].to_i },
+          position_order: options_response['position'].to_i
         }
       end
 
@@ -36,7 +36,7 @@ module CzechPostB2bClient
       end
 
       def printing_response_header_result
-        response_root_node.dig('doPrintingHeaderResult')
+        response_root_node['doPrintingHeaderResult']
       end
     end
   end

data/lib/czech_post_b2b_client/response_parsers/get_result_parcels_parser.rb

@@ -25,7 +25,7 @@ module CzechPostB2bClient
       end
 
       def response_parcel_hashes
-        [response_root_node.dig('doParcelParamResult')].flatten.compact # to always get array of hash(es)
+        [response_root_node['doParcelParamResult']].flatten.compact # to always get array of hash(es)
       end
 
       def parcel_parcel_id_from(rp_hash)
@@ -34,7 +34,7 @@ module CzechPostB2bClient
 
       def parcel_data_from(rp_hash)
         { parcel_code: rp_hash['parcelCode'],
-          states: [state_hash_from(rp_hash.dig('doParcelStateResponse'))] }
+          states: [state_hash_from(rp_hash['doParcelStateResponse'])] }
       end
 
       def updated_result_value_for(value, parcel_params_result_hash)

data/lib/czech_post_b2b_client/response_parsers/get_stats_parser.rb

@@ -5,18 +5,15 @@ module CzechPostB2bClient
     class GetStatsParser < BaseParser
       def build_result
         super
-        @result[:imports] = { requested: imports.all,
-                              with_errors: imports.err,
-                              successful: imports.ok,
-                              imported_parcels: imports.parcels }
+        @result[:imports] = imports
       end
 
       def imports
         imports_hash = response_root_node
-        OpenStruct.new(all: imports_hash.dig('importAll').to_i,
-                       err: imports_hash.dig('importErr').to_i,
-                       ok: imports_hash.dig('importOk').to_i,
-                       parcels: imports_hash.dig('parcels').to_i)
+        { requested: imports_hash['importAll'].to_i,
+          with_errors: imports_hash['importErr'].to_i,
+          successful: imports_hash['importOk'].to_i,
+          imported_parcels: imports_hash['parcels'].to_i }
       end
 
       def response_root_node_name

data/lib/czech_post_b2b_client/response_parsers/parcel_service_sync_parser.rb

@@ -35,7 +35,7 @@ module CzechPostB2bClient
       end
 
       def response_print_hash
-        response_root_node.dig('responsePrintParams')
+        response_root_node['responsePrintParams']
       end
 
       def parcel_parcel_id_from(rp_hash)
@@ -44,7 +44,7 @@ module CzechPostB2bClient
 
       def parcel_data_from(rp_hash)
         { parcel_code: rp_hash['parcelCode'],
-          states: parcel_states_form(rp_hash.dig('parcelDataResponse')) }
+          states: parcel_states_form(rp_hash['parcelDataResponse']) }
       end
 
       def parcel_states_form(data_responses)
@@ -54,8 +54,8 @@ module CzechPostB2bClient
       def print_data_from(print_hash)
         return nil if print_hash.nil? || print_hash.empty?
 
-        { pdf_content: pdf_content_from(print_hash.dig('file')),
-          state: state_hash_from(print_hash.dig('printParamsResponse')) }
+        { pdf_content: pdf_content_from(print_hash['file']),
+          state: state_hash_from(print_hash['printParamsResponse']) }
       end
 
       def pdf_content_from(pdf_content_encoded)

data/lib/czech_post_b2b_client/response_parsers/send_parcels_parser.rb

@@ -7,8 +7,8 @@ module CzechPostB2bClient
         super
 
         @result[:async_result] = {
-          transaction_id: response_header.dig('idTransaction'),
-          processing_end_expected_at: parse_time_with_correction(response_header.dig('timeStampProcessing'))
+          transaction_id: response_header['idTransaction'],
+          processing_end_expected_at: parse_time_with_correction(response_header['timeStampProcessing'])
         }
       end
 

data/lib/czech_post_b2b_client/services/address_sheets_generator.rb

@@ -5,7 +5,10 @@ module CzechPostB2bClient
     class AddressSheetsGenerator < CzechPostB2bClient::Services::Communicator
       attr_reader :parcel_codes, :options
 
+      AddressSheetsGeneratorResult = Struct.new(:pdf_content, :state_text, :state_code, keyword_init: true)
+
       def initialize(parcel_codes:, options: {})
+        super()
         @parcel_codes = parcel_codes
         @options = options
       end
@@ -37,9 +40,9 @@ module CzechPostB2bClient
       end
 
       def build_result_from(response_hash)
-        OpenStruct.new(pdf_content: response_hash.dig(:printings, :pdf_content),
-                       state_text: response_hash.dig(:response, :state, :text),
-                       state_code: response_hash.dig(:response, :state, :code))
+        AddressSheetsGeneratorResult.new(pdf_content: response_hash.dig(:printings, :pdf_content),
+                                         state_text: response_hash.dig(:response, :state, :text),
+                                         state_code: response_hash.dig(:response, :state, :code))
       end
 
       def check_for_state_errors

data/lib/czech_post_b2b_client/services/api_caller.rb

@@ -18,7 +18,10 @@ module CzechPostB2bClient
         Net::ProtocolError
       ].freeze
 
+      ApiCallerResult = Struct.new(:code, :xml, keyword_init: true)
+
       def initialize(endpoint_path:, xml:)
+        super()
         @endpoint_path = endpoint_path
         @request_xml = xml
       end
@@ -40,7 +43,7 @@ module CzechPostB2bClient
       def handle_response
         CzechPostB2bClient.logger.debug("CzechPost B2B RESPONSE: #{response} with body:\n#{response.body}")
 
-        @result = ::OpenStruct.new(code: response.code.to_i, xml: response.body)
+        @result = ApiCallerResult.new(code: response.code.to_i, xml: response.body)
         return unless b2b_error?
 
         errors.add(:b2b, b2b_error_text)
@@ -102,12 +105,12 @@ module CzechPostB2bClient
       end
 
       def b2b_error_text
-        err_code_without_namespace_regexp = %r{<(?:\w+\:)?errorCode>(\d+)</(?:\w+\:)?errorCode>}
+        err_code_without_namespace_regexp = %r{<(?:\w+:)?errorCode>(\d+)</(?:\w+:)?errorCode>}
         error_match = result.xml.match(err_code_without_namespace_regexp)
         return 'error code not found in XML' unless error_match
 
         error_code = error_match[1].to_i
-        error_details = result.xml.match(%r{<(?:\w+\:)?errorDescription>(.*)</(?:\w+\:)?errorDescription>})
+        error_details = result.xml.match(%r{<(?:\w+:)?errorDescription>(.*)</(?:\w+:)?errorDescription>})
         error = CzechPostB2bClient::B2BErrors.new_by_code(error_code, error_details[1])
         return "error code [#{error_code}] is unknown" unless error
 
@@ -115,7 +118,7 @@ module CzechPostB2bClient
       end
 
       def handle_connection_error(error)
-        @result = OpenStruct.new(code: 500, xml: '')
+        @result = ApiCallerResult.new(code: 500, xml: '')
         errors.add(:connection, "#{error.class} > #{service_uri} - #{error}")
         fail!
       end

data/lib/czech_post_b2b_client/services/delivering_inspector.rb

@@ -6,6 +6,7 @@ module CzechPostB2bClient
       attr_reader :parcel_codes
 
       def initialize(parcel_codes:)
+        super()
         @parcel_codes = parcel_codes
       end
 

data/lib/czech_post_b2b_client/services/orchestrator.rb

@@ -11,7 +11,7 @@ module CzechPostB2bClient
         service = service_class.call(service_hash.values.first)
 
         if service.failed?
-          errors.add_from_hash(Hash[service_name, service.errors.full_messages])
+          errors.add_from_hash({ service_name => service.errors.full_messages })
           fail!
         end
 

data/lib/czech_post_b2b_client/services/parcels_async_sender.rb

@@ -5,7 +5,10 @@ module CzechPostB2bClient
     class ParcelsAsyncSender < CzechPostB2bClient::Services::Communicator
       attr_reader :sending_data, :parcels
 
+      ParcelsAsyncSenderResult = Struct.new(:transaction_id, :processing_end_expected_at, keyword_init: true)
+
       def initialize(sending_data:, parcels:)
+        super()
         @sending_data = sending_data
         @parcels = parcels
       end
@@ -45,8 +48,8 @@ module CzechPostB2bClient
       end
 
       def build_result_from(response_hash)
-        OpenStruct.new(transaction_id: response_hash.dig(:async_result, :transaction_id),
-                       processing_end_expected_at: response_hash.dig(:async_result, :processing_end_expected_at))
+        ParcelsAsyncSenderResult.new(transaction_id: response_hash.dig(:async_result, :transaction_id),
+                                     processing_end_expected_at: response_hash.dig(:async_result, :processing_end_expected_at))
       end
     end
   end

data/lib/czech_post_b2b_client/services/parcels_send_process_updater.rb

@@ -5,7 +5,10 @@ module CzechPostB2bClient
     class ParcelsSendProcessUpdater < CzechPostB2bClient::Services::Communicator
       attr_reader :transaction_id
 
+      ParcelsSendProcessUpdaterResult = Struct.new(:parcels_hash, :state_text, :state_code, keyword_init: true)
+
       def initialize(transaction_id:)
+        super()
         @transaction_id = transaction_id
       end
 
@@ -36,9 +39,11 @@ module CzechPostB2bClient
       end
 
       def build_result_from(response_hash)
-        OpenStruct.new(parcels_hash: response_hash[:parcels],
-                       state_text: response_hash.dig(:response, :state, :text),
-                       state_code: response_hash.dig(:response, :state, :code))
+        ParcelsSendProcessUpdaterResult.new(
+          parcels_hash: response_hash[:parcels],
+          state_text: response_hash.dig(:response, :state, :text),
+          state_code: response_hash.dig(:response, :state, :code)
+        )
       end
 
       def check_for_state_errors

data/lib/czech_post_b2b_client/services/parcels_submission_closer.rb

@@ -6,7 +6,7 @@ module CzechPostB2bClient
       attr_reader :sending_data
 
       def initialize(sending_data:)
-        @sending_data = sending_data
+        super(sending_data: sending_data, parcels: [])
       end
 
       private

data/lib/czech_post_b2b_client/services/parcels_sync_sender.rb

@@ -8,7 +8,10 @@ module CzechPostB2bClient
     class ParcelsSyncSender < CzechPostB2bClient::Services::Communicator
       attr_reader :sending_data, :parcels
 
+      ParcelsSyncSenderResult = Struct.new(:parcels_hash, :state_text, :state_code, :pdf_content, keyword_init: true)
+
       def initialize(sending_data:, parcels:)
+        super()
         @sending_data = sending_data
         @parcels = parcels
       end
@@ -52,10 +55,12 @@ module CzechPostB2bClient
       end
 
       def build_result_from(response_hash)
-        OpenStruct.new(parcels_hash: response_hash[:parcel],
-                       pdf_content: response_hash[:parcel].values.first.dig(:printings, :pdf_content),
-                       state_text: response_hash.dig(:response, :state, :text),
-                       state_code: response_hash.dig(:response, :state, :code))
+        ParcelsSyncSenderResult.new(
+          parcels_hash: response_hash[:parcel],
+          pdf_content: response_hash[:parcel].values.first.dig(:printings, :pdf_content),
+          state_text: response_hash.dig(:response, :state, :text),
+          state_code: response_hash.dig(:response, :state, :code)
+        )
       end
 
       def check_for_state_errors

data/lib/czech_post_b2b_client/services/time_period_statisticator.rb

@@ -5,7 +5,11 @@ module CzechPostB2bClient
     class TimePeriodStatisticator < CzechPostB2bClient::Services::Communicator
       attr_reader :from_date, :to_date
 
+      TimePeriodStatisticatorResult = Struct.new(:requests, :imported_parcels, keyword_init: true)
+      TimePeriodStatisticatorRequestsResult = Struct.new(:total, :with_errors, :successful, keyword_init: true)
+
       def initialize(from_date:, to_date:)
+        super()
         @from_date = from_date
         @to_date = to_date
       end
@@ -34,10 +38,12 @@ module CzechPostB2bClient
 
       def build_result_from(response_hash)
         imports = response_hash[:imports]
-        OpenStruct.new(requests: OpenStruct.new(total: imports[:requested],
-                                                with_errors: imports[:with_errors],
-                                                successful: imports[:successful]),
-                       imported_parcels: imports[:imported_parcels])
+        TimePeriodStatisticatorResult.new(
+          requests: TimePeriodStatisticatorRequestsResult.new(total: imports[:requested],
+                                                              with_errors: imports[:with_errors],
+                                                              successful: imports[:successful]),
+          imported_parcels: imports[:imported_parcels]
+        )
       end
     end
   end

data/lib/czech_post_b2b_client/services/xsds_downloader.rb

@@ -6,7 +6,9 @@ require 'net/http'
 module CzechPostB2bClient
   module Services
     class XsdsDownloader < ApiCaller
-      def initialize(_anything); end
+      def initialize(_anything)
+        super()
+      end
 
       def steps
         %i[download_xsds]

data/lib/czech_post_b2b_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CzechPostB2bClient
-  VERSION = '1.2.7'
+  VERSION = '1.2.8'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: czech_post_b2b_client
 version: !ruby/object:Gem::Version
-  version: 1.2.7
+  version: 1.2.8
 platform: ruby
 authors:
 - Petr Mlčoch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-03-17 00:00:00.000000000 Z
+date: 2022-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ox
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: 1.26.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: 1.26.1
 - !ruby/object:Gem::Dependency
   name: rubocop-minitest
   requirement: !ruby/object:Gem::Requirement