czech_post_b2b_client 1.2.5 → 1.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b3d8606fd4218b5344ee5b5f6e6f9fae333851654d0b869d57d1c1f98fc16a8
-  data.tar.gz: 8c2833143397c0b9d909f63da014f0228a1cd26d254765176b95b523e1ddf231
+  metadata.gz: 74fa378ca71040acf1adb94fb61fa1d371ae2491273b3585bed2ef14ce6911e8
+  data.tar.gz: efda7da207ddf3146be8181c4765f8cca645020131f3cda81e211fb5ff9ea828
 SHA512:
-  metadata.gz: 248c7f29bdcbb1d7a50e55d7a81bc72eba16d0dfdbd4b980492501d62d280b8686823130eb3ceaf5853839825639d3aacca31e29777db0182da7407f73e98a67
-  data.tar.gz: e92e86057e70d34eb7cb70494545708fa865a6cec42f2c8c0e57106e076dd8fddef4857fe68e6af0503718dc52c7146e6cdd58d56138abda7715f572d26ed26f
+  metadata.gz: 9752291d61873388331118b6167d212e40aab3ce344d0306f664ba245ac5e6515296dba98a97788b0604a39355a4514ac3d409b548d14e63efe3786f920cb627
+  data.tar.gz: 257ceece993bb225b3ec020667af0fab9c26edd0b2eb16c35d41c470f70c7b8377443da68dc7c057e9d1d237e4bc74743cf70a585a5ad7c6fe10152c86990a63

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 All changes to the gem are documented here.
 
+## [1.2.6] - 2020-10-27
+
+ - fixed passing all errors from `parcelsServiceSync` response.
+
 ## [1.2.5] - 2020-10-06
 
  - `errorDescription` from `B2BError` response is now merged into error message.

data/lib/czech_post_b2b_client/request_builders/parcel_service_sync_builder.rb

@@ -61,36 +61,38 @@ module CzechPostB2bClient
             errors.add(:parcel, "Missing value for key { :#{key_chain.join(' => :')} } for parcel (parcel_id: '#{parcel_id}')!")
           end
         end
+
+        # TODO: check custom goods if present
       end
 
       def parcel_service_sync
         new_element('ns2:parcelServiceSyncRequest').tap do |ps_sync_request|
           add_element_to(ps_sync_request, do_parcel_header) # REQUIRED
-          add_element_to(ps_sync_request, do_parcel_data) # optional
+          add_element_to(ps_sync_request, do_parcel_data) # REQUIRED
         end
       end
 
       def do_parcel_header # rubocop:disable Metrics/AbcSize
         new_element('ns2:doPOLSyncParcelHeader').tap do |parcel_header|
           add_element_to(parcel_header, 'ns2:transmissionDate', value: common_data[:parcels_sending_date].strftime('%d.%m.%Y')) # Predpokladane datum podani (format DD.MM.YYYY !)
-          add_element_to(parcel_header, 'ns2:customerID', value: common_data[:customer_id]) # Technologicke cislo podavatele
+          add_element_to(parcel_header, 'ns2:customerID', value: common_data[:customer_id]) # Nepovinne: Technologicke cislo podavatele
           add_element_to(parcel_header, 'ns2:postCode', value: common_data[:sending_post_office_code]) # PSC podaci posty
           add_element_to(parcel_header, 'ns2:contractNumber', value: common_data[:contract_number]) # Nepovinne: Cislo zakazky
           add_element_to(parcel_header, 'ns2:frankingNumber', value: common_data[:franking_machine_number]) # Nepovinne: Cislo vyplatniho stroje
           add_element_to(parcel_header, 'ns2:transmissionEnd', value: common_data[:close_requests_batch]) # Nepovinna, default true: Indikace zda uzavrit podani, nebo budou jeste nasledovat dalsi requesty pro stejne podani
           add_element_to(parcel_header, 'ns2:locationNumber', value: common_data[:sending_post_office_location_number]) # Nepovinne: cislo podaciho mista (z nastaveni v Podani Online)
           add_element_to(parcel_header, 'ns2:senderCustCardNum', value: sender_data[:custom_card_number]) # Nepovinne: cislo zakaznicke karty odesilatele
-          add_element_to(parcel_header, print_params)
+          add_element_to(parcel_header, print_params) # Nepovinne
         end
       end
 
       def do_parcel_data
         new_element('ns2:doPOLSyncParcelData').tap do |do_parcel_data|
-          add_element_to(do_parcel_data, do_parcel_params)
+          add_element_to(do_parcel_data, do_parcel_params) # 1-5x
           add_element_to(do_parcel_data, do_parcel_address)
-          add_element_to(do_parcel_data, do_parcel_address_document)
-          add_element_to(do_parcel_data, do_parcel_customs_declaration)
-          add_customs_documents_to(do_parcel_data)
+          add_element_to(do_parcel_data, do_parcel_address_document) # 0-1x
+          add_element_to(do_parcel_data, do_parcel_customs_declaration) # 0-1x
+          add_customs_documents_to(do_parcel_data) # 0-3x
         end
       end
 
@@ -221,6 +223,7 @@ module CzechPostB2bClient
           add_element_to(do_p_customs_declaration, 'ns2:customValCur', value: declaration_data[:value_currency_iso_code]) # ISO kod meny celni hodnoty
           add_element_to(do_p_customs_declaration, 'ns2:importerRefNum', value: declaration_data[:importer_reference_number]) # Nepovinne: Cislo dovozce
 
+          # 0-99x
           (declaration_data[:content_descriptions] || []).each do |dsc|
             do_p_customs_declaration << custom_goods_for(dsc)
           end
@@ -242,13 +245,13 @@ module CzechPostB2bClient
 
       def custom_goods_for(description_data)
         new_element('ns2:doPOLParcelCustomsGoods').tap do |do_p_customs_goods|
-          add_element_to(do_p_customs_goods, 'ns2:sequence', value: description_data[:order].to_i) # Nepovinne: Poradi , cisl0 1-20
-          add_element_to(do_p_customs_goods, 'ns2:customCont', value: description_data[:description]) # Nepovinne: Popis zbozi
-          add_element_to(do_p_customs_goods, 'ns2:quantity', value: description_data[:quantity]) # Nepovinne: Mnozstvi
-          add_element_to(do_p_customs_goods, 'ns2:weight', value: description_data[:weight_in_kg]) # Nepovinne: Hmotnost
-          add_element_to(do_p_customs_goods, 'ns2:customVal', value: description_data[:value]) # Nepovinne: Celni hodnota
-          add_element_to(do_p_customs_goods, 'ns2:hsCode', value: description_data[:hs_code]) # Nepovinne: HS kod
-          add_element_to(do_p_customs_goods, 'ns2:iso', value: description_data[:origin_country_iso_code]) # Nepovinne: Zeme puvodu zbozi
+          add_element_to(do_p_customs_goods, 'ns2:sequence', value: description_data[:order].to_i) # Poradi , cisl0 1-20
+          add_element_to(do_p_customs_goods, 'ns2:customCont', value: description_data[:description]) # Popis zbozi
+          add_element_to(do_p_customs_goods, 'ns2:quantity', value: description_data[:quantity]) # Mnozstvi
+          add_element_to(do_p_customs_goods, 'ns2:weight', value: description_data[:weight_in_kg]) # Hmotnost
+          add_element_to(do_p_customs_goods, 'ns2:customVal', value: description_data[:value]) # Celni hodnota
+          add_element_to(do_p_customs_goods, 'ns2:hsCode', value: description_data[:hs_code]) # HS kod
+          add_element_to(do_p_customs_goods, 'ns2:iso', value: description_data[:origin_country_iso_code]) # Zeme puvodu zbozi
         end
       end
 

data/lib/czech_post_b2b_client/response_parsers/parcel_service_sync_parser.rb

@@ -44,7 +44,11 @@ module CzechPostB2bClient
 
       def parcel_data_from(rp_hash)
         { parcel_code: rp_hash['parcelCode'],
-          states: [state_hash_from(rp_hash.dig('parcelDataResponse'))] }
+          states: parcel_states_form(rp_hash.dig('parcelDataResponse')) }
+      end
+
+      def parcel_states_form(data_responses)
+        [data_responses].flatten.collect { |data_response| state_hash_from(data_response) }
       end
 
       def print_data_from(print_hash)
@@ -62,7 +66,6 @@ module CzechPostB2bClient
 
       def updated_result_value_for(value, parcel_params_result_hash)
         pd_hash = parcel_data_from(parcel_params_result_hash)
-
         return pd_hash if value.nil?
 
         # merging states

data/lib/czech_post_b2b_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CzechPostB2bClient
-  VERSION = '1.2.5'
+  VERSION = '1.2.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: czech_post_b2b_client
 version: !ruby/object:Gem::Version
-  version: 1.2.5
+  version: 1.2.6
 platform: ruby
 authors:
 - Petr Mlčoch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-10-06 00:00:00.000000000 Z
+date: 2020-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ox