cypress-on-rails 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0b54d8af351f5f44e1da67e4c75540a40f529b03434ed24a50e8e145e456084
-  data.tar.gz: 599595f9a60941b3b23696d1867fb4c687eaa24b656392df4c98650ba6786558
+  metadata.gz: 92ef9e4a473b4f2443f22531b4f9841e4b2026cd3c10752e4e21acc3aac4bd26
+  data.tar.gz: d78ddeef85ade24097a8582e9f96e116c914312cdfee9f2671921a57ce6ebc88
 SHA512:
-  metadata.gz: 05ebe6824bea9027f18f5e02425aa7f15979e6e8e36af99a3dd3112df3715d7a5d456ecd85b9a307486c873b9af5029bc7f1b6a0f75ae544670c18efe13182ae
-  data.tar.gz: d831d9abb63c8b89fad1eb5367c4ad95489f6dfc83c739da0e8508ede8a13723ef0204ad5dba80b9625f47f2d96306ec1d484f13acd77015c9a1eb3671013a34
+  metadata.gz: 8823d163582b4aa7f328ac52069db710fb851cab2e94835eda32dfbb9b7008bbe35fb4cdaa7be826dc5ca9f4db038cf8d947e1ab016b41070171b6c582f87d52
+  data.tar.gz: 34b03e8a0e6f15152ed263f234768e0af41aeb84fbe5144c5c97d305bc4e3470e592c324d155cad48534310f55682d578b4fcb292d1c6523db96bedc117b888a

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.1.1
+### Fixed
+* smart factory wrapper can handle when factory files get deleted
+
+## 1.1.0
 ### Tasks
 * add cypress examples to install generator
 * add active record integration specs

data/README.md

@@ -192,7 +192,7 @@ require 'cypress_dev/middleware'
 CypressDev.configure do |c|
   c.cypress_folder = File.expand_path("#{__dir__}/test/cypress")
 end
-use Cypress::Middleware
+use CypressDev::Middleware
 
 run MyApp 
 ```

data/lib/cypress_dev/smart_factory_wrapper.rb

@@ -29,12 +29,12 @@ module CypressDev
     end
 
     # @return [Array]
-    attr_accessor :files
     attr_accessor :factory
     attr_accessor :always_reload
 
     def initialize(files:, factory:, always_reload: false,
-                   factory_cleaner: FactoryCleaner, kernel: Kernel, file_system: File)
+                   factory_cleaner: FactoryCleaner, kernel: Kernel, file_system: File,
+                   dir_system: Dir)
       self.files = files
       self.factory = factory
       self.always_reload = always_reload
@@ -42,6 +42,7 @@ module CypressDev
       @file_system = file_system
       @factory_cleaner = factory_cleaner
       @latest_mtime = nil
+      @dir_system = dir_system
     end
 
     def create(*args)
@@ -56,6 +57,17 @@ module CypressDev
 
     private
 
+    # @param [String,Array] arg
+    def files=(array)
+      array = [array] if array.is_a?(String)
+      @dir_array = array
+    end
+
+    # @return [Array<String>]
+    def files
+      Dir[*@dir_array]
+    end
+
     def logger
       CypressDev.configuration.logger
     end

data/lib/cypress_dev/version.rb

@@ -1,3 +1,3 @@
 module CypressDev
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/lib/generators/cypress_dev/templates/spec/cypress/cypress_helper.rb

@@ -26,5 +26,5 @@ factory = FactoryGirl if defined?(FactoryGirl)
 CypressDev::SmartFactoryWrapper.configure(
     always_reload: !Rails.configuration.cache_classes,
     factory: factory,
-    files: Dir['./spec/factories/**/*.rb']
+    files: %w(spec/factories.rb ./spec/factories/**/*.rb)
 )

data/spec/cypress_dev/smart_factory_wrapper_spec.rb

@@ -14,12 +14,18 @@ RSpec.describe CypressDev::SmartFactoryWrapper do
   let(:factory_cleaner) { class_double(CypressDev::SmartFactoryWrapper::FactoryCleaner, clean: true) }
   let(:kernel_double) { class_double(Kernel, load: true) }
   let(:file_double) { FileSystemDummy.new(mtime_hash) }
+  let(:dir_double) { class_double(Dir) }
+
+  before do
+    allow(Dir).to receive(:[]).with(*files) { mtime_hash.keys }
+  end
 
   subject do
     described_class.new(files: files,
                         factory: factory_double,
                         kernel: kernel_double,
                         file_system: file_double,
+                        dir_system: dir_double,
                         factory_cleaner: factory_cleaner)
   end
 
@@ -52,7 +58,7 @@ RSpec.describe CypressDev::SmartFactoryWrapper do
     expect(kernel_double).to have_received(:load).with('file2.rb').once
   end
 
-  it 'will reload the files if a has changed' do
+  it 'will reload the files if any have changed' do
     subject.create(:user)
     expect(kernel_double).to have_received(:load).with('file1.rb').once
     expect(kernel_double).to have_received(:load).with('file2.rb').once
@@ -63,6 +69,18 @@ RSpec.describe CypressDev::SmartFactoryWrapper do
     expect(kernel_double).to have_received(:load).with('file2.rb').twice
   end
 
+  it 'will reload only the files that exist' do
+    subject.always_reload = true
+    subject.create(:user)
+    expect(kernel_double).to have_received(:load).with('file1.rb').once
+    expect(kernel_double).to have_received(:load).with('file2.rb').once
+
+    mtime_hash.delete('file1.rb')
+    subject.create_list(:user)
+    expect(kernel_double).to have_received(:load).with('file1.rb').once
+    expect(kernel_double).to have_received(:load).with('file2.rb').twice
+  end
+
   it 'will reset factory if a has changed' do
     subject.create(:user)
     expect(factory_cleaner).to have_received(:clean).with(factory_double)
@@ -80,4 +98,18 @@ RSpec.describe CypressDev::SmartFactoryWrapper do
     expect(kernel_double).to have_received(:load).with('file1.rb').twice
     expect(kernel_double).to have_received(:load).with('file2.rb').twice
   end
+
+  context 'files is a string' do
+    let(:files) { 'file*.rb' }
+
+    before do
+      allow(Dir).to receive(:[]).with('file*.rb') { mtime_hash.keys }
+    end
+
+    it 'loads all the files on first create it' do
+      subject.create(:user)
+      expect(kernel_double).to have_received(:load).with('file1.rb')
+      expect(kernel_double).to have_received(:load).with('file2.rb')
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cypress-on-rails
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - miceportal team
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-14 00:00:00.000000000 Z
+date: 2018-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack