cyclid 0.3.3 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6d5c64f60ead996640a63f571a67236cbcc6185
-  data.tar.gz: 478f7805d7e8153aa1d98a55da62f52d8543f504
+  metadata.gz: 94bc08b9bc09f947dc23c30549b14fd7a8ab3c36
+  data.tar.gz: 1f26f26ee185b9fcc8e1fd62231cc21fdb9a4e7d
 SHA512:
-  metadata.gz: d9aaeaa77e2f3d9c2c8f0cac5220e4c6a52b95411d8d7123a28b08255d4aa290276da0682c8e12cc6f93bd2c3682be398bb7ef8f5ac7654d5986a18a36bb4bb2
-  data.tar.gz: 31b39a88162dfb9998c65410dae99984bd68b0213484648b5bf2ec699648e5d8f2b17f7cf22dcd0fedb1098fef8444658771d70928732f3ac7b66332f4187fe8
+  metadata.gz: 4d26a3198eca4c25a099274aa518b388594005e18ad8702e652803976f22a3f8b316e2cd60e1d98e1f1096b0948538e30281060ca693b0318ea4d72fe9ec97a8
+  data.tar.gz: fa4f4e04485036074c143baad158684840c7ff58edac9b0d7ec2e3b490133b6803e0c09c57e019113039731c9f1664b38c5035d21acacc05f31bb41531b7f7ec

data/app/cyclid.rb

@@ -36,6 +36,12 @@ module Cyclid
                       else
                         Logger.new(Cyclid.config.log)
                       end
+
+      original_formatter = Logger::Formatter.new
+      Cyclid.logger.formatter = proc { |severity, datetime, progname, msg|
+        original_formatter.call(severity, datetime, progname, "#{Thread.current.object_id}: #{msg}")
+      }
+
     rescue StandardError => ex
       abort "Failed to initialize: #{ex}"
     end

data/app/cyclid/controllers/organizations/job.rb

@@ -104,6 +104,7 @@ module Cyclid
         # @private
         def self.registered(app)
           include Errors::HTTPErrors
+          include Exceptions
           include Constants::JobStatus
 
           # Return a list of jobs
@@ -180,12 +181,12 @@ module Cyclid
             payload = parse_request_body
             Cyclid.logger.debug payload
 
-            halt_with_json_response(400, INVALID_JOB, 'invalid job definition') \
-              unless payload.key? 'sequence' and \
-                     payload.key? 'environment'
-
             begin
               job_id = job_from_definition(payload)
+            rescue NotFoundError => ex
+              halt_with_json_response(404, INVALID_ORG, ex.to_s)
+            rescue InvalidObjectError => ex
+              halt_with_json_response(400, INVALID_JOB, ex.to_s)
             rescue StandardError => ex
               halt_with_json_response(500, INVALID_JOB, "job failed: #{ex}")
             end

data/app/cyclid/controllers/plugins.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+# Copyright 2017 Liqwyd Ltd.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Top level module for all of the core Cyclid code.
+module Cyclid
+  # Module for the Cyclid API
+  module API
+    # API endpoints for plugins information
+    # @api REST
+    class PluginController < ControllerBase
+      include Errors::HTTPErrors
+
+      # Return plugin metadata
+      get '/plugins' do
+        authorized_for!(params[:name], Operations::READ)
+
+        metadata = []
+        Cyclid.plugins.all.each do |plugin|
+          metadata << plugin.metadata
+        end
+
+        return metadata.to_json
+      end
+    end
+
+    # Register this controller
+    Cyclid.controllers << PluginController
+  end
+end

data/app/cyclid/job/helpers.rb

@@ -13,6 +13,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+require 'cyclid/linter'
+
 # Top level module for the core Cyclid code.
 module Cyclid
   # Module for the Cyclid API
@@ -21,15 +23,29 @@ module Cyclid
     module Job
       # Useful methods for dealing with Jobs
       module Helpers
+        include Cyclid::API::Exceptions
+
         # Create & dispatch a Job from the job definition
         def job_from_definition(definition, callback = nil, context = {})
+          # Job definition is a hash (converted from JSON or YAML)
+          definition.symbolize_keys!
+
           # This function will only ever be called from a Sinatra context
           org = Organization.find_by(name: params[:name])
-          halt_with_json_response(404, INVALID_ORG, 'organization does not exist') \
+          raise NotFoundError, 'organization does not exist' \
             if org.nil?
 
+          # Lint the job and reject if there are errors
+          verifier = Cyclid::Linter::Verifier.new
+          verifier.verify(definition)
+
+          raise InvalidObjectError, 'job definition has errors' \
+            unless verifier.status.errors.zero?
+
           # Create a new JobRecord
           job_record = JobRecord.new
+          job_record.job_name = definition[:name]
+          job_record.job_version = definition[:version] || '1.0.0'
           job_record.started = Time.now.to_s
           job_record.status = Constants::JobStatus::NEW
           job_record.save!
@@ -50,13 +66,15 @@ module Cyclid
             job_id = Cyclid.dispatcher.dispatch(job, job_record, callback)
           rescue StandardError => ex
             Cyclid.logger.error "job dispatch failed: #{ex}"
+            Cyclid.logger.debug ex.backtrace.join "\n"
 
             # We couldn't dispatch the job; record the failure
             job_record.status = Constants::JobStatus::FAILED
             job_record.ended = Time.now.to_s
             job_record.save!
 
-            raise
+            # Re-raise something useful
+            raise InternalError, "job dispatch failed: #{ex}"
           end
 
           return job_id

data/app/cyclid/job/job.rb

@@ -25,15 +25,12 @@ module Cyclid
         attr_reader :name, :version
 
         def initialize(job, context, org)
-          # Job is a hash (converted from JSON or YAML)
-          job.symbolize_keys!
-
           @name = job[:name]
           @version = job[:version] || '1.0.0'
 
           @context = context
           @organization = org.name
-          @environment = job[:environment]
+          @environment = job[:environment] || {}
           @sources = job[:sources] || []
           @secrets = setec_astronomy(org, (job[:secrets] || {}))
 

data/app/cyclid/job/stage.rb

@@ -48,6 +48,8 @@ module Cyclid
               action_name = step['action']
               plugin = Cyclid.plugins.find(action_name, Cyclid::API::Plugins::Action)
 
+              raise NameError, "unknown action #{action_name}" if plugin.nil?
+
               step_action = plugin.new(step)
               raise ArgumentError if step_action.nil?
 

data/app/cyclid/plugins.rb

@@ -40,6 +40,36 @@ module Cyclid
             Cyclid.plugins.register(self)
           end
 
+          # Return the plugin version
+          def version
+            @version || '1.0.0'
+          end
+
+          # Return the plugin author
+          def author
+            @author || 'Unknown'
+          end
+
+          # Return the plugin license
+          def license
+            @license || 'Unknown'
+          end
+
+          # Return a URL to the plugin homepage
+          def homepage
+            @homepage || 'https://cyclid.io'
+          end
+
+          # Return plugin metadata
+          def metadata
+            { name: @name,
+              type: human_name,
+              version: version,
+              author: author,
+              license: license,
+              homepage: homepage }
+          end
+
           # Does this plugin support configuration data?
           def config?
             false

data/app/cyclid/plugins/action/cobertura.rb

@@ -63,6 +63,14 @@ module Cyclid
           return [false, 0]
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'cobertura'
       end

data/app/cyclid/plugins/action/command.rb

@@ -43,8 +43,9 @@ module Cyclid
 
           Cyclid.logger.debug "cmd: '#{@cmd}' args: #{@args}"
 
-          @env = args[:env] if args.include? :env
-          @path = args[:path] if args.include? :path
+          @env = args[:env]
+          @path = args[:path]
+          @sudo = args[:sudo]
         end
 
         # Note that we don't need to explicitly use the log for transport
@@ -71,7 +72,7 @@ module Cyclid
             path = path ** @ctx unless path.nil?
 
             # Run the command
-            success = @transport.exec(cmd_args, path)
+            success = @transport.exec(cmd_args, path: path, sudo: @sudo)
           rescue KeyError => ex
             # Interpolation failed
             log.write "#{ex.message}\n"
@@ -81,6 +82,14 @@ module Cyclid
           [success, @transport.exit_code]
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'command'
       end

data/app/cyclid/plugins/action/email.rb

@@ -113,6 +113,14 @@ module Cyclid
           [success, 0]
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'email'
 

data/app/cyclid/plugins/action/log.rb

@@ -36,6 +36,14 @@ module Cyclid
           true
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'log'
       end

data/app/cyclid/plugins/action/script.rb

@@ -47,9 +47,8 @@ module Cyclid
                     File.join('/', 'tmp', file)
                   end
 
-          @env = args[:env] if args.include? :env
-
-          Cyclid.logger.debug "script: '#{@script}' path: #{@path}"
+          @env = args[:env]
+          @sudo = args[:sudo]
         end
 
         # Run the script action
@@ -72,7 +71,7 @@ module Cyclid
 
             # Execute the script
             log.write("Running script from #{path}...\n")
-            success = @transport.exec("chmod +x #{path} && #{path}")
+            success = @transport.exec("chmod +x #{path} && #{path}", sudo: @sudo)
           rescue KeyError => ex
             # Interpolation failed
             log.write "#{ex.message}\n"
@@ -82,6 +81,14 @@ module Cyclid
           [success, @transport.exit_code]
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'script'
       end

data/app/cyclid/plugins/action/simplecov.rb

@@ -51,6 +51,14 @@ module Cyclid
           return [false, 0]
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'simplecov'
       end

data/app/cyclid/plugins/action/slack.rb

@@ -94,6 +94,14 @@ module Cyclid
           [success, rc]
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'slack'
 

data/app/cyclid/plugins/api/github.rb

@@ -33,6 +33,14 @@ module Cyclid
             return ApiExtension::Controller.new(ApiExtension::GithubMethods, routes)
           end
 
+          # Plugin metadata
+          def metadata
+            super.merge!(version: Cyclid::Api::VERSION,
+                         license: 'Apache-2.0',
+                         author: 'Liqwyd Ltd.',
+                         homepage: 'http://docs.cyclid.io')
+          end
+
           # This plugin has configuration data
           def config?
             true

data/app/cyclid/plugins/api/github/pull_request.rb

@@ -124,6 +124,23 @@ module Cyclid
 
                 callback = GithubCallback.new(auth_token, pr_repository, pr_sha, linkback_url)
                 job_from_definition(job_definition, callback, ctx)
+              rescue NotFoundError
+                @client.create_status(pr_repository, pr_sha, 'error',
+                                      context: 'Cyclid',
+                                      description: 'The Organization does not exist')
+
+                return_failure(404, 'organization does not exist')
+              rescue InvalidObjectError
+                @client.create_status(pr_repository, pr_sha, 'error',
+                                      context: 'Cyclid',
+                                      description: 'The Job definition contains errors')
+
+                return_failure(400, 'job definition contains errors')
+              rescue InternalError
+                @client.create_status(pr_repository, pr_sha, 'error',
+                                      context: 'Cyclid', description: 'An Internal Error occurred')
+
+                return_failure(4500, "internal error: #{ex}")
               rescue StandardError
                 @client.create_status(pr_repository, pr_sha, 'error',
                                       context: 'Cyclid', description: 'An unknown error occurred')

data/app/cyclid/plugins/api/github/push.rb

@@ -104,6 +104,23 @@ module Cyclid
 
                 callback = GithubCallback.new(auth_token, push_repository, push_sha, linkback_url)
                 job_from_definition(job_definition, callback, ctx)
+              rescue NotFoundError
+                @client.create_status(pr_repository, pr_sha, 'error',
+                                      context: 'Cyclid',
+                                      description: 'The Organization does not exist')
+
+                return_failure(404, 'organization does not exist')
+              rescue InvalidObjectError
+                @client.create_status(pr_repository, pr_sha, 'error',
+                                      context: 'Cyclid',
+                                      description: 'The Job definition contains errors')
+
+                return_failure(400, 'job definition contains errors')
+              rescue InternalError
+                @client.create_status(pr_repository, pr_sha, 'error',
+                                      context: 'Cyclid', description: 'An Internal Error occurred')
+
+                return_failure(4500, "internal error: #{ex}")
               rescue StandardError
                 @client.create_status(push_repository, push_sha, 'error',
                                       context: 'Cyclid', description: 'An unknown error occurred')

data/app/cyclid/plugins/builder/docker.rb

@@ -84,6 +84,14 @@ module Cyclid
           container.delete(force: true)
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'docker'
 

data/app/cyclid/plugins/builder/google.rb

@@ -83,7 +83,7 @@ module Cyclid
 
         # Destroy the build host
         def release(_transport, buildhost)
-          name = buildhost['name']
+          name = buildhost[:name]
 
           instance = @api.servers.get(name)
           raise "instance #{name} does not exist" unless instance
@@ -92,6 +92,14 @@ module Cyclid
           raise 'failed to destroy instance' unless instance.destroy
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'google'
 

data/app/cyclid/plugins/dispatcher/local.rb

@@ -70,6 +70,14 @@ module Cyclid
           end
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'local'
       end
@@ -133,7 +141,8 @@ module Cyclid
         class Local
           include Sidekiq::Worker
 
-          sidekiq_options retry: false
+          sidekiq_options retry: false,
+                          queue: 'cyclid_jobs'
 
           # Run a job Runner asynchronously
           def perform(job, job_id, callback_object)
@@ -151,7 +160,9 @@ module Cyclid
               runner = Cyclid::API::Job::Runner.new(job_id, job, notifier)
               success = runner.run
             rescue StandardError => ex
-              Cyclid.logger.error "job runner failed: #{ex}"
+              Cyclid.logger.error "local Sidekiq Worker failed: #{ex}"
+              Cyclid.logger.debug ex.backtrace.join("\n")
+
               success = false
             end
 

data/app/cyclid/plugins/provisioner/centos.rb

@@ -41,6 +41,14 @@ module Cyclid
           end
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'centos'
 

data/app/cyclid/plugins/provisioner/debian.rb

@@ -26,7 +26,7 @@ module Cyclid
           transport.export_env('DEBIAN_FRONTEND' => 'noninteractive')
 
           # Build hosts may require an update before anything can be installed
-          success = transport.exec 'apt-get update -qq'
+          success = transport.exec('apt-get update -qq', sudo: true)
           raise 'failed to update repositories' unless success
 
           if env.key? :repos
@@ -44,13 +44,15 @@ module Cyclid
             end
 
             # We must update again to cache the new repositories
-            success = transport.exec 'apt-get update -q'
+            success = transport.exec('apt-get update -q', sudo: true)
             raise 'failed to update repositories' unless success
           end
 
           if env.key? :packages
-            success = transport.exec \
-              "apt-get install -q -y #{env[:packages].join(' ')}" \
+            success = transport.exec( \
+              "apt-get install -q -y #{env[:packages].join(' ')}", \
+              sudo: true
+            )
 
             raise "failed to install packages #{env[:packages].join(' ')}" unless success
           end
@@ -59,6 +61,14 @@ module Cyclid
           raise
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         private
 
         def add_http_repository(transport, url, repo, buildhost)
@@ -70,8 +80,10 @@ module Cyclid
           components = repo[:components]
           fragment = "deb #{url} #{release} #{components}"
 
-          success = transport.exec \
-            "sh -c \"echo '#{fragment}' | tee -a /etc/apt/sources.list.d/cyclid.list\""
+          success = transport.exec( \
+            "sh -c \"echo '#{fragment}' | tee -a /etc/apt/sources.list.d/cyclid.list\"", \
+            sudo: true
+          )
           raise "failed to add repository #{url}" unless success
 
           return unless repo.key? :key_id
@@ -79,12 +91,16 @@ module Cyclid
           # Import the signing key
           key_id = repo[:key_id]
 
-          success = transport.exec \
-            "gpg --keyserver keyserver.ubuntu.com --recv-keys #{key_id}"
+          success = transport.exec( \
+            "gpg --keyserver keyserver.ubuntu.com --recv-keys #{key_id}", \
+            sudo: true
+          )
           raise "failed to import key #{key_id}" unless success
 
-          success = transport.exec \
-            "sh -c 'gpg -a --export #{key_id} | apt-key add -'"
+          success = transport.exec( \
+            "sh -c 'gpg -a --export #{key_id} | apt-key add -'", \
+            sudo: true
+          )
           raise "failed to add repository key #{key_id}" unless success
         end
 

data/app/cyclid/plugins/provisioner/fedora.rb

@@ -41,6 +41,14 @@ module Cyclid
           end
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'fedora'
 

data/app/cyclid/plugins/provisioner/redhat/helpers.rb

@@ -30,28 +30,28 @@ module Cyclid
 
           # Install the yum-utils package
           def install_yum_utils(transport)
-            transport.exec 'yum install -q -y yum-utils'
+            transport.exec('yum install -q -y yum-utils', sudo: true)
           end
 
           # Import a signing key with RPM
           def import_signing_key(transport, key_url)
-            transport.exec("rpm #{quiet} --import #{key_url}") \
+            transport.exec("rpm #{quiet} --import #{key_url}", sudo: true)
           end
 
           # Install a package group with yum
           def yum_groupinstall(transport, groups)
             grouplist = groups.map{ |g| "\"#{g}\"" }.join(' ')
-            transport.exec "yum groupinstall #{quiet} -y #{grouplist}"
+            transport.exec("yum groupinstall #{quiet} -y #{grouplist}", sudo: true)
           end
 
           # Install a list of packages with yum
           def yum_install(transport, packages)
-            transport.exec "yum install #{quiet} -y #{packages.join(' ')}"
+            transport.exec("yum install #{quiet} -y #{packages.join(' ')}", sudo: true)
           end
 
           # Add a repository with yum-config-manager
           def yum_add_repo(transport, url)
-            transport.exec("yum-config-manager #{quiet} --add-repo #{url}")
+            transport.exec("yum-config-manager #{quiet} --add-repo #{url}", sudo: true)
           end
 
           # Use DNF to configure & install Fedora
@@ -60,7 +60,7 @@ module Cyclid
 
             if env.key? :repos
               # We need the config-manager plugin
-              transport.exec("dnf install #{quiet} -y 'dnf-command(config-manager)'")
+              transport.exec("dnf install #{quiet} -y 'dnf-command(config-manager)'", sudo: true)
 
               env[:repos].each do |repo|
                 next unless repo.key? :url
@@ -71,20 +71,20 @@ module Cyclid
 
                 if repo[:url] =~ /\.rpm$/
                   # If the URL is an RPM just install it
-                  transport.exec("dnf install #{quiet} -y #{repo[:url]}")
+                  transport.exec("dnf install #{quiet} -y #{repo[:url]}", sudo: true)
                 else
                   # Not an RPM? Let's hope it's a repo file
-                  transport.exec("dnf config-manager #{quiet} --add-repo #{repo[:url]}")
+                  transport.exec("dnf config-manager #{quiet} --add-repo #{repo[:url]}", sudo: true)
                 end
               end
             end
 
             if env.key? :groups
               groups = env[:groups].map{ |g| "\"#{g}\"" }.join(' ')
-              transport.exec "dnf groups install #{quiet} -y #{groups}"
+              transport.exec("dnf groups install #{quiet} -y #{groups}", sudo: true)
             end
 
-            transport.exec "dnf install #{quiet} -y #{env[:packages].join(' ')}" \
+            transport.exec("dnf install #{quiet} -y #{env[:packages].join(' ')}", sudo: true) \
               if env.key? :packages
           end
 
@@ -105,7 +105,7 @@ module Cyclid
 
                 if repo[:url] =~ /\.rpm$/
                   # If the URL is an RPM just install it
-                  transport.exec("yum install #{quiet} -y --nogpgcheck #{repo[:url]}")
+                  transport.exec("yum install #{quiet} -y --nogpgcheck #{repo[:url]}", sudo: true)
                 else
                   # Not an RPM? Let's hope it's a repo file
                   yum_add_repo(transport, repo[:url])
@@ -137,7 +137,8 @@ module Cyclid
 
                 if repo[:url] =~ /\.rpm$/
                   # If the URL is an RPM just install it
-                  transport.exec("yum localinstall #{quiet} -y --nogpgcheck #{repo[:url]}")
+                  transport.exec("yum localinstall #{quiet} -y --nogpgcheck #{repo[:url]}", \
+                                 sudo: true)
                 else
                   # Not an RPM? Let's hope it's a repo file
                   yum_add_repo(transport, repo[:url])
@@ -163,7 +164,7 @@ module Cyclid
                   if repo.key? :key_url
 
                 # Assume the URL is an RPM
-                transport.exec("rpm -U #{quiet} #{repo[:url]}")
+                transport.exec("rpm -U #{quiet} #{repo[:url]}", sudo: true)
               end
             end
 

data/app/cyclid/plugins/provisioner/rhel.rb

@@ -41,6 +41,14 @@ module Cyclid
           end
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'rhel'
 

data/app/cyclid/plugins/provisioner/ubuntu.rb

@@ -26,12 +26,12 @@ module Cyclid
           transport.export_env('DEBIAN_FRONTEND' => 'noninteractive')
 
           # Build hosts may require an update before anything can be installed
-          success = transport.exec 'apt-get update -qq'
+          success = transport.exec('apt-get update -qq', sudo: true)
           raise 'failed to update repositories' unless success
 
           if env.key? :repos
             # Ensure apt-add-repository is available
-            transport.exec 'apt-get install -qq -y software-properties-common'
+            transport.exec('apt-get install -qq -y software-properties-common', sudo: true)
 
             env[:repos].each do |repo|
               next unless repo.key? :url
@@ -50,13 +50,15 @@ module Cyclid
             end
 
             # We must update again to cache the new repositories
-            success = transport.exec 'apt-get update -q'
+            success = transport.exec('apt-get update -q', sudo: true)
             raise 'failed to update repositories' unless success
           end
 
           if env.key? :packages
-            success = transport.exec \
-              "apt-get install -q -y #{env[:packages].join(' ')}" \
+            success = transport.exec( \
+              "apt-get install -q -y #{env[:packages].join(' ')}", \
+              sudo: true
+            )
 
             raise "failed to install packages #{env[:packages].join(' ')}" unless success
           end
@@ -65,10 +67,18 @@ module Cyclid
           raise
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         private
 
         def add_ppa_repository(transport, url)
-          success = transport.exec "apt-add-repository -y #{url}"
+          success = transport.exec("apt-add-repository -y #{url}", sudo: true)
           raise "failed to add repository #{url}" unless success
         end
 
@@ -81,8 +91,10 @@ module Cyclid
           components = repo[:components]
           fragment = "deb #{url} #{release} #{components}"
 
-          success = transport.exec \
-            "sh -c \"echo '#{fragment}' | tee -a /etc/apt/sources.list.d/cyclid.list\""
+          success = transport.exec( \
+            "sh -c \"echo '#{fragment}' | tee -a /etc/apt/sources.list.d/cyclid.list\"", \
+            sudo: true
+          )
           raise "failed to add repository #{url}" unless success
 
           return unless repo.key? :key_id
@@ -90,12 +102,16 @@ module Cyclid
           # Import the signing key
           key_id = repo[:key_id]
 
-          success = transport.exec \
-            "gpg --keyserver keyserver.ubuntu.com --recv-keys #{key_id}"
+          success = transport.exec( \
+            "gpg --keyserver keyserver.ubuntu.com --recv-keys #{key_id}", \
+            sudo: true
+          )
           raise "failed to import key #{key_id}" unless success
 
-          success = transport.exec \
-            "sh -c 'gpg -a --export #{key_id} | apt-key add -'"
+          success = transport.exec( \
+            "sh -c 'gpg -a --export #{key_id} | apt-key add -'", \
+            sudo: true
+          )
           raise "failed to add repository key #{key_id}" unless success
         end
 

data/app/cyclid/plugins/source/git.rb

@@ -40,7 +40,7 @@ module Cyclid
             # username
             url.user = source[:token] if source.key? :token
 
-            success = transport.exec("git clone #{url}", ctx[:workspace])
+            success = transport.exec("git clone #{url}", path: ctx[:workspace])
             return false unless success
 
             # If a branch was given, check it out
@@ -51,16 +51,24 @@ module Cyclid
             match = url.path.match(%r{^.*\/([^\.]*)})
             source_dir = "#{ctx[:workspace]}/#{match[1]}"
 
-            success = transport.exec("git fetch origin #{branch}:#{branch}", source_dir)
+            success = transport.exec("git fetch origin #{branch}:#{branch}", path: source_dir)
             return false unless success
 
-            success = transport.exec("git checkout #{branch}", source_dir)
+            success = transport.exec("git checkout #{branch}", path: source_dir)
             return false unless success
           end
 
           return true
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         # Register this plugin
         register_plugin 'git'
 

data/app/cyclid/plugins/transport.rb

@@ -38,7 +38,7 @@ module Cyclid
         end
 
         # Run a command on the remote host.
-        def exec(_cmd, _path = nil)
+        def exec(_cmd, _args = {})
           false
         end
 

data/app/cyclid/plugins/transport/dockerapi.rb

@@ -49,8 +49,11 @@ module Cyclid
         end
 
         # Execute a command via the Docker API
-        def exec(cmd, path = nil)
-          command = build_command(cmd, path, @env)
+        def exec(cmd, args = {})
+          sudo = args[:sudo] || false
+          path = args[:path]
+
+          command = build_command(cmd, sudo, path, @env)
           Cyclid.logger.debug "command=#{command}"
           result = @container.exec(command, wait: 300) do |_stream, chunk|
             @log.write chunk
@@ -70,11 +73,19 @@ module Cyclid
           io.write(result)
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         register_plugin('dockerapi')
 
         private
 
-        def build_command(cmd, path = nil, env = {})
+        def build_command(cmd, sudo, path = nil, env = {})
           command = []
           if env
             vars = env.map do |k, value|
@@ -88,8 +99,10 @@ module Cyclid
           command << "cd #{path}" if path
           command << if @username == 'root'
                        cmd
+                     elsif sudo
+                       "sudo -E -n $SHELL -l -c '#{cmd}'"
                      else
-                       "sudo -E #{cmd}"
+                       cmd
                      end
           ['sh', '-l', '-c', command.join(';')]
         end

data/app/cyclid/plugins/transport/ssh.rb

@@ -66,8 +66,11 @@ module Cyclid
         end
 
         # Execute a command via. SSH
-        def exec(cmd, path = nil)
-          command = build_command(cmd, path, @env)
+        def exec(cmd, args = {})
+          sudo = args[:sudo] || false
+          path = args[:path]
+
+          command = build_command(cmd, sudo, path, @env)
           Cyclid.logger.debug "command=#{command}"
 
           @session.open_channel do |channel|
@@ -125,9 +128,17 @@ module Cyclid
           @session.close
         end
 
+        # Plugin metadata
+        def self.metadata
+          super.merge!(version: Cyclid::Api::VERSION,
+                       license: 'Apache-2.0',
+                       author: 'Liqwyd Ltd.',
+                       homepage: 'http://docs.cyclid.io')
+        end
+
         private
 
-        def build_command(cmd, path = nil, env = {})
+        def build_command(cmd, sudo, path = nil, env = {})
           command = []
           if env
             vars = env.map do |k, value|
@@ -141,8 +152,10 @@ module Cyclid
           command << "cd #{path}" if path
           command << if @username == 'root'
                        cmd
+                     elsif sudo
+                       "sudo -E -n $SHELL -l -c '#{cmd}'"
                      else
-                       "sudo -E #{cmd}"
+                       cmd
                      end
           command.join(';')
         end

data/lib/cyclid/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module Cyclid
   module Api
-    VERSION = '0.3.3'
+    VERSION = '0.4.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cyclid
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.4.0
 platform: ruby
 authors:
 - Kristian Van Der Vliet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-24 00:00:00.000000000 Z
+date: 2017-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
@@ -383,6 +383,7 @@ files:
 - app/cyclid/controllers/organizations/job.rb
 - app/cyclid/controllers/organizations/members.rb
 - app/cyclid/controllers/organizations/stages.rb
+- app/cyclid/controllers/plugins.rb
 - app/cyclid/controllers/users.rb
 - app/cyclid/controllers/users/collection.rb
 - app/cyclid/controllers/users/document.rb