customer_score 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f08c8c228668114a834da0d41b8eebf31a40a909
-  data.tar.gz: f70224278aa293022e5afd8fbf2ff84be51d3608
+  metadata.gz: 6b966b93d0b8287473dd8ef25f61d334af7058b9
+  data.tar.gz: fe94e3d98f237a6829c75fa71a43be5b751302c8
 SHA512:
-  metadata.gz: cd9589c7151c80694fdfa0828d8f285e62184d0f6ee7f2049439f5a73ca8c64eeb3b8c976abb25c3cd2b082a0e51b44ba11c683bea8f690f97a3ee7bb2b74ab2
-  data.tar.gz: 390723c31409e765e94400f2d33217099fbcd854871140f673a723834e6e4003e2a17d017bf83890b351d36d61aa352c4998bbcdeec245a72897787705d322e6
+  metadata.gz: f1fe8128094ef083285ad125d1c1da922b7e9e79dde2b52f1c8d516ca9869fc79367fdd7f58ef0cb3ecc38482fb0bce4240c843d2610b60548f609e43696dfb2
+  data.tar.gz: c994562ecef0698a431c0747360112628b618c4635aa6ca434da3ef942bc309dd7524b4ccce14c307abb8b758ddcff700a214bd7ecde7d4e0dfc3f0916647e2a

data/README.md

@@ -32,15 +32,13 @@ To retrieve scoring advice for a customer based on their income, zipcode, and ag
 
 ````ruby
 score = client.get_score("5000", "60201", "35")
-#=> "{:propensity => 0.26532, :ranking => "C"}"
+#=> {:propensity => 0.26532, :ranking => "C"}
 ```
 
 
-## Development
+## Testing
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake false` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
-
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To run tests, run `rake spec` in your console.
 
 ## Contributing
 

data/Rakefile

@@ -1 +1,6 @@
 require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+
+RSpec::Core::RakeTask.new
+task :default => :spec

data/customer_score.gemspec

@@ -30,4 +30,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.10"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_dependency 'unirest', "~> 1.1.2"
+  spec.add_development_dependency "webmock", "~> 1.14.0"
+  
 end

data/lib/customer_score/version.rb

@@ -1,3 +1,3 @@
 module CustomerScore
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/customer_score.rb

@@ -3,28 +3,38 @@ require "unirest"
 
 module CustomerScore
   class Client
+
     def initialize()
       @default_url = "http://not_real.com/customer_scoring"
     end
 
     def get_score(income, zipcode, age)
+
+      return "Please provide a valid income (no commas or decimals)" unless income.to_s !~ /\d+[,.]\d+/ 
+      return "Please provide a valid 6 or 10 digit zipcode" if zipcode.to_s !~ /^\d{5}(-\d{4})?$/
+      return "Please provide a valid age" unless age.to_s !~ /\d+[,.]\d+/ 
+     
       url = "#{@default_url}?income=#{income}&zipcode=#{zipcode}&age=#{age}"
-      case status = Unirest.get(url).code
+
+      case status = get_status(url)
       when 200
         return Unirest.get(url).body
       when 404 
-        raise ResourceNotFound, "Invalid URL"
-      when 422
-        raise InvalidInput, "Unprocessable Entity"
+        raise ResourceNotFound, "The specified resource does not exist"
       when 500
-        raise InternalError, "Internal Server Error"
+        raise InternalError, "The server encountered an internal error, please retry the request"
       else
-        raise "Error"
+        raise "Error, your request was not completed"
       end
     end
+
+    def get_status(url)
+      Unirest.get(url).code
+    end
+
   end
 
   class ResourceNotFound < Exception; end
-  class InvalidInput < Exception; end
   class InternalError < Exception; end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: customer_score
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - zoe heins
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-04-11 00:00:00.000000000 Z
+date: 2016-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.1.2
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.14.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.14.0
 description: Allows you to access scoring advice on customer
 email:
 - zcheins@gmail.com