custom_counter_cache 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 400ada3c3c7715a41f90c457b92c2657c1e78aba
-  data.tar.gz: 77fe16bc8457b85e482fdacd12a0b98f9c68c652
+  metadata.gz: 7b8cf04cebca60ef8b7cb77c5c54f0392c682e3a
+  data.tar.gz: 26aa1c6f245700136fe05a317ca2f7838b11ed57
 SHA512:
-  metadata.gz: f8fa7062dde06853f72ec4879d90c4ea4c5fda69cf49274166b8ca24aa91660dfed29bdf55bb6fdad1d8a5be139d683cd80efc66767a65bb3d611fa3b83ff0ef
-  data.tar.gz: a1626989296134b9c7cc5c30dba4eb32442932bfa54b9ba4d007a476df41ca40d2343d5c215b42896deb571838ac20d0109e9f4fd9b2dc871c4bab54eadc9ac5
+  metadata.gz: faedbd90dd2d0c094d53f0e6742453fcde890e69da1dbc554d96d0e19f2d6b009d4adcafc040a441f078ee11f93fd45a354f2fcd13b6da98c3e0c79700e7b630
+  data.tar.gz: f843efb8ff01722e9cc5e064f8c0d9c27392508b7559037ee6ee751b3537bdc35342377e38df64f82b10bfb59d35024d4926c35cecd726ded9c13d62fec4babd

data/lib/custom_counter_cache/version.rb

@@ -1,5 +1,5 @@
 module CustomCounterCache
 
-  VERSION = '0.2.3'
+  VERSION = '0.2.4'
 
 end

data/test/test_helper.rb

@@ -44,6 +44,15 @@ end
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
   include CustomCounterCache::Model
+  @@rails_5_1_or_newer = ActiveModel.version >= Gem::Version.new('5.1.0')
+
+  def saved_change_to_attribute_compat?(attr)
+    if @@rails_5_1_or_newer
+      saved_change_to_attribute?(attr)
+    else
+      attribute_changed?(attr)
+    end
+  end
 end
 
 class User < ApplicationRecord
@@ -55,7 +64,7 @@ end
 
 class Article < ApplicationRecord
   belongs_to :user
-  update_counter_cache :user, :published_count, if: Proc.new { |article| article.state_changed? }
+  update_counter_cache :user, :published_count, if: Proc.new { |article| article.saved_change_to_attribute_compat?(:state) }
   has_many :comments, as: :commentable, dependent: :destroy
   define_counter_cache :comments_count do |article|
     article.comments.where(state: "published").count
@@ -64,7 +73,7 @@ end
 
 class Comment < ApplicationRecord
   belongs_to :commentable, polymorphic: true
-  update_counter_cache :commentable, :comments_count, if: Proc.new { |comment| comment.state_changed? }
+  update_counter_cache :commentable, :comments_count, if: Proc.new { |comment| comment.saved_change_to_attribute_compat?(:state) }
 end
 
 class Counter < ApplicationRecord
@@ -87,7 +96,7 @@ end
 class Ball < ApplicationRecord
   belongs_to :box
   scope :green, lambda { where(color: 'green') }
-  update_counter_cache :box, :green_balls_count, if: Proc.new { |ball| ball.color_changed? }
+  update_counter_cache :box, :green_balls_count, if: Proc.new { |ball| ball.saved_change_to_attribute_compat?(:color) }
   update_counter_cache :box, :lifetime_balls_count, except: [:update, :destroy]
   update_counter_cache :box, :destroyed_balls_count, only: [:destroy]
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: custom_counter_cache
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Cedric Howe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2019-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -31,6 +31,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -38,6 +41,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.4.0
 description: ''
 email: cedric@howe.net
 executables: []
@@ -75,5 +81,5 @@ specification_version: 4
 summary: Custom counter_cache functionality that supports conditions and multiple
   models.
 test_files:
-- test/counter_test.rb
 - test/test_helper.rb
+- test/counter_test.rb