currency_converter 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54926655f0b8f648e0d2b014d6f1bd3b0f37dbb8
-  data.tar.gz: 98d7de1b04b89e210f6d4533b1e10fb8e71a9d86
+  metadata.gz: 5d941b72d7db2416895b8934b4acac8fd2739f3e
+  data.tar.gz: 03e7bd53d1984e7d0e17200f18af2f111e37e407
 SHA512:
-  metadata.gz: 6edc9863b7d5be579d0e44bb37e27fff824861ad0e8503a2cb106c0546b5ad8af86da450c7d5500ead5b85cc778e13915390186f00950f8a0b88e9a8cb40be77
-  data.tar.gz: 130b1a83cb7415a37385729696d37651fc3ce3f5a187fa37f098afd4e68ac492b93f8c6d0bb547ff975ac9bf25048d7e22bd6f3a87759a43fe7e95d7f744c6a7
+  metadata.gz: e9011f2aef8d40a5a1bf471e4f9a85ebeecf693b2c2fa6ccf0927ed4dceb929687deb56f4d04f1f1dacb75aed8e9eaa18c3f91d3dbf3338e072d096ff56d68a1
+  data.tar.gz: 3e358814142b2d4b06780f0ac742ee6e430af20c04eff51fb99e4d0b80f993e3e7f5d3d57437079fd18f7e5b854af80fba6dc96b5c93ccda88195886b2c6fdad

data/.coveralls.yml

@@ -0,0 +1,2 @@
+service_name: travis-ci
+repo_token: tYOGn64AUQQ7jxe0VCi8JhcMwHc8gawTc

data/.travis.yml

@@ -5,6 +5,7 @@ rvm:
   - 2.1.0
   - 2.1.1
   - 2.2
+  - 2.4.3
 
 before_install:
   - gem install bundler

data/Gemfile

@@ -1,4 +1,8 @@
 source 'https://rubygems.org'
 
+group :test do
+  gem 'coveralls', require: false
+end
+
 # Specify your gem's dependencies in currency.gemspec
 gemspec

data/README.md

@@ -1,5 +1,7 @@
 # CurrencyConverter
 
+[![Gem Version](https://badge.fury.io/rb/currency_converter.svg)](http://badge.fury.io/rb/currency_converter) [![Build Status](https://travis-ci.org/dark-prince/currency_converter.svg)](https://travis-ci.org/dark-prince/currency_converter) [![Code Climate](https://codeclimate.com/github/dark-prince/currency_converter.png)](https://codeclimate.com/github/dark-prince/currency_converter) [![Dependency Status](https://gemnasium.com/dark-prince/currency_converter.svg)](https://gemnasium.com/dark-prince/currency_converter) [![License](http://img.shields.io/license/MIT.png)](http://opensource.org/licenses/MIT) [![Coverage Status](https://coveralls.io/repos/dark-prince/currency_converter/badge.png?branch=master)](https://coveralls.io/r/dark-prince/currency_converter?branch=master)
+
 Simple Ruby API to get exchange rates from currencies using Google finance currency converter and Yahoo finance currency converter. You can convert currencies directly through this library.
 
 ## Installation
@@ -21,19 +23,19 @@ Or install it yourself as:
 To convert between two currencies using Google finance currency converter:
 
     currency_converter = CurrencyConverter::Google.new
-    currency_converter.exchange("EUR", "USD", 100)
+    currency_converter.exchange('EUR', 'USD', 100)
     => 132.89
 
-    currency_converter.exchange("USD", "EUR", 100)
+    currency_converter.exchange('USD', 'EUR', 100)
     => 75.15
 
 To convert between two currencies using Yahoo finance currency converter:
 
     currency_converter = CurrencyConverter::Yahoo.new
-    currency_converter.exchange("EUR", "USD", 1)
+    currency_converter.exchange('EUR', 'USD', 1)
     => 1.33
 
-    currency_converter.exchange("USD", "EUR", 1)
+    currency_converter.exchange('USD', 'EUR', 1)
     => 0.75
 
 ## Contributing

data/currency_converter.gemspec

@@ -20,13 +20,12 @@ Gem::Specification.new do |spec|
   spec.test_files             = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths          = ['lib']
 
-  spec.required_ruby_version  = '>= 1.8.7'
+  spec.required_ruby_version  = '>= 2.0.0'
   spec.add_dependency 'nokogiri'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake', '< 12.0.0'
-
-  spec.add_development_dependency 'rspec', '~> 2.14'
-  spec.add_development_dependency 'yard', '~> 0.8'
-  spec.add_development_dependency 'kramdown', '~> 1.1'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'yard'
+  spec.add_development_dependency 'kramdown'
 end

data/lib/currency_converter/google.rb

@@ -19,8 +19,8 @@ module CurrencyConverter
     #
     # @example
     # currency_converter = CurrencyConverter::Google.new
-    # currency_converter.exchange("USD", "EUR", 100)
-    # currency_converter.exchange("USD", "INR", 100)
+    # currency_converter.exchange('USD', 'EUR', 100)
+    # currency_converter.exchange('USD', 'INR', 100)
     def exchange(from, to, fixnum)
       @from_currency = from.upcase.to_sym
       @to_currency = to.upcase.to_sym
@@ -52,16 +52,14 @@ module CurrencyConverter
 
       return $1
     rescue Timeout::Error
-      raise StandardError, "Please check your internet connection"
+      raise StandardError, 'Please check your internet connection'
     end
 
-    # Raise errors for invalid currencies.
     def validate_currency
       raise CurrencyConverter::UnknownCurrency.new(from_currency) unless CurrencyConverter::CURRENCIES.has_key?(from_currency)
       raise CurrencyConverter::UnknownCurrency.new(to_currency) unless CurrencyConverter::CURRENCIES.has_key?(to_currency)
     end
 
-    # Raise errors for missing data.
     def validate_rate(rate)
       raise CurrencyConverter::MissingExchangeRate.new(from_currency, to_currency) if rate.to_f.zero?
     end

data/lib/currency_converter/version.rb

@@ -1,3 +1,3 @@
 module CurrencyConverter
-  VERSION = "1.1.1"
+  VERSION = '1.1.2'
 end

data/lib/currency_converter/yahoo.rb

@@ -14,10 +14,12 @@ module CurrencyConverter
     # Returns the array of currencies rates
     attr_reader :rates
 
+    API_URL = 'https://finance.yahoo.com/webservice/v1/symbols/allcurrencies/quote;currency=true?view=basic'
+
     def initialize
       response = fetch_data
 
-      parse_rates(response.body)
+      parse_rates(response)
     end
 
     # Receive the amount of you desire currency.
@@ -28,16 +30,16 @@ module CurrencyConverter
     #
     # @example
     # currency_converter = CurrencyConverter::Yahoo.new
-    # currency_converter.exchange("USD", "EUR", 100)
-    # currency_converter.exchange("USD", "INR", 100)
+    # currency_converter.exchange('USD', 'EUR', 100)
+    # currency_converter.exchange('USD', 'INR', 100)
     def exchange(base, quot, amount)
       @from_currency = base.upcase.to_sym
       @to_currency = quot.upcase.to_sym
 
       validate_currency
 
-      base_rate = rates[@from_currency].to_f
-      quot_rate = rates[@to_currency].to_f
+      base_rate = rates[from_currency].to_f
+      quot_rate = rates[to_currency].to_f
 
       rate = base_rate.zero? ? 0 : (quot_rate / base_rate)
       validate_rate(rate)
@@ -48,33 +50,27 @@ module CurrencyConverter
     private
 
     def fetch_data
-      api = "http://finance.yahoo.com/webservice/v1/symbols/allcurrencies/quote;currency=true?view=basic"
-
-      uri  = URI.parse(api)
-      http = Net::HTTP.new(uri.host, uri.port)
-      http.read_timeout = http.open_timeout = 20
-      http.start { http.request(Net::HTTP::Get.new(uri.to_s)) }
+      Net::HTTP.get(URI(API_URL))
     end
 
     def parse_rates(html)
-      @rates = { :USD => 1.0 }
+      @rates = { USD: 1.0 }
 
       result = Nokogiri::HTML(html)
+
       result.css('resource').each do |resource|
         symbol = resource.xpath(".//field[@name='symbol']").text[0,3]
         price  = resource.xpath(".//field[@name='price']").text
 
-        @rates[symbol.upcase.to_sym] = price.to_f unless symbol.nil? && price.nil?
+        rates[symbol.upcase.to_sym] = price.to_f unless symbol.nil? && price.nil?
       end
     end
 
-    # Raise errors for invalid currencies.
     def validate_currency
       raise UnknownCurrency.new(from_currency) unless CURRENCIES.has_key?(from_currency)
       raise UnknownCurrency.new(to_currency) unless CURRENCIES.has_key?(to_currency)
     end
 
-    # Raise errors for missing data.
     def validate_rate(rate)
       raise MissingExchangeRate.new(from_currency, to_currency) if rate.zero?
     end

data/spec/currency_converter/google_spec.rb

@@ -1,23 +1,23 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe CurrencyConverter::Google do
-  let(:currency_converter) { CurrencyConverter::Google.new }
+  let(:currency_converter) { described_class.new }
 
-  describe "#exchange" do
-    it "returns the correct rate" do
-      expect(currency_converter.exchange("USD", "USD", 1)).to eq 1
+  context '#exchange' do
+    it 'returns the correct rate' do
+      expect(currency_converter.exchange('USD', 'USD', 1)).to eq 1
     end
   end
 
-  describe "#validate_currency" do
-    describe CurrencyConverter::UnknownCurrency do
+  context '#validate_currency' do
+    context 'CurrencyConverter::UnknownCurrency' do
       it 'raise an error on an unsupported currency code' do
-        expect { currency_converter.exchange("EUR", "UNKNOWN", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
-        expect { currency_converter.exchange("UNKNOWN", "EUR", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
+        expect { currency_converter.exchange('EUR', 'UNKNOWN', 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
+        expect { currency_converter.exchange('UNKNOWN', 'EUR', 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
       end
 
       it 'doesn\'t raise an error for supported currency codes' do
-        expect { currency_converter.exchange("EUR", "USD", 100) }.not_to raise_error
+        expect { currency_converter.exchange('EUR', 'USD', 100) }.to_not raise_error
       end
     end
   end

data/spec/currency_converter/yahoo_spec.rb

@@ -1,23 +1,23 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe CurrencyConverter::Yahoo do
-  let(:currency_converter) { CurrencyConverter::Yahoo.new }
+  let(:currency_converter) { described_class.new }
 
-  describe "#exchange" do
-    it "returns the correct rate" do
-      expect(currency_converter.exchange("USD", "USD", 1)).to eq 1
+  context '#exchange' do
+    it 'returns the correct rate' do
+      expect(currency_converter.exchange('USD', 'USD', 1)).to eq 1
     end
   end
 
-  describe "#validate_currency" do
-    describe CurrencyConverter::UnknownCurrency do
+  context '#validate_currency' do
+    context 'CurrencyConverter::UnknownCurrency' do
       it 'raise an error on an unsupported currency code' do
-        expect { currency_converter.exchange("EUR", "UNKNOWN", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
-        expect { currency_converter.exchange("UNKNOWN", "EUR", 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
+        expect { currency_converter.exchange('EUR', 'UNKNOWN', 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
+        expect { currency_converter.exchange('UNKNOWN', 'EUR', 100) }.to raise_error(CurrencyConverter::UnknownCurrency)
       end
 
       it 'doesn\'t raise an error for supported currency codes' do
-        expect { currency_converter.exchange("EUR", "USD", 100) }.not_to raise_error
+        expect { currency_converter.exchange('EUR', 'USD', 100) }.to_not raise_error
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,5 +1,13 @@
 require 'currency_converter'
+require 'coveralls'
+
+Coveralls.wear!
 
 RSpec.configure do |config|
-  config.order = "rand"
+  config.color = true
+  config.order = 'rand'
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: currency_converter
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Diganta Mandal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-01 00:00:00.000000000 Z
+date: 2017-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -28,72 +28,72 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.14'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: kramdown
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '0'
 description: Google provides a web site to converts currencies using exchange rates
   but they have not provided any API for ruby. This is a small library that converts
   currencies exchange rate. You can convert currencies directly through this library.
@@ -103,6 +103,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".coveralls.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
@@ -132,7 +133,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.8.7
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -140,7 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Google provides a web site to converts currencies using exchange rates but