currency_coin_converter 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5fbacf0f12f980a242f4f6c765c1e7195aeb73a36e92f668a23caf7de23ad0d8
-  data.tar.gz: dcd21694c722a945656103f084110d5d42bc77143e6f488ddbaf23b2c000e242
+  metadata.gz: 9e1acd506bad9c54078c6e93298eb1687f3c98384c40587c0982845e466564cf
+  data.tar.gz: 489940cb45f403da132769bb84dcdfc8785633c2f7d18db556332abbda8f2562
 SHA512:
-  metadata.gz: 45dee2fb4709e41770c912927d205428aa24b4574d52777c5761e32091afc49f9b5a4d40c81f789276538371433763a03181ad30340e59d1f1e9e1f74f2a7767
-  data.tar.gz: 0b331d65a475f5eb86d8eca9a5831c60ddfb383e45f03d5c1e916cd0e58a97c52fe644265f4c49592684ac6ddca6bee745d75f8907b0e41da25f92293c73102a
+  metadata.gz: 4aedaef1ae1b57836423c9e481153cc0514ae39bcafd303302e6cc46b15248574e95f1bd36f335f0c3dc413159ca710c51103817ea2c039c9f2208e256682f1a
+  data.tar.gz: 65d932e61bbf521b30730cc62ad65be1426eba333d2d5f13edfa15696e9612a76e78993d23a3d3d4474a1aff8f43d381808fb12bbe6b81d621a08a80b86a5cad

data/CHANGELOG.md

@@ -1,5 +1,5 @@
 ## [Unreleased]
 
-## [0.3.2] - 2024-09-10
+## [0.3.3] - 2024-09-10
 
 - Initial release

data/lib/currency_coin_converter.rb

@@ -4,7 +4,7 @@ require 'singleton'
 require 'uri'
 
 module CurrencyCoinConverter
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 
   class Error < StandardError; end
 
@@ -16,12 +16,12 @@ module CurrencyCoinConverter
     end
 
     def convert(amount, from:, to:, round: 2)
-      (amount * conversion_rate(from:, to:)).round(round)
+      (amount * conversion_rate(from: from, to: to)).round(round)
     end
 
     def conversion_rate(from:, to:)
       conversion_rate = conversion_rates(from)[to]
-      return conversion_rate unless conversion_rate.nil?
+      return conversion_rate if conversion_rate
 
       raise Error, "currency code is invalid: #{to}"
     end
@@ -64,11 +64,11 @@ module CurrencyCoinConverter
       end
 
       def convert(amount, from:, to:, round: 2)
-        instance.convert(amount, from:, to:, round: round)
+        instance.convert(amount, from: from, to: to, round: round)
       end
 
       def conversion_rate(from:, to:)
-        instance.conversion_rate(from:, to:)
+        instance.conversion_rate(from: from, to: to)
       end
 
       def conversion_rates(base_currency)

data/spec/currency_coin_converter_spec.rb

@@ -2,7 +2,14 @@ require 'currency_coin_converter'
 
 require 'json'
 
+RSpec.configure do |config|
+  config.before(:example, :mock_get => true) do
+    allow_any_instance_of(described_class).to receive(:get).with(path: "INR").and_return(response)
+  end
+end
+
 RSpec.describe CurrencyCoinConverter::Base do
+  let(:response) { JSON.parse(File.read("spec/examples/inr.json")) }
   before do
     described_class.api_key = "fake_key"
   end
@@ -15,24 +22,21 @@ RSpec.describe CurrencyCoinConverter::Base do
     expect(described_class.api_version).to eq("v6")
   end
 
-  it '#conversion_rates returns the conversion rate for a valid currency code' do
-    response = JSON.parse(File.read("spec/examples/inr.json"))
-    allow_any_instance_of(described_class).to receive(:get).with(path: "INR").and_return(response)
+  it '#conversion_rates returns the conversion rate for a valid currency code', :mock_get => true do
+    # allow_any_instance_of(described_class).to receive(:get).with(path: "INR").and_return(response)
 
     expect(described_class.conversion_rates("INR")).to eq(response["conversion_rates"])
   end
 
-  it '#conversion_rate returns the conversion rate for valid currency codes' do
-    response = JSON.parse(File.read("spec/examples/inr.json"))
-    allow_any_instance_of(described_class).to receive(:get).with(path: "INR").and_return(response)
+  it '#conversion_rate returns the conversion rate for valid currency codes', :mock_get => true do
+    # allow_any_instance_of(described_class).to receive(:get).with(path: "INR").and_return(response)
 
     expect(described_class.conversion_rate(from: "INR", to: "USD")).to eq(response["conversion_rates"]["USD"])
     expect { described_class.conversion_rate(from: "INR", to: "US") }.to raise_error CurrencyCoinConverter::Error, "currency code is invalid: US"
   end
 
-  it '#convert returns the converted amount from one currency code to another' do
-    response = JSON.parse(File.read("spec/examples/inr.json"))
-    allow_any_instance_of(described_class).to receive(:get).with(path: "INR").and_return(response)
+  it '#convert returns the converted amount from one currency code to another', :mock_get => true do
+    # allow_any_instance_of(described_class).to receive(:get).with(path: "INR").and_return(response)
 
     expect(described_class.convert(130, from: "INR", to: "USD")).to eq(1.55)
     expect(described_class.convert(130, from: "INR", to: "USD", round: 1)).to eq(1.5)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: currency_coin_converter
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Fernanda de Jesus