currency_cloud 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 05d3528f511962b03532b5118e6aa1f12e93dee1
-  data.tar.gz: 90e96cf501b438ca7f3c93f4b20ee4ba0ac5a16c
+  metadata.gz: 56244f4c79912b074416b099f75d2d8b6b64fae8
+  data.tar.gz: 9e0a5976808d20873f383eface2acecb96a17554
 SHA512:
-  metadata.gz: 8fada2f9e4281e22a143fbe0339f3b0d9379fc18195ac189524c3ea5ddd1ace4709601cb492174e0f6a19f39f902e0a640b50e684296ad2992e4845280cf3331
-  data.tar.gz: e2a7fd923bc03e71561a4e70efa055e1aac5226045d6ca1fd51091d7fa7b2cf56337ea5a43cd1da7ee66498c7cb6b0933bcffda41f3907dc0357f1d0485c0f66
+  metadata.gz: 8a46e98ba3b1f58a7ea720d6637fd90f9d000b898365fa47328b923d527ac1ff8ab164a326008489889e4d9ac7196a47365446e3e8cd1001fb7875358a909237
+  data.tar.gz: 6d22fdca021e1c1eded5def2e69ae701fa77bdbf9b4c68ff0e2cf723203fbe6437b91e8b4d4d27b8f064e14a1d60f4d70db7e1f54cf7796ceefca9b999efe0d6

data/.gitignore

@@ -1,2 +1,3 @@
 .DS_Store
 *.gem
+Gemfile.lock

data/Gemfile

@@ -1,7 +1,6 @@
 source 'https://rubygems.org'
 
-
 gem 'sinatra'
 gem 'guard-rspec', require: false
 
-gemspec
+gemspec

data/README.md

@@ -2,7 +2,7 @@
 
 # Currency Cloud
 
-This is the official Ruby SDK for v2 of Currency Cloud's API. Additional documentation 
+This is the official Ruby SDK for v2 of Currency Cloud's API. Additional documentation
 for each API endpoint can be found at [connect.currencycloud.com][connect]. If you have any queries or you require support, please contact our implementation team at implementation@currencycloud.com.
 
 ## Installation
@@ -59,7 +59,7 @@ balances = CurrencyCloud::Balance.find
 ```
 
 ## On Behalf Of
-If you want to make calls on behalf of another user (e.g. someone who has a sub-account with you), you 
+If you want to make calls on behalf of another user (e.g. someone who has a sub-account with you), you
 can execute certain commands 'on behalf of' the user's contact_id. Here is an example:
 
 ```ruby
@@ -126,7 +126,7 @@ error in any correspondence can be very helpful.
 
 # Development
 
-Test cases can be run with: `bundle exec rspec`. There is also a `Guardfile` that 
+Test cases can be run with: `bundle exec rspec`. There is also a `Guardfile` that
 is useful for continuously rerunning tests while you develop.
 
 ## Dependencies

data/currency_cloud.gemspec

@@ -4,7 +4,7 @@ require 'currency_cloud/version'
 
 spec = Gem::Specification.new do |s|
   s.name = 'currency_cloud'
-  s.version = CurrencyCloud::Version
+  s.version = CurrencyCloud::VERSION
   s.summary = 'Ruby SDK for the Currency Cloud API'
   s.description = 'Ruby SDK for the Currency Cloud API - https://connect.currencycloud.com/'
   s.authors = ['Liam McAndrew', 'Richard Nienaber']
@@ -15,7 +15,7 @@ spec = Gem::Specification.new do |s|
 
   s.add_dependency('httparty', '~> 0.13')
   s.add_dependency('json', '~> 1.8')
-  
+
   s.add_development_dependency('rspec', '~> 3.1')
   s.add_development_dependency('rake', '~> 10.3')
   s.add_development_dependency('webmock', '~> 1.21')
@@ -25,4 +25,4 @@ spec = Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- spec/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ['lib']
-end
+end

data/lib/currency_cloud.rb

@@ -13,7 +13,7 @@ module CurrencyCloud
   class << self
      attr_accessor :environment, :login_id, :api_key, :token
   end
-  
+
   def self.session
     @session ||= CurrencyCloud::Session.new(environment, login_id, api_key, token)
   end
@@ -22,7 +22,7 @@ module CurrencyCloud
     @session.close if @session
     true
   end
-  
+
   def self.reset_session
     @session = nil
     @token = nil

data/lib/currency_cloud/{resources/account.rb → account.rb}

@@ -1,6 +1,8 @@
 module CurrencyCloud
-  class Account < Resource
+  class Account
+    include CurrencyCloud::Resource
+
     resource :accounts
     actions :create, :retrieve, :find, :update, :current
   end
-end
+end

data/lib/currency_cloud/actions.rb

@@ -0,0 +1,13 @@
+require_relative "actions/create"
+require_relative "actions/current"
+require_relative "actions/delete"
+require_relative "actions/find"
+require_relative "actions/instance_delete"
+require_relative "actions/retrieve"
+require_relative "actions/save"
+require_relative "actions/update"
+
+module CurrencyCloud
+  module Actions
+  end
+end

data/lib/currency_cloud/actions/create.rb

@@ -1,9 +1,10 @@
 module CurrencyCloud
   module Actions
     module Create
-      def create(params={})
-        post("create", params)
+      def create(params = {})
+        attrs = client.post("create", params)
+        new(attrs)
       end
     end
   end
-end
+end

data/lib/currency_cloud/actions/current.rb

@@ -2,8 +2,9 @@ module CurrencyCloud
   module Actions
     module Current
       def current
-        get('current')
+        attrs = client.get("current")
+        new(attrs)
       end
     end
   end
-end
+end

data/lib/currency_cloud/actions/delete.rb

@@ -1,21 +1,16 @@
 module CurrencyCloud
   module Actions
-    
     module Delete
+      def self.extended(base)
+        base.send(:include, InstanceDelete) # Private before Ruby 2.1
+      end
 
       # TODO: Set state to be deleted
       # TODO: Disable all actionable methods / freeze?
-      
       def delete(id)
-        post("#{id}/delete")
-      end       
-    end
-
-    module InstanceDelete
-      def delete
-        self.class.delete(id)
-        self
-      end       
+        attrs = client.post("#{id}/delete")
+        new(attrs)
+      end
     end
   end
-end
+end

data/lib/currency_cloud/actions/find.rb

@@ -1,17 +1,15 @@
 module CurrencyCloud
   module Actions
-    
+
     module Find
 
       def find(params={})
-        response = request.get("#{self.resource}/find", params)
+        response = client.get("find", params)
         mixin_class.new(self.resource, self, response)
       end
-       
-      def first(params={})
-        entities = find((params || {}).merge(per_page: 1))
-        return nil if entities.empty?
 
+      def first(params={})
+        entities = find(params.merge(per_page: 1)) || []
         entities.first
       end
 
@@ -24,4 +22,4 @@ module CurrencyCloud
       end
     end
   end
-end
+end

data/lib/currency_cloud/actions/instance_delete.rb

@@ -0,0 +1,10 @@
+module CurrencyCloud
+  module Actions
+    module InstanceDelete
+      def delete
+        self.class.delete(id)
+        self
+      end
+    end
+  end
+end

data/lib/currency_cloud/actions/retrieve.rb

@@ -1,9 +1,10 @@
 module CurrencyCloud
-  module Actions    
+  module Actions
     module Retrieve
       def retrieve(id)
-        get(id)
-      end       
+        attrs = client.get(id)
+        new(attrs)
+      end
     end
   end
-end
+end

data/lib/currency_cloud/actions/save.rb

@@ -3,12 +3,13 @@ module CurrencyCloud
     module Save
       def save
         return self if changed_attributes.empty?
-        
-        params = Hash[changed_attributes.map { |k| [k, self.send(k)] }]
-        post(id, params)
+
+        params = attributes.select { |attr| changed_attributes.include?(attr) }
+        attrs = client.post(id, params)
         changed_attributes.clear
+        self.attributes = attrs
         self
       end
     end
   end
-end
+end

data/lib/currency_cloud/actions/update.rb

@@ -1,12 +1,16 @@
 module CurrencyCloud
   module Actions
     module Update
+      def self.extended(base)
+        base.send(:include, Save) # Private before Ruby 2.1
+      end
 
       # TODO: Add .save instance method, which calls update on changed attributes
 
       def update(id, params)
-        post("#{id}", params)
+        attrs = client.post("#{id}", params)
+        new(attrs)
       end
     end
   end
-end
+end

data/lib/currency_cloud/{resources/balance.rb → balance.rb}

@@ -1,10 +1,12 @@
 module CurrencyCloud
-  class Balance < Resource
+  class Balance
+    include CurrencyCloud::Resource
+
     resource :balances
     actions :find
 
     def self.currency(ccy)
-      get(ccy)
+      new(client.get(ccy))
     end
   end
-end
+end

data/lib/currency_cloud/{resources/beneficiary.rb → beneficiary.rb}

@@ -1,13 +1,12 @@
 module CurrencyCloud
-  
-  class Beneficiary < Resource
-    
+  class Beneficiary
+    include CurrencyCloud::Resource
+
     resource :beneficiaries
-    
     actions :create, :retrieve, :find, :update, :delete
-    
+
     def self.validate(params)
-      post('validate', params)
-    end        
+      new(client.post("validate", params))
+    end
   end
-end
+end

data/lib/currency_cloud/client.rb

@@ -0,0 +1,27 @@
+module CurrencyCloud
+  class Client
+    def initialize(resource)
+      @resource = resource
+    end
+
+    def get(url, params={})
+      request.get(build_url(url), params)
+    end
+
+    def post(url, params={})
+      request.post(build_url(url), params)
+    end
+
+    def build_url(url)
+      "#{resource}/#{url}"
+    end
+
+    def request
+      RequestHandler.new
+    end
+
+    private
+
+    attr_reader :resource
+  end
+end

data/lib/currency_cloud/{resources/contact.rb → contact.rb}

@@ -1,6 +1,8 @@
 module CurrencyCloud
-  class Contact < Resource
+  class Contact
+    include CurrencyCloud::Resource
+
     resource :contacts
     actions :create, :retrieve, :find, :update, :current
   end
-end
+end

data/lib/currency_cloud/{resources/conversion.rb → conversion.rb}

@@ -1,10 +1,8 @@
 module CurrencyCloud
-  
-  class Conversion < Resource
-    
+  class Conversion
+    include CurrencyCloud::Resource
+
     resource :conversions
-    
     actions :create, :retrieve, :find
-
   end
-end
+end

data/lib/currency_cloud/conversion_dates.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class ConversionDates
+    include CurrencyCloud::Resource
+  end
+end

data/lib/currency_cloud/currency.rb

@@ -0,0 +1,5 @@
+module CurrencyCloud
+  class Currency
+    include CurrencyCloud::Resource
+  end
+end

data/lib/currency_cloud/pagination.rb

@@ -1,7 +1,4 @@
 module CurrencyCloud
-  
   class Pagination < OpenStruct
-    
   end
-  
-end
+end

data/lib/currency_cloud/{resources/payer.rb → payer.rb}

@@ -1,6 +1,8 @@
 module CurrencyCloud
-  class Payer < Resource
+  class Payer
+    include CurrencyCloud::Resource
+
     resource :payers
     actions :retrieve
   end
-end
+end

data/lib/currency_cloud/{resources/payment.rb → payment.rb}

@@ -1,9 +1,8 @@
 module CurrencyCloud
-  
-  class Payment < Resource
-    
+  class Payment
+    include CurrencyCloud::Resource
+
     resource :payments
-    
     actions :create, :retrieve, :find, :delete, :update
   end
-end
+end

data/lib/currency_cloud/rate.rb

@@ -0,0 +1,21 @@
+module CurrencyCloud
+  class Rate
+    include CurrencyCloud::Resource
+
+    resource :rates
+
+    def self.find(params)
+      response = client.get("find", params)
+
+      rates = response["rates"].map do |currency_pair, (bid, offer)|
+        new(currency_pair: currency_pair, bid: bid, offer: offer)
+      end
+
+      Rates.new(currencies: rates, unavailable: response["unavailable"])
+    end
+
+    def self.detailed(params)
+      new(client.get("detailed", params))
+    end
+  end
+end