currency-rate 1.0.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a3676983c63a5f579c68cde5320507f1ae2865e8
-  data.tar.gz: da1012848a17db8f389d10201d26e66aed2ac93b
+  metadata.gz: 9b4f9d88dac87ee1c8fec51965ae55a35f3b36df
+  data.tar.gz: 7b34cf4aeb7eca8ccfffe8aaa992eb8a267e173c
 SHA512:
-  metadata.gz: d5b015e4587fee54369ecaa39345485f2c9acdb81581fcd4f62655ec235472ef3158dd774c52a5f66b8dadcc2e49206e8c1036017c0421d6ac591aa7785448dd
-  data.tar.gz: 707067690373ce67e6cb2cd6697ac1271e7f615ff533bb73d25c196fcc987054258092524621a9773df62043408107f2b9c598da95da91352c32664b674a126f
+  metadata.gz: f77e137eeac0e9b41feb9072a787c37153fa825a8bcd2f5ae63c596b2592bc884a90cda9ad83dd25cbd553de9d55091c9b0e4273efecd7b4e37e9a86f11c85a4
+  data.tar.gz: a910962dcd6b330e4349ca99aca546c916d70c52d7021c2e40c007e96285a8f3ea3d54dd8a24fca90a03a07db26ab3d0ef4ffd60489d1a7d55c6a448e25eb7b9

data/VERSION

@@ -1 +1 @@
-1.0.0
+1.1.1

data/currency-rate.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: currency-rate 1.0.0 ruby lib
+# stub: currency-rate 1.1.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "currency-rate".freeze
-  s.version = "1.0.0"
+  s.version = "1.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Roman Snitko".freeze]
-  s.date = "2017-10-30"
+  s.date = "2017-11-13"
   s.description = "Fetches exchange rates from various sources and does the conversion".freeze
   s.email = "roman.snitko@gmail.com".freeze
   s.extra_rdoc_files = [
@@ -38,6 +38,7 @@ Gem::Specification.new do |s|
     "lib/adapters/crypto/kraken_adapter.rb",
     "lib/adapters/crypto/localbitcoins_adapter.rb",
     "lib/adapters/crypto/okcoin_adapter.rb",
+    "lib/adapters/fiat/currency_layer_adapter.rb",
     "lib/adapters/fiat/fixer_adapter.rb",
     "lib/adapters/fiat/forge_adapter.rb",
     "lib/adapters/fiat/yahoo_adapter.rb",
@@ -53,6 +54,7 @@ Gem::Specification.new do |s|
     "spec/fixtures/adapters/btc_china_adapter.yml",
     "spec/fixtures/adapters/btce_adapter.yml",
     "spec/fixtures/adapters/coinbase_adapter.yml",
+    "spec/fixtures/adapters/currency_layer_adapter.yml",
     "spec/fixtures/adapters/fixer_adapter.yml",
     "spec/fixtures/adapters/forge_adapter.yml",
     "spec/fixtures/adapters/huobi_adapter.yml",
@@ -64,6 +66,7 @@ Gem::Specification.new do |s|
     "spec/fixtures/adapters/normalized/btc_china_adapter.yml",
     "spec/fixtures/adapters/normalized/btce_adapter.yml",
     "spec/fixtures/adapters/normalized/coinbase_adapter.yml",
+    "spec/fixtures/adapters/normalized/currency_layer_adapter.yml",
     "spec/fixtures/adapters/normalized/fixer_adapter.yml",
     "spec/fixtures/adapters/normalized/forge_adapter.yml",
     "spec/fixtures/adapters/normalized/huobi_adapter.yml",
@@ -84,6 +87,7 @@ Gem::Specification.new do |s|
     "spec/lib/adapters/crypto/kraken_adapter_spec.rb",
     "spec/lib/adapters/crypto/localbitcoins_adapter_spec.rb",
     "spec/lib/adapters/crypto/okcoin_adapter_spec.rb",
+    "spec/lib/adapters/fiat/currency_layer_adapter_spec.rb",
     "spec/lib/adapters/fiat/fixer_adapter_spec.rb",
     "spec/lib/adapters/fiat/forge_adapter_spec.rb",
     "spec/lib/adapters/fiat/yahoo_adapter_spec.rb",

data/lib/adapter.rb

@@ -50,7 +50,12 @@ module CurrencyRate
       fetch_url = url
       if self.class::API_KEY_PARAM
         api_key = CurrencyRate.configuration.api_keys[self.name]
-        fetch_url << "&#{self.class::API_KEY_PARAM}=#{api_key}" if api_key
+        if api_key.nil?
+          CurrencyRate.logger.error("API key for #{self.name} not defined")
+          return nil
+        end
+        param_symbol = fetch_url.split("/").last.include?("?") ? "&" : "?"
+        fetch_url << "#{param_symbol}#{self.class::API_KEY_PARAM}=#{api_key}" if api_key
       end
       http_client = HTTP.timeout(connect: 4, read: 4)
       JSON.parse(http_client.get(fetch_url).to_s)

data/lib/adapters/fiat/currency_layer_adapter.rb

@@ -0,0 +1,30 @@
+module CurrencyRate
+  class CurrencyLayerAdapter < Adapter
+    # No need to use it for fetching, just additional information about supported currencies
+    SUPPORTED_CURRENCIES = %w(AED AFN ALL AMD ANG AOA ARS AUD AWG AZN BAM BBD BDT BGN
+                              BHD BIF BMD BND BOB BRL BSD BTC BTN BWP BYN BYR BZD CAD
+                              CDF CHF CLF CLP CNY COP CRC CUC CUP CVE CZK DJF DKK DOP
+                              DZD EGP ERN ETB EUR FJD FKP GBP GEL GGP GHS GIP GMD GNF
+                              GTQ GYD HKD HNL HRK HTG HUF IDR ILS IMP INR IQD IRR ISK
+                              JEP JMD JOD JPY KES KGS KHR KMF KPW KRW KWD KYD KZT LAK
+                              LBP LKR LRD LSL LTL LVL LYD MAD MDL MGA MKD MMK MNT MOP
+                              MRO MUR MVR MWK MXN MYR MZN NAD NGN NIO NOK NPR NZD OMR
+                              PAB PEN PGK PHP PKR PLN PYG QAR RON RSD RUB RWF SAR SBD
+                              SCR SDG SEK SGD SHP SLL SOS SRD STD SVC SYP SZL THB TJS
+                              TMT TND TOP TRY TTD TWD TZS UAH UGX USD UYU UZS VEF VND
+                              VUV WST XAF XAG XAU XCD XDR XOF XPF YER ZAR ZMK ZMW ZWL)
+
+    ANCHOR_CURRENCY = "USD"
+    FETCH_URL = "http://www.apilayer.net/api/live"
+    API_KEY_PARAM = "access_key"
+
+    def normalize(data)
+      return nil unless super
+      rates = { "anchor" => self.class::ANCHOR_CURRENCY }
+      data["quotes"].each do |key, value|
+        rates[key.sub(self.class::ANCHOR_CURRENCY, "")] = BigDecimal.new(value.to_s)
+      end
+      rates
+    end
+  end
+end

data/spec/fixtures/adapters/currency_layer_adapter.yml

@@ -0,0 +1,174 @@
+success: true
+terms: https://currencylayer.com/terms
+privacy: https://currencylayer.com/privacy
+timestamp: 1510576149
+source: USD
+quotes:
+  USDAED: 3.672899
+  USDAFN: 68.559998
+  USDALL: 114.239998
+  USDAMD: 487.070007
+  USDANG: 1.779787
+  USDAOA: 165.097026
+  USDARS: 17.478958
+  USDAUD: 1.307606
+  USDAWG: 1.78
+  USDAZN: 1.6997
+  USDBAM: 1.680301
+  USDBBD: 2
+  USDBDT: 83.139999
+  USDBGN: 1.678295
+  USDBHD: 0.377704
+  USDBIF: 1742.97998
+  USDBMD: 1
+  USDBND: 1.360602
+  USDBOB: 6.859658
+  USDBRL: 3.285801
+  USDBSD: 1
+  USDBTC: 0.000153
+  USDBTN: 64.949997
+  USDBWP: 10.633303
+  USDBYN: 1.969768
+  USDBYR: 19600
+  USDBZD: 1.997703
+  USDCAD: 1.26981
+  USDCDF: 1565.502481
+  USDCHF: 0.99374
+  USDCLF: 0.02351
+  USDCLP: 632.960022
+  USDCNY: 6.639197
+  USDCOP: 3007.5
+  USDCRC: 566.400024
+  USDCUC: 1
+  USDCUP: 26.5
+  USDCVE: 94.589996
+  USDCZK: 21.927499
+  USDDJF: 176.830002
+  USDDKK: 6.38358
+  USDDOP: 47.299999
+  USDDZD: 114.920998
+  USDEGP: 17.64496
+  USDERN: 15.279785
+  USDETB: 27.084299
+  USDEUR: 0.857399
+  USDFJD: 2.079752
+  USDFKP: 0.761599
+  USDGBP: 0.76409
+  USDGEL: 2.639904
+  USDGGP: 0.763974
+  USDGHS: 4.448505
+  USDGIP: 0.761801
+  USDGMD: 46.869999
+  USDGNF: 8995.00018
+  USDGTQ: 7.341983
+  USDGYD: 204.399994
+  USDHKD: 7.79966
+  USDHNL: 23.500999
+  USDHRK: 6.457401
+  USDHTG: 61.959999
+  USDHUF: 267.600006
+  USDIDR: 13550
+  USDILS: 3.540102
+  USDIMP: 0.763974
+  USDINR: 65.418999
+  USDIQD: 1167
+  USDIRR: 35248.999607
+  USDISK: 103.489998
+  USDJEP: 0.763974
+  USDJMD: 125.940002
+  USDJOD: 0.707504
+  USDJPY: 113.294998
+  USDKES: 103.349998
+  USDKGS: 69.723999
+  USDKHR: 4035.000398
+  USDKMF: 423.380005
+  USDKPW: 899.999782
+  USDKRW: 1117.569946
+  USDKWD: 0.302197
+  USDKYD: 0.82027
+  USDKZT: 332.959991
+  USDLAK: 8301.999725
+  USDLBP: 1505.400024
+  USDLKR: 153.600006
+  USDLRD: 122.679782
+  USDLSL: 14.364981
+  USDLTL: 3.048703
+  USDLVL: 0.62055
+  USDLYD: 1.374302
+  USDMAD: 9.485697
+  USDMDL: 17.527008
+  USDMGA: 3159.999975
+  USDMKD: 52.529999
+  USDMMK: 1363.000068
+  USDMNT: 2445.999784
+  USDMOP: 8.033203
+  USDMRO: 351.000172
+  USDMUR: 34.229818
+  USDMVR: 15.570375
+  USDMWK: 716.349976
+  USDMXN: 19.156401
+  USDMYR: 4.190017
+  USDMZN: 60.290001
+  USDNAD: 14.508944
+  USDNGN: 351.999683
+  USDNIO: 30.593497
+  USDNOK: 8.13997
+  USDNPR: 103.550003
+  USDNZD: 1.446698
+  USDOMR: 0.384799
+  USDPAB: 1
+  USDPEN: 3.2405
+  USDPGK: 3.187302
+  USDPHP: 51.200001
+  USDPKR: 105.330002
+  USDPLN: 3.632982
+  USDPYG: 5650.299805
+  USDQAR: 3.8048
+  USDRON: 3.991896
+  USDRSD: 101.433197
+  USDRUB: 59.377899
+  USDRWF: 832.289978
+  USDSAR: 3.750097
+  USDSBD: 7.797797
+  USDSCR: 13.597994
+  USDSDG: 6.659702
+  USDSEK: 8.37478
+  USDSGD: 1.36123
+  USDSHP: 0.761799
+  USDSLL: 7619.999811
+  USDSOS: 556.999519
+  USDSRD: 7.379938
+  USDSTD: 21017.400391
+  USDSVC: 8.749931
+  USDSYP: 514.97998
+  USDSZL: 14.520974
+  USDTHB: 33.049999
+  USDTJS: 8.805597
+  USDTMT: 3.41
+  USDTND: 2.515011
+  USDTOP: 2.272801
+  USDTRY: 3.877202
+  USDTTD: 6.741992
+  USDTWD: 30.176001
+  USDTZS: 2236.999921
+  USDUAH: 26.469999
+  USDUGX: 3644.999878
+  USDUSD: 1
+  USDUYU: 29.169966
+  USDUZS: 8049.999597
+  USDVEF: 9.975012
+  USDVND: 22710
+  USDVUV: 106.010002
+  USDWST: 2.5708
+  USDXAF: 562.280029
+  USDXAG: 0.059138
+  USDXAU: 0.000782
+  USDXCD: 2.702368
+  USDXDR: 0.712515
+  USDXOF: 562.570007
+  USDXPF: 102.309777
+  USDYER: 249.949997
+  USDZAR: 14.523701
+  USDZMK: 9001.198647
+  USDZMW: 9.88006
+  USDZWL: 322.355011

data/spec/fixtures/adapters/normalized/currency_layer_adapter.yml

@@ -0,0 +1,169 @@
+anchor: USD
+AED: 3.672899
+AFN: 68.559998
+ALL: 114.239998
+AMD: 487.070007
+ANG: 1.779787
+AOA: 165.097026
+ARS: 17.478958
+AUD: 1.307606
+AWG: 1.78
+AZN: 1.6997
+BAM: 1.680301
+BBD: 2
+BDT: 83.139999
+BGN: 1.678295
+BHD: 0.377704
+BIF: 1742.97998
+BMD: 1
+BND: 1.360602
+BOB: 6.859658
+BRL: 3.285801
+BSD: 1
+BTC: 0.000153
+BTN: 64.949997
+BWP: 10.633303
+BYN: 1.969768
+BYR: 19600
+BZD: 1.997703
+CAD: 1.26981
+CDF: 1565.502481
+CHF: 0.99374
+CLF: 0.02351
+CLP: 632.960022
+CNY: 6.639197
+COP: 3007.5
+CRC: 566.400024
+CUC: 1
+CUP: 26.5
+CVE: 94.589996
+CZK: 21.927499
+DJF: 176.830002
+DKK: 6.38358
+DOP: 47.299999
+DZD: 114.920998
+EGP: 17.64496
+ERN: 15.279785
+ETB: 27.084299
+EUR: 0.857399
+FJD: 2.079752
+FKP: 0.761599
+GBP: 0.76409
+GEL: 2.639904
+GGP: 0.763974
+GHS: 4.448505
+GIP: 0.761801
+GMD: 46.869999
+GNF: 8995.00018
+GTQ: 7.341983
+GYD: 204.399994
+HKD: 7.79966
+HNL: 23.500999
+HRK: 6.457401
+HTG: 61.959999
+HUF: 267.600006
+IDR: 13550
+ILS: 3.540102
+IMP: 0.763974
+INR: 65.418999
+IQD: 1167
+IRR: 35248.999607
+ISK: 103.489998
+JEP: 0.763974
+JMD: 125.940002
+JOD: 0.707504
+JPY: 113.294998
+KES: 103.349998
+KGS: 69.723999
+KHR: 4035.000398
+KMF: 423.380005
+KPW: 899.999782
+KRW: 1117.569946
+KWD: 0.302197
+KYD: 0.82027
+KZT: 332.959991
+LAK: 8301.999725
+LBP: 1505.400024
+LKR: 153.600006
+LRD: 122.679782
+LSL: 14.364981
+LTL: 3.048703
+LVL: 0.62055
+LYD: 1.374302
+MAD: 9.485697
+MDL: 17.527008
+MGA: 3159.999975
+MKD: 52.529999
+MMK: 1363.000068
+MNT: 2445.999784
+MOP: 8.033203
+MRO: 351.000172
+MUR: 34.229818
+MVR: 15.570375
+MWK: 716.349976
+MXN: 19.156401
+MYR: 4.190017
+MZN: 60.290001
+NAD: 14.508944
+NGN: 351.999683
+NIO: 30.593497
+NOK: 8.13997
+NPR: 103.550003
+NZD: 1.446698
+OMR: 0.384799
+PAB: 1
+PEN: 3.2405
+PGK: 3.187302
+PHP: 51.200001
+PKR: 105.330002
+PLN: 3.632982
+PYG: 5650.299805
+QAR: 3.8048
+RON: 3.991896
+RSD: 101.433197
+RUB: 59.377899
+RWF: 832.289978
+SAR: 3.750097
+SBD: 7.797797
+SCR: 13.597994
+SDG: 6.659702
+SEK: 8.37478
+SGD: 1.36123
+SHP: 0.761799
+SLL: 7619.999811
+SOS: 556.999519
+SRD: 7.379938
+STD: 21017.400391
+SVC: 8.749931
+SYP: 514.97998
+SZL: 14.520974
+THB: 33.049999
+TJS: 8.805597
+TMT: 3.41
+TND: 2.515011
+TOP: 2.272801
+TRY: 3.877202
+TTD: 6.741992
+TWD: 30.176001
+TZS: 2236.999921
+UAH: 26.469999
+UGX: 3644.999878
+USD: 1
+UYU: 29.169966
+UZS: 8049.999597
+VEF: 9.975012
+VND: 22710
+VUV: 106.010002
+WST: 2.5708
+XAF: 562.280029
+XAG: 0.059138
+XAU: 0.000782
+XCD: 2.702368
+XDR: 0.712515
+XOF: 562.570007
+XPF: 102.309777
+YER: 249.949997
+ZAR: 14.523701
+ZMK: 9001.198647
+ZMW: 9.88006
+ZWL: 322.355011

data/spec/lib/adapters/fiat/currency_layer_adapter_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+RSpec.describe CurrencyRate::CurrencyLayerAdapter do
+  before(:all) { @data, @normalized = data_for :currency_layer }
+
+  before { stub_request(:get, /apilayer/).to_return(body: @data.to_json) }
+
+  before { @adapter = CurrencyRate::CurrencyLayerAdapter.instance }
+
+  describe "#normalize" do
+    it "brings data to canonical form" do
+      expect(@adapter.normalize(@data)).to eq(@normalized)
+    end
+  end
+
+  describe "#exchange_data" do
+    context "when api_key not defined" do
+      it "returns nil" do
+        expect(@adapter.exchange_data).to be_nil
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: currency-rate
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Roman Snitko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-31 00:00:00.000000000 Z
+date: 2017-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -107,6 +107,7 @@ files:
 - lib/adapters/crypto/kraken_adapter.rb
 - lib/adapters/crypto/localbitcoins_adapter.rb
 - lib/adapters/crypto/okcoin_adapter.rb
+- lib/adapters/fiat/currency_layer_adapter.rb
 - lib/adapters/fiat/fixer_adapter.rb
 - lib/adapters/fiat/forge_adapter.rb
 - lib/adapters/fiat/yahoo_adapter.rb
@@ -122,6 +123,7 @@ files:
 - spec/fixtures/adapters/btc_china_adapter.yml
 - spec/fixtures/adapters/btce_adapter.yml
 - spec/fixtures/adapters/coinbase_adapter.yml
+- spec/fixtures/adapters/currency_layer_adapter.yml
 - spec/fixtures/adapters/fixer_adapter.yml
 - spec/fixtures/adapters/forge_adapter.yml
 - spec/fixtures/adapters/huobi_adapter.yml
@@ -133,6 +135,7 @@ files:
 - spec/fixtures/adapters/normalized/btc_china_adapter.yml
 - spec/fixtures/adapters/normalized/btce_adapter.yml
 - spec/fixtures/adapters/normalized/coinbase_adapter.yml
+- spec/fixtures/adapters/normalized/currency_layer_adapter.yml
 - spec/fixtures/adapters/normalized/fixer_adapter.yml
 - spec/fixtures/adapters/normalized/forge_adapter.yml
 - spec/fixtures/adapters/normalized/huobi_adapter.yml
@@ -153,6 +156,7 @@ files:
 - spec/lib/adapters/crypto/kraken_adapter_spec.rb
 - spec/lib/adapters/crypto/localbitcoins_adapter_spec.rb
 - spec/lib/adapters/crypto/okcoin_adapter_spec.rb
+- spec/lib/adapters/fiat/currency_layer_adapter_spec.rb
 - spec/lib/adapters/fiat/fixer_adapter_spec.rb
 - spec/lib/adapters/fiat/forge_adapter_spec.rb
 - spec/lib/adapters/fiat/yahoo_adapter_spec.rb