currency-exchange 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 121b7ded7102fe40a445a02f76676947e2ed98b0
-  data.tar.gz: 1af8a71511b96ba4cdd1faabbe67e3be4e9f8654
+  metadata.gz: cae34a8ff24cbf2c72da3a25d154c0df7f50f4eb
+  data.tar.gz: 70bb79bccf54be8082b548afd9dbe51fa134b5d7
 SHA512:
-  metadata.gz: dfb57b60ceab51c8b007a8cee95ce0667c7e8f7dd906eea941263276aedbff2921b8a581580d6ab78274e9bbc9e7a88bc03b3be9fb913f0a06c7ff4b105b730f
-  data.tar.gz: bff669b2ae7c0bc07c5e70a58f2d75c133d69c4361611f2fb8a8b8fc7a8eea5aaec0c0b3b3efa7bfaf8a59d2e58f8dc27fc08fd0881ec7bf6a8effcdba983180
+  metadata.gz: fd109387b7dcf9f9617236e9ce4bca62d21077111d947e9ec8b76f34c58a9b72ed1235a03f480312296d366900b88bc64289ae9333ce0d66f7d4fd072f1600ca
+  data.tar.gz: de290948bfd0a34dc4b0a483af2f831ee67bf8a6b553b1b854044b81d4e79041a7cf2e11c4c24ea20fa9124a938453097a8e39e07c76ce81ee35f633f2b323af

data/.rubocop.yml

@@ -265,3 +265,6 @@ UnderscorePrefixedVariableName:
 
 Void:
   Enabled: false
+
+Rails/TimeZone:
+  Enabled: false

data/README.md

@@ -1,4 +1,4 @@
-https://travis-ci.org/letz/ruby-pushbullet.svg?branch=master
+[![Build Status](https://travis-ci.org/letz/currency_exchange.svg?branch=master)](https://travis-ci.org/letz/currency_exchange)
 
 # CurrencyExchange
 

data/lib/currency_exchange.rb

@@ -7,4 +7,5 @@ require 'currency_exchange/version'
 require 'currency_exchange/network'
 require 'currency_exchange/yahoo'
 require 'currency_exchange/google'
+require 'currency_exchange/xe'
 require 'currency_exchange/rate'

data/lib/currency_exchange/google.rb

@@ -10,9 +10,11 @@ class CurrencyExchange::Google
     exchange = Nokogiri::HTML(resp).css('#currency_converter_result')
     currency1 = exchange.children.first.text.split(' ')[1]
     rate, currency2 = exchange.css('.bld').inner_text.split(' ')
-    CurrencyExchange::Rate.new(name: "#{currency1}/#{currency2}", rate: rate)
+    CurrencyExchange::Rate.new("#{currency1}/#{currency2}", rate)
   end
 
+  # Private Methods
+
   def self.request_rate(query)
     CurrencyExchange::Network.get "#{BASE_URL}?#{query_builder(query)}"
   end
@@ -20,4 +22,5 @@ class CurrencyExchange::Google
   def self.query_builder(query)
     QUERY % query
   end
+  private_class_method :request_rate, :query_builder
 end

data/lib/currency_exchange/rate.rb

@@ -3,12 +3,12 @@ class CurrencyExchange::Rate
 
   DATE_FORMAT = '%m/%d/%Y %H:%M %P'
 
-  def initialize(name:, rate:, date: nil, time: nil, ask: nil, bid: nil)
+  def initialize(name, rate, options = {})
     @name = name
     @rate = rate.to_f
-    @time = parse_date date, time
-    @ask = ask.to_f
-    @bid = bid.to_f
+    @time = parse_date options[:date], options[:time]
+    @ask = options[:ask].to_f
+    @bid = options[:bid].to_f
   end
 
   def convert_value(value)
@@ -19,9 +19,19 @@ class CurrencyExchange::Rate
     CurrencyExchange::Yahoo.get_rates [[currency1, currency2]]
   end
 
+  private
+
   def parse_date(date, time)
+    parse_date_format(date, time) || parse_date_no_format(date) || Time.now
+  end
+
+  def parse_date_format(date, time)
     Time.strptime "#{date} #{time}", DATE_FORMAT
-  rescue ArgumentError
-    Time.zone.now
+    rescue ArgumentError
+  end
+
+  def parse_date_no_format(date)
+    Time.parse date
+    rescue ArgumentError, TypeError
   end
 end

data/lib/currency_exchange/version.rb

@@ -1,3 +1,3 @@
 class CurrencyExchange
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/lib/currency_exchange/xe.rb

@@ -0,0 +1,40 @@
+class CurrencyExchange::Xe
+  BASE_URL = 'http://www.xe.com/currencyconverter/convert/'
+  QUERY = 'Amount=1&From=%s&To=%s'
+
+  def self.get_rate(query)
+    rates_parser request_rate(query)
+  end
+
+  def self.rates_parser(resp)
+    doc = Nokogiri::HTML(resp)
+    date = parse_date(doc)
+    currency1, currency2, rate = parse_rate doc
+
+    CurrencyExchange::Rate.new("#{currency1}/#{currency2}", rate, date: date)
+  end
+
+  # Private Methods
+
+  def self.request_rate(query)
+    CurrencyExchange::Network.get "#{BASE_URL}?#{query_builder(query)}"
+  end
+
+  def self.query_builder(query)
+    QUERY % query
+  end
+
+  def self.parse_date(doc)
+    doc.css('.uccMMR').css('a').children.first.inner_text.
+      split('Mid-market rates: ').last
+  end
+
+  def self.parse_rate(doc)
+    exchange = doc.css('.uccResUnit').css('.leftCol')[0].inner_text
+    currency1, currency2 = exchange.split(' = ')
+    currency1 = currency1.split(' ').last
+    rate, currency2 = currency2.split(' ')
+    [currency1, currency2, rate]
+  end
+  private_class_method :request_rate, :query_builder, :parse_date, :parse_rate
+end

data/lib/currency_exchange/yahoo.rb

@@ -26,7 +26,7 @@ class CurrencyExchange::Yahoo
     node.each do |attribute|
       hash[attribute.name.downcase.to_sym] = attribute.inner_text
     end
-    CurrencyExchange::Rate.new(hash)
+    CurrencyExchange::Rate.new(hash[:name], hash[:rate], hash)
   end
 
   def self.query_builder(array)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: currency-exchange
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Ricardo Leitão
@@ -130,6 +130,7 @@ files:
 - lib/currency_exchange/network.rb
 - lib/currency_exchange/rate.rb
 - lib/currency_exchange/version.rb
+- lib/currency_exchange/xe.rb
 - lib/currency_exchange/yahoo.rb
 homepage: https://github.com/letz/currency_exchange
 licenses: