curation_concerns 1.7.2 → 1.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d15b59d55d78440e70e6f40b0c0892065436ea41
-  data.tar.gz: c3d817c1978120de064a838441a8c40c668ce3e1
+  metadata.gz: b8e3a51d73c77e6ee4533319b2e0dbc7b8afed1c
+  data.tar.gz: c1cb7a95bc11873894ec02b198c0925db1e1ff27
 SHA512:
-  metadata.gz: d14c0baaf6373a14d4ba6b14343cdb81e2f0e93342f835fe6bb029a56087dcf04f43f8b822241737ef2dc66256c989c86a0b985d6e9a0c02c4f64275371ecefb
-  data.tar.gz: a280ccee709f04466a253c04106195fab1d9c8d014c14bf6aa6cf84bce359e44ab09d441b6849b4c61c08853feac88b0e345e95d0e1e781ab6577f590cf8cc9c
+  metadata.gz: 7617b194446b007e5b23f6f58d9f5ba08f57f6bf26a46b07264141688c751aec136adf36a409f52d73b87280c24e012652cbb94798ff613938edffb1b420c33d
+  data.tar.gz: e542b1d43ab5205cd042a4fa6c7398a7bcbfd2956c7fbd92a092d3ef3fcec932b40503bc6e9122125080e2ecd34595ccf1d85e5117a37f9f9388edd9a295e50f

data/CONTRIBUTING.md

@@ -3,6 +3,13 @@
 We want your help to make Project Hydra great.
 There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
 
+## Code of Conduct
+
+The Hydra community is dedicated to providing a welcoming and positive experience for all its
+members, whether they are at a formal gathering, in a social setting, or taking part in activities
+online.  Please see our [Code of Conduct](https://wiki.duraspace.org/display/hydra/Code+of+Conduct)
+for more information.
+
 ## Hydra Project Intellectual Property Licensing and Ownership
 
 All code contributors must have an Individual Contributor License Agreement (iCLA) on file with the Hydra Project Steering Group.
@@ -10,12 +17,16 @@ If the contributor works for an institution, the institution must have a Corpora
 
 https://wiki.duraspace.org/display/hydra/Hydra+Project+Intellectual+Property+Licensing+and+Ownership
 
+You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
+
 ## Contribution Tasks
 
 * Reporting Issues
 * Making Changes
+* Documenting Code
+* Committing Changes
 * Submitting Changes
-* Merging Changes
+* Reviewing and Merging Changes
 
 ### Reporting Issues
 
@@ -36,8 +47,28 @@ https://wiki.duraspace.org/display/hydra/Hydra+Project+Intellectual+Property+Lic
   * Then checkout the new branch with `git checkout fix/master/my_contribution`.
   * Please avoid working directly on the `master` branch.
   * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
+* Make sure you have added sufficient tests and documentation for your changes.
+  * Test functionality with RSpec; est features / UI with Capybara.
+* Run _all_ the tests to assure nothing else was accidentally broken.
+
+### Documenting Code
+
+* All new public methods, modules, and classes should include inline documentation in [YARD](http://yardoc.org/).
+  * Documentation should seek to answer the question "why does this code exist?"
+* Document private / protected methods as desired.
+* If you are working in a file with no prior documentation, do try to document as you gain understanding of the code.
+  * If you don't know exactly what a bit of code does, it is extra likely that it needs to be documented. Take a stab at it and ask for feedback in your pull request. You can use the 'blame' button on GitHub to identify the original developer of the code and @mention them in your comment.
+  * This work greatly increases the usability of the code base and supports the on-ramping of new committers.
+  * We will all be understanding of one another's time constraints in this area.
+* YARD examples:
+  * [Hydra::Works::RemoveGenericFile](https://github.com/projecthydra-labs/hydra-works/blob/master/lib/hydra/works/services/generic_work/remove_generic_file.rb)
+  * [ActiveTriples::LocalName::Minter](https://github.com/ActiveTriples/active_triples-local_name/blob/master/lib/active_triples/local_name/minter.rb)
+* [Getting started with YARD](http://www.rubydoc.info/gems/yard/file/docs/GettingStarted.md)
+
+### Committing changes
+
 * Make commits of logical units.
-  * Your commit should include a high level description of your work in HISTORY.textile 
+  * Your commit should include a high level description of your work in HISTORY.textile
 * Check for unnecessary whitespace with `git diff --check` before committing.
 * Make sure your commit messages are [well formed](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
 * If you created an issue, you can close it by including "Closes #issue" in your commit message. See [Github's blog post for more details](https://github.com/blog/1386-closing-issues-via-commit-messages)
@@ -58,7 +89,9 @@ https://wiki.duraspace.org/display/hydra/Hydra+Project+Intellectual+Property+Lic
 
         class PostsController
           def index
-            respond_with Post.limit(10)
+            respond_to do |wants|
+              wants.html { render 'index' }
+            end
           end
         end
 
@@ -70,38 +103,53 @@ https://wiki.duraspace.org/display/hydra/Hydra+Project+Intellectual+Property+Lic
       long to fit in 72 characters
 ```
 
-* Make sure you have added the necessary tests for your changes.
-* Run _all_ the tests to assure nothing else was accidentally broken.
-* When you are ready to submit a pull request
-
 ### Submitting Changes
 
-[Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
-
 * Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
 * Make sure your branch is up to date with its parent branch (i.e. master)
   * `git checkout master`
   * `git pull --rebase`
   * `git checkout <your-branch>`
   * `git rebase master`
-  * It is likely a good idea to run your tests again.
-* Squash the commits for your branch into one commit
-  * `git rebase --interactive HEAD~<number-of-commits>` ([See Github help](https://help.github.com/articles/interactive-rebase))
-  * To determine the number of commits on your branch: `git log master..<your-branch> --oneline | wc -l`
+  * It is a good idea to run your tests again.
+* If you've made more than one commit take a moment to consider whether squashing commits together would help improve their logical grouping.
+  * [Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
+  * `git rebase --interactive master` ([See Github help](https://help.github.com/articles/interactive-rebase))
   * Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
 * Push your changes to a topic branch in your fork of the repository.
 * Submit a pull request from your fork to the project.
 
-### Merging Changes
+### Reviewing and Merging Changes
+
+We adopted [Github's Pull Request Review](https://help.github.com/articles/about-pull-request-reviews/) for our repositories.
+Common checks that may occur in our repositories:
+
+1. Travis CI - where our automated tests are running
+2. Hound CI - where we check for style violations
+3. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
+4. CodeClimate - is our code remaining healthy (at least according to static code analysis)
+
+If one or more of the required checks failed (or are incomplete), the code should not be merged (and the UI will not allow it). If all of the checks have passed, then anyone on the project (including the pull request submitter) may merge the code.
+
+*Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (Travis CI is usually the culprit), so he does not merge the pull request. Eventually, all of the checks pass. At this point, Carolyn or anyone else may merge the pull request.*
+
+#### Things to Consider When Reviewing
+
+First, the person contributing the code is putting themselves out there. Be mindful of what you say in a review.
+
+* Ask clarifying questions
+* State your understanding and expectations
+* Provide example code or alternate solutions, and explain why
+
+This is your chance for a mentoring moment of another developer. Take time to give an honest and thorough review of what has changed. Things to consider:
 
-* It is considered "poor from" to merge your own request.
-* Please take the time to review the changes and get a sense of what is being changed. Things to consider:
   * Does the commit message explain what is going on?
-  * Does the code changes have tests? _Not all changes need new tests, some changes are refactorings_
+  * Does the code changes have tests? _Not all changes need new tests, some changes are refactors_
+  * Do new or changed methods, modules, and classes have documentation?
   * Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
-  * Did the Travis tests complete successfully?
-* If you are uncertain, bring other contributors into the conversation by creating a comment that includes their @username.
-* If you like the pull request, but want others to chime in, create a +1 comment and tag a user.
+  * Does the description of the new/changed specs match your understanding of what the spec is doing?
+
+If you are uncertain, bring other contributors into the conversation by assigning them as a reviewer.
 
 # Additional Resources
 

data/app/actors/curation_concerns/actors/add_to_collection_actor.rb

@@ -22,8 +22,11 @@ module CurationConcerns
           # remove from old collections
           (curation_concern.in_collection_ids - new_collection_ids).each do |old_id|
             collection = ::Collection.find(old_id)
-            collection.members.delete(curation_concern)
-            collection.save
+            # don't remove from collections current user doesn't have edit permissions for
+            if collection.edit_users.include? user.email
+              collection.members.delete(curation_concern)
+              collection.save
+            end
           end
 
           # add to new

data/app/controllers/concerns/curation_concerns/download_behavior.rb

@@ -40,6 +40,12 @@ module CurationConcerns
       # that files are in a LDP basic container, and thus, included in the asset's uri.
       def authorize_download!
         authorize! :read, params[asset_param_key]
+      rescue CanCan::AccessDenied
+        redirect_to default_image
+      end
+
+      def default_image
+        ActionController::Base.helpers.image_path 'default.png'
       end
 
       # Overrides Hydra::Controller::DownloadBehavior#load_file, which is hard-coded to assume files are in BasicContainer.

data/app/presenters/curation_concerns/work_show_presenter.rb

@@ -130,6 +130,7 @@ module CurationConcerns
       def ordered_ids
         @ordered_ids ||= begin
                            ActiveFedora::SolrService.query("proxy_in_ssi:#{id}",
+                                                           rows: 10_000,
                                                            fl: "ordered_targets_ssim")
                                                     .flat_map { |x| x.fetch("ordered_targets_ssim", []) }
                          end
@@ -137,9 +138,11 @@ module CurationConcerns
 
       # These are the file sets that belong to this work, but not necessarily
       # in order.
+      # Arbitrarily maxed at 10 thousand; had to specify rows due to solr's default of 10
       def file_set_ids
         @file_set_ids ||= begin
                             ActiveFedora::SolrService.query("{!field f=has_model_ssim}FileSet",
+                                                            rows: 10_000,
                                                             fl: ActiveFedora.id_field,
                                                             fq: "{!join from=ordered_targets_ssim to=id}id:\"#{id}/list_source\"")
                                                      .flat_map { |x| x.fetch(ActiveFedora.id_field, []) }

data/lib/curation_concerns/version.rb

@@ -1,3 +1,3 @@
 module CurationConcerns
-  VERSION = '1.7.2'.freeze
+  VERSION = '1.7.3'.freeze
 end

data/spec/actors/curation_concerns/add_to_collections_actor_spec.rb

@@ -3,6 +3,9 @@ describe CurationConcerns::Actors::AddToCollectionActor do
   let(:user) { create(:user) }
   let(:curation_concern) { GenericWork.new }
   let(:attributes) { {} }
+  let(:collection) { create(:collection).tap do |col|
+    col.apply_depositor_metadata user
+  end }
   subject do
     CurationConcerns::Actors::ActorStack.new(curation_concern,
                                              user,
@@ -26,7 +29,6 @@ describe CurationConcerns::Actors::AddToCollectionActor do
   end
 
   describe 'create' do
-    let(:collection) { create(:collection) }
     let(:attributes) do
       { collection_ids: [collection.id], title: ['test'] }
     end
@@ -35,5 +37,30 @@ describe CurationConcerns::Actors::AddToCollectionActor do
       expect(subject.create(attributes)).to be true
       expect(collection.reload.members).to eq [curation_concern]
     end
+
+    describe "when work is in user's own collection" do
+      it "removes the work from that collection" do
+        # had to move collection and subject down into the spec to ensure they use the same user
+        collection = create(:collection).tap do |col|
+          col.apply_depositor_metadata user
+        end
+        subject.create(attributes)
+        expect(subject.create(collection_ids: [])).to be true
+        expect(collection.reload.members).to eq []
+      end
+    end
+
+    describe "when work is in another user's collection" do
+      let(:other_user) { create(:user) }
+      before do
+        collection.apply_depositor_metadata other_user
+        subject.create(attributes)
+      end
+
+      it "doesn't remove the work from that collection" do
+        expect(subject.create(collection_ids: [])).to be true
+        expect(collection.reload.members).to eq [curation_concern]
+      end
+    end
   end
 end

data/spec/controllers/downloads_controller_spec.rb

@@ -6,6 +6,7 @@ describe DownloadsController do
     let(:file_set) do
       FactoryGirl.create(:file_with_work, user: user, content: File.open(fixture_file_path('files/image.png')))
     end
+    let(:default_image) { ActionController::Base.helpers.image_path 'default.png' }
     it 'calls render_404 if the object does not exist' do
       expect(controller).to receive(:render_404) { controller.render body: nil }
       get :show, params: { id: '8675309' }
@@ -15,18 +16,16 @@ describe DownloadsController do
       let(:another_user) { FactoryGirl.create(:user) }
       before { sign_in another_user }
 
-      it 'redirects to root' do
+      it 'redirects to the default image' do
         get :show, params: { id: file_set.to_param }
-        expect(response).to redirect_to root_path
-        expect(flash['alert']).to eq 'You are not authorized to access this page.'
+        expect(response).to redirect_to default_image
       end
     end
 
     context "when user isn't logged in" do
-      it 'redirects to sign in' do
+      it 'redirects to the default image' do
         get :show, params: { id: file_set.to_param }
-        expect(response).to redirect_to new_user_session_path
-        expect(flash['alert']).to eq 'You are not authorized to access this page.'
+        expect(response).to redirect_to default_image
       end
 
       it 'authorizes the resource using only the id' do

data/spec/presenters/curation_concerns/work_show_presenter_spec.rb

@@ -81,6 +81,16 @@ describe CurationConcerns::WorkShowPresenter do
       expect(presenter.file_set_presenters.map(&:id)).to eq obj.ordered_member_ids
     end
 
+    context "solr query" do
+      before do
+        expect(ActiveFedora::SolrService).to receive(:query).twice.with(anything, hash_including(rows: 10_000)).and_return([])
+      end
+
+      it "requests >10 rows" do
+        presenter.file_set_presenters
+      end
+    end
+
     context "when some of the members are not file sets" do
       let(:another_work) { create(:work) }
       before do

data/spec/services/curation_concerns/workflow/permission_query_spec.rb

@@ -165,12 +165,18 @@ module CurationConcerns
           subject { described_class.scope_processing_agents_for(user: nil) }
           it { is_expected.to eq([]) }
         end
+
         context 'when user is persisted' do
           let(:user) { create(:user) }
+          before do
+            allow(user).to receive(:groups).and_return(['librarians'])
+          end
+
           subject { described_class.scope_processing_agents_for(user: user) }
+
           it 'will equal [kind_of(Sipity::Agent)]' do
             is_expected.to contain_exactly(PowerConverter.convert_to_sipity_agent(user),
-                                           PowerConverter.convert_to_sipity_agent(Group.new('registered')))
+                                           PowerConverter.convert_to_sipity_agent(Group.new('librarians')))
           end
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: curation_concerns
 version: !ruby/object:Gem::Version
-  version: 1.7.2
+  version: 1.7.3
 platform: ruby
 authors:
 - Matt Zumwalt
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-10 00:00:00.000000000 Z
+date: 2017-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: hydra-head
@@ -1591,7 +1591,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: A Rails Engine that allows an application to CRUD CurationConcern objects