cukeforker 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c97c06d29ce5a9948bf8cd30b8a7a8685aee2596
-  data.tar.gz: 8b9f43ba7f53e6501a896fd924d39812e1392440
+  metadata.gz: becd9202bf711742b3c2641599a388314744fc13
+  data.tar.gz: 8c2897ef60b92f651693ef0591ded68337fffd5f
 SHA512:
-  metadata.gz: 192e850138726137effab9b5cc07e8149dd0b1730b9eb19a27aa9ed9ee3fc04a253938c2e1e9ffe776d3ce153a1892b3805dd96d932303ad85731c98ae84d2e2
-  data.tar.gz: 26639c5e02f9dc75e28748880897d928be38a9501351dbfaa7fd2763cfe7d030f95983c01177df49e35f08b04a97d73a1f659b73f327765b3485014b60fa2cad
+  metadata.gz: 2e83d8b780b6fa2540fd13d53e19474e6310916881963e950a77a77af32f2e1603ff3cb6207a2303171b4a8a5725f45026a184e6e245869389acc9adf3267583
+  data.tar.gz: 1845ce7c0b69cafabadd56b36362080cd52ff2e3328a1a523c325d2762ff4885eb6a569d967fb21f4297320d195a23fd01430cdc552d472f15aedd328b51b0fe

data/.gitignore

@@ -5,4 +5,5 @@ Gemfile.lock
 \#*
 .\#*
 .idea
-.ruby-version
+.ruby-version
+/coverage

data/README.mdown

@@ -1,12 +1,19 @@
-cukeforker
-==========
+# cukeforker
 
 Forking cukes and VNC displays.
 
 [![Build Status](https://secure.travis-ci.org/jarib/cukeforker.png)](http://travis-ci.org/jarib/cukeforker)
+[![Code Climate](https://codeclimate.com/github/jarib/cukeforker.png)](https://codeclimate.com/github/jarib/cukeforker)
+[![Coverage Status](https://coveralls.io/repos/jarib/cukeforker/badge.png)](https://coveralls.io/r/jarib/cukeforker)
+
+### NB!
+
+If you're using cukeforker with selenium-webdriver and Firefox, all versions prior to 2.40 has a bug where custom
+Firefox profiles created in a forked process would not get cleaned up. Please make sure you're using selenium-webdriver >= 2.40
+to avoid this.
+
+## Usage
 
-Usage
-=============
 
 ```ruby
     # parallelize per feature

data/cukeforker.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.add_dependency "cucumber", ">= 1.1.5"
   s.add_dependency "vnctools", ">= 0.0.5"
   s.add_development_dependency "rspec", "~> 2.5"
-  s.add_development_dependency "simplecov"
+  s.add_development_dependency "coveralls"
   s.add_development_dependency "rake", "~> 0.9.2"
 
   s.files         = `git ls-files`.split("\n")

data/lib/cukeforker/runner.rb

@@ -25,14 +25,15 @@ module CukeForker
     include Observable
 
     DEFAULT_OPTIONS = {
-      :max    => 2,
-      :vnc    => false,
-      :record => false,
-      :notify => nil,
-      :out    => Dir.pwd,
-      :log    => true,
-      :format => :html,
-      :delay  => 0
+      :max        => 2,
+      :vnc        => false,
+      :record     => false,
+      :notify     => nil,
+      :out        => Dir.pwd,
+      :log        => true,
+      :format     => :html,
+      :delay      => 0,
+      :fail_fast  => false,
     }
 
     def self.run(features, opts = {})
@@ -48,6 +49,7 @@ module CukeForker
       listeners  = Array(opts[:notify])
       extra_args = Array(opts[:extra_args])
       delay      = opts[:delay]
+      fail_fast  = opts[:fail_fast]
 
       if opts[:log]
         listeners << LoggingListener.new
@@ -73,7 +75,7 @@ module CukeForker
         end
       end
 
-      queue = WorkerQueue.new max, delay
+      queue = WorkerQueue.new(max, delay, fail_fast)
       features.each do |feature|
         queue.add Worker.new(feature, format, out, extra_args)
       end

data/lib/cukeforker/version.rb

@@ -1,3 +1,3 @@
 module CukeForker
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/lib/cukeforker/worker.rb

@@ -3,9 +3,9 @@ module CukeForker
     include Observable
 
     class << self
-       attr_writer :id
-       def id; @id ||= -1; end
-     end
+      attr_writer :id
+      def id; @id ||= -1; end
+    end
 
     attr_reader :status, :feature, :pid, :format, :out, :id, :data
 
@@ -40,10 +40,9 @@ module CukeForker
     end
 
     def args
-      args = %W[--format #{format} --out #{output}]
+      args = Array(format).flat_map { |f| %W[--format #{f} --out #{output(f)}] }
       args += @extra_args
       args << feature
-
       args
     end
 
@@ -57,7 +56,8 @@ module CukeForker
        ]"
     end
 
-    def output
+    def output(format=nil)
+      format = @format if format.nil?
       File.join out, "#{basename}.#{format}"
     end
 
@@ -73,6 +73,15 @@ module CukeForker
       @basename ||= feature.gsub(/\W/, '_')
     end
 
+    def kill
+      return unless pid
+
+      Process.kill("TERM", pid)
+      Process.wait(pid)
+    rescue
+      # could not kill worker, ignore
+    end
+
     private
 
     def execute_cucumber

data/lib/cukeforker/worker_queue.rb

@@ -2,9 +2,10 @@ module CukeForker
   class WorkerQueue
     include Observable
 
-    def initialize(max, delay)
+    def initialize(max, delay, fail_fast=false)
       @max = max
       @delay = delay
+      @fail_fast = fail_fast
 
       if @max < 0
         raise ArgumentError, "max workers cannot be negative, got #{@max.inspect}"
@@ -121,6 +122,12 @@ module CukeForker
       @running.delete worker
       @finished << worker
 
+      if @fail_fast && worker.failed?
+        @pending.clear
+        @running.each { |w| w.kill }
+        @running.clear
+      end
+
       fire :on_worker_finished, worker
     end
 

data/spec/cukeforker/runner_spec.rb

@@ -14,13 +14,14 @@ module CukeForker
         log       = false
         features  = %w[a b]
         delay     = 1
+        fail_fast = false
 
         mock_queue = double(WorkerQueue)
         mock_workers = Array.new(2) { |n| double("Worker-#{n}") }
 
         Process.stub(:pid => 1234)
 
-        WorkerQueue.should_receive(:new).with(max, 1).and_return mock_queue
+        WorkerQueue.should_receive(:new).with(max, 1, fail_fast).and_return mock_queue
         Worker.should_receive(:new).with("a", :json, "/tmp", []).and_return mock_workers[0]
         Worker.should_receive(:new).with("b", :json, "/tmp", []).and_return mock_workers[1]
 
@@ -29,12 +30,13 @@ module CukeForker
         mock_queue.should_receive(:add).with mock_workers[1]
 
         Runner.create(features,
-          :max    => max,
-          :notify => listeners,
-          :format => format,
-          :log    => false,
-          :out    => out,
-          :delay  => 1
+          :max        => max,
+          :notify     => listeners,
+          :format     => format,
+          :log        => false,
+          :out        => out,
+          :delay      => 1,
+          :fail_fast  => fail_fast,
         ).should be_kind_of(Runner)
       end
 

data/spec/cukeforker/worker_queue_spec.rb

@@ -3,7 +3,8 @@ require File.expand_path("../../spec_helper", __FILE__)
 module CukeForker
   describe WorkerQueue do
     let(:workers) { Array.new(5) { |n| double("Worker-#{n}") } }
-    let(:queue) { WorkerQueue.new(3, 0) }
+    let(:queue) { WorkerQueue.new(3, 0, false) }
+
 
     it "adds an item to the queue" do
       queue.should_not be_backed_up
@@ -50,9 +51,9 @@ module CukeForker
 
       queue.fill
 
-      workers[0].stub(:finished? => true)
-      workers[1].stub(:finished? => true)
-      workers[2].stub(:finished? => false)
+      workers[0].stub(:finished? => true, :failed? => false)
+      workers[1].stub(:finished? => true, :failed? => false)
+      workers[2].stub(:finished? => false, :failed? => false)
 
       queue.poll
 
@@ -70,9 +71,9 @@ module CukeForker
 
       workers.each { |w| queue.add w }
 
-      workers[0].stub(:start => nil, :finished? => true)
-      workers[1].stub(:start => nil, :finished? => true)
-      workers[2].stub(:start => nil, :finished? => false)
+      workers[0].stub(:start => nil, :finished? => true, :failed? => false)
+      workers[1].stub(:start => nil, :finished? => true, :failed? => false)
+      workers[2].stub(:start => nil, :finished? => false, :failed? => false)
 
       listener.should_receive(:on_worker_starting).exactly(3).times
       queue.fill
@@ -124,9 +125,9 @@ module CukeForker
       queue.stub :start_time => Time.now
       workers[0..2].each { |w| queue.add w }
 
-      workers[0].stub(:start => nil)
-      workers[1].stub(:start => nil)
-      workers[2].stub(:start => nil)
+      workers[0].stub(:start => nil, :failed? => false)
+      workers[1].stub(:start => nil, :failed? => false)
+      workers[2].stub(:start => nil, :failed? => false)
 
       workers[0].should_receive(:finished?).twice.and_return false, true
       workers[1].should_receive(:finished?).twice.and_return false, true
@@ -148,13 +149,45 @@ module CukeForker
 
       workers[0..2].each { |w| queue.add w }
 
-      workers[0].stub(:start => nil, :finished? => true)
-      workers[1].stub(:start => nil, :finished? => false)
-      workers[2].stub(:start => nil, :finished? => false)
+      workers[0].stub(:start => nil, :finished? => true, :failed? => false)
+      workers[1].stub(:start => nil, :finished? => false, :failed? => false)
+      workers[2].stub(:start => nil, :finished? => false, :failed? => false)
 
       queue.fill
       queue.poll
       queue.eta.should == [Time.now + seconds_per_child*2, 2, 1]
     end
-  end # WorkerQueue
+
+    context "with fail fast enabled" do
+      let(:workers) { Array.new(10) { |n| double("Worker-#{n}") } }
+      let(:queue) { WorkerQueue.new(3, 0, true) }
+
+      it "should exit after the first test failure" do
+        queue.should be_empty
+
+        workers.each { |w| queue.add w }
+
+        workers[0].stub(:start => nil, :finished? => true, :failed? => false)
+        workers[1].stub(:start => nil, :finished? => false, :failed? => false, :kill => nil)
+        workers[2].stub(:start => nil, :finished? => false, :failed? => false, :kill => nil)
+        queue.fill
+        queue.poll
+
+        workers[3].stub(:start => nil, :finished? => false, :failed? => true)
+        queue.fill
+        queue.poll
+
+        workers[3].stub(:finished? => true)
+        queue.fill
+        queue.poll
+
+        queue.should_not be_backed_up
+        queue.should be_empty
+        queue.instance_variable_get(:@finished).should == [ workers[0], workers[3] ]
+
+        queue.should have_failures
+      end
+    end
+
+ end # WorkerQueue
 end # CukeForker

data/spec/cukeforker/worker_spec.rb

@@ -25,6 +25,19 @@ module CukeForker
       end
     end
 
+    context "running a scenario with multiple report formats" do
+      formats = [ :json, :junit ]
+      path    = "some/path"
+      let(:worker) { Worker.new("some/feature:51", formats, path) }
+
+      it "has an output file for each format specified" do
+        expected_args = formats.flat_map do |f|
+          %W[--format #{f} --out #{path}/some_feature_51.#{f}]
+        end
+        worker.args.each_cons(expected_args.size).include?(expected_args).should be_true
+      end
+    end
+
     it "creates an argument string based on the given parameters" do
       worker.args.should == %w{--format json --out some/path/some_feature.json --extra args some/feature }
     end
@@ -115,5 +128,22 @@ module CukeForker
       Process.stub(:waitpid2).and_raise(Errno::ESRCH)
       worker.should be_finished
     end
+
+    it "can kill the child process" do
+      worker.stub(:pid => $$)
+
+      Process.should_receive(:kill)
+      Process.should_receive(:wait)
+
+      worker.kill
+    end
+
+    it "ignores failures when killing the child" do
+      worker.stub(:pid => $$)
+
+      Process.should_receive(:kill).and_raise(Errno::ECHILD)
+      worker.kill.should be_nil
+    end
+
   end # Worker
 end # CukeForker

data/spec/spec_helper.rb

@@ -1,10 +1,5 @@
-if ENV['COVERAGE']
-  raise "simplecov only works on 1.9" unless RUBY_PLATFORM >= "1.9"
-  require 'simplecov'
-  SimpleCov.start {
-    add_filter "spec/"
-  }
-end
+require 'coveralls'
+Coveralls.wear!
 
 $LOAD_PATH.unshift File.expand_path("../lib")
 require 'cukeforker'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cukeforker
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Jari Bakken
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-16 00:00:00.000000000 Z
+date: 2014-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.5'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -138,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: cukeforker
-rubygems_version: 2.1.10
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Library to maintain a forking queue of Cucumber processes
@@ -152,4 +152,3 @@ test_files:
 - spec/cukeforker/worker_queue_spec.rb
 - spec/cukeforker/worker_spec.rb
 - spec/spec_helper.rb
-has_rdoc: