cukedep 0.1.04 → 0.1.05

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Y2U1MzA1ZGE1MjhjMTYzYmM3NmQ4MzViNzUxNjBiNjQxNTMyODU1OA==
+    YmZmMTZlZmJkZDljYTBiYTNlM2Q4ZGNjYjIxNjU5MTIxOTliOWIyOQ==
   data.tar.gz: !binary |-
-    MDkxZTE4MGJjYjYyYTcwMTgwYTRjMTc3MWE0YTQxMzQwZjM4ZGQ3Ng==
+    YmIzZDMzMjJlMTE5NTFjODNjYmE2OTI3ZjAzNDEzYzU0MzJhNGQ4NA==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    YWRhNTE5NTBlYzRmYTg4NWRjYjdmYmYwMDFmYjcyN2M2YmM0YzI2YjkxMGU3
-    YTQ0YTMyOGJlYjU2NTc2ODBkZTJmN2Q1ZThlZTFhNzhhODAwYWMxOTQ0Yzc3
-    ZGNmMmNkYjlkYTYyYWY2MjJjMTQ3NTUzNWE1ZWZhMDBjOTQ2NDY=
+    MGUzMWUyODkyYzU1MGE4ODMyZWJhYWZmMGVkYzI4YjMzNGUwNDdhNTAzYjRh
+    MzEyYTdhNTljZjMxY2I4ZWYxODZlNzc1NmYwYzcxYzA3MzAwNWUzOWI4MTU5
+    NzE3NTEwMDhjY2JmNzY3N2I1YmUyMDkwNGViNTczN2I5Y2EwNDg=
   data.tar.gz: !binary |-
-    YWU3YzA2ODAzMWQ5ZjdkYTNiNzZhNzMzNjFkOGYzNWViYTgxNDg4NzAwNWJm
-    NmE2ZWM3YmQ5NWFhOTA5ZWYxYWE3ZjczMzE0ZTU1M2Q4MTUyNDAwNTY2NDcw
-    ZGFhMDM3ZGZiNWRhYzAwMjQ0MGYzYTkwMmI1MTgyOTc5N2Q4MzQ=
+    ZjE3NWYwYzIyOGY1ZTVhZjJkMGYwMGM2MDFiOGNiM2ZjNGQxMmVkNTkxMDFj
+    MDY3Mjg2MTljYzJjZjMxNjE2NTRjYTRjMzU3NmY3NDM1ODJkODZlZDE0NGUw
+    OGM4YjcxZmI0YmVkNDZlZTdmZjAyMmQyNTgxYjg1OTdmOTJhM2Q=

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.1.05 / 2014-02-20
+* [CHANGE] File `.rubocop.yml`. Updated, cop EmptyLinesAroundBody disabled.
+* [CHANGE] Style of several /lib files improved:  `feature-model`, `feature-rep`, `file-action`, `gherkin-facade`, `hook-dsl`, `sandbox`.
+
 ### 0.1.04 / 2013-01-14
 * [CHANGE] File `.travis.yml`. Addition of MRI Ruby 2.1.0 to Travis CI.
 * [CHANGE] File `LICENSE.txt`. Addition of 2014 in copyright year.

data/lib/cukedep/constants.rb

@@ -3,7 +3,7 @@
 
 module Cukedep # Module used as a namespace
   # The version number of the gem.
-  Version = '0.1.04'
+  Version = '0.1.05'
 
   # Brief description of the gem.
   Description = 'Manage dependencies between Cucumber feature files'

data/lib/cukedep/feature-model.rb

@@ -14,7 +14,7 @@ module Cukedep # This module is used as a namespace
 # See also: Is this topological sort in Ruby flawed?
 class FeatureModel
 
-FeatureDependencies = Struct.new(:dependee, :dependents)
+  FeatureDependencies = Struct.new(:dependee, :dependents)
 
 # Helper class used internally by FeatureModel class.
 # Purpose: to try to create a valid dependency graph and perform a
@@ -164,7 +164,7 @@ EOS
   
   # Output the nodes as graph vertices + their edges with parent node
   def emit_body(anIO)
-  anIO.puts  <<-EOS
+    anIO.puts  <<-EOS
   subgraph island {
     node [shape = box, style=filled, color=lightgray];
 EOS
@@ -243,6 +243,7 @@ EOS
 
 
   protected
+
   def validated_model(theFeatureFiles)
     return theFeatureFiles
   end
@@ -279,7 +280,7 @@ EOS
         unless aMapping.include?(a_tag)
           msg_p1 = "Feature with identifier '#{its_id}'"
           msg_p2 = " depends on unknown feature '#{a_tag}'"
-          fail(StandardError, msg_p1 = msg_p2)
+          fail(StandardError, msg_p1, msg_p2)
         end
         aMapping[a_tag]
       end

data/lib/cukedep/feature-rep.rb

@@ -31,6 +31,7 @@ class FeatureRep
   end
   
   public
+
   # The list of all feature identifiers retrieved from the dependency tags
   def dependency_tags()
     dep_tags = tags.select { |t| t =~ DependencyPrefix }

data/lib/cukedep/file-action.rb

@@ -19,15 +19,15 @@ class FileAction
 
 
   # Datavalue semantic: FileActions don't have identity
-  def ==(another)
-    return true if self.object_id == another.object_id
-    return false if self.class != another.class
+  def ==(other)
+    return true if object_id == other.object_id
+    return false if self.class != other.class
 
     attrs = [:patterns, :delta]
     equality = true
 
     attrs.each do |accessor|
-      equality = self.send(accessor) == another.send(accessor)
+      equality = send(accessor) == other.send(accessor)
       break unless equality
     end
 
@@ -36,10 +36,13 @@ class FileAction
 
 
   protected
+
   def validate_file_patterns(filePatterns)
-    raise StandardError, 'Expecting a list of file patterns' unless filePatterns.kind_of?(Array)
+    err_msg = 'Expecting a list of file patterns'
+    fail StandardError, err_msg unless filePatterns.kind_of?(Array)
     filePatterns.each do |filePatt|
-      raise StandardError, "Invalid value in list of file patterns: #{filePatt}" unless filePatt.kind_of?(String)
+      err_msg = "Invalid value in list of file patterns: #{filePatt}"
+      fail StandardError, err_msg unless filePatt.kind_of?(String)
     end
 
     return filePatterns
@@ -47,11 +50,11 @@ class FileAction
 
   def validate_delta(aDelta)
     case aDelta
-    when NilClass then validated = nil
-    when String
-      validated = aDelta.empty? ? nil : aDelta
-    else
-      raise StandardError, 'Invalid relative path #{aDelta}'
+      when NilClass then validated = nil
+      when String
+        validated = aDelta.empty? ? nil : aDelta
+      else
+        fail StandardError, 'Invalid relative path #{aDelta}'
     end
 
     return validated
@@ -89,7 +92,7 @@ class DeleteAction < FileAction
   def run!(targetDir)
     return if patterns.empty?
     orig_dir = Dir.getwd  # Store current work directory
-    #pp orig_dir
+    # pp orig_dir
 
     begin
       Dir.chdir(full_path(targetDir))
@@ -103,6 +106,7 @@ class DeleteAction < FileAction
   end
 
   private
+
   def single_action(aFilename)
     FileUtils.remove_file(aFilename)
   end
@@ -136,6 +140,7 @@ class CopyAction < FileAction
   end
 
   private
+  
   def single_action(aFilename, aDirectory)
     FileUtils.cp(aFilename, aDirectory)
   end
@@ -143,29 +148,34 @@ class CopyAction < FileAction
 end # class
 
 
-# An (file) action triplet combines three FileActions that are executed in sequence.
+# An (file) action triplet combines three FileActions 
+# that are executed in sequence.
 class ActionTriplet
 
   attr_reader(:save_action)
   attr_reader(:delete_action)
   attr_reader(:copy_action)
 
-  #[theActionSettings] An object that responds to the [] operator.
-  # The argument of the operator must be: :save_patterns, :save_subdir, :delete_patterns, :delete_subdir,
+  # [theActionSettings] An object that responds to the [] operator.
+  # The argument of the operator must be:
+  # :save_patterns, :save_subdir, :delete_patterns, :delete_subdir,
   # :copy_patterns, :copy_subdir
   def initialize(theActionSettings)
-    @save_action = CopyAction.new(theActionSettings[:save_patterns], theActionSettings[:save_subdir])
-    @delete_action = DeleteAction.new(theActionSettings[:delete_patterns], theActionSettings[:delete_subdir])
-    @copy_action = CopyAction.new(theActionSettings[:copy_patterns], theActionSettings[:copy_subdir])
+    @save_action = CopyAction.new(theActionSettings[:save_patterns], 
+      theActionSettings[:save_subdir])
+    @delete_action = DeleteAction.new(theActionSettings[:delete_patterns],
+      theActionSettings[:delete_subdir])
+    @copy_action = CopyAction.new(theActionSettings[:copy_patterns],
+      theActionSettings[:copy_subdir])
   end
 
 
-  def ==(another)
-    return true if self.object_id == another.object_id
+  def ==(other)
+    return true if object_id == other.object_id
 
-    return (save_action == another.save_action) &&
-      (delete_action == another.delete_action) &&
-      (copy_action == another.copy_action)
+    return (save_action == other.save_action) &&
+      (delete_action == other.delete_action) &&
+      (copy_action == other.copy_action)
   end
 
 
@@ -181,7 +191,7 @@ class ActionTriplet
   # Return nil if no triplet was found for the event.
   def self.builtin(anEvent)
     @@builtin_actions ||= {
-      before_each: ActionTriplet.new( {
+      before_each: ActionTriplet.new({
         save_patterns: [],
         save_subdir: '',
         delete_patterns: ['*.feature'],
@@ -189,7 +199,7 @@ class ActionTriplet
         copy_patterns: [],
         copy_subdir: './features'
       }),
-      after_each: ActionTriplet.new( {
+      after_each: ActionTriplet.new({
         save_patterns: [],
         save_subdir: '',
         delete_patterns: ['*.feature'], # Remove feature files after the run
@@ -208,4 +218,4 @@ end # class
 
 end # module
 
-# End of file
+# End of file

data/lib/cukedep/gherkin-facade.rb

@@ -38,8 +38,11 @@ module Cukedep # This module is used as a namespace
       # Parse them
       filenames.each do |fname|
         puts "  #{fname}" if verbose
-        # To prevent encoding issue, open the file with an explicit external encoding
-        File::open(fname, "r:#{external_encoding}") { |f| parser.parse(f.read, fname, 0) }
+        # To prevent encoding issue, open the file
+        # with an explicit external encoding
+        File.open(fname, "r:#{external_encoding}") do |f| 
+          parser.parse(f.read, fname, 0) 
+        end
       end
       
       return aListener
@@ -49,4 +52,4 @@ module Cukedep # This module is used as a namespace
 
 end # module
 
-# End of file
+# End of file

data/lib/cukedep/hook-dsl.rb

@@ -27,7 +27,7 @@ module HookDSL
   def after_cuke(aScope, &aBlock)
     kind = :after
     scope = validated_scope(kind, aScope)
-    register_hook(kind, aScope, aBlock) if block_given?
+    register_hook(kind, scope, aBlock) if block_given?
   end
 
 =begin
@@ -46,18 +46,19 @@ module HookDSL
 =end
 
   private
+  
   def register_hook(aKind, aScope, aBlock)
     scope = validated_scope(aKind, aScope)
 
     ivar = "@#{aKind}_hooks".to_sym
-    self.instance_variable_set(ivar, {}) if self.instance_variable_get(ivar).nil?
-    self.instance_variable_get(ivar)[scope] = aBlock
+    instance_variable_set(ivar, {}) if instance_variable_get(ivar).nil?
+    instance_variable_get(ivar)[scope] = aBlock
   end
   
   def validated_scope(aKind, aScope)
     unless ValidHookScopes.include?(aScope)
       msg = "Unknown scope '#{aScope}' for #{aKind}_cuke hook."
-      raise StandardError, msg
+      fail StandardError, msg
     end
     
     return aScope
@@ -71,10 +72,11 @@ module HookDSL
     end
     
     handler = hooks.nil? ? nil : hooks.fetch(aScope)
+    return handler
   end
 
 end # module
 
 end # module
 
-# End of file
+# End of file

data/lib/cukedep/sandbox.rb

@@ -18,4 +18,4 @@ module Cukedep # This module is used as a namespace
 
 end # module
 
-# End of file
+# End of file

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cukedep
 version: !ruby/object:Gem::Version
-  version: 0.1.04
+  version: 0.1.05
 platform: ruby
 authors:
 - Dimitri Geshef
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-14 00:00:00.000000000 Z
+date: 2014-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber