cuke_sniffer 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a9c28cd72cb8c92f7652554a02e08e8011396fcc
-  data.tar.gz: 4a51196a738f9e34cfdca8956be6470b60c6e9b1
+  metadata.gz: b53fd2a4aa90a0c9a77360600b64f0d5a8317d88
+  data.tar.gz: b801e304f3cfca26540c38e01046e551f1de7814
 SHA512:
-  metadata.gz: 6d5100b8206489608e24dff3b95455bbec3a28b618a11e099e1ab744dad19bea92f3144e6bcfc42a00a060dc94e2570e591cb942cf6f4833893d7e31e8bc77d3
-  data.tar.gz: fda70ca7da1d441871df0d041d233dc56922fb026ef4bd134c6a40c0079929d377514f8b48f371c5b8d6d5cf65df5b4c41a1975fb7e8ae3867f590206a09991b
+  metadata.gz: 785c6e575269118fe0aa09d13f24e90a47d791dd94a20c2d45a44e2eb2dbd0fd2fde67e63a60b097cab09c337dcdaa8a6ad7fcf9a7bf1a41877c6619d9f32302
+  data.tar.gz: fc488ea1e58617e8d3973fdc0ca8145524da4607f0c2f10ae84f1cd98cfb36f34b1c1f61f13fb00058ce910f7e826a918a772087882d9810d70c7cd43876553e

data/lib/cuke_sniffer/feature_rules_evaluator.rb

@@ -30,6 +30,10 @@ module CukeSniffer
       comparison_object.tags == tags
     end
 
+    def is_comment_and_tag?(line)
+      true if line =~ /^\#.*\@.*$/
+    end
+
     private
 
     def create_name(line, filter)

data/lib/cuke_sniffer/formatter.rb

@@ -13,9 +13,9 @@ module CukeSniffer
     def self.output_console(cuke_sniffer)
       summary = cuke_sniffer.summary
       output = "Suite Summary" +
-                "  Total Score: #{summary[:total_score]}\n" +
-                get_output_summary_nodes(cuke_sniffer) +
-                console_improvement_list(summary[:improvement_list])
+          "  Total Score: #{summary[:total_score]}\n" +
+          get_output_summary_nodes(cuke_sniffer) +
+          console_improvement_list(summary[:improvement_list])
 
       puts output
     end
@@ -32,9 +32,9 @@ module CukeSniffer
     # Formats the section data for a summary object
     def self.console_summary(name, summary)
       "  #{name}\n" +
-      "    Min: #{summary[:min]}\n" +
-      "    Max: #{summary[:max]}\n" +
-      "    Average: #{summary[:average]}\n"
+          "    Min: #{summary[:min]}\n" +
+          "    Max: #{summary[:max]}\n" +
+          "    Average: #{summary[:average]}\n"
     end
 
     # Formats the improvement list data for summary
@@ -55,7 +55,9 @@ module CukeSniffer
     def self.output_html(cuke_sniffer, file_name = DEFAULT_OUTPUT_FILE_NAME, template_name = "standard_template")
       cuke_sniffer = sort_cuke_sniffer_lists(cuke_sniffer)
       output = ERB.new(extract_markup("#{template_name}.html.erb")).result(binding)
-      File.open(format_html_file_name(file_name), 'w') do |f| f.write(output) end
+      File.open(format_html_file_name(file_name), 'w') do |f|
+        f.write(output)
+      end
     end
 
     # Returns an ERB page built up for the passed file name
@@ -102,7 +104,9 @@ module CukeSniffer
       end
     end
 
-    # Creates an xml file in the junit with issues organized by file.
+    # Creates an xml file that can be read by Jenkins/Hudson in the junit format with issues organized and collated by file.
+    # Each file becomes a testsuite with corresponding failures associated to it.
+    # If no failures are found this will be marked as a pass by Jenkins/Hudson.
     # file_name defaults to "cuke_sniffer_result.xml" unless specified
     #  cuke_sniffer.output_xml
     # Or
@@ -111,34 +115,47 @@ module CukeSniffer
       file_name = file_name + ".xml" unless file_name =~ /\.xml$/
       results = {}
       failures = 0
+      suits={}
       current = cuke_sniffer.features
       current.concat cuke_sniffer.scenarios
       current.concat cuke_sniffer.step_definitions
       current.concat cuke_sniffer.hooks
       current.each do |test|
         location = test.location.gsub("#{Dir.pwd}/", '')
-        location_no_line = location.gsub(/:[0-9]*/,'')
+        location_no_line = location.gsub(/:[0-9]*/, '')
         line_num = location.include?(":") ? location.gsub(/.*:(.*)/, "\\1") : "full_file"
-        errors = test.rules_hash.keys.map {|f| {:line => line_num,
-                                                :severity => test.rules_hash,
-                                                :error => f,
-                                                :formatted => "Severity: #{test.rules_hash[f]}\nLocation: #{location}\nError: #{f}"}}
+        errors = test.rules_hash.keys.map { |f| {:line => "line: #{line_num}",
+                                                 :error => f,
+                                                 :formatted => "Location: #{location}",
+                                                 :instances => "Instances: #{test.rules_hash[f]}"
+        } }
         results[location_no_line] = results[location_no_line].nil? ? errors : results[location_no_line].concat(errors)
         failures += test.rules_hash.size
       end
+      results.each do |location, failure|
+        suits[location]=failure
+      end
       builder = Nokogiri::XML::Builder.new do |xml|
         xml.testsuites(:tests => results.size, :failures => failures) do
-          results.each do |location, failures|
-            failures.each do |failure|
-              xml.testcase(:classname => location, :name => failure[:line], :time => 0) do
-                xml.failure(failure[:formatted], :type => 'failure', :message => failure[:error])
+          suits.each do |location, failures|
+            xml.testsuite(:name => location, :tests => 1, :failures => failures.length) do
+              if failures.length == 0
+                xml.testcase(:classname => location, :name => location, :time => 0, :status => 0)
+              else
+                failures.each do |failure|
+                  xml.testcase(:classname => location, :name => failure[:line], :time => 0, :status => failure[:instances]) do
+                    xml.failure(failure[:formatted], :type => 'failure', :message => "#{failure[:error]} #{failure[:instances]}")
+                  end
+                end
               end
             end
           end
         end
       end
       output = builder.to_xml
-      File.open(file_name, 'w') do |f| f.write(output) end
+      File.open(file_name, 'w') do |f|
+        f.write(output)
+      end
       # Return here to aid testing.
       output
     end

data/lib/cuke_sniffer/report/features.html.erb

@@ -101,10 +101,7 @@
                         <% next if scenario.score == 0 %>
                         <div class="col-md-12 scenario">
                           <div class="col-md-12 title">
-                            <div class="btn btn-xs btn-default" style="display:none;"> <!--TODO enable this feature -->
-                              View <span class="glyphicon glyphicon-eye-open"></span>
-                            </div>
-                            <%= scenario.type %>: <%=scenario.name %>
+                            <%= scenario.type %>: <%=scenario.name %> (line: <%=scenario.start_line %>)
                           </div>
                           <div class="col-md-12 details well">
                             <% SummaryHelper::sort_improvement_list(scenario.rules_hash).each do |phrase, count| %>
@@ -129,4 +126,4 @@
       <% end %>
     </div>
   </div>
-</div>
+</div>

data/lib/cuke_sniffer/rule_config.rb

@@ -53,11 +53,16 @@ module CukeSniffer
                 lambda { |feature_rule_target, rule|
                   tokens = feature_rule_target.tags.collect { |line| line.split }.flatten
 
+                  return_value = nil
+
                   tokens.each_with_index do |token, index|
                     if feature_rule_target.is_comment?(token) && tokens[0...index].any? { |x| x =~ /\A@/ }
-                      return feature_rule_target.store_rule(rule)
+                      return_value = feature_rule_target.store_rule(rule)
+                      break
                     end
                   end
+
+                  return_value
                 }
         },
         :universal_nested_step => {
@@ -198,11 +203,14 @@ module CukeSniffer
             :score => WARNING,
             :targets => ["Scenario"],
             :reason => lambda { |scenario, rule| step_order = scenario.get_step_order
-                        ["But", "*", "And"].each { |type| step_order.delete(type) }
-                        if(step_order != %w(Given When Then) and step_order != %w(When Then))
-                          scenario.store_rule(rule)
-                        end}
-
+                        if !step_order.empty?
+                          ["But", "*", "And"].each { |type| step_order.delete(type) }
+                          step_order = step_order.chunk { |keyword| keyword }.map(&:first)
+                          if(step_order != %w(Given When Then) and step_order != %w(When Then))
+                            scenario.store_rule(rule)
+                          end
+                        end
+            }
         },
         :invalid_first_step => {
             :enabled => true,
@@ -315,7 +323,7 @@ module CukeSniffer
             :score => WARNING,
             :targets => ["Feature", "Scenario"],
             :reason => lambda { |feature_rule_target, rule| feature_rule_target.tags.each do | tag |
-                          feature_rule_target.store_rule(rule, rule.phrase.gsub("{class}", feature_rule_target.type)) if feature_rule_target.is_comment?(tag)
+                          feature_rule_target.store_rule(rule, rule.phrase.gsub("{class}", feature_rule_target.type)) if feature_rule_target.is_comment_and_tag?(tag)
                         end}
         },
         :empty_hook => {
@@ -347,6 +355,16 @@ module CukeSniffer
                         all_tags.flatten!
                         unique_tags = all_tags.uniq
                         true unless all_tags == unique_tags}
+        },
+        :duplicate_scenario_name => {
+            :enabled => true,
+            :phrase => "Feature has scenarios with the same name.",
+            :score => WARNING,
+            :targets => ["Feature"],
+            :reason => lambda { |feature, rule|
+                          names = feature.scenarios.collect { |scenario| scenario.name }
+                          return names.length > names.uniq.length
+            }
         }
     }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cuke_sniffer
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Robert Cochran
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-28 00:00:00.000000000 Z
+date: 2017-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri