cuke_modeler 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae2a37ad321f1cf9ea164210a52981ed565a2f5c
-  data.tar.gz: 2eaf5c8db10ddfba8c9ff2a0a0b61198929d98f7
+  metadata.gz: 4779a73d0414df470da374597d5a5db928e9f1fd
+  data.tar.gz: fd1e0ab88380b774e1301789d50a89cce58716e8
 SHA512:
-  metadata.gz: 9e43d4812d7bb826cc7fabc0a957c6ffd7f8a0b54f518c9ecdea9ebd24e7dd96f63ffb565ecbf58c487eb4c55d5c3953edbcaec7e2a8dce276a88e7bd2b23dd7
-  data.tar.gz: 738a51078b7c0b4551f5a31670f7c42ec5dece16a8d23ac272d2e25d16bd06244926cfb385f25abf4636b1b371c426ba941bd8009aab9b07438bb179208fbb14
+  metadata.gz: '029706fe40a199ddb8b12c90de6c61b61576afab23c29603b43524f22b88c6d4373b52aa059f34f2a495c11f8f787956785684a5145ed5ac0f3dc2ff0bc994a8'
+  data.tar.gz: 3e41b0e4310907be62af428dcdc4e511ee783aa82e4aae93f5ec4977cc7724400ba83911b0b2ca5af65a2716e1391750c86e17d2cdda1f2b305a42247112a91a

data/.travis.yml

@@ -1,3 +1,7 @@
+os:
+  - linux
+  - osx
+
 language: ruby
 rvm:
   - 1.8.7
@@ -5,19 +9,26 @@ rvm:
   - 2.0.0
   - 2.1.6
   - 2.2.2
+  - 2.3.3
+  - 2.4.0
+  - jruby-9.1.7.0
 
 gemfile:
   - testing/gemfiles/gherkin2.gemfile
   - testing/gemfiles/gherkin3.gemfile
   - testing/gemfiles/gherkin4.gemfile
 
-
 matrix:
   exclude:
+  # gherkin 3.x does not work with Ruby 1.8.x
   - rvm: 1.8.7
     gemfile: testing/gemfiles/gherkin3.gemfile
+  # gherkin 4.x does not work with Ruby 1.8.x
   - rvm: 1.8.7
     gemfile: testing/gemfiles/gherkin4.gemfile
+  # Travis does not provide 1.8.7 on OSX
+  - rvm: 1.8.7
+    os: osx
 
 # todo - Remove this once TravisCI fixes their bundler issue (https://github.com/alphagov/govuk_template/pull/186)
 before_install:

data/Gemfile

@@ -4,24 +4,25 @@ source 'https://rubygems.org'
 gemspec
 
 # cuke_modeler can play with pretty much any version of these but they all play differently with Ruby
-if RUBY_VERSION =~ /^1\.8/
-  gem 'cucumber', '<1.3.0'
-  gem 'gherkin', '<2.12.0'
-  gem 'rake', '< 11.0' # Rake dropped 1.8.x support after this version
-elsif RUBY_VERSION =~ /^1\./
-  gem 'cucumber', '<2.0.0'
-end
 
 if RUBY_VERSION =~ /^1\./
+
   gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
   gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
   gem 'term-ansicolor', '< 1.4' # The 'term-ansicolor' gem requires Ruby 2.x on/after this version
-end
 
-if RUBY_VERSION =~ /^2\./
+  if RUBY_VERSION =~ /^1\.8/
+    gem 'cucumber', '~> 1.0' # Ruby 1.8.x support dropped after this version
+    gem 'gherkin', '< 2.12.1' # Ruby 1.8.x support dropped after this version
+    gem 'rake', '< 11.0' # Ruby 1.8.x support dropped after this version
+  end
+
+elsif RUBY_VERSION =~ /^2\./
+
+  if RUBY_VERSION =~ /^2\.[23456789]/
+    gem 'test-unit'
+  end
+
   gem 'gherkin', '~> 4.0'
-end
 
-if RUBY_VERSION =~ /^2\.[23456789]/
-  gem 'test-unit'
 end

data/History.md

@@ -1,3 +1,8 @@
+### Version 1.2.1 / 2017-04-25
+
+* Now officially compatible with Rake 12.x.
+
+
 ### Version 1.2.0 / 2016-11-23
 
 * The comments in a feature file are now a modeled element.
@@ -139,7 +144,7 @@
   being populated if the instance was given a diretory to model.
 
 * Bug fix - Fixed a bug that occurred if a Directory object was asked for its 
-  #name when it was created as 'abstract' instead of modeling an existing 
+  \#name when it was created as 'abstract' instead of modeling an existing 
   directory.
 
 

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2014 Eric Kessler
+Copyright (c) 2014-2017 Eric Kessler, et al
 
 MIT License
 

data/README.md

@@ -1,7 +1,9 @@
 [![Gem Version](https://badge.fury.io/rb/cuke_modeler.svg)](https://rubygems.org/gems/cuke_modeler)
-[![Build Status](https://travis-ci.org/enkessler/cuke_modeler.svg?branch=dev)](https://travis-ci.org/enkessler/cuke_modeler)
 [![Dependency Status](https://gemnasium.com/enkessler/cuke_modeler.svg)](https://gemnasium.com/enkessler/cuke_modeler)
-
+[![Build Status](https://travis-ci.org/enkessler/cuke_modeler.svg?branch=dev)](https://travis-ci.org/enkessler/cuke_modeler)
+[![Build status](https://ci.appveyor.com/api/projects/status/is8xqvoqn3pjh9l0/branch/dev?svg=true)](https://ci.appveyor.com/project/enkessler/cuke-modeler/branch/dev)
+[![Coverage Status](https://coveralls.io/repos/github/enkessler/cuke_modeler/badge.svg?branch=dev)](https://coveralls.io/github/enkessler/cuke_modeler?branch=dev)
+[![MIT Licence](https://badges.frapsoft.com/os/mit/mit.svg?v=103)](https://opensource.org/licenses/mit-license.php)
 
 
 # CukeModeler

data/appveyor.yml

@@ -0,0 +1,47 @@
+version: '1.0.{build}'
+
+environment:
+  matrix:
+    - RUBY_VERSION: 187-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin2.gemfile
+    - RUBY_VERSION: 193-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin2.gemfile
+    - RUBY_VERSION: 200-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin2.gemfile
+    - RUBY_VERSION: 21-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin2.gemfile
+    - RUBY_VERSION: 22-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin2.gemfile
+
+    - RUBY_VERSION: 193-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin3.gemfile
+    - RUBY_VERSION: 200-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin3.gemfile
+    - RUBY_VERSION: 21-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin3.gemfile
+    - RUBY_VERSION: 22-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin3.gemfile
+
+    - RUBY_VERSION: 193-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin4.gemfile
+    - RUBY_VERSION: 200-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin4.gemfile
+    - RUBY_VERSION: 21-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin4.gemfile
+    - RUBY_VERSION: 22-x64
+      BUNDLE_GEMFILE: testing/gemfiles/gherkin4.gemfile
+
+
+install:
+  - set PATH=C:\Ruby%RUBY_VERSION%\bin;%PATH%
+  - bundle install
+
+build: off
+
+before_test:
+  - ruby -v
+  - gem -v
+  - bundle -v
+
+test_script:
+  - bundle exec rake

data/cuke_modeler.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency('multi_json', '~> 1.0')
 
   spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "rake", '< 12.0.0'
+  spec.add_development_dependency "rake", '< 13.0.0'
   spec.add_development_dependency 'cucumber', '< 3.0.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'simplecov', '< 1.0.0'

data/lib/cuke_modeler/adapters/gherkin_2_adapter.rb

@@ -263,7 +263,7 @@ module CukeModeler
             when 'scenario_outline'
               adapt_outline!(element, gathered_comments)
             else
-              raise("Unknown element type: #{element['type']}")
+              raise(ArgumentError, "Unknown element type: #{element['type']}")
           end
         end
       end

data/lib/cuke_modeler/containing.rb

@@ -75,12 +75,6 @@ module CukeModeler
       populate_source_line(table_object, parsed_table_data)
     end
 
-    def populate_tablerow(row_object, parsed_row_data)
-      populate_source_line(row_object, parsed_row_data)
-      populate_row_cells(row_object, parsed_row_data)
-      populate_parsing_data(row_object, parsed_row_data)
-    end
-
     def populate_cell(cell_object, parsed_cell_data)
       populate_cell_value(cell_object, parsed_cell_data)
       populate_source_line(cell_object, parsed_cell_data)

data/lib/cuke_modeler/parsing.rb

@@ -18,8 +18,8 @@ module CukeModeler
     # The *gherkin* gem loads differently and has different grammar rules across major versions. Parsing
     # will be done with an 'adapter' appropriate to the version of the *gherkin* gem that has been activated.
 
-    case
-      when Gem.loaded_specs['gherkin'].version.version[/^4/]
+    case Gem.loaded_specs['gherkin'].version.version
+      when /^4\./
         require 'gherkin/parser'
         require 'cuke_modeler/adapters/gherkin_4_adapter'
 
@@ -33,7 +33,7 @@ module CukeModeler
           CukeModeler::Gherkin4Adapter
         end
 
-      when Gem.loaded_specs['gherkin'].version.version[/^3/]
+      when /^3\./
         require 'gherkin/parser'
         require 'cuke_modeler/adapters/gherkin_3_adapter'
 
@@ -85,7 +85,7 @@ module CukeModeler
       # The dialects currently known by the gherkin gem
       def dialects
         unless @dialects
-          @dialects = Gem.loaded_specs['gherkin'].version.version[/^2/] ? Gherkin::I18n::LANGUAGES : Gherkin::DIALECTS
+          @dialects = Gem.loaded_specs['gherkin'].version.version[/^2\./] ? Gherkin::I18n::LANGUAGES : Gherkin::DIALECTS
         end
 
         @dialects

data/lib/cuke_modeler/version.rb

@@ -1,4 +1,4 @@
 module CukeModeler
   # The gem version
-  VERSION = "1.2.0"
+  VERSION = '1.2.1'
 end

data/testing/gemfiles/gherkin2.gemfile

@@ -1,22 +1,25 @@
 source 'https://rubygems.org'
 
 gemspec :path => "../../"
-gem "gherkin", "< 3.0.0"
+gem "gherkin", "~> 2.0"
 
 # cuke_modeler can play with pretty much any version of these but they all play differently with Ruby
-if RUBY_VERSION =~ /^1\.8/
-  gem 'cucumber', '<1.3.0'
-  gem 'rake', '< 11.0' # Rake dropped 1.8.x support after this version
-elsif RUBY_VERSION =~ /^1\./
-  gem 'cucumber', '>=1.0.0', '<2.0.0'
-end
 
 if RUBY_VERSION =~ /^1\./
+
   gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
   gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
   gem 'term-ansicolor', '< 1.4' # The 'term-ansicolor' gem requires Ruby 2.x on/after this version
-end
 
-if RUBY_VERSION =~ /^2\.[23456789]/
-  gem 'test-unit'
+  if RUBY_VERSION =~ /^1\.8/
+    gem 'cucumber', '~> 1.0' # Ruby 1.8.x support dropped after this version
+    gem 'rake', '< 11.0' # Ruby 1.8.x support dropped after this version
+  end
+
+elsif RUBY_VERSION =~ /^2\./
+
+  if RUBY_VERSION =~ /^2\.[23456789]/
+    gem 'test-unit'
+  end
+
 end

data/testing/gemfiles/gherkin3.gemfile

@@ -4,17 +4,17 @@ gemspec :path => "../../"
 gem "gherkin", "~> 3.0"
 
 # cuke_modeler can play with pretty much any version of these but they all play differently with Ruby
-if RUBY_VERSION =~ /^1\.8/
-  gem 'cucumber', '<1.3.0'
-  gem 'rake', '< 11.0' # Rake dropped 1.8.x support after this version
-end
 
 if RUBY_VERSION =~ /^1\./
+
   gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
   gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
   gem 'term-ansicolor', '< 1.4' # The 'term-ansicolor' gem requires Ruby 2.x on/after this version
-end
 
-if RUBY_VERSION =~ /^2\.[23456789]/
-  gem 'test-unit'
+elsif RUBY_VERSION =~ /^2\./
+
+  if RUBY_VERSION =~ /^2\.[23456789]/
+    gem 'test-unit'
+  end
+
 end

data/testing/gemfiles/gherkin4.gemfile

@@ -4,17 +4,17 @@ gemspec :path => "../../"
 gem "gherkin", "~> 4.0"
 
 # cuke_modeler can play with pretty much any version of these but they all play differently with Ruby
-if RUBY_VERSION =~ /^1\.8/
-  gem 'cucumber', '<1.3.0'
-  gem 'rake', '< 11.0' # Rake dropped 1.8.x support after this version
-end
 
 if RUBY_VERSION =~ /^1\./
+
   gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
   gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
   gem 'term-ansicolor', '< 1.4' # The 'term-ansicolor' gem requires Ruby 2.x on/after this version
-end
 
-if RUBY_VERSION =~ /^2\.[23456789]/
-  gem 'test-unit'
+elsif RUBY_VERSION =~ /^2\./
+
+  if RUBY_VERSION =~ /^2\.[23456789]/
+    gem 'test-unit'
+  end
+
 end

data/testing/rspec/spec/integration/feature_file_integration_spec.rb

@@ -169,7 +169,7 @@ describe 'FeatureFile, Integration' do
                              '# row comment']
 
         # gherkin 2.x 'loses' comments that are not followed by some element
-        expected_comments << '# final comment' unless Gem.loaded_specs['gherkin'].version.version[/^2/]
+        expected_comments << '# final comment' unless Gem.loaded_specs['gherkin'].version.version[/^2\./]
 
 
         expect(comments).to match_array(expected_comments)

data/testing/rspec/spec/integration/feature_integration_spec.rb

@@ -599,4 +599,43 @@ describe 'Feature, Integration' do
 
   end
 
+
+  describe 'stuff that is in no way part of the public API and entirely subject to change' do
+
+    it 'provides a useful explosion message if it encounters an entirely new type of feature child' do
+      begin
+        $old_method = CukeModeler::Parsing.method(:parse_text)
+
+
+        # Monkey patch the parsing method to mimic what would essentially be Gherkin creating new types of language objects
+        module CukeModeler
+          module Parsing
+            class << self
+              def parse_text(source_text, filename)
+                result = $old_method.call(source_text, filename)
+
+                result.first['feature']['elements'].first['type'] = :some_unknown_type
+
+                result
+              end
+            end
+          end
+        end
+
+
+        expect { clazz.new("#{@feature_keyword}:\n#{@scenario_keyword}:\n#{@step_keyword} foo") }.to raise_error(ArgumentError, /Unknown.*some_unknown_type/)
+      ensure
+        # Making sure that our changes don't escape a test and ruin the rest of the suite
+        module CukeModeler
+          module Parsing
+            class << self
+              define_method(:parse_text, $old_method)
+            end
+          end
+        end
+      end
+    end
+
+  end
+
 end

data/testing/rspec/spec/integration/gherkin_2_adapter_spec.rb

@@ -3,6 +3,8 @@ require "#{File.dirname(__FILE__)}/../spec_helper"
 
 describe 'Gherkin2Adapter, Integration', :gherkin2 => true do
 
+  let(:clazz) { CukeModeler::Gherkin2Adapter }
+  let(:adapter) { clazz.new }
   let(:source_text) { "# feature comment
                        @tag1 @tag2 @tag3
                        #{@feature_keyword}: A feature with everything it could have
@@ -66,9 +68,9 @@ describe 'Gherkin2Adapter, Integration', :gherkin2 => true do
                            | value |
                        # final comment" }
   let(:feature_file) { path = "#{@default_file_directory}/#{@default_feature_file_name}"
-  File.open(path, "w") { |file| file.puts source_text }
+                       File.open(path, "w") { |file| file.puts source_text }
 
-  CukeModeler::FeatureFile.new(path) }
+                       CukeModeler::FeatureFile.new(path) }
   let(:feature) { feature_file.feature }
 
 
@@ -152,4 +154,15 @@ describe 'Gherkin2Adapter, Integration', :gherkin2 => true do
     expect(model.parsing_data['cells']).to be_nil
   end
 
+
+  describe 'stuff that is in no way part of the public API and entirely subject to change' do
+
+    it 'provides a useful explosion message if it encounters an entirely new type of test' do
+      partial_feature_ast = {"elements" => [{"type" => "some_unknown_type"}]}
+
+      expect { adapter.adapt_feature!(partial_feature_ast, []) }.to raise_error(ArgumentError, /Unknown.*some_unknown_type/)
+    end
+
+  end
+
 end

data/testing/rspec/spec/integration/gherkin_3_adapter_spec.rb

@@ -3,6 +3,8 @@ require "#{File.dirname(__FILE__)}/../spec_helper"
 
 describe 'Gherkin3Adapter, Integration', :gherkin3 => true do
 
+  let(:clazz) { CukeModeler::Gherkin3Adapter }
+  let(:adapter) { clazz.new }
   let(:source_text) { "# feature comment
                        @tag1 @tag2 @tag3
                        #{@feature_keyword}: A feature with everything it could have
@@ -66,9 +68,9 @@ describe 'Gherkin3Adapter, Integration', :gherkin3 => true do
                            | value |
                        # final comment" }
   let(:feature_file) { path = "#{@default_file_directory}/#{@default_feature_file_name}"
-  File.open(path, "w") { |file| file.puts source_text }
+                       File.open(path, "w") { |file| file.puts source_text }
 
-  CukeModeler::FeatureFile.new(path) }
+                       CukeModeler::FeatureFile.new(path) }
   let(:feature) { feature_file.feature }
 
 
@@ -146,4 +148,21 @@ describe 'Gherkin3Adapter, Integration', :gherkin3 => true do
     expect(model.parsing_data[:cells]).to be_nil
   end
 
+
+  describe 'stuff that is in no way part of the public API and entirely subject to change' do
+
+    it 'provides a useful explosion message if it encounters an entirely new type of test' do
+      partial_feature_ast = {:type => :Feature, :location => {:line => 1, :column => 1}, :scenarioDefinitions => [{:type => :some_unknown_type}]}
+
+      expect { adapter.adapt_feature!(partial_feature_ast) }.to raise_error(ArgumentError, /Unknown.*some_unknown_type/)
+    end
+
+    it 'provides a useful explosion message if it encounters an entirely new type of step block' do
+      partial_feature_ast = {:type => :Feature, :location => {:line => 1, :column => 1}, :scenarioDefinitions => [{:type => :Scenario, :tags => [], :location => {:line => 1, :column => 1}, :steps => [{:type => :Step, :location => {:line => 1, :column => 1}, :argument => {:type => :some_unknown_type, :location => {:line => 1, :column => 1}, :content => ""}}]}]}
+
+      expect { adapter.adapt_feature!(partial_feature_ast) }.to raise_error(ArgumentError, /Unknown.*some_unknown_type/)
+    end
+
+  end
+
 end

data/testing/rspec/spec/integration/gherkin_4_adapter_spec.rb

@@ -3,6 +3,8 @@ require "#{File.dirname(__FILE__)}/../spec_helper"
 
 describe 'Gherkin4Adapter, Integration', :gherkin4 => true do
 
+  let(:clazz) { CukeModeler::Gherkin4Adapter }
+  let(:adapter) { clazz.new }
   let(:source_text) { "# feature comment
                        @tag1 @tag2 @tag3
                        #{@feature_keyword}: A feature with everything it could have
@@ -66,9 +68,9 @@ describe 'Gherkin4Adapter, Integration', :gherkin4 => true do
                            | value |
                        # final comment" }
   let(:feature_file) { path = "#{@default_file_directory}/#{@default_feature_file_name}"
-  File.open(path, "w") { |file| file.puts source_text }
+                       File.open(path, "w") { |file| file.puts source_text }
 
-  CukeModeler::FeatureFile.new(path) }
+                      CukeModeler::FeatureFile.new(path) }
   let(:feature) { feature_file.feature }
 
 
@@ -145,4 +147,21 @@ describe 'Gherkin4Adapter, Integration', :gherkin4 => true do
     expect(model.parsing_data[:cells]).to be_nil
   end
 
+
+  describe 'stuff that is in no way part of the public API and entirely subject to change' do
+
+    it 'provides a useful explosion message if it encounters an entirely new type of test' do
+      partial_feature_ast = {:type => :Feature, :location => {:line => 1, :column => 1}, :children => [{:type => :some_unknown_type}]}
+
+      expect { adapter.adapt_feature!(partial_feature_ast) }.to raise_error(ArgumentError, /Unknown.*some_unknown_type/)
+    end
+
+    it 'provides a useful explosion message if it encounters an entirely new type of step block' do
+      partial_feature_ast = {:type => :Feature, :location => {:line => 1, :column => 1}, :children => [{:type => :Scenario, :tags => [], :location => {:line => 1, :column => 1}, :steps => [{:type => :Step, :location => {:line => 1, :column => 1}, :argument => {:type => :some_unknown_type, :location => {:line => 1, :column => 1}, :content => ""}}]}]}
+
+      expect { adapter.adapt_feature!(partial_feature_ast) }.to raise_error(ArgumentError, /Unknown.*some_unknown_type/)
+    end
+
+  end
+
 end

data/testing/rspec/spec/integration/parsing_integration_spec.rb

@@ -43,7 +43,7 @@ describe 'Parsing, Integration' do
     end
 
     it 'includes the type of object provided when raising an non-string exception' do
-      expect { nodule.parse_text(5) }.to raise_error(ArgumentError, /Fixnum/)
+      expect { nodule.parse_text(:not_a_string) }.to raise_error(ArgumentError, /Symbol/)
     end
 
     # todo - Stop doing this. Just return a feature file rooted AST.
@@ -62,44 +62,35 @@ describe 'Parsing, Integration' do
 
     it 'includes the underlying error message in the error that it raises' do
       begin
+        $old_method = CukeModeler::Parsing.method(:parsing_method)
+
         # Custom error type in order to ensure that we are throwing the correct thing
         module CukeModeler
           class TestError < StandardError
           end
         end
 
-        # Monkey patch Gherkin to throw the error that we need for testing
-        if Gem.loaded_specs['gherkin'].version.version[/^3|4/]
-          old_method = Gherkin::Parser.instance_method(:parse)
-
-          module Gherkin
-            class Parser
-              def parse(*args)
+        # Monkey patch the parsing method to throw the error that we need for testing
+        module CukeModeler
+          module Parsing
+            class << self
+              def parsing_method(*args)
                 raise(CukeModeler::TestError, 'something went wrong')
               end
             end
           end
-        else
-          old_method = Gherkin::Parser::Parser.instance_method(:parse)
-
-          module Gherkin
-            module Parser
-              class Parser
-                def parse(*args)
-                  raise(CukeModeler::TestError, 'something went wrong')
-                end
-              end
-            end
-          end
         end
 
+
         expect { nodule.parse_text('bad file') }.to raise_error(/CukeModeler::TestError.*something went wrong/)
       ensure
         # Making sure that our changes don't escape a test and ruin the rest of the suite
-        if Gem.loaded_specs['gherkin'].version.version[/^3|4/]
-          Gherkin::Parser.send(:define_method, :parse, old_method)
-        else
-          Gherkin::Parser::Parser.send(:define_method, :parse, old_method)
+        module CukeModeler
+          module Parsing
+            class << self
+              define_method(:parsing_method, $old_method)
+            end
+          end
         end
       end
 

data/testing/rspec/spec/spec_helper.rb

@@ -28,7 +28,7 @@ require "#{this_dir}/../../dialect_helper"
 
 # Use a fake dialect for testing in order to avoid hard coded language assumptions in the
 # implementation. Only possible with newer versions of Gherkin.
-if Gem.loaded_specs['gherkin'].version.version[/^2/]
+if Gem.loaded_specs['gherkin'].version.version[/^2\./]
   CukeModeler::DialectHelper.set_dialect(Gherkin::I18n::LANGUAGES['en'])
   CukeModeler::Parsing.dialect = 'en'
 else
@@ -58,12 +58,12 @@ end
 
 
 RSpec.configure do |config|
-  case
-    when Gem.loaded_specs['gherkin'].version.version[/^4/]
+  case Gem.loaded_specs['gherkin'].version.version
+    when /^4\./
       config.filter_run_excluding :gherkin2 => true,
                                   :gherkin3 => true,
                                   :gherkin4 => false
-    when Gem.loaded_specs['gherkin'].version.version[/^3/]
+    when /^3\./
       config.filter_run_excluding :gherkin2 => true,
                                   :gherkin3 => false,
                                   :gherkin4 => true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_modeler
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-24 00:00:00.000000000 Z
+date: 2017-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
@@ -78,14 +78,14 @@ dependencies:
     requirements:
     - - "<"
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 13.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "<"
       - !ruby/object:Gem::Version
-        version: 12.0.0
+        version: 13.0.0
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
@@ -176,6 +176,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- appveyor.yml
 - cuke_modeler.gemspec
 - lib/cuke_modeler.rb
 - lib/cuke_modeler/adapters/gherkin_2_adapter.rb
@@ -335,7 +336,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.7
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: A gem providing functionality to model Gherkin based test suites.