cuke_modeler 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1918fdba29731f9245ec6e80b77b64f92428bd6e
-  data.tar.gz: f823ab2cc837ebba7994be52255ceea98ca276a3
+  metadata.gz: c92f8c24b0eb10a93381bc8c70e4afff4be3af22
+  data.tar.gz: 878358f86a7f812b4d2268e708155f1c34b31ce1
 SHA512:
-  metadata.gz: 45546e2f8d77d4edafdd57a4ad648ce28b859b54614d94d7673f7aafdae766c2478eb2eff9393e33f9334e0583049efedecec02b2fb6bcea9d9cd9faa22ecf91
-  data.tar.gz: ef236d460ecb932f5c8475378baa7fd56dfb178580cd65108ff726eec12c9ea5fda43951912fe59f22580d0a1c70a2404d74e70faf766c5de499cd4f35238c47
+  metadata.gz: 3fd79be1950f2d569a4456aca2c5eca55e2243e4957a0d094c657224c1179709adb19b353d1a46da74e556e3ebafa551f4c3e97e7537f0072074e9c572ea3514
+  data.tar.gz: d9852037c1c5394afa1240fd3f2a3ddde314606a999fd6ab93360bffd70df27a1cc58d0a852acf9c85f33db9f6367daf0fd4e8f9985825008f167dc6f734fa82

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.idea/*

data/Gemfile

@@ -7,8 +7,6 @@ gemspec
 if RUBY_VERSION =~ /^1\.8/
   gem 'cucumber', '<1.3.0'
   gem 'gherkin', '<2.12.0'
-  gem 'mime-types', '<2.0.0'
-  gem 'rest-client', '<1.7.0'
   gem 'rake', '< 11.0' # Rake dropped 1.8.x support after this version
 elsif RUBY_VERSION =~ /^1\./
   gem 'cucumber', '<2.0.0'
@@ -17,6 +15,7 @@ end
 if RUBY_VERSION =~ /^1\./
   gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
   gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
+  gem 'term-ansicolor', '< 1.4' # The 'term-ansicolor' gem requires Ruby 2.x on/after this version
 end
 
 if RUBY_VERSION =~ /^2\./

data/History.md

@@ -1,3 +1,9 @@
+### Version 1.0.4 / 2016-10-07
+
+* Bug Fix - Fixed a bug that caused some models to include nil objects in their 
+  children collection if they did not have the relevant child object.
+
+
 ### Version 1.0.3 / 2016-09-12
 
 * Fixed a gem dependency that was accidentally declared with '<=' instead of '<'.

data/lib/cuke_modeler/models/feature_file.rb

@@ -35,7 +35,7 @@ module CukeModeler
 
     # Returns the model objects that belong to this model.
     def children
-      [@feature]
+      @feature ? [@feature] : []
     end
 
     # Returns a string representation of this model. For a feature file

data/lib/cuke_modeler/models/step.rb

@@ -39,7 +39,7 @@ module CukeModeler
 
     # Returns the model objects that belong to this model.
     def children
-      [block]
+      block ? [block] : []
     end
 
     # Returns a string representation of this model. For a step model,

data/lib/cuke_modeler/version.rb

@@ -1,4 +1,4 @@
 module CukeModeler
   # The gem version
-  VERSION = "1.0.3"
+  VERSION = "1.0.4"
 end

data/testing/gemfiles/gherkin2.gemfile

@@ -6,8 +6,6 @@ gem "gherkin", "< 3.0.0"
 # cuke_modeler can play with pretty much any version of these but they all play differently with Ruby
 if RUBY_VERSION =~ /^1\.8/
   gem 'cucumber', '<1.3.0'
-  gem 'mime-types', '<2.0.0'
-  gem 'rest-client', '<1.7.0'
   gem 'rake', '< 11.0' # Rake dropped 1.8.x support after this version
 elsif RUBY_VERSION =~ /^1\./
   gem 'cucumber', '>=1.0.0', '<2.0.0'
@@ -16,6 +14,7 @@ end
 if RUBY_VERSION =~ /^1\./
   gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
   gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
+  gem 'term-ansicolor', '< 1.4' # The 'term-ansicolor' gem requires Ruby 2.x on/after this version
 end
 
 if RUBY_VERSION =~ /^2\.[23456789]/

data/testing/gemfiles/gherkin3.gemfile

@@ -6,14 +6,13 @@ gem "gherkin", "~> 3.0"
 # cuke_modeler can play with pretty much any version of these but they all play differently with Ruby
 if RUBY_VERSION =~ /^1\.8/
   gem 'cucumber', '<1.3.0'
-  gem 'mime-types', '<2.0.0'
-  gem 'rest-client', '<1.7.0'
   gem 'rake', '< 11.0' # Rake dropped 1.8.x support after this version
 end
 
 if RUBY_VERSION =~ /^1\./
   gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
   gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
+  gem 'term-ansicolor', '< 1.4' # The 'term-ansicolor' gem requires Ruby 2.x on/after this version
 end
 
 if RUBY_VERSION =~ /^2\.[23456789]/

data/testing/gemfiles/gherkin4.gemfile

@@ -6,14 +6,13 @@ gem "gherkin", "~> 4.0"
 # cuke_modeler can play with pretty much any version of these but they all play differently with Ruby
 if RUBY_VERSION =~ /^1\.8/
   gem 'cucumber', '<1.3.0'
-  gem 'mime-types', '<2.0.0'
-  gem 'rest-client', '<1.7.0'
   gem 'rake', '< 11.0' # Rake dropped 1.8.x support after this version
 end
 
 if RUBY_VERSION =~ /^1\./
   gem 'tins', '< 1.7' # The 'tins' gem requires Ruby 2.x on/after this version
   gem 'json', '< 2.0' # The 'json' gem drops pre-Ruby 2.x support on/after this version
+  gem 'term-ansicolor', '< 1.4' # The 'term-ansicolor' gem requires Ruby 2.x on/after this version
 end
 
 if RUBY_VERSION =~ /^2\.[23456789]/

data/testing/rspec/spec/unit/shared/containing_models_unit_specs.rb

@@ -15,4 +15,11 @@ shared_examples_for 'a containing model' do
     expect(model.children).to be_an(Array)
   end
 
+  it 'does not return objects for children that it does not have' do
+    # Ensuring an empty, childless model
+    model = clazz.new
+
+    expect(model.children).to_not include(nil)
+  end
+
 end

data/todo.txt

@@ -7,9 +7,6 @@ Show less boilerplate code in the documentation
 
 document helper modules as not part of the public API
 
-See if the 'stringio' require is really needed.
-See if the 'version' require is really needed.
-parsing module needs json/multijson require line?
 # todo - remove hard coded newlines in feature files so that Relish and other text editors can wrap them on its own
 # todo - incorporate cuke_modeler extensions from other projects
 # todo - add plenty of testing around weird and minimal gherkin text for all models
@@ -19,12 +16,9 @@ Backlog
 -------------
 
 replace joined array source text with single string source text/heredocs
-Make sure that specs use clazz instead of fully specifying the class under test (done)
 Don't bother to test directory create/destroy around unit tests
 unit testing around parsing/modeling cases (whitespace, indentation, minimalistic feature elements, etc.)
 replace "\n" usages with the currently set record separator (i.e "\$" )
-Clean up step verifications (done)
-Figure out why using empty files for directory_modeling.feature doesn't work (done)
 Fix transient test failures (permission denied file access problems)
 make sure that all classes and tests are covered and attaches to code coverage
 use 'here doc' for source text construction in rspec tests

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_modeler
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-12 00:00:00.000000000 Z
+date: 2016-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin