cuke_linter 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5bc16cc61de218e7a1790a86b16d614e9b831e24fb31b46dafa7fe60fbc6768a
-  data.tar.gz: d4bc88c2c166feef1057e89d2430889cb3baa4522a7bf03e2cc2a05586069707
+  metadata.gz: 2262e2bfc35fa228578832a6dcaaf98c414ae641316de99c0e4123d58951bbf6
+  data.tar.gz: 02334cd45f28a225cef180e451f95eac230bcbc7912ae41637e6e999abe539f8
 SHA512:
-  metadata.gz: 2504c5d82a51883f883976bc427b9894a8af138a92bd4d714d8cac8c0dbfca9bff9467811002cfd748ad9f9f8d47ce3584d30443927cbce029ceb2549d8c12bb
-  data.tar.gz: 557843507486823449ff2cfed0e8e69f1b5500f3996a42df170e83286ef61d247bc586f3cf04b2393ad5b4b619080a9a95264620631dd82b8f0490cb411241dc
+  metadata.gz: 93e8b329df051721fd6ca9405740863ca4c8bcee606cbfe33854ad9d57e63bb4d5c3da99c0a4345d349e77f3adb39d676cec088ed469a557f44c90dcff1b6111
+  data.tar.gz: 31bdfa3dcb5dd22066b481aa45d9499b2f5c96a2f31f79581a8c1d2afa5d0d2d136ef247199e2ee5846914779f6955fad373ce9783bf7c4907ad6df4102c621e

data/CHANGELOG.md

@@ -6,7 +6,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-Nothing yet...
+Nothing yet... *(see development branch)*
+
+## [0.11.0] - 2019-11-01
+
+### Added
+ - New linters
+   - FeatureFileWithInvalidNameLinter
+   - TestWithBadNameLinter
 
 
 ## [0.10.0] - 2019-10-04
@@ -105,7 +112,8 @@ Nothing yet...
 - Custom linters, formatters, and command line usability
 
 
-[Unreleased]: https://github.com/enkessler/cuke_linter/compare/v0.10.0...HEAD
+[Unreleased]: https://github.com/enkessler/cuke_linter/compare/v0.11.0...HEAD
+[0.11.0]: https://github.com/enkessler/cuke_linter/compare/v0.10.0...v0.11.0
 [0.10.0]: https://github.com/enkessler/cuke_linter/compare/v0.9.0...v0.10.0
 [0.9.0]: https://github.com/enkessler/cuke_linter/compare/v0.8.0...v0.9.0
 [0.8.0]: https://github.com/enkessler/cuke_linter/compare/v0.7.0...v0.8.0

data/lib/cuke_linter/linters/feature_file_with_invalid_name_linter.rb

@@ -0,0 +1,21 @@
+module CukeLinter
+
+  # A linter that detects invalid feature file names
+
+  class FeatureFileWithInvalidNameLinter < Linter
+
+    # The rule used to determine if a model has a problem
+    def rule(model)
+      return false unless model.is_a?(CukeModeler::FeatureFile)
+
+      base = File.basename model.path
+      base =~ /[A-Z -]/
+    end
+
+    # The message used to describe the problem that has been found
+    def message
+      'Feature files should be snake_cased.'
+    end
+
+  end
+end

data/lib/cuke_linter/linters/linter.rb

@@ -25,7 +25,11 @@ module CukeLinter
       if problem_found
         problem_message = respond_to?(:message) ? message : @message
 
-        { problem: problem_message, location: "#{model.get_ancestor(:feature_file).path}:#{model.source_line}" }
+        if model.is_a?(CukeModeler::FeatureFile)
+          { problem: problem_message, location: "#{model.path}" }
+        else
+          { problem: problem_message, location: "#{model.get_ancestor(:feature_file).path}:#{model.source_line}" }
+        end
       else
         nil
       end

data/lib/cuke_linter/linters/test_with_bad_name_linter.rb

@@ -0,0 +1,24 @@
+module CukeLinter
+
+  # A linter that detects scenarios and outlines that have a bad name
+
+  class TestWithBadNameLinter < Linter
+
+    # The rule used to determine if a model has a problem
+    def rule(model)
+      return false unless model.is_a?(CukeModeler::Scenario) || model.is_a?(CukeModeler::Outline)
+
+      lowercase_name = model.name.downcase
+      return true if lowercase_name.include?('test') ||
+                     lowercase_name.include?('verif') ||
+                     lowercase_name.include?('check')
+      false
+    end
+
+    # The message used to describe the problem that has been found
+    def message
+      '"Test", "Verify" and "Check" should not be used in scenario names.'
+    end
+
+  end
+end

data/lib/cuke_linter/version.rb

@@ -1,4 +1,4 @@
 module CukeLinter
   # The release version of this gem
-  VERSION = '0.10.0'
+  VERSION = '0.11.0'
 end

data/lib/cuke_linter.rb

@@ -7,6 +7,7 @@ require 'cuke_linter/linters/linter'
 require 'cuke_linter/linters/background_does_more_than_setup_linter'
 require 'cuke_linter/linters/element_with_too_many_tags_linter'
 require 'cuke_linter/linters/example_without_name_linter'
+require 'cuke_linter/linters/feature_file_with_invalid_name_linter'
 require 'cuke_linter/linters/feature_with_too_many_different_tags_linter'
 require 'cuke_linter/linters/feature_without_name_linter'
 require 'cuke_linter/linters/feature_without_description_linter'
@@ -17,6 +18,7 @@ require 'cuke_linter/linters/step_with_end_period_linter'
 require 'cuke_linter/linters/step_with_too_many_characters_linter'
 require 'cuke_linter/linters/test_should_use_background_linter'
 require 'cuke_linter/linters/test_with_action_step_as_final_step_linter'
+require 'cuke_linter/linters/test_with_bad_name_linter'
 require 'cuke_linter/linters/test_with_no_action_step_linter'
 require 'cuke_linter/linters/test_with_no_name_linter'
 require 'cuke_linter/linters/test_with_no_verification_step_linter'
@@ -33,6 +35,7 @@ module CukeLinter
   @original_linters = { 'BackgroundDoesMoreThanSetupLinter'            => BackgroundDoesMoreThanSetupLinter.new,
                         'ElementWithTooManyTagsLinter'                 => ElementWithTooManyTagsLinter.new,
                         'ExampleWithoutNameLinter'                     => ExampleWithoutNameLinter.new,
+                        'FeatureFileWithInvalidNameLinter'             => FeatureFileWithInvalidNameLinter.new,
                         'FeatureWithTooManyDifferentTagsLinter'        => FeatureWithTooManyDifferentTagsLinter.new,
                         'FeatureWithoutDescriptionLinter'              => FeatureWithoutDescriptionLinter.new,
                         'FeatureWithoutNameLinter'                     => FeatureWithoutNameLinter.new,
@@ -43,6 +46,7 @@ module CukeLinter
                         'StepWithTooManyCharactersLinter'              => StepWithTooManyCharactersLinter.new,
                         'TestShouldUseBackgroundLinter'                => TestShouldUseBackgroundLinter.new,
                         'TestWithActionStepAsFinalStepLinter'          => TestWithActionStepAsFinalStepLinter.new,
+                        'TestWithBadNameLinter'                        => TestWithBadNameLinter.new,
                         'TestWithNoActionStepLinter'                   => TestWithNoActionStepLinter.new,
                         'TestWithNoNameLinter'                         => TestWithNoNameLinter.new,
                         'TestWithNoVerificationStepLinter'             => TestWithNoVerificationStepLinter.new,
@@ -110,7 +114,7 @@ module CukeLinter
   def self.lint(file_paths: [], model_trees: [], linters: self.registered_linters.values, formatters: [[CukeLinter::PrettyFormatter.new]])
 
     # TODO: Test this?
-    # Because directive memoization is based on a model's `#object_id` and Ruby reuses object IDs over the life
+    # Because directive memoization is based on a model's `#object_id` and Ruby reuses object IDs over the
     # life of a program as objects are garbage collected, it is not safe to remember the IDs forever. However,
     # models shouldn't get GC'd in the middle of the linting process and so the start of the linting process is
     # a good time to reset things

data/testing/cucumber/features/default_linters.feature

@@ -11,6 +11,7 @@ Feature: Default Linters
       | BackgroundDoesMoreThanSetupLinter            |
       | ElementWithTooManyTagsLinter                 |
       | ExampleWithoutNameLinter                     |
+      | FeatureFileWithInvalidNameLinter             |
       | FeatureWithTooManyDifferentTagsLinter        |
       | FeatureWithoutDescriptionLinter              |
       | FeatureWithoutNameLinter                     |
@@ -21,6 +22,7 @@ Feature: Default Linters
       | StepWithTooManyCharactersLinter              |
       | TestShouldUseBackgroundLinter                |
       | TestWithActionStepAsFinalStepLinter          |
+      | TestWithBadNameLinter                        |
       | TestWithNoActionStepLinter                   |
       | TestWithNoNameLinter                         |
       | TestWithNoVerificationStepLinter             |

data/testing/cucumber/features/linters/feature_file_with_invalid_name.feature

@@ -0,0 +1,20 @@
+Feature: Feature file with invalid name linter
+
+  As a writer of documentation
+  I want to be warned about invalid file names
+  so that I name all features consistently
+
+  Scenario Outline: Linting
+    Given a feature file model named "<name>.feature"
+    And a linter for features with invalid file names
+    When it is linted
+    Then an error is reported:
+      | linter                           | problem                              | location       |
+      | FeatureFileWithInvalidNameLinter | Feature files should be snake_cased. | <path_to_file> |
+
+    Examples: Invalid Names
+      | name    |
+      | Lint    |
+      | lintMe  |
+      | lint me |
+      | lint-me |

data/testing/cucumber/features/linters/test_with_bad_name.feature

@@ -0,0 +1,29 @@
+
+Feature: Tests with bad names are reported
+
+  As a writer of documentation
+  I want to be warned about assertion style scenario names
+  So that I will be able to understand the intent
+
+  Scenario Outline: Flag a test with a bad name
+
+    Note: Also works on outlines.
+
+    Given a linter for tests with bad names
+    And the following feature:
+      """
+      Feature: Bad scenario names
+
+        Scenario: <example_word> scenario name
+          This scenario uses a bad name
+      """
+    When it is linted
+    Then an error is reported:
+      | linter                | problem                                                            | location         |
+      | TestWithBadNameLinter | "Test", "Verify" and "Check" should not be used in scenario names. | <path_to_file>:3 |
+
+  Examples:
+    | example_word |
+    | test         |
+    | verify       |
+    | check        |

data/testing/cucumber/step_definitions/setup_steps.rb

@@ -25,6 +25,10 @@ Given(/^a linter for features without scenarios$/) do
   @linter = CukeLinter::FeatureWithoutScenariosLinter.new
 end
 
+Given(/^a linter for features with invalid file names$/) do
+  @linter = CukeLinter::FeatureFileWithInvalidNameLinter.new
+end
+
 Given(/^no other linters have been registered or unregistered$/) do
   CukeLinter.reset_linters
 end
@@ -37,6 +41,10 @@ Given(/^a linter for outlines with only one example row$/) do
   @linter = CukeLinter::OutlineWithSingleExampleRowLinter.new
 end
 
+Given("a linter for tests with bad names") do
+  @linter = CukeLinter::TestWithBadNameLinter.new
+end
+
 Given(/^a linter for tests with too many steps$/) do
   @linter = CukeLinter::TestWithTooManyStepsLinter.new
 end
@@ -189,3 +197,9 @@ And(/^a feature file model based on the following text:$/) do |text|
 
   @model = CukeModeler::FeatureFile.new(file_path)
 end
+
+Given(/^a feature file model named "([^"]*)"$/) do |file_path|
+  @model = CukeModeler::FeatureFile.new
+
+  @model.path = file_path
+end

data/testing/cucumber/step_definitions/verification_steps.rb

@@ -15,10 +15,18 @@ Then(/^the resulting output will include the following:$/) do |text|
 end
 
 Then(/^an error is reported:$/) do |table|
+  if @model.is_a?(CukeModeler::FeatureFile)
+    model_path        = @model.path
+    model_source_line = ''
+  else
+    model_path        = @model.get_ancestor(:feature_file).path
+    model_source_line = @model.source_line.to_s
+  end
+
   table.hashes.each do |error_record|
     expect(@results).to include({ linter:   error_record['linter'],
                                   problem:  error_record['problem'],
-                                  location: error_record['location'].sub('<path_to_file>', @model.get_ancestor(:feature_file).path).sub('<model_line_number>', @model.source_line.to_s) })
+                                  location: error_record['location'].sub('<path_to_file>', model_path).sub('<model_line_number>', model_source_line) })
   end
 end
 

data/testing/model_factory.rb

@@ -27,6 +27,12 @@ module CukeLinter
       model
     end
 
+    def self.generate_feature_file_model
+      model              = CukeModeler::FeatureFile.new
+
+      model
+    end
+
     def self.generate_example_model(source_text: 'Examples:', parent_file_path: 'path_to_file')
       fake_parent_model = generate_outline_model(parent_file_path: parent_file_path)
 

data/testing/rspec/spec/integration/cuke_linter_integration_spec.rb

@@ -174,46 +174,37 @@ RSpec.describe CukeLinter do
   end
 
   it 'has a default set of registered linters' do
-    expect(subject.registered_linters.keys).to include('BackgroundDoesMoreThanSetupLinter')
-    expect(subject.registered_linters['BackgroundDoesMoreThanSetupLinter']).to be_a(CukeLinter::BackgroundDoesMoreThanSetupLinter)
-    expect(subject.registered_linters.keys).to include('ElementWithTooManyTagsLinter')
-    expect(subject.registered_linters['ElementWithTooManyTagsLinter']).to be_a(CukeLinter::ElementWithTooManyTagsLinter)
-    expect(subject.registered_linters.keys).to include('ExampleWithoutNameLinter')
-    expect(subject.registered_linters['ExampleWithoutNameLinter']).to be_a(CukeLinter::ExampleWithoutNameLinter)
-    expect(subject.registered_linters.keys).to include('FeatureWithTooManyDifferentTagsLinter')
-    expect(subject.registered_linters['FeatureWithTooManyDifferentTagsLinter']).to be_a(CukeLinter::FeatureWithTooManyDifferentTagsLinter)
-    expect(subject.registered_linters.keys).to include('FeatureWithoutDescriptionLinter')
-    expect(subject.registered_linters['FeatureWithoutDescriptionLinter']).to be_a(CukeLinter::FeatureWithoutDescriptionLinter)
-    expect(subject.registered_linters.keys).to include('FeatureWithoutNameLinter')
-    expect(subject.registered_linters['FeatureWithoutNameLinter']).to be_a(CukeLinter::FeatureWithoutNameLinter)
-    expect(subject.registered_linters.keys).to include('FeatureWithoutScenariosLinter')
-    expect(subject.registered_linters['FeatureWithoutScenariosLinter']).to be_a(CukeLinter::FeatureWithoutScenariosLinter)
-    expect(subject.registered_linters.keys).to include('OutlineWithSingleExampleRowLinter')
-    expect(subject.registered_linters['OutlineWithSingleExampleRowLinter']).to be_a(CukeLinter::OutlineWithSingleExampleRowLinter)
-    expect(subject.registered_linters.keys).to include('SingleTestBackgroundLinter')
-    expect(subject.registered_linters['SingleTestBackgroundLinter']).to be_a(CukeLinter::SingleTestBackgroundLinter)
-    expect(subject.registered_linters.keys).to include('StepWithEndPeriodLinter')
-    expect(subject.registered_linters['StepWithEndPeriodLinter']).to be_a(CukeLinter::StepWithEndPeriodLinter)
-    expect(subject.registered_linters.keys).to include('StepWithTooManyCharactersLinter')
-    expect(subject.registered_linters['StepWithTooManyCharactersLinter']).to be_a(CukeLinter::StepWithTooManyCharactersLinter)
-    expect(subject.registered_linters.keys).to include('TestShouldUseBackgroundLinter')
-    expect(subject.registered_linters['TestShouldUseBackgroundLinter']).to be_a(CukeLinter::TestShouldUseBackgroundLinter)
-    expect(subject.registered_linters.keys).to include('TestWithActionStepAsFinalStepLinter')
-    expect(subject.registered_linters['TestWithActionStepAsFinalStepLinter']).to be_a(CukeLinter::TestWithActionStepAsFinalStepLinter)
-    expect(subject.registered_linters.keys).to include('TestWithNoActionStepLinter')
-    expect(subject.registered_linters['TestWithNoActionStepLinter']).to be_a(CukeLinter::TestWithNoActionStepLinter)
-    expect(subject.registered_linters.keys).to include('TestWithNoNameLinter')
-    expect(subject.registered_linters['TestWithNoNameLinter']).to be_a(CukeLinter::TestWithNoNameLinter)
-    expect(subject.registered_linters.keys).to include('TestWithNoVerificationStepLinter')
-    expect(subject.registered_linters['TestWithNoVerificationStepLinter']).to be_a(CukeLinter::TestWithNoVerificationStepLinter)
-    expect(subject.registered_linters.keys).to include('TestWithSetupStepAfterActionStepLinter')
-    expect(subject.registered_linters['TestWithSetupStepAfterActionStepLinter']).to be_a(CukeLinter::TestWithSetupStepAfterActionStepLinter)
-    expect(subject.registered_linters.keys).to include('TestWithSetupStepAfterVerificationStepLinter')
-    expect(subject.registered_linters['TestWithSetupStepAfterVerificationStepLinter']).to be_a(CukeLinter::TestWithSetupStepAfterVerificationStepLinter)
-    expect(subject.registered_linters.keys).to include('TestWithSetupStepAsFinalStepLinter')
-    expect(subject.registered_linters['TestWithSetupStepAsFinalStepLinter']).to be_a(CukeLinter::TestWithSetupStepAsFinalStepLinter)
-    expect(subject.registered_linters.keys).to include('TestWithTooManyStepsLinter')
-    expect(subject.registered_linters['TestWithTooManyStepsLinter']).to be_a(CukeLinter::TestWithTooManyStepsLinter)
+    subject.reset_linters
+
+    default_linter_classes = ['BackgroundDoesMoreThanSetupLinter',
+                              'ElementWithTooManyTagsLinter',
+                              'ExampleWithoutNameLinter',
+                              'FeatureFileWithInvalidNameLinter',
+                              'FeatureWithTooManyDifferentTagsLinter',
+                              'FeatureWithoutDescriptionLinter',
+                              'FeatureWithoutNameLinter',
+                              'FeatureWithoutScenariosLinter',
+                              'OutlineWithSingleExampleRowLinter',
+                              'SingleTestBackgroundLinter',
+                              'StepWithEndPeriodLinter',
+                              'StepWithTooManyCharactersLinter',
+                              'TestShouldUseBackgroundLinter',
+                              'TestWithActionStepAsFinalStepLinter',
+                              'TestWithBadNameLinter',
+                              'TestWithNoActionStepLinter',
+                              'TestWithNoNameLinter',
+                              'TestWithNoVerificationStepLinter',
+                              'TestWithSetupStepAfterActionStepLinter',
+                              'TestWithSetupStepAfterVerificationStepLinter',
+                              'TestWithSetupStepAsFinalStepLinter',
+                              'TestWithTooManyStepsLinter']
+
+    expect(subject.registered_linters.keys).to eq(default_linter_classes)
+
+    default_linter_classes.each do |clazz|
+      expect(subject.registered_linters[clazz]).to be_a(CukeLinter.const_get(clazz))
+
+    end
   end
 
   it 'returns to its default set of linters after being reset' do

data/testing/rspec/spec/integration/linters/feature_file_with_invalid_name_integration_spec.rb

@@ -0,0 +1,8 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::FeatureFileWithInvalidNameLinter do
+
+  it_should_behave_like 'a linter at the integration level'
+
+end

data/testing/rspec/spec/integration/linters/test_with_bad_name_integration_spec.rb

@@ -0,0 +1,8 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::TestWithBadNameLinter do
+
+  it_should_behave_like 'a linter at the integration level'
+
+end

data/testing/rspec/spec/unit/linters/feature_file_with_invalid_name_linter_unit_spec.rb

@@ -0,0 +1,106 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::FeatureFileWithInvalidNameLinter do
+
+  let(:model_file_path) { 'some_file_path' }
+
+  it_should_behave_like 'a linter at the unit level'
+
+
+  it 'has a name' do
+    expect(subject.name).to eq('FeatureFileWithInvalidNameLinter')
+  end
+
+  describe 'linting' do
+
+    it "only lints the file name" do
+      test_model      = CukeLinter::ModelFactory.generate_feature_file_model
+      test_model.path = 'bad-directory/good_file.feature'
+
+      expect(subject.lint(test_model)).to be_nil
+    end
+
+    context "with a feature file model that has an invalid file name" do
+
+      let(:test_model) do
+        model = CukeLinter::ModelFactory.generate_feature_file_model
+
+        model.path = model_file_path
+        model
+      end
+
+      context 'because its file name is capitalized' do
+        let(:model_file_path) { 'Terrible' }
+
+        it_should_behave_like 'a linter linting a bad model'
+
+        it 'records a problem' do
+          result = subject.lint(test_model)
+
+          expect(result[:problem]).to eq('Feature files should be snake_cased.')
+        end
+      end
+
+      context 'because its file name is camel-cased' do
+        let(:model_file_path) { 'veryBad' }
+
+        it_should_behave_like 'a linter linting a bad model'
+
+        it 'records a problem' do
+          result = subject.lint(test_model)
+
+          expect(result[:problem]).to eq('Feature files should be snake_cased.')
+        end
+      end
+
+      context 'because its file name contains whitespace' do
+        let(:model_file_path) { 'stop this' }
+
+        it_should_behave_like 'a linter linting a bad model'
+
+        it 'records a problem' do
+          result = subject.lint(test_model)
+
+          expect(result[:problem]).to eq('Feature files should be snake_cased.')
+        end
+      end
+
+      context 'because its file name is hyphenated' do
+        let(:model_file_path) { 'the-worst-path' }
+
+        it_should_behave_like 'a linter linting a bad model'
+
+        it 'records a problem' do
+          result = subject.lint(test_model)
+
+          expect(result[:problem]).to eq('Feature files should be snake_cased.')
+        end
+      end
+
+    end
+
+    context "with a feature file model that does have a valid file name" do
+
+      let(:test_model) do
+        model = CukeLinter::ModelFactory.generate_feature_file_model
+
+        model.path = 'very_good_path'
+        model
+      end
+
+      it_should_behave_like 'a linter linting a good model'
+
+    end
+
+    context 'a non-test model' do
+
+      let(:test_model) { CukeModeler::Model.new }
+
+      it_should_behave_like 'a linter linting a good model'
+
+    end
+
+  end
+
+end

data/testing/rspec/spec/unit/linters/linter_unit_specs.rb

@@ -40,13 +40,18 @@ shared_examples_for 'a linter linting a bad model' do
   end
 
   it 'correctly records the location of the problem' do
-    test_model.source_line = 1
-    result                 = subject.lint(test_model)
-    expect(result[:location]).to eq("#{model_file_path}:1")
-
-    test_model.source_line = 3
-    result                 = subject.lint(test_model)
-    expect(result[:location]).to eq("#{model_file_path}:3")
+    if test_model.is_a?(CukeModeler::FeatureFile)
+      result                 = subject.lint(test_model)
+      expect(result[:location]).to eq("#{model_file_path}")
+    else
+      test_model.source_line = 1
+      result                 = subject.lint(test_model)
+      expect(result[:location]).to eq("#{model_file_path}:1")
+
+      test_model.source_line = 3
+      result                 = subject.lint(test_model)
+      expect(result[:location]).to eq("#{model_file_path}:3")
+    end
   end
 
 end

data/testing/rspec/spec/unit/linters/test_with_bad_name_linter_unit_spec.rb

@@ -0,0 +1,81 @@
+require_relative '../../../../../environments/rspec_env'
+
+
+RSpec.describe CukeLinter::TestWithBadNameLinter do
+
+  let(:model_file_path) { 'some_file_path' }
+
+  it_should_behave_like 'a linter at the unit level'
+
+
+  it 'has a name' do
+    expect(subject.name).to eq('TestWithBadNameLinter')
+  end
+
+  describe 'linting' do
+
+    ['scenario', 'outline'].each do |model_type|
+
+      context "with a #{model_type} that has a bad name" do
+
+        context 'because its name contains a bad word' do
+
+          ['test', 'check', 'verify'].each do |bad_word|
+
+            let(:test_model) do
+              model      = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
+              model.name = "#{bad_word} bad names are reported"
+
+              model
+            end
+
+            it_should_behave_like 'a linter linting a bad model'
+
+            it 'records a problem' do
+              result = subject.lint(test_model)
+
+              expect(result[:problem]).to eq('"Test", "Verify" and "Check" should not be used in scenario names.')
+            end
+
+          end
+
+          context 'because bad words are case insensitive' do
+
+            ['Test', 'TEST'].each do |bad_word|
+
+              let(:test_model) do
+                model      = CukeLinter::ModelFactory.send("generate_#{model_type}_model", parent_file_path: model_file_path)
+                model.name = "#{bad_word} bad names are reported"
+
+                model
+              end
+
+              it_should_behave_like 'a linter linting a bad model'
+
+              it 'records a problem' do
+                result = subject.lint(test_model)
+
+                expect(result[:problem]).to eq('"Test", "Verify" and "Check" should not be used in scenario names.')
+              end
+
+            end
+
+          end
+
+        end
+
+        context 'a non-test model' do
+
+          let(:test_model) { CukeModeler::Model.new }
+
+          it_should_behave_like 'a linter linting a good model'
+
+        end
+
+      end
+
+    end
+
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuke_linter
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Eric Kessler
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-10-04 00:00:00.000000000 Z
+date: 2019-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cuke_modeler
@@ -180,6 +180,7 @@ files:
 - lib/cuke_linter/linters/background_does_more_than_setup_linter.rb
 - lib/cuke_linter/linters/element_with_too_many_tags_linter.rb
 - lib/cuke_linter/linters/example_without_name_linter.rb
+- lib/cuke_linter/linters/feature_file_with_invalid_name_linter.rb
 - lib/cuke_linter/linters/feature_with_too_many_different_tags_linter.rb
 - lib/cuke_linter/linters/feature_without_description_linter.rb
 - lib/cuke_linter/linters/feature_without_name_linter.rb
@@ -191,6 +192,7 @@ files:
 - lib/cuke_linter/linters/step_with_too_many_characters_linter.rb
 - lib/cuke_linter/linters/test_should_use_background_linter.rb
 - lib/cuke_linter/linters/test_with_action_step_as_final_step_linter.rb
+- lib/cuke_linter/linters/test_with_bad_name_linter.rb
 - lib/cuke_linter/linters/test_with_no_action_step_linter.rb
 - lib/cuke_linter/linters/test_with_no_name_linter.rb
 - lib/cuke_linter/linters/test_with_no_verification_step_linter.rb
@@ -209,6 +211,7 @@ files:
 - testing/cucumber/features/linters/background_does_more_than_setup.feature
 - testing/cucumber/features/linters/element_with_too_many_tags.feature
 - testing/cucumber/features/linters/example_without_name.feature
+- testing/cucumber/features/linters/feature_file_with_invalid_name.feature
 - testing/cucumber/features/linters/feature_with_too_many_different_tags.feature
 - testing/cucumber/features/linters/feature_without_description.feature
 - testing/cucumber/features/linters/feature_without_name.feature
@@ -219,6 +222,7 @@ files:
 - testing/cucumber/features/linters/step_with_end_period.feature
 - testing/cucumber/features/linters/test_should_use_background.feature
 - testing/cucumber/features/linters/test_with_action_as_final_step.feature
+- testing/cucumber/features/linters/test_with_bad_name.feature
 - testing/cucumber/features/linters/test_with_no_action_step.feature
 - testing/cucumber/features/linters/test_with_no_name.feature
 - testing/cucumber/features/linters/test_with_no_verification_step.feature
@@ -241,6 +245,7 @@ files:
 - testing/rspec/spec/integration/linters/background_does_more_than_setup_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/element_with_too_many_tags_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/example_without_name_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/feature_file_with_invalid_name_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_with_too_many_different_tags_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_without_description_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/feature_without_name_linter_integration_spec.rb
@@ -253,6 +258,7 @@ files:
 - testing/rspec/spec/integration/linters/step_with_too_many_characters_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_should_use_background_linter_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_action_step_as_final_step_linter_integration_spec.rb
+- testing/rspec/spec/integration/linters/test_with_bad_name_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_no_action_step_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_no_name_integration_spec.rb
 - testing/rspec/spec/integration/linters/test_with_no_verification_step_integration_spec.rb
@@ -267,6 +273,7 @@ files:
 - testing/rspec/spec/unit/linters/configurable_linter_unit_specs.rb
 - testing/rspec/spec/unit/linters/element_with_too_many_tags_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/example_without_name_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/feature_file_with_invalid_name_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_with_too_many_different_tags_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_without_description_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/feature_without_name_linter_unit_spec.rb
@@ -279,6 +286,7 @@ files:
 - testing/rspec/spec/unit/linters/step_with_too_many_characters_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_should_use_background_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_action_step_as_final_step_linter_unit_spec.rb
+- testing/rspec/spec/unit/linters/test_with_bad_name_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_no_action_step_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_no_name_linter_unit_spec.rb
 - testing/rspec/spec/unit/linters/test_with_no_verification_step_linter_unit_spec.rb