cuitar 1.0.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 20ff1454cc92d75b0a189f3c8bf3e96034589c714d3ba87f9d5f1407557ba0df
-  data.tar.gz: ed8274b5b49cb0092291c8c6aee810ca0e049803e1a5924520ad52b4ebe52996
+  metadata.gz: c558641038eaa45b9d00fe5f7e0c8fe46c06aaec4bc3d42a8edd53ea86d722fc
+  data.tar.gz: ef534ebed29d24549b58bc1347d0620c0d5b6c5e52004c2d3af83ce5f208301f
 SHA512:
-  metadata.gz: '0822a51e245202b439f164e546ebfea756f9cdd0dcb37be94d5b97b4d184a41c8daf929cbaaf11d115eef3bd85df26384892e65c35713ecff7eae6615a294bf8'
-  data.tar.gz: cece5b93f180399ce3c7458529c28b0f80e3fded1461670f1d201fc375ef9427bbd4c76b365f356cf5a35ab62c3a5ed0f2100743c3fce1c44575b66b86777901
+  metadata.gz: fd58ced15b82cb16b256addf25e279cf496b1b8c48e2cfc34a841c73e8fdb5b84178407bf19fe3f1cd03fcf4c6dc6b13c722a23a4a16a5ce4c61566dca388f8e
+  data.tar.gz: e1d054a05a214b7c7991dd393b53af0b251d184bd89899f9249130789c8d64c81c8fb7a6b38d8dcb59d60f6befd60e58435cfa15c69ab46613716876dd9c3817

data/.gitignore

@@ -6,3 +6,4 @@
 /pkg/
 /spec/reports/
 /tmp/
+.ruby-version

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    cuitar (1.0.0)
+    cuitar (1.2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    minitest (5.14.2)
-    rake (12.3.1)
+    minitest (5.18.0)
+    rake (12.3.3)
 
 PLATFORMS
   ruby
@@ -18,4 +18,4 @@ DEPENDENCIES
   rake (~> 12.0)
 
 BUNDLED WITH
-   2.1.4
+   2.4.10

data/README.md

@@ -28,8 +28,6 @@ cuit_number = '20228518310' # o '20-22851831-0' o 20228518310
 
 cuit = Cuit.new(cuit_number)
 
-cuit.valid? # => true
-
 cuit.to_s # => '20-22851831-0'
 ```
 
@@ -41,6 +39,22 @@ cuit.to_s # => '20-22851831-0'
 
 * Un `Integer` comprendido por los 11 números que componen una CUIT.
 
+Instanciar la clase `Cuit` con una CUIT inválida genera un `ArgumentError`
+
+```ruby
+cuit_number = 123
+
+cuit = Cuit.new(cuit_number) # => Invalid CUIT (ArgumentError)
+```
+
+Es posible validar una CUIT
+
+```ruby
+Cuit.valid?(123) # => false
+
+Cuit.valid?(20228518310) # =>  #<Cuit:0x000000010f589930 @check_digit=0, @cuit="20228518310", @dni="22851831", @type="20">
+```
+
 
 ## Contribuciones
 

data/cuitar.gemspec

@@ -7,20 +7,20 @@ Gem::Specification.new do |spec|
   spec.email         = ['sebas@wasabit.com.ar']
 
   spec.summary       = 'Valida y formatea CUIT argentinas.'
-  spec.description   = 'Valida y formatea CUIT argentinas.'
+  spec.description   = 'Validador y formateador de CUIT (Clave Única Tributaria) Argentina.'
   spec.homepage      = 'https://github.com/srabuini/cuitar'
   spec.license       = 'MIT'
   spec.required_ruby_version = Gem::Requirement.new('>= 2.3.0')
 
-  # spec.metadata['allowed_push_host'] = "TODO: Set to 'http://mygemserver.com'"
-
   spec.metadata['homepage_uri'] = spec.homepage
   spec.metadata['source_code_uri'] = 'https://github.com/srabuini/cuitar'
 
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
+
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/cuit.rb

@@ -1,16 +1,22 @@
 class Cuit
+  def self.valid?(cuit)
+    begin
+      new(cuit)
+    rescue
+      false
+    end
+  end
+
   def initialize(cuit)
-    @cuit = cuit.to_s.tr('^0-9', '')
+    @cuit = cuit.to_s.gsub(/\D/, '')
+
+    raise ArgumentError, 'Invalid CUIT' unless valid?
   end
 
   def to_s
     [type, dni, check_digit].join('-')
   end
 
-  def valid?
-    @cuit.size == 11 && calculated_digit == check_digit
-  end
-
   private
 
   def type
@@ -35,8 +41,20 @@ class Cuit
           .zip(cuit_sequence)
           .reduce(0) { |a, e| a + e.reduce(:*) }
 
-    diff = 11 - sum % 11
+    diff = 11 - (sum % 11)
 
     diff == 11 ? 0 : diff
   end
+
+  def right_length?
+    @cuit.length == 11
+  end
+
+  def checked?
+    calculated_digit == check_digit
+  end
+
+  def valid?
+    right_length? && checked?
+  end
 end

data/lib/cuitar/version.rb

@@ -1,3 +1,3 @@
 module Cuitar
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.2.0'.freeze
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: cuitar
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Sebastian Rabuini
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-28 00:00:00.000000000 Z
+date: 2023-03-31 00:00:00.000000000 Z
 dependencies: []
-description: Valida y formatea CUIT argentinas.
+description: Validador y formateador de CUIT (Clave Única Tributaria) Argentina.
 email:
 - sebas@wasabit.com.ar
 executables: []
@@ -36,7 +36,8 @@ licenses:
 metadata:
   homepage_uri: https://github.com/srabuini/cuitar
   source_code_uri: https://github.com/srabuini/cuitar
-post_install_message: 
+  rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -51,8 +52,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.4.6
+signing_key:
 specification_version: 4
 summary: Valida y formatea CUIT argentinas.
 test_files: []