cuenta_digital 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85a78d3f37c6b04c0bd37b008da468dc87076cc1adf8ffb24e83c5722ccd2533
-  data.tar.gz: 4aa62b7837bf4445e3fdf8d317060fd92948ee35d3341ecb5eafdc11f5e543fe
+  metadata.gz: 8b78d57edda1b829e9ea2ee6d352a0f91fd409c3c0516b460cf1dea191b7c2a7
+  data.tar.gz: 2dc9a771ced4160f5ae186304e520535880a41a0f750f39210acf392617caeed
 SHA512:
-  metadata.gz: c350334de734c6556b7eeaff36924f144599c94bb47aa5a8ea37c2809c0007b173e1b80268bbc20ae7cf2b85f56d102edc1ed53d9575b210544484be98758e4d
-  data.tar.gz: fb65094d6e8f5ea9276d571a9e1099dd3a0119cce22289ef0e640f9e3167da761d2edceee5f47a5106e931fe0c9addb39045d57539c847b405add72b4cbc426a
+  metadata.gz: 6162c9bd7d524991c27f0dbed6d984fa4ab16f227b0407061c8857b9b488e81fe50c88733fd3baf598bc6a249887db408ce0db9af5cf325d92fc72d170aa9558
+  data.tar.gz: ef26033d936568136c8445ed28057282d149cdcfcbb483b4320fab21dcfee55ce9bb35c70215e93e226a6879c5ecda3e4f48e8adf88fc4bf734f29cf6dc4562e

data/README.md

@@ -131,16 +131,6 @@ This method return `CuentaDigital::Response` object
 - **bar_code**
 - **csv_line**
 
-#### Methods
-
-- [class method] `process_webhook`:
-
-```ruby
-CuentaDigital::Payment.process_webhook(csv) # String csv separated by ','
-```
-
-return arrays of `CuentaDigital::Payment`
-
 - [class method] `request`. Only get transactions completed
 
 
@@ -164,6 +154,19 @@ return arrays of `CuentaDigital::Payment`
 CuentaDigital::Payment.request(control: 'e9161bfccfba345237fb1311b890203f', date: Time.new(2019, 07, 01), opts: { wget: false, sandbox: true })
 ```
 
+### Webhook
+
+#### Methods
+
+- [class method] `process`:
+
+```ruby
+CuentaDigital::Payment.process(csv) # String csv separated by ','
+```
+
+return arrays of `CuentaDigital::Payment`
+
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/cuenta_digital/coupon.rb

@@ -74,6 +74,8 @@ module CuentaDigital
     end
 
     def generate(xml: true, wget: false)
+      return false unless valid?
+
       retries = 0
       begin
         if wget
@@ -118,6 +120,8 @@ module CuentaDigital
       validate_attributes_presence
       validate_standar_values
       validate_format_values
+      validate_dates
+      valideate_lengths
     end
 
     def validate_attributes_presence
@@ -128,23 +132,67 @@ module CuentaDigital
 
       missing_attributes.uniq.each do |attr|
         @errors[attr.to_sym] = [] unless errors.key?(attr)
-        @errors[attr.to_sym] << CuentaDigital::Exception::MissingAttributes.new(attr).message
+        @errors[attr.to_sym] << [
+          :cant_be_blank,
+          CuentaDigital::Exception::MissingAttributes.new(attr).message
+        ]
+      end
+
+      if @first_due_date.blank? && !@second_due_date.blank?
+        @errors[:first_due_date] = [] unless errors.key?(:first_due_date)
+        @errors[:first_due_date] << [
+          :cant_be_blank,
+          CuentaDigital::Exception::MissingAttributes.new(:first_due_date).message
+        ]
+      end
+
+      if @amount.blank? && !@second_amount.blank?
+        @errors[:amount] = [] unless errors.key?(:amount)
+        @errors[:amount] << [
+          :cant_be_blank,
+          CuentaDigital::Exception::MissingAttributes.new(:amount).message
+        ]
       end
     end
 
     def validate_standar_values
-      return if CuentaDigital::CURRENCIES.keys.include?(@currency)
+      return if CuentaDigital::CURRENCIES.key?(@currency)
 
       @errors[:currency] = [] unless errors.key?(:currency)
-
-      @errors[:currency] << CuentaDigital::Exception::InvalidValueAttribute.new("currency, Possible values #{CuentaDigital::CURRENCIES.keys}").message
+      @errors[:currency] << [
+        :unsupported_value,
+        CuentaDigital::Exception::InvalidValueAttribute.new("currency, Possible values #{CuentaDigital::CURRENCIES.keys}").message
+      ]
     end
 
     def validate_format_values
       return if @email_to.nil? || !@email_to.match(CuentaDigital::VALID_EMAIL_REGEX).nil?
 
       @errors[:email_to] = [] unless errors.key?(:email_to)
-      @errors[:email_to] << CuentaDigital::Exception::InvalidFormat.new(attr).message
+      @errors[:email_to] << [
+        :invalid_format,
+        CuentaDigital::Exception::InvalidFormat.new(attr).message
+      ]
+    end
+
+    def validate_dates
+      return unless (@first_due_date && @second_due_date) && @second_due_date <= @first_due_date
+
+      @errors[:second_due_date] = [] unless errors.key?(:second_due_date)
+      @errors[:second_due_date] << [
+        :second_due_date_must_be_greater_than_first_due_date,
+        CuentaDigital::Exception::InvalidValueAttribute.new('second due date cant be greater than or equal to first due date').message
+      ]
+    end
+
+    def valideate_lengths
+      return if code.size <= 50
+
+      @errors[:code] = [] unless errors.key?(:code)
+      @errors[:code] << [
+        :code_must_be_greater_than_50_characters,
+        CuentaDigital::Exception::InvalidValueAttribute.new('code cant be greater than 50 chars').message
+      ]
     end
   end
 end

data/lib/cuenta_digital/payment.rb

@@ -17,6 +17,7 @@ module CuentaDigital
                   :checksum,
                   :operation_event_number,
                   :bar_code,
+                  :secret,
                   :csv_line
 
     def initialize(params = {})
@@ -32,6 +33,7 @@ module CuentaDigital
       @checksum = params[:checksum]
       @bar_code = params[:bar_code]
       @csv_line = params[:csv_line]
+      @secret = params[:secret]
     end
 
     def credit?
@@ -42,37 +44,8 @@ module CuentaDigital
       @operation_kind == 0
     end
 
-    # Linea de operaciones:
-    # CSV: Clase de operacion,Fecha de la operacion,Hora de la operacion,Monto,Codigo de Barras,Referencia,Medio de pago,Codigo unico de operacion,Checksum de operacion,Numero de operacion en evento
-    # Linea final:
-    # CSV: Valor fijo 3 indicando linea final,Fecha actual,Horario actual,Monto total de creditos en evento,Monto total de debitos en evento,Cantidad de operaciones,Checksum
-    def self.process_webhook(csv)
-      csv_splitted = csv.split("\n")
-      _final_line = csv_splitted.pop
-
-      csv_splitted.map do |result|
-        args = result.split(',')
-
-        params = {
-          csv_line: result,
-          operation_kind: args[0],
-          payment_date: Time.parse(
-            [
-              args[1].insert(2, '-').insert(5, '-'),
-              args[2].insert(2, ':').insert(5, ':')
-            ].join(' ')
-          ),
-          net_amount: args[3],
-          bar_code: args[4],
-          reference: args[5],
-          payment_method: args[6],
-          operation_id: args[7],
-          checksum: args[8],
-          operation_event_number: args[9]
-        }
-
-        CuentaDigital::Payment.new(params)
-      end
+    def secret_valid?
+      secret.nil? || Digest::SHA256.hexdigest(@secret) == @checksum
     end
 
     def self.uri(control:, sandbox: false, date: Time.now, from: nil, to: nil)
@@ -111,7 +84,7 @@ module CuentaDigital
     # Fecha del cobro|Horario de la operacion (HHmmss)|Monto Bruto|Monto neto recibido|Comision|Su referencia|Medio de pago usado|Codigo interno unico de operacion|Cobro numero 1 del archivo
     # Ejemplo de una linea del archivo:
     # 30122008|221500|1000.50|999.50|1.00|cliente9879|PagoFacil|23a0f1c7b636c08660abbe4f02360633-de70dbb3f907c613ddce6566667f92c6|1
-    def self.request(control:, date: Time.now, from: nil, to: nil, opts: { wget: false, sandbox: false })
+    def self.collector(control:, date: Time.now, from: nil, to: nil, opts: { wget: false, sandbox: false })
       retries = 0
 
       uri_request = uri(control: control, sandbox: opts[:sandbox], date: date, from: from, to: to)

data/lib/cuenta_digital/version.rb

@@ -1,3 +1,3 @@
 module CuentaDigital
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/lib/cuenta_digital/webhook.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+module CuentaDigital
+  # Linea de operaciones:
+  # CSV: Clase de operacion,Fecha de la operacion,Hora de la operacion,Monto,Codigo de Barras,Referencia,Medio de pago,Codigo unico de operacion,Checksum de operacion,Numero de operacion en evento
+  # Linea final:
+  # CSV: Valor fijo 3 indicando linea final,Fecha actual,Horario actual,Monto total de creditos en evento,Monto total de debitos en evento,Cantidad de operaciones,Checksum
+
+  # El Checksum de la operacion (firma) corresponde a una encriptacion SHA256 concatenando:
+  # - la clase de operacion,
+  # - la fecha de la operacion,
+  # - hora de la operacion,
+  # - Monto,
+  # - Codigo de Barras,
+  # - Referencia,
+  # - Codigo unico de operacion
+  # - clave de seguridad
+  # ash('sha256',ClaseDDMMYYYHHMMSSMontoBarraReferenciaUnicoClave),
+  # su finalidad es la validacion de la operacion.
+  class Webhook
+    def self.process(csv, secret = nil)
+      csv_splitted = csv.split("\n")
+      _final_line = csv_splitted.pop
+
+      csv_splitted.map do |result|
+        args = result.split(',')
+
+        params = {
+          csv_line: result,
+          secret: secret,
+          operation_kind: args[0],
+          payment_date: Time.parse(
+            [
+              args[1].insert(2, '-').insert(5, '-'),
+              args[2].insert(2, ':').insert(5, ':')
+            ].join(' ')
+          ),
+          net_amount: args[3],
+          bar_code: args[4],
+          reference: args[5],
+          payment_method: args[6],
+          operation_id: args[7],
+          checksum: args[8],
+          operation_event_number: args[9]
+        }
+
+        params[:secret] = if secret
+                            [args[0],
+                             args[1].delete('-'),
+                             args[2].delete(':'),
+                             args[3],
+                             args[4],
+                             args[5],
+                             args[7],
+                             secret].sum
+                          end
+
+        CuentaDigital::Payment.new(params)
+      end
+    end
+  end
+end

data/lib/cuenta_digital.rb

@@ -4,6 +4,7 @@ require 'cuenta_digital/version'
 require 'cuenta_digital/coupon'
 require 'cuenta_digital/response'
 require 'cuenta_digital/payment'
+require 'cuenta_digital/webhook'
 require 'cuenta_digital/exception'
 
 require 'digest'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuenta_digital
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - ga6ix
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-07-15 00:00:00.000000000 Z
+date: 2019-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -103,6 +103,7 @@ files:
 - lib/cuenta_digital/payment.rb
 - lib/cuenta_digital/response.rb
 - lib/cuenta_digital/version.rb
+- lib/cuenta_digital/webhook.rb
 homepage: https://github.com/gedera/cuenta_digital
 licenses:
 - MIT