cucumber_factory 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3153238ae9f4c30fd21e6dd493621e361d4bc6b508521effc93fbb4cb4be8af2
-  data.tar.gz: c152087fd0231027a94abf15f2abff5c3b3857c714212f3c1eefa67902b32b3e
+  metadata.gz: baa05dc176d4705c737b2ad4f7257f01f0da4d0e07aae0513acc8248c7577550
+  data.tar.gz: 68ff25b1099b7eabb458e60e9cb95e8edb8ec7051befdd2c493353b7c23ef0f1
 SHA512:
-  metadata.gz: 48b39f6ebaedb5bca521d07579384cbcffea01eb4638787de026ce683b1db2abc70fd91227f272cd88a75cb3a15cd8e780989b99a3429313aa6f9e0f6a8575c9
-  data.tar.gz: 5b16cb2d4e73c1fde061b12e31a23944a3d6889316002805cd0f0bb7d0355cf520d01cb587c5a0ab58648633f83189ee2bba9597b2bda7217315db5fc48ca218
+  metadata.gz: 4ca06816ddcc668384556e40eef5466bb231dc9c4c458bb277f7296fd715d32e73d70af414d2e8c2cc8a9e5bd6157d59ec99c9e93ca737c5a2b015bfb1c82970
+  data.tar.gz: 293eabcf22252aca840ca43800d24f9e75a5a4cbf20aa6efbcfa52051782e2f3c5c6286166fc44c56decaad247972d7d487cc0fe08f7661527512ce2c80da7d9

data/CHANGELOG.md

@@ -15,6 +15,13 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 
 -
 
+## 2.1.1 - 2020-05-20
+
+### Compatible changes
+
+- Cucumber 2.1.0 introduced some regressions which are being addressed with this patch:
+    - Fix the assignment of polymorphic associations.
+    - Restore the support for inherited traits within nested factories.
 
 ## 2.1.0 - 2020-03-09
 

data/Gemfile.cucumber-1.3.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cucumber_factory (2.1.0)
+    cucumber_factory (2.1.1)
       activerecord
       activesupport
       cucumber

data/Gemfile.cucumber-2.4.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cucumber_factory (2.1.0)
+    cucumber_factory (2.1.1)
       activerecord
       activesupport
       cucumber

data/Gemfile.cucumber-3.0.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cucumber_factory (2.1.0)
+    cucumber_factory (2.1.1)
       activerecord
       activesupport
       cucumber

data/Gemfile.cucumber-3.1.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cucumber_factory (2.1.0)
+    cucumber_factory (2.1.1)
       activerecord
       activesupport
       cucumber

data/lib/cucumber_factory/build_strategy.rb

@@ -11,6 +11,7 @@ module CucumberFactory
         factory = factory_bot_factory(model_prose, variants)
 
         if factory
+          factory.compile # Required to load inherited traits!
           strategy = factory_bot_strategy(factory, model_prose, variants)
           transient_attributes = factory_bot_transient_attributes(factory, variants)
         else

data/lib/cucumber_factory/factory.rb

@@ -146,14 +146,16 @@ module CucumberFactory
       end
 
       def attribute_value(world, model_class, transient_attributes, attribute, value)
-        association_class = resolve_association_class(attribute, model_class, transient_attributes)
+        associated, association_class = resolve_association(attribute, model_class, transient_attributes)
 
         if matches_fully?(value, VALUE_ARRAY)
           elements_str = unquote(value)
           value = elements_str.scan(VALUE_SCALAR).map { |v| attribute_value(world, model_class, transient_attributes, attribute, v) }
-        elsif association_class.present?
+        elsif associated
           if matches_fully?(value, VALUE_LAST_RECORD)
-            value = CucumberFactory::Switcher.find_last(association_class) or raise Error, "There is no last #{attribute}"
+            raise(Error, "Cannot set last #{model_class}##{attribute} for polymorphic associations") unless association_class.present?
+
+            value = CucumberFactory::Switcher.find_last(association_class) || raise(Error, "There is no last #{attribute}")
           elsif matches_fully?(value, VALUE_STRING)
             value = unquote(value)
             value = get_named_record(world, value) || transform_value(world, value)
@@ -169,17 +171,25 @@ module CucumberFactory
         value
       end
 
-      def resolve_association_class(attribute, model_class, transient_attributes)
+      def resolve_association(attribute, model_class, transient_attributes)
         return unless model_class.respond_to?(:reflect_on_association)
 
-        klass = if model_class.reflect_on_association(attribute)
-          model_class.reflect_on_association(attribute).klass
+        association = model_class.reflect_on_association(attribute)
+        association_class = nil
+
+        if association
+          association_class = association.klass unless association.polymorphic?
+          associated = true
         elsif transient_attributes.include?(attribute.to_sym)
           klass_name = attribute.to_s.camelize
-          klass_name.constantize if Object.const_defined?(klass_name)
+          if Object.const_defined?(klass_name)
+            association_class = klass_name.constantize
+            associated = true
+          end
         else
-          nil
+          associated = false
         end
+        [associated, association_class]
       end
 
       def resolve_scalar_value(world, model_class, attribute, value)

data/lib/cucumber_factory/version.rb

@@ -1,3 +1,3 @@
 module CucumberFactory
-  VERSION = '2.1.0'
+  VERSION = '2.1.1'
 end

data/spec/cucumber_factory/steps_spec.rb

@@ -356,6 +356,44 @@ title: Before Sunrise
       prequel = Movie.find_by_title!('Before Sunrise')
       movie.prequel.should == prequel
     end
+
+    it 'supports named associations with polymorphic associations' do
+      invoke_cucumber_step('"my opera" is an opera')
+      invoke_cucumber_step('there is a movie with the premiere site "my opera"')
+    end
+
+    it 'does not support last record references with polymorphic associations as the target class cannot be guessed' do
+      invoke_cucumber_step('there is an opera')
+      expect {
+        invoke_cucumber_step('there is a movie with the premiere site above')
+      }.to raise_error(CucumberFactory::Factory::Error, 'Cannot set last Movie#premiere_site for polymorphic associations')
+    end
+
+    it 'works with nested factories (BUGFIX)' do
+      invoke_cucumber_step('there is a subgenre movie')
+    end
+
+    describe 'references to named records are tracked correctly' do
+      # CucumberFactory keeps track of all created records by their attributes.
+      # For example, if you create a user with the name "Peter" you can reference him later on as "Peter".
+
+      it 'does not overwrite existing references when associating new records with another reference (BUGFIX)' do
+        invoke_cucumber_step('"reviewer" is a user with the id "1"')
+        movie1 = invoke_cucumber_step('there is a movie with the reviewer "reviewer" and the id "2"') # <- should not overwrite the 'reviewer' reference
+        movie2 = invoke_cucumber_step('there is a movie with the reviewer "reviewer" and the id "3"')
+
+        expect(movie1.reviewer_id).to eq(1)
+        expect(movie2.reviewer_id).to eq(1)
+      end
+
+      it 'does not set new references when setting primary keys of an association (BUGFIX)' do
+        movie1 = invoke_cucumber_step('there is a movie with the id "123" and the user id "456"')  # <- should not set a '456' reference
+        movie2 = invoke_cucumber_step('there is a movie with the user id "456"')
+
+        expect(movie1.reviewer_id).to eq(456)
+        expect(movie2.reviewer_id).to eq(456)
+      end
+    end
   end
 
   context 'without FactoryBot' do

data/spec/support/database.rb

@@ -7,6 +7,8 @@ Gemika::Database.new.rewrite_schema! do
     t.integer :reviewer_id
     t.string :uuid_reviewer_id
     t.integer :box_office_result
+    t.string :premiere_site_type
+    t.bigint :premiere_site_id
   end
 
   create_table :users do |t|

data/spec/support/factories/factories.rb

@@ -25,7 +25,21 @@ FactoryBot.define do
     end
   end
 
-  factory :movie, :class => Movie
+  factory :movie, :class => Movie do
+    transient do
+      user { nil }
+      user_id { nil }
+    end
+
+    after(:build) do |movie, evaluator|
+      movie.reviewer = evaluator.user if evaluator.user
+      movie.reviewer_id = evaluator.user_id if evaluator.user_id
+    end
+
+    trait :parent_movie_trait
+
+    factory :subgenre_movie, traits: [:parent_movie_trait]
+  end
   factory :opera, :class => Opera
   factory :payment, :class => Payment
   factory :uuid_user, :class => UuidUser

data/spec/support/models/movie.rb

@@ -3,6 +3,7 @@ class Movie < ActiveRecord::Base
   belongs_to :prequel, :class_name => "Movie"
   belongs_to :reviewer, :class_name => "User"
   belongs_to :uuid_reviewer, :class_name => "UuidUser"
+  belongs_to :premiere_site, polymorphic: true, required: false
 
   validate do |record|
     record.errors.add(:reviewer, 'may not be deleted') if record.reviewer and record.reviewer.deleted?

data/spec/support/models/opera.rb

@@ -1,3 +1,3 @@
 class Opera < ActiveRecord::Base
-
+  has_many :movies, as: :premiere_site, inverse_of: :premiere_site
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber_factory
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-31 00:00:00.000000000 Z
+date: 2020-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -134,7 +134,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Create records from Cucumber features without writing step definitions.