cucumber_factory 1.13.0 → 1.14.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: 0fe3dc644f2055470649f9f9c6e4c1daab8ee30b4ad2136cc12011c393404fb9
+  data.tar.gz: 7ee265cbb4c3c83752f39ba8f5af0aff938fbee6a83e8fc5b7f4d4d77a2407c6
+SHA512:
+  metadata.gz: d37b11bf0e7ac0d9c3103734c102ce88df8eec096d171ebc239ebc9306e0cb767eb75c11a272c10d7a643b7edaa5658475f34884d4ce2e287ccec2c96025dc3c
+  data.tar.gz: cfecaf32af5b283cc2f77bba6c69d96bc52bf69a37862e5e2e2562a73a30674842291aa0dbd60f240edf34121cdc251bc9829492ea0f57a809f33bec71afe7d2

data/Gemfile

@@ -0,0 +1 @@
+./gemfiles/Gemfile.cucumber-2.4

data/Gemfile.lock

@@ -0,0 +1 @@
+./gemfiles/Gemfile.cucumber-2.4.lock

data/README.md

@@ -10,20 +10,23 @@ cucumber_factory allows you to create ActiveRecord objects directly from your [C
 Basic usage
 -----------
 
-To create a new record with default attributes:
+To create a new record with default attributes, begin any step with `Given there is`:
 
 ```cucumber
 Given there is a movie
 ```
 
-To create the record, cucumber_factory will call [`Movie.make`](http://github.com/notahat/machinist), [`Factory.create(:movie)`](http://github.com/thoughtbot/factory_bot), [`Movie.create!`](http://apidock.com/rails/ActiveRecord/Persistence/ClassMethods/create%21) or `Movie.new`, depending on what's available.
+To create the record, cucumber_factory will call [`FactoryBot.create(:movie)`](http://github.com/thoughtbot/factory_bot), `FactoryGirl.create(:movie)`, [`Movie.make`](http://github.com/notahat/machinist), [`Movie.create!`](http://apidock.com/rails/ActiveRecord/Persistence/ClassMethods/create%21) or `Movie.new`, depending on what's available.
 
-To create a new record with attributes set, you can say:
+Quoted strings and numbers denote attribute values:
 
 ```cucumber
-Given there is a movie with the title "Sunshine" and the year "2007"
+Given there is a movie with the title "Sunshine" and the year 2007
 ```
 
+Setting boolean attributes
+--------------------------
+
 Boolean attributes can be set by appending `which`, `that` or `who` at the end:
 
 ```cucumber
@@ -39,6 +42,10 @@ Given there is a movie which is awesome, popular and successful but not science
 And there is a director with the income "500000" but with the account balance "-30000"
 ```
 
+
+Setting many attributes with a table
+------------------------------------
+
 If you have many attribute assignments you can use doc string or data table:
 
 ```cucumber
@@ -102,10 +109,30 @@ Given there is a movie with the prequel above and these attributes:
   | comedy | false    |
 ```
 
-Support for popular factory gems
---------------------------------
 
-[Machinist blueprints](http://github.com/notahat/machinist) and [factory_bot factories](http://github.com/thoughtbot/factory_bot) will be used when available.
+Setting array attributes or has_many associations
+-------------------------------------------------
+
+You can set `has_many` associations by referring to multiple named records in square brackets:
+
+```cucumber
+Given there is a movie with the title "Sunshine"
+And there is a movie with the title "Limitless"
+And there is a movie with the title "Salt"
+And there is a user with the favorite movies ["Sunshine", "Limitless" and "Salt"]
+```
+
+When using [PostgreSQL array columns](https://www.postgresql.org/docs/9.1/static/arrays.html), you can set an array attribute to a value with square brackets:
+
+```cucumber
+Given there is a movie with the tags ["comedy", "drama" and "action"]
+```
+
+
+
+
+Using named factories and traits
+--------------------------------
 
 You can use a [FactoryBot child factory](https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#inheritance) or [Machinist named blueprint](https://github.com/notahat/machinist/tree/1.0-maintenance#named-blueprints) by putting the variant name in parentheses:
 
@@ -120,8 +147,10 @@ Given there is a movie (moody, dark) with the title "Interstellar"
 ```
 
 
+
+
 Overriding factory steps
------------------------
+------------------------
 
 If you want to override a factory step with your own version, just do so:
 

data/lib/cucumber/factory.rb

@@ -2,6 +2,7 @@ require 'cucumber/factory/build_strategy'
 
 module Cucumber
   class Factory
+    class Error < StandardError; end
 
     ATTRIBUTES_PATTERN = '( with the .+?)?( (?:which|who|that) is .+?)?'
     TEXT_ATTRIBUTES_PATTERN = ' (?:with|and) these attributes:'
@@ -11,6 +12,14 @@ module Cucumber
 
     NAMED_RECORDS_VARIABLE = :'@named_cucumber_factory_records'
 
+    VALUE_INTEGER = /\d+/
+    VALUE_DECIMAL = /[\d\.]+/
+    VALUE_STRING = /"[^"]*"/
+    VALUE_ARRAY = /\[[^\]]*\]/
+    VALUE_LAST_RECORD = /\babove\b/
+
+    VALUE_SCALAR = /#{VALUE_STRING}|#{VALUE_DECIMAL}|#{VALUE_INTEGER}/
+
     CLEAR_NAMED_RECORDS_STEP_DESCRIPTOR = {
       :kind => :Before,
       :block => proc { Cucumber::Factory.send(:reset_named_records, self) }
@@ -96,11 +105,10 @@ module Cucumber
         model_class = build_strategy.model_class
         attributes = {}
         if raw_attributes.try(:strip).present?
-          raw_attributes.scan(/(?:the |and |with |but |,| )+(.*?) ("([^\"]*)"|above)/).each do |fragment|
+          raw_attributes.scan(/(?:the |and |with |but |,| )+(.*?) (#{VALUE_SCALAR}|#{VALUE_ARRAY}|#{VALUE_LAST_RECORD})/).each do |fragment|
             attribute = attribute_name_from_prose(fragment[0])
-            value_type = fragment[1] # 'above' or a quoted string
-            value = fragment[2] # the value string without quotes
-            attributes[attribute] = attribute_value(world, model_class, attribute, value_type, value)
+            value = fragment[1]
+            attributes[attribute] = attribute_value(world, model_class, attribute, value)
           end
         end
         if raw_boolean_attributes.try(:strip).present?
@@ -131,20 +139,53 @@ module Cucumber
         record
       end
 
-      def attribute_value(world, model_class, attribute, value_type, value)
+      def attribute_value(world, model_class, attribute, value)
         association = model_class.respond_to?(:reflect_on_association) ? model_class.reflect_on_association(attribute) : nil
-        if association.present?
-          if value_type == "above"
-            value = CucumberFactory::Switcher.find_last(association.klass) or raise "There is no last #{attribute}"
-          else
+
+        if matches_fully?(value, VALUE_ARRAY)
+          elements_str = unquote(value)
+          value = elements_str.scan(VALUE_SCALAR).map { |v| attribute_value(world, model_class, attribute, v) }
+        elsif association.present?
+          if matches_fully?(value, VALUE_LAST_RECORD)
+            value = CucumberFactory::Switcher.find_last(association.klass) or raise Error, "There is no last #{attribute}"
+          elsif matches_fully?(value, VALUE_STRING)
+            value = unquote(value)
             value = get_named_record(world, value) || transform_value(world, value)
+          else
+            raise Error, "Cannot set association #{model_class}##{attribute} to #{value}. To identify a previously created record, use `above` or a quoted string."
           end
         else
+          value = resolve_scalar_value(world, model_class, attribute, value)
+        end
+        value
+      end
+
+      def resolve_scalar_value(world, model_class, attribute, value)
+        if matches_fully?(value, VALUE_STRING)
+          value = unquote(value)
           value = transform_value(world, value)
+        elsif matches_fully?(value, VALUE_INTEGER)
+          value = value.to_i
+        elsif matches_fully?(value, VALUE_DECIMAL)
+          value = BigDecimal(value)
+        else
+          raise Error, "Cannot set attribute #{model_class}##{attribute} to #{value}."
         end
         value
       end
 
+      def unquote(string)
+        string[1, string.length - 2]
+      end
+
+      def full_regexp(partial_regexp)
+        Regexp.new("\\A" + partial_regexp.source + "\\z", partial_regexp.options)
+      end
+
+      def matches_fully?(string, partial_regexp)
+        string =~ full_regexp(partial_regexp)
+      end
+
       def transform_value(world, value)
         # Transforms were a feature available in Cucumber 1 and 2.
         # They have been kind-of replaced by ParameterTypes, which don't work with generic steps

data/lib/cucumber_factory/version.rb

@@ -1,3 +1,3 @@
 module CucumberFactory
-  VERSION = '1.13.0'
+  VERSION = '1.14.0'
 end

data/spec/cucumber_factory/steps_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 
-
 describe 'steps provided by cucumber_factory' do
 
   before(:each) do
@@ -198,7 +197,7 @@ describe 'steps provided by cucumber_factory' do
   it "should raise a proper error if there is no previous record when saying 'above'" do
     lambda do
       invoke_cucumber_step('there is a movie with the title "Before Sunset" and the reviewer above and the prequel above')
-    end.should raise_error(RuntimeError, "There is no last reviewer")
+    end.should raise_error(/There is no last reviewer/i)
   end
 
   it "should reload an object assigned to a belongs_to before assigning" do
@@ -274,6 +273,65 @@ describe 'steps provided by cucumber_factory' do
     user.deleted.should == true
   end
 
+  it "should allow to set integer attributes without surrounding quotes" do
+    invoke_cucumber_step('there is a plain Ruby class with the amount 123 and the total 456')
+    obj = PlainRubyClass.last
+    obj.attributes[:amount].should == 123
+    obj.attributes[:total].should == 456
+  end
+
+  it "should allow to set decimal attributes without surrounding quotes" do
+    invoke_cucumber_step('there is a plain Ruby class with the amount 1.23 and the total 45.6')
+    obj = PlainRubyClass.last
+    obj.attributes[:amount].should be_a(BigDecimal)
+    obj.attributes[:amount].to_s.should == "1.23"
+    obj.attributes[:total].should be_a(BigDecimal)
+    obj.attributes[:total].to_s.should == "45.6"
+  end
+
+  it "should allow set an array of strings with square brackets" do
+    invoke_cucumber_step('there is a plain Ruby class with the tags ["foo", "bar"] and the list ["bam", "baz"]')
+    obj = PlainRubyClass.last
+    obj.attributes[:tags].should == ['foo', 'bar']
+    obj.attributes[:list].should == ['bam', 'baz']
+  end
+
+  it "should allow set an array of numbers with square brackets" do
+    invoke_cucumber_step('there is a plain Ruby class with the integers [1, 2] and the decimals [3.4, 4.5]')
+    obj = PlainRubyClass.last
+    obj.attributes[:integers].should == [1, 2]
+    obj.attributes[:decimals].should == [BigDecimal('3.4'), BigDecimal('4.5')]
+  end
+
+  it 'should allow to set an empty array' do
+    invoke_cucumber_step('there is a plain Ruby class with the tags []')
+    obj = PlainRubyClass.last
+    obj.attributes[:tags].should == []
+  end
+
+  it 'should allow to separate array values with either a comma or "and"' do
+    invoke_cucumber_step('there is a plain Ruby class with the tags ["foo", "bar" and "baz"] and the list ["bam", "baz" and "qux"]')
+    obj = PlainRubyClass.last
+    obj.attributes[:tags].should == ['foo', 'bar', 'baz']
+    obj.attributes[:list].should == ['bam', 'baz', 'qux']
+  end
+
+  it 'should allow to separate array values with an Oxford comma' do
+    invoke_cucumber_step('there is a plain Ruby class with the tags ["foo", "bar", and "baz"] and the list ["bam", "baz", and "qux"]')
+    obj = PlainRubyClass.last
+    obj.attributes[:tags].should == ['foo', 'bar', 'baz']
+    obj.attributes[:list].should == ['bam', 'baz', 'qux']
+  end
+
+  it "should allow to set a has_many association by refering to multiple named records in square brackets" do
+    invoke_cucumber_step('there is a movie with the title "Sunshine"')
+    invoke_cucumber_step('there is a movie with the title "Limitless"')
+    invoke_cucumber_step('there is a user with the reviewed movies ["Sunshine" and "Limitless"]')
+    user = User.last
+    reviewed_movie_titles = user.reviewed_movies.map(&:title)
+    reviewed_movie_titles.should =~ ['Sunshine', 'Limitless']
+  end
+
   it "should allow attribute names starting with 'the'" do
     PlainRubyClass.should_receive(:new).with({:theme => 'Sci-fi'})
     invoke_cucumber_step('there is a plain ruby class with the theme "Sci-fi"')

data/spec/spec_helper.rb

@@ -9,4 +9,11 @@ Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each {|f| require f}
 Dir["#{File.dirname(__FILE__)}/shared_examples/**/*.rb"].sort.each {|f| require f}
 
 Gemika::RSpec.configure_clean_database_before_example
+
 Gemika::RSpec.configure_should_syntax
+
+Gemika::RSpec.configure do |config|
+  config.before(:each) do
+    PlainRubyClass.reset
+  end
+end

data/spec/support/models/plain_ruby_class.rb

@@ -1,4 +1,20 @@
-class PlainRubyClass
-  def initialize(options)
-  end
-end
+class PlainRubyClass
+  def initialize(attributes)
+    @attributes = attributes
+    self.class.last = self
+  end
+
+  attr_reader :attributes
+
+  def self.last
+    @last
+  end
+
+  def self.last=(instance)
+    @last = instance
+  end
+
+  def self.reset
+    @last = nil
+  end
+end

data/spec/support/models/user.rb

@@ -1,3 +1,5 @@
-class User < ActiveRecord::Base
-
-end
+class User < ActiveRecord::Base
+
+  has_many :reviewed_movies, :class_name => 'Movie', :foreign_key => 'reviewer_id'
+
+end

metadata

@@ -1,93 +1,82 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: cucumber_factory
-version: !ruby/object:Gem::Version 
-  hash: 35
-  prerelease: 
-  segments: 
-  - 1
-  - 13
-  - 0
-  version: 1.13.0
+version: !ruby/object:Gem::Version
+  version: 1.14.0
 platform: ruby
-authors: 
+authors:
 - Henning Koch
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2018-04-26 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2018-10-26 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: cucumber
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: activesupport
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: activerecord
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: cucumber_priority
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cucumber_priority
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 0
-        - 2
-        - 0
+      - !ruby/object:Gem::Version
         version: 0.2.0
   type: :runtime
-  version_requirements: *id004
-description: Cucumber Factory allows you to create ActiveRecord models from your Cucumber features without writing step definitions for each model.
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+description: Cucumber Factory allows you to create ActiveRecord models from your Cucumber
+  features without writing step definitions for each model.
 email: github@makandra.de
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- .gitignore
-- .rspec
-- .ruby-version
-- .travis.yml
+files:
+- ".gitignore"
+- ".rspec"
+- ".ruby-version"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE
@@ -109,10 +98,6 @@ files:
 - lib/cucumber_factory/version.rb
 - spec/cucumber_factory/factory/build_strategy_spec.rb
 - spec/cucumber_factory/steps_spec.rb
-- spec/rails-2.3/app_root/log/test.log
-- spec/rails-3.0/app_root/log/test.log
-- spec/rails-3.2/app_root/log/test.log
-- spec/rails-4.0/app_root/log/test.log
 - spec/spec_helper.rb
 - spec/support/cucumber_helper.rb
 - spec/support/database.rb
@@ -129,38 +114,27 @@ files:
 - spec/support/models/user.rb
 - spec/support/models/uuid_user.rb
 homepage: http://github.com/makandra/cucumber_factory
-licenses: 
+licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.30
+rubygems_version: 2.7.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Create records from Cucumber features without writing step definitions.
 test_files: []
-
-has_rdoc: