cucumber 0.7.1 → 0.7.2

data/.gitignore

@@ -12,10 +12,8 @@ doc
 *.swp
 target
 *.tmproj
-examples/self_test/tmp
 .#*
 .idea
 *.pyc
 rerun.txt
 ._*
-examples/self_test/tmp

data/History.txt

@@ -1,3 +1,8 @@
+== 0.7.2 (2010-05-03)
+
+=== Bugfixes
+* REALLY add backwards compatibility fix (with deprecation warning) for legacy 0.6.4 formatters. (Aslak Hellesøy)
+
 == 0.7.1 (2010-05-03)
 
 === Bugfixes
@@ -60,7 +65,7 @@ Treetop is gone and replaced with Ragel. The new Ragel parser lives in the gherk
 Parse times are up to 100 times faster.
 
 === New Features
-* Upgraded Sinatra example to use Snatra 1.0 and Capybara. (Aslak Hellesøy)
+* Upgraded Sinatra example to use Sinatra 1.0 and Capybara. (Aslak Hellesøy)
 
 === Changed Features
 * New i18n translations now have to be contributed to the gherkin project.

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
-:patch: 1
+:patch: 2
 :build:
 :major: 0
 :minor: 7

data/cucumber.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{cucumber}
-  s.version = "0.7.1"
+  s.version = "0.7.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Aslak Helles\303\270y"]
-  s.date = %q{2010-05-03}
+  s.date = %q{2010-05-04}
   s.default_executable = %q{cucumber}
   s.description = %q{Behaviour Driven Development with elegance and joy}
   s.email = %q{cukes@googlegroups.com}
@@ -541,7 +541,7 @@ Gem::Specification.new do |s|
 
                      (::)   U P G R A D I N G    (::)
 
-Thank you for installing cucumber-0.7.1.
+Thank you for installing cucumber-0.7.2.
 Please be sure to read http://wiki.github.com/aslakhellesoy/cucumber/upgrading
 for important information about this release. Happy cuking!
 

data/features/custom_formatter.feature

@@ -51,8 +51,12 @@ Feature: Custom Formatter
       And a file named "features/f.feature" with:
         """
         Feature: We like old cukes
-          Scenario: just print me
+          Scenario Outline: just print me
             Given this step works
+
+            Examples: print me too
+              |foo|
+              |bar|
         """
       And a file named "features/step_definitions/steps.rb" with:
         """
@@ -74,19 +78,28 @@ Feature: Custom Formatter
             def scenario_name(keyword, name, file_colon_line, source_indent)
               @io.puts "#{keyword} #{name}"
             end
+
+            def examples_name(keyword, name)
+              @io.puts "#{keyword} #{name}"
+            end
           end
         end
         """
       When I run cucumber features/f.feature --format Legacy::Formator
       Then STDERR should be
         """
-        Legacy::Formator is using a deprecated formatter API. The signature has changed to :feature_name(keyword, name) # no trailing : in keyword
-        Legacy::Formator is using a deprecated formatter API. The :scenario_name method does not receive trailing : in keyword
+        Legacy::Formator is using a deprecated formatter API. Starting with Cucumber 0.7.0 the signatures
+        that have changed are:
+          feature_name(keyword, name)  # Two arguments. The keyword argument will not contain a colon.
+          scenario_name(keyword, name, file_colon_line, source_indent)  # The keyword argument will not contain a colon.
+          examples_name(keyword, name)  # The keyword argument will not contain a colon.
+
 
         """
       Then it should pass with
         """
         Feature: We like old cukes
-        Scenario: just print me
+        Scenario Outline: just print me
+        Examples: print me too
 
         """

data/lib/cucumber/ast/tree_walker.rb

@@ -171,27 +171,48 @@ module Cucumber
       def send_to_all(message, *args)
         @listeners.each do |listener|
           if listener.respond_to?(message)
-            if listener.respond_to?(:feature_name) && 
-              (listener.method(:feature_name) rescue false) && 
-              listener.method(:feature_name).arity == 1
-              # Legacy
-              case message.to_sym
-              when :feature_name
-                warn("#{listener.class} is using a deprecated formatter API. The signature has changed to :feature_name(keyword, name) # no trailing : in keyword")
-                listener.feature_name("#{args[0]}: #{args[1]}")
-              when :scenario_name, :examples_name
-                warn("#{listener.class} is using a deprecated formatter API. The :scenario_name method does not receive trailing : in keyword")
-                listener.__send__(message, "#{args[0]}:", args[1], args[2], args[3])
-              else
-                listener.__send__(message, *args)
-              end
+            if legacy_listener?(listener)
+              warn_legacy(listener)
+              legacy_invoke(listener, message, *args)
             else
               listener.__send__(message, *args)
             end
           end
         end
       end
-      
+
+      def legacy_listener?(listener)
+        listener.respond_to?(:feature_name) && 
+        (listener.method(:feature_name) rescue false) && 
+        listener.method(:feature_name).arity == 1
+      end
+
+      def warn_legacy(listener)
+        @warned_listeners ||= []
+        unless @warned_listeners.index(listener)
+          warn("#{listener.class} is using a deprecated formatter API. Starting with Cucumber 0.7.0 the signatures\n" + 
+          "that have changed are:\n" +
+          "  feature_name(keyword, name)  # Two arguments. The keyword argument will not contain a colon.\n" +
+          "  scenario_name(keyword, name, file_colon_line, source_indent)  # The keyword argument will not contain a colon.\n" +
+          "  examples_name(keyword, name)  # The keyword argument will not contain a colon.\n"
+          )
+        end
+        @warned_listeners << listener
+      end
+
+      def legacy_invoke(listener, message, *args)
+        case message.to_sym
+        when :feature_name
+          listener.feature_name("#{args[0]}: #{args[1]}")
+        when :scenario_name, :examples_name
+          args_with_colon = args.dup
+          args_with_colon[0] += ':'
+          listener.__send__(message, *args_with_colon)
+        else
+          listener.__send__(message, *args)
+        end
+      end
+
       def extract_method_name_from(call_stack)
         call_stack[0].match(/in `(.*)'/).captures[0]
       end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 7
-  - 1
-  version: 0.7.1
+  - 2
+  version: 0.7.2
 platform: ruby
 authors: 
 - "Aslak Helles\xC3\xB8y"
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-05-03 00:00:00 +02:00
+date: 2010-05-04 00:00:00 +02:00
 default_executable: cucumber
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -720,7 +720,7 @@ post_install_message: |+
   
                        (::)   U P G R A D I N G    (::)
   
-  Thank you for installing cucumber-0.7.1.
+  Thank you for installing cucumber-0.7.2.
   Please be sure to read http://wiki.github.com/aslakhellesoy/cucumber/upgrading
   for important information about this release. Happy cuking!