cucumber-tcl 0.0.3 → 0.0.4

data/CONTRIBUTING.md

@@ -0,0 +1,29 @@
+## Running tests
+
+    gem install bundler
+    bundle install
+    bundle exec rake
+
+This runs tests on both the Ruby and Tcl code.
+
+## Release Process
+
+* Bump the version number in `lib/cucumber/tcl/version`.
+
+Now release it
+
+    bundle update && bundle exec rake # check all tests are passing
+    git commit -m "Release `cat lib/cucumber/tcl/version`"
+    rake release
+
+## Gaining Release Karma
+
+To become a release manager, create a pull request adding your name to the list below, and include your [Rubygems email address](https://rubygems.org/sign_up) in the ticket. One of the existing Release managers will then add you.
+
+Current release managers:
+  * [Matt Wynne](https://rubygems.org/profiles/mattwynne)
+  * [Jonathan Owers](https://rubygems.org/profiles/jowers)
+
+To grant release karma, issue the following command:
+
+    gem owner cucumber-tcl --add <NEW OWNER RUBYGEMS EMAIL>

data/README.md

@@ -12,7 +12,6 @@ You'll need the following:
 
 * tcl8.5 and dev libraries
 * ruby > 1.9.1 along with its dev libraries
-* [Cucumber-Ruby](https://github.com/cucumber/cucumber)
 
 How to use
 ----------
@@ -53,3 +52,39 @@ If your regular expression captures any matches, you should provide a list of va
       puts "$quantity cucumbers bought. Price was $price"
     }
 
+You can use basic tables in your scenarios. The data from the table s made available to your step definition, via the last variable name you pass into the capture list. For example, if you had the following step in your feature:
+
+    Given I have added the following products to my shopping cart:
+      | apple  | £2.00 |
+      | orange | £3.00 |
+      | banana | £1.50 |
+
+I could write the step definition for the Given step as:
+
+    Given {^I have added the following products to my shopping cart:$} {table_data} {
+      puts "$table_data"
+    }
+
+The data in the table is provided as a list of lists, so in the above example, table data would look like:
+
+    {"apple" "£2.00"} {"orange" "£3.00"} {"banana" "£1.50"}
+
+meaning you can access each element using `lindex`, e.g.
+
+    puts [lindex [lindex $table_data 0] 0]
+    apple
+
+If your step definition captures a match in the step definition as well as has a table, the table variable will always be last, e.g.
+
+    When I buy the following items from Tesco:
+      | cabbage |
+      | potato  |
+      | onion   |
+
+and in your step definition, you might have
+
+    Given {^I buy the following items from (\w+):$} {store items} {
+      puts "I've been shopping at $store"
+      puts "The first item I bought was [lindex $items 0]"
+    }
+

data/features/data_tables.feature

@@ -0,0 +1,27 @@
+Feature: DataTables
+
+  @wip
+  Scenario: Match a step with a DataTable
+    Given a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+        Given passing with a DataTable:
+          | a | b |
+          | c | d |
+      """
+    And a file named "features/support/env.rb" with:
+      """
+      require 'cucumber/tcl'
+      """
+    And a file named "features/step_defintions/steps.tcl" with:
+      """
+      Given {^passing with a DataTable:$} {content} {
+        puts $content
+      }
+      """
+    When I run `cucumber`
+    Then it should pass with:
+      """
+      {{a} {b}} {{c} {d}}
+      """

data/features/reset_state.feature

@@ -0,0 +1,37 @@
+Feature: Reset state
+
+  In order to keep state from leaking between scenarios, by default,
+  we create a new Tcl interpreter for each test case.
+
+  Scenario: Set a global variable in one scenario and access it in another
+    Given a file named "features/test.feature" with:
+      """
+      Feature:
+        Scenario:
+          Given I set a global variable
+          When I print the global variable
+
+        Scenario:
+          When I print the global variable
+      """
+    And a file named "features/step_definitions/steps.tcl" with:
+      """
+      global g
+       
+      Given {^I set a global variable$} {
+        set ::g value
+      }
+
+      When {^I print the global variable$} {
+        puts $::g
+      }
+      """
+    And a file named "features/support/env.rb" with:
+      """
+      require 'cucumber/tcl'
+      """
+    When I run `cucumber`
+    Then it should fail with:
+      """
+      can't read "::g": no such variable
+      """

data/lib/cucumber/tcl.rb

@@ -3,7 +3,9 @@ require 'cucumber/tcl/step_definitions'
 
 if respond_to?(:AfterConfiguration)
   AfterConfiguration do |config|
-    step_definitions = Cucumber::Tcl::StepDefinitions.new(File.dirname(__FILE__) + '/tcl/framework.tcl')
-    config.filters << Cucumber::Tcl::ActivateSteps.new(step_definitions)
+    create_step_definitions = lambda {
+      Cucumber::Tcl::StepDefinitions.new(File.dirname(__FILE__) + '/tcl/framework.tcl')
+    }
+    config.filters << Cucumber::Tcl::ActivateSteps.new(create_step_definitions)
   end
 end

data/lib/cucumber/tcl/activate_steps.rb

@@ -3,19 +3,23 @@ require 'cucumber/core/filter'
 module Cucumber
   module Tcl
 
-    ActivateSteps = Cucumber::Core::Filter.new(:step_definitions) do
+    ActivateSteps = Cucumber::Core::Filter.new(:create_step_definitions) do
       def test_case(test_case)
         activated_steps = test_case.test_steps.map do |test_step|
-          attempt_to_activate(test_step)
+          step_definitions.attempt_to_activate(test_step)
         end
         test_case.with_steps(activated_steps).describe_to receiver
+        reset_step_definitons
       end
 
       private
 
-      def attempt_to_activate(test_step)
-        return test_step unless step_definitions.match?(test_step)
-        test_step.with_action &step_definitions.action_for(test_step)
+      def reset_step_definitons
+        @step_definitions = nil
+      end
+
+      def step_definitions
+        @step_definitions ||= create_step_definitions.call
       end
     end
 

data/lib/cucumber/tcl/data_table.rb

@@ -0,0 +1,24 @@
+module Cucumber
+  module Tcl
+
+    # Wraps the Cucumber DataTable so that when passed through to tcl, its
+    # string representation is easy to parse into a tcl list.
+    class DataTable
+      def initialize(original)
+        @raw = original.raw
+      end
+
+      def to_s
+        to_tcl_list(@raw.map { |row| to_tcl_list(row) })
+      end
+
+      private
+
+      def to_tcl_list(array)
+        array.map { |element| "{" + element + "}" }.join(" ")
+      end
+    end
+
+  end
+end
+

data/lib/cucumber/tcl/framework.tcl

@@ -57,7 +57,6 @@ proc step_definition_exists { step_name } {
 
 
 proc execute_step_definition { step_name {multiline_args {}} } {
-  # TODO: handle parameters in the regexp
   set res [_search_steps $step_name 1 $multiline_args]
   return $res
 

data/lib/cucumber/tcl/step_definitions.rb

@@ -1,4 +1,5 @@
 require 'tcl'
+require 'cucumber/tcl/data_table'
 
 module Cucumber
   module Tcl
@@ -9,6 +10,13 @@ module Cucumber
         @tcl = ::Tcl::Interp.load_from_file(path)
       end
 
+      def attempt_to_activate(test_step)
+        return test_step unless match?(test_step)
+        test_step.with_action &action_for(test_step)
+      end
+
+      private
+
       def match?(test_step)
         step_name = test_step.name
         @tcl.proc('step_definition_exists').call(step_name) == "1"
@@ -30,6 +38,10 @@ module Cucumber
           @arguments << arg.content
         end
 
+        def data_table(arg)
+          @arguments << DataTable.new(arg)
+        end
+
         def to_a
           @arguments
         end

data/lib/cucumber/tcl/version

@@ -1 +1 @@
-0.0.3
+0.0.4

data/spec/cucumber/tcl/data_table_spec.rb

@@ -0,0 +1,13 @@
+require 'cucumber/tcl/data_table'
+require 'cucumber/core/ast/data_table'
+
+module Cucumber::Tcl
+  describe DataTable do
+    it "#to_s converts to Tcl list of lists" do
+      raw = [["a", "b"], ["c", "d"]]
+      original = Cucumber::Core::Ast::DataTable.new(raw, Cucumber::Core::Ast::Location.new(__FILE__, 8))
+      table = DataTable.new(original)
+      expect(table.to_s).to eq '{{a} {b}} {{c} {d}}'
+    end
+  end
+end

data/spec/cucumber/tcl/fixtures/{everything_is_defined.tcl → everything_ok.tcl}

@@ -1,3 +1,6 @@
+proc execute_step_definition { step_name } {
+}
+
 proc step_definition_exists { step_name } {
   return 1
 }

data/spec/cucumber/tcl/step_definitions_spec.rb

@@ -1,18 +1,16 @@
 require 'cucumber/tcl'
 require 'cucumber/core/ast'
+require 'cucumber/core/test/step'
 
 module Cucumber::Tcl
   describe StepDefinitions do
-    it "can query for a step definition" do
-      step_definitions = StepDefinitions.new(File.dirname(__FILE__) + '/fixtures/everything_is_defined.tcl')
-      expect(step_definitions.match?(double(name: 'passing'))).to be_truthy
-    end
 
     it "can activate a passing tcl step" do
-      step_definitions = StepDefinitions.new(File.dirname(__FILE__) + '/fixtures/everything_passes.tcl')
-      ast_step = double(multiline_arg: Cucumber::Core::Ast::EmptyMultilineArgument.new)
-      test_step = double(name: "a step", source: [ ast_step ])
-      expect { step_definitions.action_for(test_step).call }.not_to raise_error
+      step_definitions = StepDefinitions.new(File.dirname(__FILE__) + '/fixtures/everything_ok.tcl')
+      location = double
+      ast_step = double(name: double, location: location, multiline_arg: Cucumber::Core::Ast::EmptyMultilineArgument.new)
+      test_step = Cucumber::Core::Test::Step.new([ ast_step ])
+      expect(step_definitions.attempt_to_activate(test_step).location).to eq location
     end
   end
 end

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-tcl
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
+  prerelease: 
 platform: ruby
 authors:
 - Matt Wynne
@@ -10,11 +11,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-18 00:00:00.000000000 Z
+date: 2015-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-tcl
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,6 +24,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -29,6 +32,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -36,6 +40,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -43,6 +48,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -50,6 +56,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -57,6 +64,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -64,6 +72,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -71,6 +80,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -78,6 +88,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -85,6 +96,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -92,6 +104,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -103,53 +116,52 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .rspec
+- CONTRIBUTING.md
 - Gemfile
 - README.md
 - Rakefile
 - circle.yml
 - cucumber-tcl.gemspec
+- features/data_tables.feature
 - features/define_a_step.feature
 - features/doc_strings.feature
+- features/reset_state.feature
 - features/support/aruba.rb
 - lib/cucumber/tcl.rb
 - lib/cucumber/tcl/activate_steps.rb
+- lib/cucumber/tcl/data_table.rb
 - lib/cucumber/tcl/framework.tcl
 - lib/cucumber/tcl/step_definitions.rb
 - lib/cucumber/tcl/test/test_framework.tcl
 - lib/cucumber/tcl/version
-- spec/cucumber/tcl/fixtures/everything_is_defined.tcl
-- spec/cucumber/tcl/fixtures/everything_passes.tcl
+- spec/cucumber/tcl/data_table_spec.rb
+- spec/cucumber/tcl/fixtures/everything_ok.tcl
 - spec/cucumber/tcl/step_definitions_spec.rb
 homepage: https://github.com/cucumber/cucumber-ruby-tcl
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options:
 - --charset=UTF-8
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
-summary: cucumber-tcl-0.0.3
-test_files:
-- features/define_a_step.feature
-- features/doc_strings.feature
-- features/support/aruba.rb
-- spec/cucumber/tcl/fixtures/everything_is_defined.tcl
-- spec/cucumber/tcl/fixtures/everything_passes.tcl
-- spec/cucumber/tcl/step_definitions_spec.rb
+specification_version: 3
+summary: cucumber-tcl-0.0.4
+test_files: []
 has_rdoc: 

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: defc8ca2dc36af1dbba2a7401d5d29166fe4e717
-  data.tar.gz: 565ada350e542eac6379c4fe5b018694b8160f86
-SHA512:
-  metadata.gz: d614a61d2673340c6aeaa4802f869d98c9d999900a4c0ca295d91a79de7a30aaff1d08ac74d8280c3d135e32ae4f5901b2d8535c5e256fd0d671bc5d3770c5f6
-  data.tar.gz: 8853b3a1ad2474a20f4fdd4dea049b3f047990721f64afcb17fd1ebf2786287526154af9cb33c8bf997132d3d8fd44dfc1c89a5dd37652d5fe3cd1e31da9336d

data/spec/cucumber/tcl/fixtures/everything_passes.tcl

@@ -1,3 +0,0 @@
-proc execute_step_definition { step_name } {
-  return 0
-}