cucumber-sammies 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2b3130bf6e99e26faf47e30d1679e5076beed569
-  data.tar.gz: f32229fce4bf1645aaae3baf1eebab1025595870
+SHA256:
+  metadata.gz: 8cd14e88d8019ccd11028cc966b0329a6ab2297e5ad6b193e3d6c7a3085cc590
+  data.tar.gz: b4ef8c552e48a80dcb1815530ed8d01642b5f6e71ec02f2a2e073ad223051459
 SHA512:
-  metadata.gz: ca9c7b76ab132244d4c7cdd82b6ccc9566d1edcca3fbe236e2cf9300e6d7ec7c66626709121dcd1d444a0937054bbf79ab4a89ca072a9559a41dd5e8576d8fc5
-  data.tar.gz: cd184acca4477f66cf8e75ff4f7ff9d1e7c0a9dc388168b58624b0d5eec4a8af3b0a49edb44121fd2756029f428a2238d5412b59f4aa228ba07d4547d778f8f5
+  metadata.gz: 40b75afbe9aaf52ba3021e0db221abd727b8c234daa35ac7ae9b03ff87841642a31d41c73f055c82c29e9d0d724f8d486fc0aee3792df2cd372ededd48c6d048
+  data.tar.gz: ba1465cc585487785b7c8bf9987eb797bc9cf6bc39da3940012a24d1887c3eb62b35432b1bad9633c5b434f6bc3b268dfb6cbf9fdd4782191a888a51c78cacbc

data/.rubocop.yml

@@ -0,0 +1,431 @@
+# Continue here: https://raw.githubusercontent.com/rubocop-hq/rubocop/master/config/default.yml
+# TODO: Skipped rails or naming or style
+
+AllCops:
+  Exclude:
+    - 'node_modules/**/*'
+    - 'vendor/**/*'
+    - '.git/**/*'
+    - 'db/**/*'
+    - 'lib/tasks/cucumber.rake'
+    - 'config/routes.rb'
+    - 'features/**/*'
+  EnabledByDefault: false
+  DisabledByDefault: true
+
+require: rubocop-performance
+
+Bundler/DuplicatedGem:
+  Enabled: true
+
+Bundler/InsecureProtocolSource:
+  Enabled: true
+
+Bundler/OrderedGems:
+  Enabled: true
+
+Gemspec/DuplicatedAssignment:
+  Enabled: true
+
+Gemspec/OrderedDependencies:
+  Enabled: true
+
+Gemspec/RequiredRubyVersion:
+  Enabled: true
+
+Layout/BlockEndNewline:
+  Enabled: true
+
+Layout/ClassStructure:
+  Enabled: true
+
+Layout/ClosingParenthesisIndentation:
+  Enabled: true
+
+Layout/ConditionPosition:
+  Enabled: true
+
+Layout/DefEndAlignment:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+Layout/EmptyLineBetweenDefs:
+  Enabled: true
+
+Layout/EmptyLines:
+  Enabled: true
+
+Layout/EmptyLinesAroundAccessModifier:
+  Enabled: true
+
+Layout/EndAlignment:
+  Enabled: true
+
+Layout/EndOfLine:
+  Enabled: true
+
+Layout/EmptyLinesAroundArguments:
+  Enabled: true
+
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/InitialIndentation:
+  Enabled: true
+
+Layout/LeadingBlankLines:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAfterNot:
+  Enabled: true
+
+Layout/SpaceAfterSemicolon:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceInsideStringInterpolation:
+  Enabled: true
+
+Layout/Tab:
+  Enabled: true
+
+Layout/TrailingBlankLines:
+  Enabled: true
+
+Layout/TrailingWhitespace:
+  Enabled: true
+
+Lint/AssignmentInCondition:
+  Enabled: true
+
+Lint/BooleanSymbol:
+  Enabled: true
+
+Lint/CircularArgumentReference:
+  Enabled: true
+
+Lint/Debugger:
+  Enabled: false
+
+Lint/DuplicateCaseCondition:
+  Enabled: true
+
+Lint/DuplicateMethods:
+  Enabled: true
+
+Lint/DuplicatedKey:
+  Enabled: true
+
+Lint/EachWithObjectArgument:
+  Enabled: true
+
+Lint/ElseLayout:
+  Enabled: true
+
+Lint/EmptyEnsure:
+  Enabled: true
+
+Lint/EmptyExpression:
+  Enabled: true
+
+Lint/EmptyInterpolation:
+  Enabled: true
+
+Lint/EmptyWhen:
+  Enabled: true
+
+Lint/EnsureReturn:
+  Enabled: true
+
+Lint/FloatOutOfRange:
+  Enabled: true
+
+Lint/FormatParameterMismatch:
+  Enabled: true
+
+Lint/HandleExceptions:
+  Enabled: true
+
+Lint/ImplicitStringConcatenation:
+  Enabled: true
+
+Lint/IneffectiveAccessModifier:
+  Enabled: true
+
+Lint/InheritException:
+  Enabled: true
+
+Lint/InterpolationCheck:
+  Enabled: true
+
+Lint/LiteralAsCondition:
+  Enabled: true
+
+Lint/LiteralInInterpolation:
+  Enabled: true
+
+Lint/Loop:
+  Enabled: true
+
+Lint/MissingCopEnableDirective:
+  Enabled: true
+
+Lint/MultipleCompare:
+  Enabled: true
+
+Lint/NestedMethodDefinition:
+  Enabled: true
+
+Lint/NextWithoutAccumulator:
+  Enabled: true
+
+Lint/NonLocalExitFromIterator:
+  Enabled: true
+
+# This caused too much confusion.
+Lint/NumberConversion:
+  Enabled: false
+
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: true
+
+Lint/PercentStringArray:
+  Enabled: true
+
+Lint/PercentSymbolArray:
+  Enabled: true
+
+Lint/RandOne:
+  Enabled: true
+
+Lint/RedundantWithIndex:
+  Enabled: true
+
+Lint/RedundantWithObject:
+  Enabled: true
+
+Lint/RegexpAsCondition:
+  Enabled: true
+
+Lint/RequireParentheses:
+  Enabled: true
+
+Lint/RescueException:
+  Enabled: true
+
+Lint/RescueType:
+  Enabled: true
+
+Lint/ReturnInVoidContext:
+  Enabled: true
+
+Lint/SafeNavigationChain:
+  Enabled: true
+
+Lint/SafeNavigationConsistency:
+  Enabled: true
+
+Lint/ShadowedArgument:
+  Enabled: true
+
+Lint/ShadowedException:
+  Enabled: true
+
+Lint/ShadowingOuterLocalVariable:
+  Enabled: true
+
+Lint/StringConversionInInterpolation:
+  Enabled: true
+
+Lint/Syntax:
+  Enabled: true
+
+Lint/UnderscorePrefixedVariableName:
+  Enabled: true
+
+Lint/UnifiedInteger:
+  Enabled: true
+
+Lint/UnneededRequireStatement:
+  Enabled: true
+
+Lint/UnneededSplatExpansion:
+  Enabled: true
+
+Lint/UnreachableCode:
+  Enabled: true
+
+Lint/UnusedBlockArgument:
+  Enabled: true
+
+Lint/UnusedMethodArgument:
+  Enabled: true
+
+Lint/UselessAccessModifier:
+  Enabled: true
+
+Lint/UselessAssignment:
+  Enabled: true
+
+Lint/UselessComparison:
+  Enabled: true
+
+Lint/UselessElseWithoutRescue:
+  Enabled: true
+
+Lint/UselessSetterCall:
+  Enabled: true
+
+Lint/Void:
+  Enabled: true
+  
+Metrics/AbcSize:
+  Enabled: true
+  Max: 150
+
+Metrics/BlockLength:
+  Enabled: true
+  Max: 50
+
+Metrics/BlockNesting:
+  Enabled: true
+  Max: 3
+
+Metrics/ClassLength:
+  Description: 'Avoid long classes'
+  Enabled: true
+  Max: 250
+
+Metrics/CyclomaticComplexity:
+  Enabled: true
+  Max: 12
+
+Metrics/LineLength:
+  Enabled: true
+  Max: 200
+
+Metrics/MethodLength:
+  Description: 'Avoid long methods.'
+  Enabled: true
+  Max: 30
+
+Metrics/ModuleLength:
+  Description: 'Avoid long modules.'
+  Enabled: true
+  Max: 250
+
+Metrics/ParameterLists:
+  Description: 'Avoid long parameter lists.'
+  Enabled: true
+  Max: 100
+
+Metrics/PerceivedComplexity:
+  Enabled: true
+  Max: 10
+
+Performance/Caller:
+  Enabled: true
+
+Performance/Casecmp:
+  Enabled: true
+
+# TODO: Re-enable
+Performance/ChainArrayAllocation:
+  Enabled: false
+
+Performance/CompareWithBlock:
+  Enabled: true
+
+Performance/Count:
+  Enabled: true
+
+Performance/Detect:
+  Enabled: true
+
+Performance/DoubleStartEndWith:
+  Enabled: true
+
+Performance/EndWith:
+  Enabled: true
+
+Performance/FixedSize:
+  Enabled: true
+
+Performance/FlatMap:
+  Enabled: true
+
+Performance/InefficientHashSearch:
+  Enabled: true
+
+Performance/RangeInclude:
+  Enabled: true
+
+Performance/RedundantBlockCall:
+  Enabled: true
+
+Performance/RedundantMatch:
+  Enabled: true
+
+Performance/RedundantMerge:
+  Enabled: true
+
+Style/RedundantSortBy:
+  Enabled: true
+
+Performance/RegexpMatch:
+  Enabled: true
+
+Performance/ReverseEach:
+  Enabled: true
+
+Style/Sample:
+  Enabled: true
+
+Performance/Size:
+  Enabled: true
+
+Performance/StartWith:
+  Enabled: true
+
+Performance/StringReplacement:
+  Enabled: true
+
+Performance/TimesMap:
+  Enabled: true
+
+Performance/UnfreezeString:
+  Enabled: true
+
+Style/UnneededSort:
+  Enabled: true
+
+Security/Eval:
+  Enabled: false
+
+Security/JSONLoad:
+  Enabled: true
+
+Security/MarshalLoad:
+  Enabled: true
+
+Security/Open:
+  Enabled: true
+
+Security/YAMLLoad:
+  Enabled: true

data/.ruby-version

@@ -0,0 +1 @@
+2.6.3

data/Gemfile.lock

@@ -0,0 +1,20 @@
+PATH
+  remote: .
+  specs:
+    cucumber-sammies (0.1.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    rake (12.3.2)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler (~> 1.17.2)
+  cucumber-sammies!
+  rake (~> 12.3.2)
+
+BUNDLED WITH
+   1.17.2

data/README.md

@@ -1,7 +1,6 @@
 # Cucumber::Sammies
 
 [![Code Climate](https://codeclimate.com/github/starfighterheavy/cucumber-sammies/badges/gpa.svg)](https://codeclimate.com/github/starfighterheavy/cucumber-sammies)
-[![Dependency Status](https://gemnasium.com/starfighterheavy/cucumber-sammies.svg)](https://gemnasium.com/starfighterheavy/cucumber-sammies)
 [![Gem Version](https://badge.fury.io/rb/cucumber-sammies.svg)](https://badge.fury.io/rb/cucumber-sammies)
 
 ![Cucumber Sandwhiches](./sammies.jpg)

data/cucumber-sammies.gemspec

@@ -1,4 +1,3 @@
-
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "cucumber/sammies/version"
@@ -23,6 +22,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "bundler", "~> 1.17.2"
+  spec.add_development_dependency "rake", "~> 12.3.2"
 end

data/lib/cucumber/sammies/step_definitions/all_steps.rb

@@ -1,7 +1,4 @@
-# coding: UTF-8
-
 Dir[File.join(File.dirname(__FILE__), '/step_definitions/*_steps.rb')].each do |f|
   name = File.basename(f, '.rb')
   require "cucumber/sammies/step_definitions/#{name}"
 end
-

data/lib/cucumber/sammies/step_definitions/content_steps.rb

@@ -1,3 +1,7 @@
+Then /^I should see an image with the src "(.*)"$/ do |image_src|
+  expect(page).to have_xpath("//img[contains(@src,'#{image_src}')]")
+end
+
 Then /^the page title should be "(.*)"$/ do |title|
   expect(page.title).to eq(title)
 end
@@ -7,17 +11,17 @@ Then /^the page body should include "(.*)"$/ do |content|
 end
 
 Then /^I should see "(.*)"$/ do |content|
-  expect(page).to have_content(content)
+  expect(page).to have_content(content, normalize_ws: true)
 end
 
 Then /^I should not see "(.*)"$/ do |content|
-  expect(page).not_to have_content(content)
+  expect(page).not_to have_content(content, normalize_ws: true)
 end
 
 Then(/^I see the (.*) flash message$/) do |message|
- expect(page).to have_content(resolve_locale(message))
+  expect(page).to have_content(resolve_locale(message), normalize_ws: true)
 end
 
 Then(/^I (should )?see the localized text for "(.*)"$/) do |_should, message|
- expect(page).to have_content(resolve_locale(message))
+  expect(page).to have_content(resolve_locale(message), normalize_ws: true)
 end

data/lib/cucumber/sammies/step_definitions/environment_steps.rb

@@ -6,7 +6,6 @@ Given /^the "(.*)" ENV should be set to "(.*)"$/ do |key, value|
   expect(ENV[key]).to eq value
 end
 
-
 Then /^"(.*)" should raise a "(.*)" error$/ do |expression, error|
   expect { eval(expression) }.to raise_error(/#{error}/)
 end

data/lib/cucumber/sammies/step_definitions/form_steps.rb

@@ -1,5 +1,13 @@
-When(/^I click "(.*)"$/) do |link|
-  click_on link
+When('I confirm') do
+  page.driver.browser.switch_to.alert.accept
+end
+
+When('I hit enter on {string}') do |id|
+  page.find("##{id}").send_keys(:return)
+end
+
+Then('the {string} field should contain {string}') do |label, value|
+  expect(find_field(label).value).to eq(value)
 end
 
 When(/^I click the first "(.*)"$/) do |link|
@@ -11,7 +19,7 @@ When(/^I click the "(.*)" submit button$/) do |link|
 end
 
 When /^(?:|I )select "([^"]*)" from "([^"]*)"$/ do |value, field|
-  select(value, :from => field)
+  select(value, from: field)
 end
 
 When(/^I check the ([^"]+) box$/) do |label|
@@ -42,13 +50,13 @@ def select_year_month(year:, month:, day: nil, field:)
     field = find(:xpath, ".//label[contains(.,'#{field}')]")[:for]
     field.gsub!(/_[1-3]{1}i$/, '')
   end
-  select year,  :from => "#{field}_1i"
-  select month, :from => "#{field}_2i"
-  select day, :from => "#{field}_3i" if day
+  select year,  from: "#{field}_1i"
+  select month, from: "#{field}_2i"
+  select day, from: "#{field}_3i" if day
 end
 
 When /^(?:|I )fill in "([^"]*)" (?:with|for) "([^"]*)"$/ do |field, value|
-  fill_in(field, :with => value)
+  fill_in(field, with: value)
 end
 
 Then /^nothing should be selected for "([^"]*)"$/ do |field|
@@ -58,6 +66,7 @@ Then /^nothing should be selected for "([^"]*)"$/ do |field|
     value = selected_option ? selected_option.value : nil
     value.should be_blank
   rescue Capybara::ElementNotFound
+    Rails.logger.info "Element not found: #{field}"
   end
 end
 
@@ -68,6 +77,7 @@ Then /^"([^"]*)" should( not)? be an option for "([^"]*)"$/ do |value, negate, f
     begin
       field_labeled(field).find(:xpath, xpath).should_not be_present
     rescue Capybara::ElementNotFound
+      Rails.logger.info "Element not found: #{field}"
     end
   else
     field_labeled(field).find(:xpath, xpath).should be_present

data/lib/cucumber/sammies/step_definitions/navigation_steps.rb

@@ -1,12 +1,51 @@
 require_relative '../support/resolvers'
 
+When('I switch to the new tab') do
+  page.driver.browser.switch_to.window(page.driver.browser.window_handles.last)
+end
+
+Then('the {string} button should be disabled') do |text|
+  expect(page).to have_button(text, disabled: true)
+end
+
+When('I hover over {string}') do |el|
+  page.find(el).hover
+end
+
+When('I click the {word} {string} icon') do |index, icon|
+  page.all('i', text: icon)[index.to_i - 1].click
+  sleep(1)
+end
+
+Then('I should see {int} {string} icons') do |count, icon|
+  expect(page.all('i', text: icon).size).to eq(count)
+end
+
+Then('I should not see a {string} icon') do |icon|
+  expect(page.all('i', text: icon).size).to eq(0)
+end
+
+When('I click the first {string} button') do |button|
+  first(:button, button).click
+end
+
+When('I click the {string} icon') do |icon|
+  page.find('i', text: /#{icon}/i).click
+end
+
+When(/^I click "(.*)"$/) do |link|
+  click_on link
+end
+
+When 'I reload the page' do
+  visit current_url
+end
+
 Then(/^I am taken to (a|an|the) (.*) page$/) do |inclusive, path|
   path.split(' ').each do |part|
     expect(current_path.split('/')).to include(part)
   end
-  unless inclusive == 'the'
-    expect(current_path.split('/').last.to_i).to be > 0
-  end
+  expect(current_path.split('/').last.to_i).to be > 0 unless inclusive == 'the'
 end
 
 When(/^I set the subdomain to "(.*)"$/) do |subdomain|
@@ -48,8 +87,8 @@ Then /^(?:|I )should be on the (.+) page$/ do |page_name|
   expected_path = resolve_path(page_name)
 
   # Consider two pages equal if they only differ by a trailing slash.
-  current_path = expected_path if current_path.chomp("/") == expected_path.chomp("/")
-  current_path = expected_path if current_path.gsub("/#", "#") == expected_path.gsub("/#", "#")
+  current_path = expected_path if current_path.chomp('/') == expected_path.chomp('/')
+  current_path = expected_path if current_path.gsub('/#', '#') == expected_path.gsub('/#', '#')
 
   current_path.should == expected_path
 end

data/lib/cucumber/sammies/step_definitions/table_steps.rb

@@ -3,8 +3,8 @@ Then /^I should not see the table "(.*)"$/ do |caption|
 end
 
 Then /^the table "(.*)" should contain:$/ do |caption, data|
-  table = page.find('caption', text: caption).first(:xpath,".//..").all('tr').map { |tr|
-    tr.all('th,td').map { |col| col.text }
-  }
+  table = page.find('caption', text: caption).first(:xpath, './/..').all('tr').map do |tr|
+    tr.all('th,td').map(&:text)
+  end
   data.diff!(table)
 end

data/lib/cucumber/sammies/step_definitions/time_steps.rb

@@ -3,7 +3,6 @@
 if defined?(Timecop)
 
   module TimecopHarness
-
     # When you have to make your rails app time zone aware you have to go 100%
     # otherwise you are better off ignoring time zones at all.
     # https://makandracards.com/makandra/8723-guide-to-localizing-a-rails-application
@@ -28,7 +27,6 @@ if defined?(Timecop)
         Time.now
       end
     end
-
   end
 
   World(TimecopHarness)
@@ -54,13 +52,13 @@ if defined?(Timecop)
   #     When it is a few hours earlier
   When /^it is (\d+|a|some|a few) (seconds?|minutes?|hours?|days?|weeks?|months?|years?) (later|earlier)$/ do |amount, unit, direction|
     amount = case amount
-      when 'a'
-        1
-      when 'some', 'a few'
-        10
-      else
-        amount.to_i
-    end
+             when 'a'
+               1
+             when 'some', 'a few'
+               10
+             else
+               amount.to_i
+             end
     amount = -amount if direction == 'earlier'
     Timecop.travel(current_time + amount.send(unit))
   end

data/lib/cucumber/sammies/step_definitions/troubleshooting_steps.rb

@@ -1,3 +1,11 @@
+When('I peak at the logs') do
+  page.driver.manage.get_log(:browser)
+end
+
+When('I wait {float} seconds') do |seconds|
+  sleep(seconds)
+end
+
 When /^I log the page$/ do
   Cucumber.logger.info page.body
 end

data/lib/cucumber/sammies/support/resolvers.rb

@@ -5,21 +5,21 @@ module Resolvers
   end
 
   def resolve_path(str)
-    send(str.gsub(' ', '_') + '_path')
+    send(str.tr(' ', '_') + '_path')
   end
 
   def resolve_ivar(str)
-    model = str.gsub(' ', '_')
+    model = str.tr(' ', '_')
     instance_variable_get("@#{model}")
   end
 
   def set_ivar(str, value)
-    model = str.gsub(' ', '_')
+    model = str.tr(' ', '_')
     instance_variable_set("@#{model}", value)
   end
 
   def resolve_class(str)
-    str.singularize.titleize.gsub(' ', '').constantize
+    str.singularize.titleize.delete(' ').constantize
   end
 end
 World(Resolvers)

data/lib/cucumber/sammies/version.rb

@@ -1,5 +1,5 @@
 module Cucumber
   module Sammies
-    VERSION = "0.1.2"
+    VERSION = "0.2.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-sammies
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Jonathan Kirst
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-29 00:00:00.000000000 Z
+date: 2019-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: 1.17.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: 1.17.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.2
 description: 
 email:
 - jskirst@gmail.com
@@ -46,8 +46,11 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
+- ".ruby-version"
 - CODE_OF_CONDUCT.md
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -87,8 +90,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Cucumber step definitions for rails applications.