cucumber-messages 9.0.3 → 10.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 304247d3eec1872fef25ec59a3736cf56c42c9f31f7599d644a6fb7b3130da4a
-  data.tar.gz: 3ff363852d1e6786c0f8938cd5fd1a27f451e0c0d27fa1521de2ac2543b06ac3
+  metadata.gz: 3548d581ea0cbe4a0e13073a6e0886b98bea566f76414b1d7cb0c94a87e91321
+  data.tar.gz: 6eea11ad3537fc9cf1c89fb2721fa1df4426939ba08c84563d3853c556be6fc8
 SHA512:
-  metadata.gz: 8c68b49a5ddebc229ed94f9762ef5a5d261025d987298f3c00b22a8484c6283b42a28df927fbd82078ad9cb693ea17d6f94b26cd4d5e9d8d8662a56e29db0191
-  data.tar.gz: c5a059f32adab04dcdfa1ffa1c983a71ebcb913321dc09791d3a611dcffd9b41590dac95c25795cf06daeb4fa4f04dc19823c69750aef179b8741847781345fc
+  metadata.gz: 12fbf050c3ed3f149bf495432d3b886635dd5d63ec9e30b114c92b4c3437784601907ee5b2e14514c873f812cb88916bdfd7793b6c5a3c363bc979e441c2a731
+  data.tar.gz: 82d61564a8a814a36b68c3ec025e721f4ba9098a948258f29c55484c270fdb616905c3efb897e05837de699ae311c1ca43f57a99b07c738192cd4de187c8e2e0

data/lib/cucumber/messages.pb.rb

@@ -108,7 +108,7 @@ module Cucumber
     class TestCaseFinished < ::Protobuf::Message; end
     class TestStepStarted < ::Protobuf::Message; end
     class TestStepFinished < ::Protobuf::Message; end
-    class TestResult < ::Protobuf::Message
+    class TestStepResult < ::Protobuf::Message
       class Status < ::Protobuf::Enum
         define :UNKNOWN, 0
         define :PASSED, 1
@@ -133,6 +133,7 @@ module Cucumber
     class StepDefinition < ::Protobuf::Message; end
     class StepDefinitionPattern < ::Protobuf::Message; end
     class ParameterType < ::Protobuf::Message; end
+    class UndefinedParameterType < ::Protobuf::Message; end
     class CommandActionComplete < ::Protobuf::Message; end
     class CommandRunBeforeTestRunHooks < ::Protobuf::Message; end
     class CommandRunAfterTestRunHooks < ::Protobuf::Message; end
@@ -196,6 +197,7 @@ module Cucumber
       optional ::Cucumber::Messages::StepDefinition, :step_definition, 25
       optional ::Cucumber::Messages::Hook, :hook, 26
       optional ::Cucumber::Messages::ParameterType, :parameter_type, 27
+      optional ::Cucumber::Messages::UndefinedParameterType, :undefined_parameter_type, 28
     end
 
     class Location
@@ -441,14 +443,14 @@ module Cucumber
     end
 
     class TestStepFinished
-      optional ::Cucumber::Messages::TestResult, :test_result, 1
+      optional ::Cucumber::Messages::TestStepResult, :test_step_result, 1
       optional ::Cucumber::Messages::Timestamp, :timestamp, 2
       optional :string, :test_step_id, 3
       optional :string, :test_case_started_id, 4
     end
 
-    class TestResult
-      optional ::Cucumber::Messages::TestResult::Status, :status, 1
+    class TestStepResult
+      optional ::Cucumber::Messages::TestStepResult::Status, :status, 1
       optional :string, :message, 2
       optional ::Cucumber::Messages::Duration, :duration, 3
       optional :bool, :will_be_retried, 4
@@ -457,6 +459,7 @@ module Cucumber
     class TestRunFinished
       optional :bool, :success, 1
       optional ::Cucumber::Messages::Timestamp, :timestamp, 2
+      optional :string, :message, 3
     end
 
     class CommandStart
@@ -527,9 +530,14 @@ module Cucumber
       optional :bool, :use_for_snippets, 4
     end
 
+    class UndefinedParameterType
+      optional :string, :name, 1
+      optional :string, :expression, 2
+    end
+
     class CommandActionComplete
       optional :string, :completed_id, 1
-      optional ::Cucumber::Messages::TestResult, :test_result, 2
+      optional ::Cucumber::Messages::TestStepResult, :test_step_result, 2
       optional :string, :snippet, 3
     end
 

data/lib/cucumber/messages/protobuf_ndjson.rb

@@ -4,27 +4,8 @@ module Cucumber
   module Messages
     module WriteNdjson
       def write_ndjson_to(io)
-        # https://github.com/ruby-protobuf/protobuf/pull/410
-        json = self.to_json(lower_camel_case: true)
-        ob = JSON.parse(json)
-        remove_empties(ob)
-        io.puts(JSON.generate(ob))
-      end
-
-      def remove_empties(ob)
-        if Hash === ob
-          ob.each do |key, value|
-            if value == [] || value == '' || value == 0
-              ob.delete(key)
-            else
-              remove_empties(value)
-            end
-          end
-        elsif Array === ob
-          ob.each do |value|
-            remove_empties(value)
-          end
-        end
+        io.write(self.to_json(proto3: true))
+        io.write("\n")
       end
     end
   end

data/lib/cucumber/messages/time_conversion.rb

@@ -14,13 +14,13 @@ module Cucumber
 
       def seconds_to_duration(seconds_float)
         seconds, second_modulus = seconds_float.divmod(1)
-        nanos = second_modulus / NANOSECONDS_PER_SECOND
+        nanos = second_modulus * NANOSECONDS_PER_SECOND
         Duration.new(seconds: seconds, nanos: nanos)
       end
 
       def duration_to_seconds(duration)
         seconds_part = duration.seconds
-        nanos_part = duration.nanos / NANOSECONDS_PER_SECOND
+        nanos_part = duration.nanos.to_f / NANOSECONDS_PER_SECOND
         seconds_part + nanos_part
       end
     end

data/spec/cucumber/messages/ndjson_serialization_spec.rb

@@ -7,7 +7,7 @@ module Cucumber
       it "json-roundtrips messages with bytes fields" do
         a1 = Attachment.new(binary: [1,2,3,4].pack('C*'))
         expect(a1.binary.length).to eq(4)
-        a2 = Attachment.new(JSON.parse(a1.to_json))
+        a2 = Attachment.new(JSON.parse(a1.to_json(proto3: true)))
         expect(a2).to(eq(a1))
       end
 
@@ -22,6 +22,38 @@ module Cucumber
         expect(json).to eq("{\"source\":{}}\n")
       end
 
+      it "omits empty number fields in output" do
+        io = StringIO.new
+        message = Envelope.new(
+          test_case_started: TestCaseStarted.new(
+            timestamp: Timestamp.new(
+              seconds: 0
+            )
+          )
+        )
+        message.write_ndjson_to(io)
+
+        io.rewind
+        json = io.read
+
+        expect(json).to eq('{"testCaseStarted":{"timestamp":{}}}' + "\n")
+      end
+
+      it "omits empty repeated fields in output" do
+        io = StringIO.new
+        message = Envelope.new(
+          parameter_type: ParameterType.new(
+            regular_expressions: []
+          )
+        )
+        message.write_ndjson_to(io)
+
+        io.rewind
+        json = io.read
+
+        expect(json).to eq('{"parameterType":{}}' + "\n")
+      end
+
       it "can be serialised over an ndjson stream" do
         outgoing_messages = [
           Envelope.new(source: Source.new(data: 'Feature: Hello')),

data/spec/cucumber/messages/time_conversion_spec.rb

@@ -13,7 +13,6 @@ module Cucumber
         expect(time_again).to eq(time)
       end
 
-
       it 'converts to and from seconds duration' do
         duration_in_seconds = 1234
         duration = seconds_to_duration(duration_in_seconds)
@@ -21,6 +20,14 @@ module Cucumber
 
         expect(duration_in_seconds_again).to eq(duration_in_seconds)
       end
+
+      it 'converts to and from seconds duration (with decimal places)' do
+        duration_in_seconds = 3.000161
+        duration = seconds_to_duration(duration_in_seconds)
+        duration_in_seconds_again = duration_to_seconds(duration)
+
+        expect(duration_in_seconds_again).to be_within(0.000000001).of(duration_in_seconds)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-messages
 version: !ruby/object:Gem::Version
-  version: 9.0.3
+  version: 10.0.1
 platform: ruby
 authors:
 - Aslak Hellesøy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-10 00:00:00.000000000 Z
+date: 2020-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: protobuf-cucumber
@@ -19,7 +19,7 @@ dependencies:
         version: '3.10'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.10.4
+        version: 3.10.8
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '3.10'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.10.4
+        version: 3.10.8
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -162,7 +162,7 @@ rubyforge_project:
 rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
-summary: cucumber-messages-9.0.3
+summary: cucumber-messages-10.0.1
 test_files:
 - spec/cucumber/messages/time_conversion_spec.rb
 - spec/cucumber/messages/ndjson_serialization_spec.rb