cucumber-core 17.0.0 → 18.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88faed296b96d11e574838451644e6ab5e784bb2e4bdf9238f24b4488dc4a902
-  data.tar.gz: 020fe0f4bbc9072752a0748465157991e9c65765ce47c33061c89bedd7e37db0
+  metadata.gz: 40198f152a14c95e0b6bc0edd0191ea57223037d6452849926f20691114cfb4f
+  data.tar.gz: 81b94a76c6113fbd26be6aba465294d61185d48202ef153196b95465f094f7c3
 SHA512:
-  metadata.gz: 9f1900994b1560af95ba5871cd9ee8f9647d1e93e4148e6ed1d56406c4fffaa85afdccebfc9d05a11d795bebf473e2450589656d193e7d42d6412d4c1a861fa4
-  data.tar.gz: 7490537caa92180e2887080e8bd7fa169bc9994dd2d01262ffb57b3d3b3d5df1a34c7ae6503d5433847409b44586e221bdd2dd00ec7f28a094c00878751e480e
+  metadata.gz: e20c7fad6648efad8b47f55c79259c7c35106b0778c714e31f387dbcfae17699a5283841894f5ec94ab8dd7f3792c4fd6958186ebf5a3845404c26318e9d3fa1
+  data.tar.gz: 5c2477e304ae210c4c0efde9b2445c576d209cc116fd78e25b95afe7965c6cbba4161ae1e8e2235c3aa3d1bd92668a001f163f5dabd848206758a7a2700484c9

data/CHANGELOG.md

@@ -10,6 +10,10 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ## [Unreleased]
 
+## [18.0.0] - 2026-07-13
+### Changed
+- Tidied up a bunch of mostly internal test code to be more rubocop compliant
+
 ## [17.0.0] - 2026-06-01
 ### Added
 - Added `#to_envelope` for `Cucumber::Core::Gherkin::Document` ([#329](https://github.com/cucumber/cucumber-ruby-core/pull/329))
@@ -88,12 +92,9 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 ## [14.0.0] - 2024-08-08
 ### Changed
 - Permit usage of gherkin up to v29 and messages up to v26
-- **Internal Breaking Change**: Structure of `Action` classes have changed.
-See upgrading notes for [14.0.0.md](upgrading_notes/14.0.0.md#upgrading-to-cucumber-core-1400)
-([#282](https://github.com/cucumber/cucumber-ruby-core/pull/282))
 
 ### Removed
-- Remove support for ruby 2.6 and below. 2.7 or higher is required now (Autofixed to Ruby 2.7 styles)
+- Removed support for ruby 2.6 and below. 2.7 or higher is required now (Autofixed to Ruby 2.7 styles)
 
 ## [13.0.3] - 2024-07-24
 ### Changed
@@ -149,7 +150,8 @@ See upgrading notes for [13.0.0.md](upgrading_notes/13.0.0.md#upgrading-to-cucum
 ### Changed
 - Updated `cucumber-gherkin` and `cucumber-messages`
 
-[Unreleased]: https://github.com/cucumber/cucumber-ruby-core/compare/v17.0.0...HEAD
+[Unreleased]: https://github.com/cucumber/cucumber-ruby-core/compare/v18.0.0...HEAD
+[18.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v17.0.0...v18.0.0
 [17.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v16.2.0...v17.0.0
 [16.2.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v16.1.1...v16.2.0
 [16.1.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v16.1.0...v16.1.1
@@ -169,3 +171,10 @@ See upgrading notes for [13.0.0.md](upgrading_notes/13.0.0.md#upgrading-to-cucum
 [12.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v11.1.0...v12.0.0
 [11.1.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v11.0.0...v11.1.0
 [11.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.1.1...v11.0.0
+.3]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.2...v13.0.3
+[13.0.2]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.1...v13.0.2
+[13.0.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.0...v13.0.1
+[13.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v12.0.0...v13.0.0
+[12.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v11.1.0...v12.0.0
+[11.1.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v11.0.0...v11.1.0
+[11.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.1.1...v11.0.0

data/lib/cucumber/core/gherkin/parser.rb

@@ -5,7 +5,7 @@ require 'gherkin'
 module Cucumber
   module Core
     module Gherkin
-      ParseError = Class.new(StandardError)
+      class ParseError < StandardError; end
 
       class Parser
         attr_reader :receiver, :event_bus, :gherkin_query

data/lib/cucumber/core/gherkin/writer/accepts_comments.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Core
+    module Gherkin
+      module Writer
+        module AcceptsComments
+          def comment(line)
+            comment_lines << "# #{line}"
+          end
+
+          def comment_lines
+            @comment_lines ||= []
+          end
+
+          def slurp_comments
+            comment_lines.tap { @comment_lines = nil }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/gherkin/writer/background.rb

@@ -10,7 +10,9 @@ module Cucumber
           include HasElements
           include HasOptionsInitializer
           include HasDescription
-          include Indentation.level 2
+          extend Indentation
+
+          indentation_level 2
 
           default_keyword 'Background'
 

data/lib/cucumber/core/gherkin/writer/doc_string.rb

@@ -7,7 +7,9 @@ module Cucumber
     module Gherkin
       module Writer
         class DocString
-          include Indentation.level(6)
+          extend Indentation
+
+          indentation_level 6
 
           attr_reader :strings, :content_type
           private :strings, :content_type

data/lib/cucumber/core/gherkin/writer/example.rb

@@ -8,7 +8,9 @@ module Cucumber
     module Gherkin
       module Writer
         class Example < Scenario
-          include Indentation.level 4
+          extend Indentation
+
+          indentation_level 4
 
           default_keyword 'Example'
         end

data/lib/cucumber/core/gherkin/writer/examples.rb

@@ -12,7 +12,9 @@ module Cucumber
           include HasOptionsInitializer
           include HasRows
           include HasDescription
-          include Indentation.level(4)
+          extend Indentation
+
+          indentation_level 4
 
           default_keyword 'Examples'
 

data/lib/cucumber/core/gherkin/writer/feature.rb

@@ -12,7 +12,9 @@ module Cucumber
           include HasElements
           include HasOptionsInitializer
           include HasDescription
-          include Indentation.level(0)
+          extend Indentation
+
+          indentation_level 0
 
           default_keyword 'Feature'
 

data/lib/cucumber/core/gherkin/writer/has_description.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Core
+    module Gherkin
+      module Writer
+        module HasDescription
+          private
+
+          def description
+            options.fetch(:description, '').split("\n").map(&:strip)
+          end
+
+          def description_statement
+            description.map { |s| indent(s, 2) } unless description.empty?
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/gherkin/writer/has_elements.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Core
+    module Gherkin
+      module Writer
+        module HasElements
+          include AcceptsComments
+
+          def self.included(base)
+            base.extend HasElementBuilders
+          end
+
+          def build(source = [])
+            elements.inject(source + statements) { |acc, el| el.build(acc) }
+          end
+
+          private
+
+          def elements
+            @elements ||= []
+          end
+
+          module HasElementBuilders
+            def elements(*names)
+              names.each { |name| element(name) }
+            end
+
+            private
+
+            def element(name)
+              define_method(name) do |*args, &source|
+                factory_name = String(name).split('_').map(&:capitalize).join
+                factory = Writer.const_get(factory_name)
+                factory.new(slurp_comments, *args).tap do |builder|
+                  builder.instance_exec(&source) if source
+                  elements << builder
+                end
+                self
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/gherkin/writer/has_options_initializer.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Core
+    module Gherkin
+      module Writer
+        module HasOptionsInitializer
+          def self.included(base)
+            base.extend HasDefaultKeyword
+          end
+
+          attr_reader :name, :options
+          private :name, :options
+
+          def initialize(*args)
+            @comments = args.shift if args.first.is_a?(Array)
+            @comments ||= []
+            @options = args.pop if args.last.is_a?(Hash)
+            @options ||= {}
+            @name = args.first
+          end
+
+          private
+
+          def comments_statement
+            @comments
+          end
+
+          def keyword
+            options.fetch(:keyword) { self.class.keyword }
+          end
+
+          def name_statement
+            "#{keyword}: #{name}".strip
+          end
+
+          def tag_statement
+            tags
+          end
+
+          def tags
+            options[:tags]
+          end
+
+          module HasDefaultKeyword
+            def default_keyword(keyword)
+              @keyword = keyword
+            end
+
+            def keyword
+              @keyword
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/gherkin/writer/has_rows.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Core
+    module Gherkin
+      module Writer
+        module HasRows
+          def row(*cells)
+            rows << cells
+          end
+
+          def rows
+            @rows ||= []
+          end
+
+          private
+
+          def row_statements(indent = nil)
+            rows.map { |row| indent(table_row(row), indent) }
+          end
+
+          def table_row(row)
+            padded = pad(row)
+            "| #{padded.join(' | ')} |"
+          end
+
+          def pad(row)
+            row.map.with_index { |text, position| justify_cell(text, position) }
+          end
+
+          def column_length(column)
+            lengths = rows.transpose.map { |r| r.map(&:length).max }
+            lengths[column]
+          end
+
+          def justify_cell(cell, position)
+            cell.ljust(column_length(position))
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/gherkin/writer/helpers.rb

@@ -1,177 +1,9 @@
 # frozen_string_literal: true
 
-module Cucumber
-  module Core
-    module Gherkin
-      module Writer
-        module HasOptionsInitializer
-          def self.included(base)
-            base.extend HasDefaultKeyword
-          end
+require_relative 'accepts_comments'
 
-          attr_reader :name, :options
-          private :name, :options
-
-          def initialize(*args)
-            @comments = args.shift if args.first.is_a?(Array)
-            @comments ||= []
-            @options = args.pop if args.last.is_a?(Hash)
-            @options ||= {}
-            @name = args.first
-          end
-
-          private
-
-          def comments_statement
-            @comments
-          end
-
-          def keyword
-            options.fetch(:keyword) { self.class.keyword }
-          end
-
-          def name_statement
-            "#{keyword}: #{name}".strip
-          end
-
-          def tag_statement
-            tags
-          end
-
-          def tags
-            options[:tags]
-          end
-
-          module HasDefaultKeyword
-            def default_keyword(keyword)
-              @keyword = keyword
-            end
-
-            def keyword
-              @keyword
-            end
-          end
-        end
-
-        module AcceptsComments
-          def comment(line)
-            comment_lines << "# #{line}"
-          end
-
-          def comment_lines
-            @comment_lines ||= []
-          end
-
-          def slurp_comments
-            comment_lines.tap { @comment_lines = nil }
-          end
-        end
-
-        module HasElements
-          include AcceptsComments
-
-          def self.included(base)
-            base.extend HasElementBuilders
-          end
-
-          def build(source = [])
-            elements.inject(source + statements) { |acc, el| el.build(acc) }
-          end
-
-          private
-
-          def elements
-            @elements ||= []
-          end
-
-          module HasElementBuilders
-            def elements(*names)
-              names.each { |name| element(name) }
-            end
-
-            private
-
-            def element(name)
-              define_method(name) do |*args, &source|
-                factory_name = String(name).split('_').map(&:capitalize).join
-                factory = Writer.const_get(factory_name)
-                factory.new(slurp_comments, *args).tap do |builder|
-                  builder.instance_exec(&source) if source
-                  elements << builder
-                end
-                self
-              end
-            end
-          end
-        end
-
-        module Indentation
-          def self.level(number)
-            Module.new do
-              define_method(:indent) do |string, amount = nil|
-                return string if string.nil? || string.empty?
-
-                amount ||= number
-                "#{' ' * amount}#{string}"
-              end
-
-              define_method(:indent_level) do
-                number
-              end
-
-              define_method(:prepare_statements) do |*statements|
-                statements.flatten.compact.map { |s| indent(s) }
-              end
-            end
-          end
-        end
-
-        module HasDescription
-          private
-
-          def description
-            options.fetch(:description, '').split("\n").map(&:strip)
-          end
-
-          def description_statement
-            description.map { |s| indent(s, 2) } unless description.empty?
-          end
-        end
-
-        module HasRows
-          def row(*cells)
-            rows << cells
-          end
-
-          def rows
-            @rows ||= []
-          end
-
-          private
-
-          def row_statements(indent = nil)
-            rows.map { |row| indent(table_row(row), indent) }
-          end
-
-          def table_row(row)
-            padded = pad(row)
-            "| #{padded.join(' | ')} |"
-          end
-
-          def pad(row)
-            row.map.with_index { |text, position| justify_cell(text, position) }
-          end
-
-          def column_length(column)
-            lengths = rows.transpose.map { |r| r.map(&:length).max }
-            lengths[column]
-          end
-
-          def justify_cell(cell, position)
-            cell.ljust(column_length(position))
-          end
-        end
-      end
-    end
-  end
-end
+require_relative 'has_description'
+require_relative 'has_elements'
+require_relative 'has_options_initializer'
+require_relative 'has_rows'
+require_relative 'indentation'

data/lib/cucumber/core/gherkin/writer/indentation.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module Cucumber
+  module Core
+    module Gherkin
+      module Writer
+        module Indentation
+          def indentation_level(number)
+            create_indent(number)
+            create_indent_level(number)
+            create_prepare_statements
+          end
+
+          private
+
+          def create_indent(number)
+            define_method(:indent) do |string, amount = nil|
+              return string if string.nil? || string.empty?
+
+              amount ||= number
+              "#{' ' * amount}#{string}"
+            end
+          end
+
+          def create_indent_level(number)
+            define_method(:indent_level) do
+              number
+            end
+          end
+
+          def create_prepare_statements
+            define_method(:prepare_statements) do |*statements|
+              statements.flatten.compact.map { |s| indent(s) }
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/cucumber/core/gherkin/writer/rule.rb

@@ -12,7 +12,9 @@ module Cucumber
           include HasElements
           include HasOptionsInitializer
           include HasDescription
-          include Indentation.level 2
+          extend Indentation
+
+          indentation_level 2
 
           default_keyword 'Rule'
 

data/lib/cucumber/core/gherkin/writer/scenario.rb

@@ -10,7 +10,9 @@ module Cucumber
           include HasElements
           include HasOptionsInitializer
           include HasDescription
-          include Indentation.level 2
+          extend Indentation
+
+          indentation_level 2
 
           default_keyword 'Scenario'
 

data/lib/cucumber/core/gherkin/writer/scenario_outline.rb

@@ -10,7 +10,9 @@ module Cucumber
           include HasElements
           include HasOptionsInitializer
           include HasDescription
-          include Indentation.level 2
+          extend Indentation
+
+          indentation_level 2
 
           default_keyword 'Scenario Outline'
 

data/lib/cucumber/core/gherkin/writer/step.rb

@@ -11,7 +11,9 @@ module Cucumber
         class Step
           include HasElements
           include HasOptionsInitializer
-          include Indentation.level 4
+          extend Indentation
+
+          indentation_level 4
 
           default_keyword 'Given'
 

data/lib/cucumber/core/gherkin/writer/table.rb

@@ -7,7 +7,10 @@ module Cucumber
     module Gherkin
       module Writer
         class Table
-          include Indentation.level(6)
+          extend Indentation
+
+          indentation_level 6
+
           include HasRows
 
           def initialize(*); end

data/lib/cucumber/core/test/data_table.rb

@@ -57,7 +57,7 @@ module Cucumber
         end
 
         def inspect
-          %{#<#{self.class} #{raw.inspect}>}
+          %(#<#{self.class} #{raw.inspect}>)
         end
 
         def lines_count

data/lib/cucumber/core/test/location.rb

@@ -5,7 +5,7 @@ require 'set'
 module Cucumber
   module Core
     module Test
-      IncompatibleLocations = Class.new(StandardError)
+      class IncompatibleLocations < StandardError; end
 
       module Location
         def self.of_caller(additional_depth = 0)

data/lib/cucumber/core/test/result/flaky.rb

@@ -12,7 +12,7 @@ module Cucumber
         # retry, therefore only the class method self.ok? is needed.
         class Flaky
           def self.ok?
-            false
+            true
           end
         end
       end

data/lib/cucumber/core/test/timer.rb

@@ -38,7 +38,7 @@ module Cucumber
             end
           elsif (defined?(RUBY_ENGINE) ? RUBY_ENGINE : 'ruby') == 'jruby'
             def time_in_nanoseconds
-              java.lang.System.nanoTime()
+              java.lang.System.nanoTime
             end
           else
             def time_in_nanoseconds

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cucumber-core
 version: !ruby/object:Gem::Version
-  version: 17.0.0
+  version: 18.0.0
 platform: ruby
 authors:
 - Aslak Hellesøy
@@ -184,13 +184,19 @@ files:
 - lib/cucumber/core/gherkin/document.rb
 - lib/cucumber/core/gherkin/parser.rb
 - lib/cucumber/core/gherkin/writer.rb
+- lib/cucumber/core/gherkin/writer/accepts_comments.rb
 - lib/cucumber/core/gherkin/writer/background.rb
 - lib/cucumber/core/gherkin/writer/doc_string.rb
 - lib/cucumber/core/gherkin/writer/example.rb
 - lib/cucumber/core/gherkin/writer/examples.rb
 - lib/cucumber/core/gherkin/writer/feature.rb
 - lib/cucumber/core/gherkin/writer/gherkin.rb
+- lib/cucumber/core/gherkin/writer/has_description.rb
+- lib/cucumber/core/gherkin/writer/has_elements.rb
+- lib/cucumber/core/gherkin/writer/has_options_initializer.rb
+- lib/cucumber/core/gherkin/writer/has_rows.rb
 - lib/cucumber/core/gherkin/writer/helpers.rb
+- lib/cucumber/core/gherkin/writer/indentation.rb
 - lib/cucumber/core/gherkin/writer/rule.rb
 - lib/cucumber/core/gherkin/writer/scenario.rb
 - lib/cucumber/core/gherkin/writer/scenario_outline.rb
@@ -257,5 +263,5 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 4.0.10
 specification_version: 4
-summary: cucumber-core-17.0.0
+summary: cucumber-core-18.0.0
 test_files: []