cucumber-core 12.0.0 → 13.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5044df1d888874e71128efa080115becbb8c21a6e0ea79da117119b88390ae99
-  data.tar.gz: a3a96cb3867f71c52f8cd430271f8751a8b819b3d195f027ca8573af4b537c6d
+  metadata.gz: 8be25fb56be8e8108a968aaf270b1e296df496b660a5d8536bb1c7cfe3e74359
+  data.tar.gz: e08583f1d1cfabd07ed42fb58ec6c0b4f3361d7b0c90286f29d26dbfd8bfb918
 SHA512:
-  metadata.gz: ffab80fbb75922f2580383bdfa3747e1675dc524c945df0c94b5ae6146bd77907526ed81a049ea0a05b68cac5e5267ca0c698cc0b4483acd6e0428feedf4cbf8
-  data.tar.gz: 4ee61046f1f49501db71e4a9d2792a4205c4fcd37da5481dd86cfe7a9be1fc01988a3ed5dc561332538969bd44cfa762d80712a6b4bc5d8594d24a9d24181932
+  metadata.gz: 1ad8d22710c9bff29cc1a4ab1a3d5cc41a4a10325aa25accdcde0a833489d4a0a6a98d9415452868551e312bc7672063ba89bf5f3929bc1448384c253a69768b
+  data.tar.gz: 14437bb84b31edf7bbad45cf1575770e90b907ccff5d284b89cb7b42aa9f3f5197f812a02dd762b3e121044dab6bc0a6fc4ecf322548267e56c8c7298b35e7c8

data/CHANGELOG.md

@@ -1,287 +1,55 @@
 # Changelog
 
-## [Unreleased]
-
-## [12.0.0] - 2023-09-06
-### Changed
-- Update gherkin and messages minimum dependencies
-- Added in new rubocop sub-gems for testing, pinning versions where appropriate
-- Removed all redundant / incorrect rubocop config overrides (Placed in TODO file)
-
-### Removed
-- Remove support for ruby 2.4 and below. 2.5 or higher is required now
-
-## [11.1.0] - 2022-12-22
-### Changed
-- Update gherkin and messages dependencies
-
-### Fixed
-- Restore support for matching a scenario by tag and step line numbers. ([#237](https://github.com/cucumber/cucumber-ruby-core/pull/237), [#238](https://github.com/cucumber/cucumber-ruby-core/pull/238), [#239](https://github.com/cucumber/cucumber-ruby-core/pull/239))
-
-## [11.0.0]
-### Changed
-- Updated `cucumber-gherkin` and `cucumber-messages`
+All notable changes to this project will be documented in this file.
 
-## [10.1.1]
-### Changed
-- Patched `cucumber-tag-expressions`
+This project adheres to [Semantic Versioning](http://semver.org).
 
-## [10.1.0]
-### Changed
-- Patched `cucumber-gherkin`, `cucumber-messages` and `cucumber-tag-expressions`
+This document is formatted according to the principles of [Keep A CHANGELOG](http://keepachangelog.com).
 
-## [10.0.1]
-### Changed
-- Patched `cucumber-gherkin` and `cucumber-messages`
+Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CONTRIBUTING.md) for more info on how to contribute to Cucumber.
 
-## [10.0.0]
-### Changed
-- Upgraded to gherkin v20 and messages v17.
-
-## [9.0.1]
-### Fixed
-- Skipped scenarios do not affect anymore status of flaky scenarios on retry
-([#218](https://github.com/cucumber/cucumber-ruby-core/pull/218) @eduardrudko)
+## [Unreleased]
 
-## [9.0.0]
+## [13.0.0] - 2023-12-05
 ### Changed
-- Upgraded to gherkin v18 and messages v15
-- Updated other dependencies (look at the diff for details)
+- Now using a 2-tiered changelog to avoid any bugs when using polyglot-release
+- More refactoring of the repo by fixing up a bunch of manual rubocop offenses (See PR's for details)
+([#259](https://github.com/cucumber/cucumber-ruby-core/pull/259) [#262](https://github.com/cucumber/cucumber-ruby-core/pull/262) [#268](https://github.com/cucumber/cucumber-ruby-core/pull/268) [#274](https://github.com/cucumber/cucumber-ruby-core/pull/274))
+- In all `Summary` and `Result` classes, changed the `strict` argument into a keyword argument
+See upgrading notes for [13.0.0.md](upgrading_notes/13.0.0.md#upgrading-to-1300)
+([#261](https://github.com/cucumber/cucumber-ruby-core/pull/261))
+- Permit usage of gherkin v27
 
-## [8.0.1]
 ### Fixed
-- Make releases from docker using secrets from keybase
-
-## [8.0.0]
-### Changed
-- Updated dependencies (look at the diff for details)
-
-## [7.1.0]
-### Changed
-- `cucumber-gherkin` ~> 14.0.1
-- `cucumber-messages` ~> 12.2.0
-- Updated gems:
-
-## [7.0.0]
-### Changed
-- cucumber-gherkin ~> 13
-- cucumber-messages ~> 12
-- Updated monorepo libraries:
-
-## [6.0.0]
-### Added
-- Add `envelope` event, which are used when emitting `Cucumber::Messages`
-- Add `TestCaseCreated` and `TestStepCreated` events, emitted when compiling a `Pickle`
-- Add `Id` field to `TestCase` and `TestStep`
-- Added rubocop (with todo file), and removed backports gems
-([#186](https://github.com/cucumber/cucumber-ruby-core/pull/186),
-[#182](https://github.com/cucumber/cucumber-ruby-core/issues/182)
-[tas50](https://github.com/tas50),
-[luke-hill](https://github.com/luke-hill))
-
-### Changed
-- Update to Gherkin 10
+- Restore support for matching a scenario by its Feature, Background, and Rule line numbers ([#247](https://github.com/cucumber/cucumber-ruby-core/pull/247))
 
 ### Removed
-- Remove location for MultiLine arguments
+- Remove legacy `unindent` gem (Now no longer required since Ruby 2.3 and Squiggly heredocs) ([#278](https://github.com/cucumber/cucumber-ruby-core/pull/278))
 
-## [5.0.2]
+## [12.0.0] - 2023-09-06
 ### Changed
-- Update to use Gherkin v8
+- Update gherkin and messages minimum dependencies
+- Added in new rubocop sub-gems for testing, pinning versions where appropriate
+- Removed all redundant / incorrect rubocop config overrides (Placed in TODO file)
+- Began to refactor the repo by initially fixing up a bunch of rubocop auto-fix offenses (See PRs for details)
+([#257](https://github.com/cucumber/cucumber-ruby-core/pull/257) [#258](https://github.com/cucumber/cucumber-ruby-core/pull/258))
 
-## [5.0.1]
 ### Removed
-- Remove support for ruby 2.2 and below. 2.3 or higher is required now.
-
-## [5.0.0]
-### Changed
-- Update to use Gherkin v7
+- Remove support for ruby 2.4 and below. 2.5 or higher is required now
 
-## [4.0.0]
+## [11.1.0] - 2022-12-22
 ### Changed
-- Update to use Gherkin v6 ([#158](https://github.com/cucumber/cucumber-ruby-core/pull/158) @brasmusson)
-- Let Scenarios with no Steps get the result status Undefined ([#157](https://github.com/cucumber/cucumber-ruby-core/pull/157) @brasmusson)
-- Convert to use the Gherkin compiler and Pickles ([#156](https://github.com/cucumber/cucumber-ruby-core/pull/156) @brasmusson)
-
-### Removed
-- Remove the support for old style tag expressions ([#159](https://github.com/cucumber/cucumber-ruby-core/pull/159) @brasmusson)
-
-## [3.2.1]
-### Fixed
-- Switched `gherkin` in Gemspec to use _pessimistic_ versioning. (These two commits aren't merged into `master`, as they already exist in newer commits. This is a 'backported' patch to resolve [#160](https://github.com/cucumber/cucumber-ruby-core/issues/160)).
-
-## [3.2.0]
-### Added
-- Add the GherkinSourceParsedEvent ([#155](https://github.com/cucumber/cucumber-ruby-core/pull/155) @brasmusson)
-- Add #original_location to Cucumber::Core::Ast::Step and Cucumber::Core::Test::Step ([#150](https://github.com/cucumber/cucumber-ruby-core/pull/150), [#149](https://github.com/cucumber/cucumber-ruby-core/issues/149) @brasmusson)
+- Update gherkin and messages dependencies
 
 ### Fixed
-- Set message and backtrace for undefined result also when skipping (@brasmusson)
-
-## [3.1.0]
-### Changed
-- Upgraded to `cucumber-tag_expressions` 1.1.0
-- Upgraded to `gherkin` 5.0.0
-
-## [3.0.0]
-### Added
-- Do not create test cases for scenarios with no steps ([#144](https://github.com/cucumber/cucumber-ruby-core/pull/144) @brasmusson)
-- Handle selective strict settings ([#143](https://github.com/cucumber/cucumber-ruby-core/pull/143) @brasmusson)
+- Restore support for matching a scenario by tag and step line numbers. ([#237](https://github.com/cucumber/cucumber-ruby-core/pull/237), [#238](https://github.com/cucumber/cucumber-ruby-core/pull/238), [#239](https://github.com/cucumber/cucumber-ruby-core/pull/239))
 
+## [11.0.0] - 2022-05-18
 ### Changed
-- Step#name renamed to #text ([#137](https://github.com/cucumber/cucumber-ruby-core/pull/137) [@olleolleolle](https://github.com/olleolleolle))
-- Use past tense in event names (`xStarting` -> `xStarted`) (see [cucumber/cucumber-ruby#1166](https://github.com/cucumber/cucumber-ruby/issues/1166) @brasmusson).
-
-### Fixed
-- Fix DataTable's Location to be aware of all of its lines ([#142](https://github.com/cucumber/cucumber-ruby-core/pull/142) @botandrose)
-- As per [#251](https://github.com/cucumber/cucumber/issues/251): renamed History.md to CHANGELOG.md, added contributing message at beginning, and misc formatting. ([#145](https://github.com/cucumber/cucumber-ruby-core/pull/145) [jaysonesmith](https://github.com/jaysonesmith))
-
-## [3.0.0.pre.2]
-### Added
-- Add a flaky result type to be used for flaky scenarios ([#141](https://github.com/cucumber/cucumber-ruby-core/pull/141), [cucumber/cucumber-ruby#1044](https://github.com/cucumber/cucumber-ruby/issues/1044) @brasmusson)
-- Make the Summary report able to say if the total result is ok ([#140](https://github.com/cucumber/cucumber-ruby-core/pull/140) @brasmusson)
-- Replay previous events to new subscribers ([#136](https://github.com/cucumber/cucumber-ruby-core/pull/136) @mattwynne)
-- Ruby 2.4.0 compatibility ([#120](https://github.com/cucumber/cucumber-ruby-core/pull/120) @junaruga)
-- Use tag expressions ([#116](https://github.com/cucumber/cucumber-ruby-core/pull/116) @brasmusson)
-- Access example table row data by param name ([#118](https://github.com/cucumber/cucumber-ruby-core/pull/118) @enkessler)
-
-### Fixed
-- Travis: jruby-9.1.10.0 ([#130](https://github.com/cucumber/cucumber-ruby-core/pull/130) @olleolleolle)
-- Travis: jruby-9.1.12.0 ([#133](https://github.com/cucumber/cucumber-ruby-core/pull/132) @olleolleolle)
-
-## [2.0.0]
-### Added
-- Implement equality for test cases ([#111](https://github.com/cucumber/cucumber-ruby-core/pull/111) @mattwynne)
-- Implement an event bus (moved from Cucumber-Ruby) ([#106](https://github.com/cucumber/cucumber-ruby-core/pull/106) @mattwynne)
-- Use frozen string literals ([#105](https://github.com/cucumber/cucumber-ruby-core/pull/105) @twalpole)
-
-### Fixed
-- Handle incomplete examples to scenario outlines. ([109](https://github.com/cucumber/cucumber-ruby-core/pull/109) @brasmusson)
-- Add with_filtered_backtrace method to unknown result ([107](https://github.com/cucumber/cucumber-ruby-core/pull/107) @danascheider)
-
-### Removed
-- Remove support for Ruby v1.9.3. ([112](https://github.com/cucumber/cucumber-ruby-core/pull/112) @brasmusson)
-
-## [1.5.0]
-### Added
-- Update to Gherkin v4.0 (@brasmusson)
-
-### Fixed
-- Use monotonic time ([#103](https://github.com/cucumber/cucumber-ruby-core/pull/103) @mikz)
-
-## [1.4.0]
-### Added
-- Update to Gherkin v3.2.0 (@brasmusson)
-
-### Fixed
-
-## [1.3.1]
-### Added
-
-### Fixed
-- Speed up location filtering ([#99](https://github.com/cucumber/cucumber-ruby-core/issues/99) @mattwynne @akostadinov @brasmusson)
-
-## [1.3.0]
-### Added
-- Add factory method to Cucumber::Core::Ast::Location that uses the output from Proc#source_location (@brasmusson)
-- Integrate Gherkin3 parser (@brasmusson)
-
-### Fixed
-- Make sure that `after_test_step` is sent also when a test step is interrupted by (a timeout in) an around hook ([cucumber/cucumber-ruby#909](https://github.com/cucumber/cucumber-ruby/issues/909) @brasmusson)
-- Improve the check that a test_step quacks like a Cucumber::Core::Test::Step ([95](https://github.com/cucumber/cucumber-ruby-core/issues/95) @brasmusson)
-
-## [1.2.0]
-### Added
-- Enable the location of actions to be the step or hook location (@brasmusson)
-- Add the comments to the Steps, Examples tables and Examples table rows Ast classes (@brasmusson)
-- Expose name, description and examples_rows attributes of `Ast::ExamplesTable` (@mattwynne)
-- Add #to_sym to Cucumber::Core::Test::Result classes ([#89](https://github.com/cucumber/cucumber-ruby-core/pull/89) @pdswan)
-- Add #ok? to Cucumber::Core::Test::Result classes ([#92](https://github.com/cucumber/cucumber-ruby-core/pull/92) @brasmusson)
-
-### Fixed
-
-## [1.1.3]
-### Added
-- Added custom `inspect` methods for AST Nodes (@tooky)
-
-## [1.1.2]
-### Added
-- Make Test Case names for Scenario Outlines language neutral [83](https://github.com/cucumber/cucumber-ruby-core/pull/83) (@brasmusson)
-- Add predicate methods for Multline arguments (@mattwynne)
-- Expose `Test::Case#feature` (@mattwynne)
-- Fail test case if around hook fails (@mattwynne, @tooky)
-- Expose `Test::Case#around_hooks` (@tooky)
-
-## [1.1.1]
-### Added
-- Calculate actual keyword for snippets (@brasmusson)
-
-### Fixed
-- Remove keyword from `Test::Case#name` [82](https://github.com/cucumber/cucumber-ruby-core/pull/82) (@richarda)
-
-## [1.1.0]
-### Added
-- LocationsFilter now sorts test cases as well as filtering them (@mattwynne)
-
-## [1.0.0]
-### Added
-- Added dynamic filter class constructor (@mattwynne)
-
-## [1.0.0.beta.4]
-### Added
-- Introduce a Duration object (#[71](https://github.com/cucumber/cucumber-ruby-core/pull/71) [@brasmusson](https://github.com/brasmusson))
-- BeforeStep hooks (#[70](https://github.com/cucumber/cucumber-ruby-core/pull/70) [@almostwhitehat](https://github.com/almostwhitehat))
-- Expose `Test::Case#test_steps` (@mattwynne)
-
-### Fixed
-- Handle empty feature files (#[77](https://github.com/cucumber/cucumber-ruby-core/pull/77), [cucumber/cucumber-ruby#771](https://github.com/cucumber/cucumber-ruby/issues/771) [@brasmusson](https://github.com/brasmusson))
-- Run after hooks in reverse order (#[69](https://github.com/cucumber/cucumber-ruby-core/pull/69) [@erran](https://github.com/erran))
-
-## [1.0.0.beta.3]
-
-## [1.0.0.beta.2]
-
-## [1.0.0.beta.3]
-
-## [1.0.0.beta.2]
+- Updated `cucumber-gherkin` and `cucumber-messages`
 
-[Unreleased]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.1.1...main
-[12.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.1.1...main
-[11.1.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.1.1...main
+[Unreleased]: https://github.com/cucumber/cucumber-ruby-core/compare/v13.0.0...HEAD
+[13.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v12.0.0...v13.0.0
+[12.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v11.1.0...v12.0.0
+[11.1.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v11.0.0...v11.1.0
 [11.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.1.1...v11.0.0
-[10.1.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.1.0...v10.1.1
-[10.1.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.0.1...v10.1.0
-[10.0.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v10.0.0...v10.0.1
-[10.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v9.0.1...v10.0.0
-[9.0.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v9.0.0...v9.0.1
-[9.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v8.0.1...v9.0.0
-[8.0.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v8.0.0...v8.0.1
-[8.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v7.1.0...v8.0.0
-[7.1.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v7.0.0...v7.1.0
-[7.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v6.0.0...v7.0.0
-[6.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v5.0.2...v6.0.0
-[5.0.2]: https://github.com/cucumber/cucumber-ruby-core/compare/v5.0.1...v5.0.2
-[5.0.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v5.0.0...v5.0.1
-[5.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v4.0.0...v5.0.0
-[4.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v3.2.0...v4.0.0
-[3.2.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v3.2.0...v3.2.1
-[3.2.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v3.1.0...v3.2.0
-[3.1.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v3.0.0...3.1.0
-[3.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v3.0.0.pre.2...v3.0.0
-[3.0.0.pre.2]: https://github.com/cucumber/cucumber-ruby-core/compare/v2.0.0...3.0.0.pre.2
-[2.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.5.0...2.0.0
-[1.5.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.4.0...v1.5.0
-[1.4.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.3.1...v1.4.0
-[1.3.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.3.0...v1.3.1
-[1.3.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.2.0...v1.3.0
-[1.2.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.3...v1.2.0
-[1.1.3]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.2...v1.1.3
-[1.1.2]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.1...v1.1.2
-[1.1.1]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.1.0...v1.1.1
-[1.1.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0...v1.1.0
-[1.0.0]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.4...v1.0.0
-[1.0.0.beta.4]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.3...v1.0.0.beta.4
-[1.0.0.beta.3]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.2...v1.0.0.beta.3
-[1.0.0.beta.2]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.1...v1.0.0.beta.2
-[1.0.0.beta.3]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.2...v1.0.0.beta.3
-[1.0.0.beta.2]: https://github.com/cucumber/cucumber-ruby-core/compare/v1.0.0.beta.1...v1.0.0.beta.2

data/lib/cucumber/core/compiler.rb

@@ -37,17 +37,18 @@ module Cucumber
       def create_test_case(pickle)
         uri = pickle.uri
         test_steps = pickle.steps.map { |step| create_test_step(step, uri) }
-        lines = source_lines_for_pickle(pickle).sort.reverse
-        tags = pickle.tags.map { |tag| Test::Tag.new(Test::Location.new(uri, source_line_for_pickle_tag(tag)), tag.name) }
-        test_case = Test::Case.new(id_generator.new_id, pickle.name, test_steps, Test::Location.new(uri, lines), tags, pickle.language)
+        location = location_from_pickle(pickle)
+        parent_locations = parent_locations_from_pickle(pickle)
+        tags = tags_from_pickle(pickle, uri)
+        test_case = Test::Case.new(id_generator.new_id, pickle.name, test_steps, location, parent_locations, tags, pickle.language)
         @event_bus&.test_case_created(test_case, pickle)
         test_case
       end
 
       def create_test_step(pickle_step, uri)
-        lines = source_lines_for_pickle_step(pickle_step).sort.reverse
+        location = location_from_pickle_step(pickle_step, uri)
         multiline_arg = create_multiline_arg(pickle_step, uri)
-        step = Test::Step.new(id_generator.new_id, pickle_step.text, Test::Location.new(uri, lines), multiline_arg)
+        step = Test::Step.new(id_generator.new_id, pickle_step.text, location, multiline_arg)
         @event_bus&.test_step_created(step, pickle_step)
         step
       end
@@ -55,37 +56,57 @@ module Cucumber
       def create_multiline_arg(pickle_step, _uri)
         if pickle_step.argument
           if pickle_step.argument.doc_string
-            doc_string = pickle_step.argument.doc_string
-            Test::DocString.new(
-              doc_string.content,
-              doc_string.media_type
-            )
+            doc_string_from_pickle_step(pickle_step)
           elsif pickle_step.argument.data_table
-            data_table = pickle_step.argument.data_table
-            Test::DataTable.new(
-              data_table.rows.map { |row| row.cells.map { |cell| cell.value } }
-            )
+            data_table_from_pickle_step(pickle_step)
           end
         else
           Test::EmptyMultilineArgument.new
         end
       end
 
-      def source_lines_for_pickle(pickle)
-        pickle.ast_node_ids.map { |id| source_line(id) }
+      def location_from_pickle(pickle)
+        lines = pickle.ast_node_ids.map { |id| source_line(id) }
+        Test::Location.new(pickle.uri, lines.sort.reverse)
       end
 
-      def source_lines_for_pickle_step(pickle_step)
-        pickle_step.ast_node_ids.map { |id| source_line(id) }
+      def parent_locations_from_pickle(pickle)
+        parent_lines = gherkin_query.scenario_parent_locations(pickle.ast_node_ids[0]).map(&:line)
+        Test::Location.new(pickle.uri, parent_lines)
       end
 
-      def source_line_for_pickle_tag(tag)
-        source_line(tag.ast_node_id)
+      def location_from_pickle_step(pickle_step, uri)
+        lines = pickle_step.ast_node_ids.map { |id| source_line(id) }
+        Test::Location.new(uri, lines.sort.reverse)
+      end
+
+      def tags_from_pickle(pickle, uri)
+        pickle.tags.map do |tag|
+          location = Test::Location.new(uri, source_line(tag.ast_node_id))
+          Test::Tag.new(location, tag.name)
+        end
       end
 
       def source_line(id)
         gherkin_query.location(id).line
       end
+
+      def doc_string_from_pickle_step(pickle_step)
+        doc_string = pickle_step.argument.doc_string
+        Test::DocString.new(
+          doc_string.content,
+          doc_string.media_type
+        )
+      end
+
+      def data_table_from_pickle_step(pickle_step)
+        data_table = pickle_step.argument.data_table
+        Test::DataTable.new(
+          data_table.rows.map do |row|
+            row.cells.map(&:value)
+          end
+        )
+      end
     end
   end
 end

data/lib/cucumber/core/event.rb

@@ -1,61 +1,60 @@
+# frozen_string_literal: true
+
 module Cucumber
   module Core
     class Event
-
       # Macro to generate new sub-classes of {Event} with
       # attribute readers.
-      def self.new(*attributes)
+      def self.new(*events)
         # Use normal constructor for subclasses of Event
-        return super if self.ancestors.index(Event) > 0
+        return super if ancestors.index(Event) > 0
 
         Class.new(Event) do
-          attr_reader(*attributes)
-
-          define_method(:initialize) do |*args|
-            attributes.zip(args) do |name, value|
-              instance_variable_set "@#{name}".to_sym, value
+          # NB: We need to use metaprogramming here instead of direct variable obtainment
+          # because JRuby does not guarantee the order in which variables are defined is equivalent
+          # to the order in which they are obtainable
+          #
+          # See https://github.com/jruby/jruby/issues/7988 for more info
+          attr_reader(*events)
+
+          define_method(:initialize) do |*attributes|
+            events.zip(attributes) do |name, value|
+              instance_variable_set("@#{name}".to_sym, value)
             end
           end
 
           define_method(:attributes) do
-            attributes.map { |attribute| self.send(attribute) }
+            events.map { |var| instance_variable_get(:"@#{var}") }
           end
 
           define_method(:to_h) do
-            attributes.reduce({}) { |result, attribute|
-              value = self.send(attribute)
-              result[attribute] = value
-              result
-            }
+            events.zip(attributes).to_h
           end
 
-          define_method(:event_id) do
+          def event_id
             self.class.event_id
           end
         end
       end
 
-
       class << self
-
-        # @return [Symbol] the underscored name of the class to be used
-        #                  as the key in an event registry.
+        # @return [Symbol] the underscored name of the class to be used as the key in an event registry
         def event_id
-          underscore(self.name.split("::").last).to_sym
+          underscore(name.split('::').last).to_sym
         end
 
         private
 
         def underscore(string)
-          string.to_s.gsub('::', '/').
-          gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').
-          gsub(/([a-z\d])([A-Z])/, '\1_\2').
-          tr("-", "_").
-          downcase
+          string
+            .to_s
+            .gsub('::', '/').
+            gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').
+            gsub(/([a-z\d])([A-Z])/, '\1_\2').
+            tr('-', '_').
+            downcase
         end
-
       end
-
     end
   end
 end

data/lib/cucumber/core/event_bus.rb

@@ -1,13 +1,13 @@
+# frozen_string_literal: true
+
 require 'cucumber/core/events'
 
 module Cucumber
   module Core
-
     # Event Bus
     #
     # Implements an in-process pub-sub event broadcaster allowing multiple observers
     # to subscribe to events that fire as your tests are executed.
-    #
     class EventBus
       attr_reader :event_types
 
@@ -18,8 +18,7 @@ module Cucumber
         @event_queue = []
       end
 
-      # Register for an event. The handler proc will be called back with each of the attributes
-      # of the event.
+      # Register for an event. The handler proc will be called back with each of the attributes of the event
       def on(event_id, handler_object = nil, &handler_proc)
         handler = handler_proc || handler_object
         validate_handler_and_event_id!(handler, event_id)
@@ -28,9 +27,8 @@ module Cucumber
         broadcast_queued_events_to handler, event_class
       end
 
-      # Broadcast an event
       def broadcast(event)
-        raise ArgumentError, "Event type #{event.class} is not registered. Try one of these:\n#{event_types.values.join("\n")}" unless is_registered_type?(event.class)
+        raise ArgumentError, "Event type #{event.class} is not registered. Try one of these:\n#{event_types.values.join("\n")}" unless registered_type?(event.class)
         handlers_for(event.class).each { |handler| handler.call(event) }
         @event_queue << event
       end
@@ -40,34 +38,33 @@ module Cucumber
         broadcast event_class.new(*args)
       end
 
+      def respond_to_missing?(event_id, *args)
+        event_types.key?(event_id) || super
+      end
+
       private
 
       def broadcast_queued_events_to(handler, event_type)
-        @event_queue.select { |event|
-          event.instance_of?(event_type)
-        }.each { |event|
-          handler.call(event)
-        }
+        @event_queue.select { |event| event.instance_of?(event_type) }.each { |event| handler.call(event) }
       end
 
       def handlers_for(event_class)
         @handlers[event_class.to_s] ||= []
       end
 
-      def is_registered_id?(event_id)
-        event_types.keys.include?(event_id)
+      def registered_type?(event_type)
+        event_types.values.include?(event_type)
       end
 
-      def is_registered_type?(event_type)
-        event_types.values.include?(event_type)
+      def registered_id?(event_id)
+        event_types.keys.include?(event_id)
       end
 
       def validate_handler_and_event_id!(handler, event_id)
-        raise ArgumentError, "Please pass either an object or a handler block" unless handler
-        raise ArgumentError, "Please use a symbol for the event_id" unless event_id.is_a?(Symbol)
-        raise ArgumentError, "Event ID #{event_id} is not recognised. Try one of these:\n#{event_types.keys.join("\n")}" unless is_registered_id?(event_id)
+        raise ArgumentError, 'Please pass either an object or a handler block' unless handler
+        raise ArgumentError, 'Please use a symbol for the event_id' unless event_id.is_a?(Symbol)
+        raise ArgumentError, "Event ID #{event_id} is not recognised. Try one of these:\n#{event_types.keys.join("\n")}" unless registered_id?(event_id)
       end
     end
-
   end
 end