cuba-sendfile 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0084ae1453a3893ad7604b40124c24a73c248e15
-  data.tar.gz: a021a95ccbbfaba97470fa001dc7f70838ed53a8
+  metadata.gz: 54b99567f95e4589cd7887ec97b1dd3720ea18cc
+  data.tar.gz: 24dea4bfd2c0cf32ff09a406c150490372e509ce
 SHA512:
-  metadata.gz: a58f9109dc76cd561566282708b8866bb5ae47821a92a9ffe69d3ffef00e9104858cff3b4261292d373a96bf38bebd9e53173bf707bdf7c6602ccd9cc08547e4
-  data.tar.gz: b8af6b451fde9b6567dbe3e0671f47b3695c1ed6102a3582ca1e18ef14be1e061d6f5f34362a5244529b1473c2be7fc8ebdc0134276025e769b16dd9a817cd5b
+  metadata.gz: 1cb2f5f844556602a43341d7c55985ca6041e4a13f67343ac6d6b071c020404fc592075ec12f9ccc4f6be7d98d8b627008d5d45bd2096abcd9ac5e08b98fe5e5
+  data.tar.gz: fe91e2e44c214c41a58bbb1da138bb252b55f4482ba950bb4dcf2edab1c39307268546f4de826b6b0ca4289d5a9bfc8fe1f0d69b30c698b02ca63d81f6aeca13

data/README.md

@@ -10,23 +10,32 @@ Usage
 require "cuba"
 require "cuba/send_file"
 
-Cuba.plugin(Cuba::SendFile)
+Cuba.plugin(SendFile)
 
 Cuba.define do
-  on root do
-    send_file("foo.png")
-  end
-
-  on "/download" do
-    disposition = 'attachment; filename="foo.png"'
-    send_file("foo.png", "Content-Disposition" => disposition)
+  on "foo" do
+    send_file("foo.pdf")
   end
 end
 ```
 
+For **attachments**, it's recommended to use the HTML5 [download][download] attribute.
+
+```html
+<a href="/foo" download>Download foo</a>
+```
+
+You can specify a filename too:
+
+```html
+<a href="/foo" download="bar.pdf">Download bar</a>
+```
+
 Installation
 ------------
 
 ```
 $ gem install cuba-sendfile
 ```
+
+[download]: http://davidwalsh.name/download-attribute

data/cuba-sendfile.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name        = "cuba-sendfile"
-  s.version     = "0.0.1"
-  s.summary     = "File sending for Cuba"
+  s.version     = "0.0.2"
+  s.summary     = "File sending for Cuba."
   s.description = s.summary
   s.authors     = ["Francesco Rodríguez"]
   s.email       = ["frodsan@me.com"]

data/lib/cuba/send_file.rb

@@ -1,12 +1,8 @@
-class Cuba
-  module SendFile
-    def send_file(path, headers = {})
-      file = Rack::File.new(nil, headers)
-      file.path = path
+module SendFile
+  def send_file(path)
+    file = Rack::File.new(nil)
+    file.path = path
 
-      result = file.serving(env)
-
-      halt([result[0], result[1], file])
-    end
+    halt(file.serving(env))
   end
 end

data/test/send_file.rb

@@ -3,16 +3,12 @@ require_relative "../lib/cuba/send_file"
 
 FILE = __dir__ + "/foo.txt"
 
-Cuba.plugin(Cuba::SendFile)
+Cuba.plugin(SendFile)
 
 Cuba.define do
   on root do
     send_file(FILE)
   end
-
-  on "custom" do
-    send_file(FILE, "Content-Disposition" => "disposition")
-  end
 end
 
 scope do
@@ -30,10 +26,4 @@ scope do
     assert_equal "Hello World\n".length.to_s, last_response["Content-Length"]
     assert_equal File.mtime(FILE).httpdate, last_response["Last-Modified"]
   end
-
-  test "sets custom header" do
-    get "/custom"
-
-    assert_equal "disposition", last_response["Content-Disposition"]
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cuba-sendfile
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Francesco Rodríguez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-05 00:00:00.000000000 Z
+date: 2014-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cuba
@@ -52,7 +52,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: File sending for Cuba
+description: File sending for Cuba.
 email:
 - frodsan@me.com
 executables: []
@@ -89,5 +89,5 @@ rubyforge_project:
 rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
-summary: File sending for Cuba
+summary: File sending for Cuba.
 test_files: []