csvlint 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: a5c033caad4d4ee2536ecf2af837461a946151e1
-  data.tar.gz: 1c9d644f1295bbbeb2c160828d3a520f6b35999c
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    NzY4MzE5MGI1OWI4YzkzY2U1MTZlMWJjNDM4YzM5ZjNiMWI5ZWIyMA==
+  data.tar.gz: !binary |-
+    OTM5MWJmYzNkYTBiMjM4ZGU3Yjc2NTY0Njk4OTEzMDJhNmI2Yjg5Mg==
 SHA512:
-  metadata.gz: cf5029278e55511925b7abad559489810d8e56555ea46afd68960af2d18db786a6f0df2afa30ba4bcd99c1ea9d149d570536e94b84d45ce9bdae837d395dc1f2
-  data.tar.gz: 56f23ba6e7b701af2e7ec575519d46e7b4c29bfa6403f123359b89d58c1191df65166b3739a663b1febc66d8c54f9a339394ca74a890e42ccba2fb6cb03fc4d3
+  metadata.gz: !binary |-
+    YzU4NzJmZTlkYWE1NTY0MGY4NzY0N2Q1NDYxMzI1N2YxYjZhZThmNDZhMDVj
+    Mjc1YmMyZGZkODhlNDE4OWZiYWM5NmVjNTNiOGRmMjI0OGY4ZjJkY2I4OTNl
+    ZmYwMGMwN2YwOWNlYmUzNjZjNWU3OTEzYTIwZDYzMGMzZDBiOGQ=
+  data.tar.gz: !binary |-
+    YTkwNWVlNjlmZGZkZDJjNmUyZGQxMzBkYzViOTc1NzlhNjYzYjU3ZDljMmRl
+    YzExNDFkMDUxOThkMjJkNDRkZWYxZjNlMzdmYTRmNjI1MTliNGYzOWQxYzY3
+    MGIxMjA1YzhkYjUwOWZkOGU2NjViYjNlNjBhMTY4NTY0N2E4MmI=

data/.travis.yml

@@ -3,8 +3,26 @@ rvm:
 notifications:
   irc:
     channels:
-      - "irc.freenode.net#theodi"
+    - irc.freenode.net#theodi
     template:
-      - "%{repository} %{branch} - %{message} %{build_url}"
+    - '%{repository} %{branch} - %{message} %{build_url}'
     on_success: change
-    on_failure: always
+    on_failure: always
+deploy:
+  provider: rubygems
+  api_key:
+    secure: fjnPS61/skQ1PsRJu1SYWIct0vjdkTyQhj0ria9zfcJfbWbfiHnpehVh1ege3sTUkDSTvoOFT35jzEeozvtKZOlAWMU5QbL8LTXu+JSp9olOdSuGeWRWVuQT3NLgRJW0+2c7N66piZvnRUUTyt2P8VIR8c/Ltuhc32bUGL7X6Gw=
+  gem: csvlint
+  on:
+    tags: true
+    repo: theodi/csvlint.rb
+    all_branches: true
+after_success:
+- export GEM_VERSION=`ruby -e "puts Gem::Specification.load(Dir['*.gemspec'].first).version.to_s"`
+- '[ "$TRAVIS_BRANCH" == "master" ] && [ "$TRAVIS_PULL_REQUEST" == "false" ] && curl
+  -v -X POST -d ''{"ref":"refs/tags/''$GEM_VERSION''","sha":"''$TRAVIS_COMMIT''"}''  --header
+  "Content-Type:application/json" -u $GITHUB_USER:$GITHUB_PASSWORD "https://api.github.com/repos/$TRAVIS_REPO_SLUG/git/refs"'
+env:
+  global:
+  - secure: hM8Pv/EAZoB4fGGEUwKQQ/2+mgKbUac+PH2cwud25l2MJ64eoKEMZzfy4TF6+XMIzXhlWpsg4s51y6K3+W8pUyRAuwo2MsN5Iee7HnLz+LlYTiT0//iQdAmxQ0JlOyh8vd2SEFBcVfwpp/iZFIHAfbBO73ZDXhtGMEieMk025I0=
+  - secure: hsKbZ0kVKVU/e8oVCPJpRmBxbbieN2tVbyjdhJo/UYchcyLWeGAmAj/ApUDL4SyR0HZxpfi+SIsGFNRy5LnrFeCFgY9aZ6u9ma4n0Y2cTElMRt5kvI/c28FehsRjCzAe6W8dxwhJ8wSkvFDNpLml47/iy8bw4a7aUZDdq3OYXck=

data/README.md

@@ -157,7 +157,7 @@ An example schema file is:
 
 Parsing and validating with a schema:
 
-	schema = Schema.load_from_json_table(uri)
+	schema = Csvlint::Schema.load_from_json_table(uri)
 	validator = Csvlint::Validator.new( "http://example.org/data.csv", nil, schema )
 
 Supported constraints:

data/features/step_definitions/validation_info_steps.rb

@@ -13,6 +13,6 @@ Then(/^there should be (\d+) info messages?$/) do |num|
   @info_messages.count.should == num.to_i
 end
 
-Then(/^that message should have the type "(.*?)"$/) do |msg_type|
-  @info_messages.first.type.should == msg_type.to_sym
+Then(/^one of the messages should have the type "(.*?)"$/) do |msg_type|
+  @info_messages.find{|x| x.type == msg_type.to_sym}.should be_present
 end

data/features/validation_info.feature

@@ -5,20 +5,20 @@ Feature: Get validation information messages
     And it is stored at the url "http://example.com/example1.csv"
     And I set header to "true" 
     And I ask if there are info messages
-    Then there should be 1 info message
-    And that message should have the type "nonrfc_line_breaks"
+    Then there should be 2 info messages
+    And one of the messages should have the type "nonrfc_line_breaks"
 
   Scenario: CR line endings in file give an info message
     Given I have a CSV file called "cr-line-endings.csv"
     And it is stored at the url "http://example.com/example1.csv"
     And I set header to "true" 
     And I ask if there are info messages
-    Then there should be 1 info message
-    And that message should have the type "nonrfc_line_breaks"
+    Then there should be 2 info messages
+    And one of the messages should have the type "nonrfc_line_breaks"
 
   Scenario: CRLF line endings in file produces no info messages
     Given I have a CSV file called "crlf-line-endings.csv"
     And it is stored at the url "http://example.com/example1.csv"
     And I set header to "true" 
     And I ask if there are info messages
-    Then there should be 0 info messages
+    Then there should be 1 info message

data/lib/csvlint.rb

@@ -1,4 +1,3 @@
-require "csvlint/version"
 require 'csv'
 require 'open-uri'
 require 'mime/types'

data/lib/csvlint/error_collector.rb

@@ -1,43 +1,25 @@
 module Csvlint
-  
   module ErrorCollector
-      
-    def build_message(type, category, row, column, content, constraints)
-      Csvlint::ErrorMessage.new({
-                                  :type => type,
-                                  :category => category,
-                                  :row => row,
-                                  :column => column,
-                                  :content => content,
-                                  :constraints => constraints
-                                })
+    attr_reader :errors, :warnings, :info_messages
+
+    def build_errors(type, category = nil, row = nil, column = nil, content = nil, constraints = {})
+      @errors << Csvlint::ErrorMessage.new(type, category, row, column, content, constraints)
     end
-    
-    MESSAGE_LEVELS = [
-      :errors,
-      :warnings,
-      :info_messages
-    ]
-    
-    MESSAGE_LEVELS.each do |level|
-      
-      attr_reader level
-      
-      define_method "build_#{level}" do |type, category = nil, row = nil, column = nil, content = nil, constraints = {}|
-        instance_variable_get("@#{level}") << build_message(type, category, row, column, content, constraints)
-      end
-      
+    def build_warnings(type, category = nil, row = nil, column = nil, content = nil, constraints = {})
+      @warnings << Csvlint::ErrorMessage.new(type, category, row, column, content, constraints)
     end
-    
+    def build_info_messages(type, category = nil, row = nil, column = nil, content = nil, constraints = {})
+      @info_messages << Csvlint::ErrorMessage.new(type, category, row, column, content, constraints)
+    end
+
     def valid?
       errors.empty?
     end
-    
+
     def reset
-      MESSAGE_LEVELS.each do |level|
-        instance_variable_set("@#{level}", [])
-      end
+      @errors = []
+      @warnings = []
+      @info_messages = []
     end
-    
   end
-end
+end

data/lib/csvlint/error_message.rb

@@ -1,15 +1,14 @@
 module Csvlint
-
   class ErrorMessage
-  
     attr_reader :type, :category, :row, :column, :content, :constraints
-  
-    def initialize(params)
-      params.each do |key, value|
-        self.instance_variable_set("@#{key}".to_sym, value)
-      end
+
+    def initialize(type, category, row, column, content, constraints)
+      @type = type
+      @category = category
+      @row = row
+      @column = column
+      @content = content
+      @constraints = constraints
     end
-  
   end
-
-end
+end

data/lib/csvlint/types.rb

@@ -4,54 +4,79 @@ require 'active_support/core_ext/date/conversions'
 require 'active_support/core_ext/time/conversions'
 
 module Csvlint
-  
   module Types
-    
     SIMPLE_FORMATS = {
-      'string'  => lambda { |value, constraints| value },
-      'numeric'     => lambda do |value, constraints| 
-        begin
-          Integer value 
-        rescue ArgumentError
-          Float value
+      'string' => lambda { |value| true },
+      'numeric' => lambda { |value| value.strip[/\A[-+]?\d*\.?\d+(?:[eE][-+]?\d+)?\z/] },
+      'uri' => lambda do |value|
+        if value.strip[/\Ahttps?:/]
+          u = URI.parse(value)
+          u.kind_of?(URI::HTTP) || u.kind_of?(URI::HTTPS)
         end
-      end,
-      'uri'  => lambda do |value, constraints|
-        u = URI.parse value
-        raise ArgumentError unless u.kind_of?(URI::HTTP) || u.kind_of?(URI::HTTPS)
-        u
       end
     }
-    
-    def self.date_format(klass = DateTime, value, type)
-      date = klass.strptime(value, klass::DATE_FORMATS[type])
-      raise ArgumentError unless date.to_formatted_s(type) == value
+
+    def self.date_format(klass, value, format, pattern)
+      if value[pattern]
+        klass.strptime(value, format).strftime(format) == value
+      end
     end
-    
+
     def self.included(base)
-      Time::DATE_FORMATS[:iso8601] = "%Y-%m-%dT%H:%M:%SZ"
-      Time::DATE_FORMATS[:hms] = "%H:%M:%S"
-      
-      Date::DATE_FORMATS.each do |type|
-        SIMPLE_FORMATS["date_#{type.first}"] = lambda do |value, constraints|
-          date_format(Date, value, type.first)
+      [
+        [ :db, "%Y-%m-%d",
+               /\A\d{4,}-\d\d-\d\d\z/],
+        [ :number, "%Y%m%d",
+                   /\A\d{8}\z/],
+        [ :short, "%e %b",
+                  /\A[ \d]\d (?:#{Date::ABBR_MONTHNAMES.join('|')})\z/],
+        [ :rfc822, "%e %b %Y",
+                   /\A[ \d]\d (?:#{Date::ABBR_MONTHNAMES.join('|')}) \d{4,}\z/],
+        [ :long, "%B %e, %Y",
+                 /\A(?:#{Date::MONTHNAMES.join('|')}) [ \d]\d, \d{4,}\z/],
+      ].each do |type,format,pattern|
+        SIMPLE_FORMATS["date_#{type}"] = lambda do |value|
+          date_format(Date, value, format, pattern)
         end
       end
-    
-      Time::DATE_FORMATS.each do |type|
-        SIMPLE_FORMATS["dateTime_#{type.first}"] = lambda do |value, constraints|
-          date_format(Time, value, type.first)
+
+      # strptime doesn't support widths like %9N, unlike strftime.
+      # @see http://ruby-doc.org/stdlib-2.0/libdoc/date/rdoc/DateTime.html
+      [
+        [ :time,    "%H:%M",
+                    /\A\d\d:\d\d\z/],
+        [ :hms,     "%H:%M:%S",
+                    /\A\d\d:\d\d:\d\d\z/],
+        [ :db,      "%Y-%m-%d %H:%M:%S",
+                    /\A\d{4,}-\d\d-\d\d \d\d:\d\d:\d\d\z/],
+        [ :iso8601, "%Y-%m-%dT%H:%M:%SZ",
+                    /\A\d{4,}-\d\d-\d\dT\d\d:\d\d:\d\dZ\z/],
+        [ :number,  "%Y%m%d%H%M%S",
+                    /\A\d{14}\z/],
+        [ :nsec,    "%Y%m%d%H%M%S%N",
+                    /\A\d{23}\z/],
+        [ :short,   "%d %b %H:%M",
+                    /\A\d\d (?:#{Date::ABBR_MONTHNAMES.join('|')}) \d\d:\d\d\z/],
+        [ :long,    "%B %d, %Y %H:%M",
+                    /\A(?:#{Date::MONTHNAMES.join('|')}) \d\d, \d{4,} \d\d:\d\d\z/],
+      ].each do |type,format,pattern|
+        SIMPLE_FORMATS["dateTime_#{type}"] = lambda do |value|
+          date_format(Time, value, format, pattern)
         end
       end
     end
-        
+
     TYPE_VALIDATIONS = {
-        'http://www.w3.org/2001/XMLSchema#string'  => SIMPLE_FORMATS['string'],
+        'http://www.w3.org/2001/XMLSchema#string'  => lambda { |value, constraints| value },
         'http://www.w3.org/2001/XMLSchema#int'     => lambda { |value, constraints| Integer value },
         'http://www.w3.org/2001/XMLSchema#integer' => lambda { |value, constraints| Integer value },
         'http://www.w3.org/2001/XMLSchema#float'   => lambda { |value, constraints| Float value },
         'http://www.w3.org/2001/XMLSchema#double'   => lambda { |value, constraints| Float value },
-        'http://www.w3.org/2001/XMLSchema#anyURI'  => SIMPLE_FORMATS['uri'],
+        'http://www.w3.org/2001/XMLSchema#anyURI'  => lambda do |value, constraints|
+          u = URI.parse value
+          raise ArgumentError unless u.kind_of?(URI::HTTP) || u.kind_of?(URI::HTTPS)
+          u
+        end,
         'http://www.w3.org/2001/XMLSchema#boolean' => lambda do |value, constraints|
           return true if ['true', '1'].include? value
           return false if ['false', '0'].include? value
@@ -100,14 +125,13 @@ module Csvlint
           d = Date.strptime(value, date_pattern)
           raise ArgumentError unless d.strftime(date_pattern) == value
           d
-        end,     
+        end,
         'http://www.w3.org/2001/XMLSchema#gYearMonth' => lambda do |value, constraints|
           date_pattern = constraints["datePattern"] || "%Y-%m"
           d = Date.strptime(value, date_pattern)
           raise ArgumentError unless d.strftime(date_pattern) == value
           d
-        end 
+        end,
     }
   end
-
 end

data/lib/csvlint/validate.rb

@@ -20,14 +20,9 @@ module Csvlint
       @formats = []
       @schema = schema
       
-      @assumed_header = true
       @supplied_dialect = dialect != nil
-      
-      if dialect
-        @assumed_header = false
-      end
-      
-      @dialect = dialect_defaults = {
+            
+      @dialect = {
         "header" => true,
         "delimiter" => ",",
         "skipInitialSpace" => true,
@@ -50,8 +45,9 @@ module Csvlint
         io = @source.respond_to?(:gets) ? @source : open(@source, :allow_redirections=>:all)
         validate_metadata(io)
         parse_csv(io)
-        unless @col_counts.inject(:+).nil?
-          build_warnings(:title_row, :structure) if @col_counts.first < (@col_counts.inject(:+) / @col_counts.count)
+        sum = @col_counts.inject(:+)
+        unless sum.nil?
+          build_warnings(:title_row, :structure) if @col_counts.first < (sum / @col_counts.size.to_f)
         end
         build_warnings(:check_options, :structure) if @expected_columns == 1        
         check_consistency      
@@ -66,11 +62,18 @@ module Csvlint
       @encoding = io.charset rescue nil
       @content_type = io.content_type rescue nil
       @headers = io.meta rescue nil    
+      assumed_header = undeclared_header = !@supplied_dialect
       if @headers
+        if @headers["content-type"] =~ /text\/csv/
+          @csv_header = true
+          undeclared_header = false
+          assumed_header = true
+        end
         if @headers["content-type"] =~ /header=(present|absent)/
           @csv_header = true if $1 == "present"
           @csv_header = false if $1 == "absent"
-          @assumed_header = false
+          undeclared_header = false
+          assumed_header = false
         end
         if @headers["content-type"] !~ /charset=/
           build_warnings(:no_encoding, :context) 
@@ -81,12 +84,13 @@ module Csvlint
         build_warnings(:excel, :context) if @content_type == nil && @extension =~ /.xls(x)?/
         build_errors(:wrong_content_type, :context) unless (@content_type && @content_type =~ /text\/csv/)
         
-        if @assumed_header && !@supplied_dialect && (@content_type == nil || @headers["content-type"] !~ /header=(present|absent)/ )
+        if undeclared_header
           build_errors(:undeclared_header, :structure)
+          assumed_header = false
         end
         
       end
-      build_info_messages(:assumed_header, :structure) if @assumed_header
+      build_info_messages(:assumed_header, :structure) if assumed_header
     end
     
     def parse_csv(io)
@@ -109,27 +113,27 @@ module Csvlint
         loop do
          current_line = current_line + 1
          begin
+           wrapper.reset_line
            row = csv.shift
            @data << row
-           wrapper.finished
            if row             
-             if header? && current_line == 1
+             if current_line == 1 && header?
                row = row.reject {|r| r.blank? }
                validate_header(row)
-               @col_counts << row.count
+               @col_counts << row.size
              else               
                build_formats(row, current_line)
-               @col_counts << row.reject {|r| r.blank? }.count
-               @expected_columns = row.count unless @expected_columns != 0
+               @col_counts << row.reject {|r| r.blank? }.size
+               @expected_columns = row.size unless @expected_columns != 0
                
-               build_errors(:blank_rows, :structure, current_line, nil, wrapper.line) if row.reject{ |c| c.nil? || c.empty? }.count == 0
+               build_errors(:blank_rows, :structure, current_line, nil, wrapper.line) if row.reject{ |c| c.nil? || c.empty? }.size == 0
                
                if @schema
                  @schema.validate_row(row, current_line)
                  @errors += @schema.errors
                  @warnings += @schema.warnings
                else
-                 build_errors(:ragged_rows, :structure, current_line, nil, wrapper.line) if !row.empty? && row.count != @expected_columns
+                 build_errors(:ragged_rows, :structure, current_line, nil, wrapper.line) if !row.empty? && row.size != @expected_columns
                end
                
              end
@@ -137,7 +141,6 @@ module Csvlint
              break
            end         
          rescue CSV::MalformedCSVError => e
-           wrapper.finished
            type = fetch_error(e)
            if type == :stray_quote && !wrapper.line.match(csv.row_sep)
              build_errors(:line_breaks, :structure)
@@ -147,7 +150,6 @@ module Csvlint
          end
       end
       rescue ArgumentError => ae
-        wrapper.finished           
         build_errors(:invalid_encoding, :structure, current_line, wrapper.line) unless reported_invalid_encoding
         reported_invalid_encoding = true
       end
@@ -172,7 +174,7 @@ module Csvlint
     end
     
     def header?
-      return @csv_header
+      @csv_header
     end
     
     def fetch_error(error)
@@ -200,10 +202,10 @@ module Csvlint
         
         SIMPLE_FORMATS.each do |type, lambda|
           begin
-            lambda.call(col, {})
-            @format = type
-          rescue => e
-            nil
+            if lambda.call(col)
+              @format = type
+            end
+          rescue ArgumentError, URI::InvalidURIError
           end
         end
         
@@ -214,13 +216,11 @@ module Csvlint
     def check_consistency
       percentages = []
                 
-      formats = SIMPLE_FORMATS.map {|type, lambda| type }
-            
-      formats.each do |type, regex|
-        @formats.count.times do |i|
+      SIMPLE_FORMATS.keys.each do |type|
+        @formats.each_with_index do |format,i|
           percentages[i] ||= {}
-          unless @formats[i].nil?
-            percentages[i][type] = @formats[i].grep(/^#{type}$/).count.to_f / @formats[i].count.to_f
+          unless format.nil?
+            percentages[i][type] = format.count(type) / format.size.to_f
           end
         end
       end

data/lib/csvlint/version.rb

@@ -1,3 +1,3 @@
 module Csvlint
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/lib/csvlint/wrapped_io.rb

@@ -1,39 +1,21 @@
 module Csvlint
-  class WrappedIO
-    def initialize(io)
-      @io = io
-      @line = ""
+  class WrappedIO < SimpleDelegator
+    attr_reader :line
+
+    def reset_line
+      @line = ''
     end
-  
+
     def gets(*args)
-      if args.count == 1 && args[0].is_a?(String)
-        delim = args[0]
-        @line = "" if @new_line
-        s = @io.gets(delim)
-        if s != nil
-          @line << s 
+      if args.size == 1 && args[0].is_a?(String)
+        s = __getobj__.gets(args[0])
+        if s
+          @line << s
         end
-        return s
+        s
       else
-        @io.gets(*args)
+        __getobj__.gets(*args)
       end
     end
-  
-    def eof?
-      @io.eof?
-    end
-  
-    def finished
-      @new_line = true
-    end
-  
-    def line
-      @line
-    end
-    
-    def method_missing(method, *args)
-      @io.send(method, *args)
-    end
-    
   end
-end
+end

data/spec/validator_spec.rb

@@ -53,17 +53,40 @@ describe Csvlint::Validator do
       validator = Csvlint::Validator.new("http://example.com/example.csv", opts)
       expect( validator.header? ).to eql(false)      
     end
-    
-    it "should look in content-type for header" do
+
+    it "should look in content-type for header=absent" do
       stub_request(:get, "http://example.com/example.csv").to_return(:status => 200, :headers=>{"Content-Type" => "text/csv; header=absent"}, :body => File.read(File.join(File.dirname(__FILE__),'..','features','fixtures','valid.csv')))
       validator = Csvlint::Validator.new("http://example.com/example.csv")
       expect( validator.header? ).to eql(false)
+      expect( validator.errors.size ).to eql(0)
+    end
 
+    it "should look in content-type for header=present" do
       stub_request(:get, "http://example.com/example.csv").to_return(:status => 200, :headers=>{"Content-Type" => "text/csv; header=present"}, :body => File.read(File.join(File.dirname(__FILE__),'..','features','fixtures','valid.csv')))
       validator = Csvlint::Validator.new("http://example.com/example.csv")
-      expect( validator.header? ).to eql(true)              
-    end  
-    
+      expect( validator.header? ).to eql(true)
+      expect( validator.errors.size ).to eql(0)
+    end
+
+    it "assume header present if not specified in content type" do
+      stub_request(:get, "http://example.com/example.csv").to_return(:status => 200, :headers=>{"Content-Type" => "text/csv"}, :body => File.read(File.join(File.dirname(__FILE__),'..','features','fixtures','valid.csv')))
+      validator = Csvlint::Validator.new("http://example.com/example.csv")
+      expect( validator.header? ).to eql(true)
+      expect( validator.errors.size ).to eql(0)
+      expect( validator.info_messages.size ).to eql(1)
+      expect( validator.info_messages.first.type).to eql(:assumed_header)
+    end
+
+    it "give undeclared header error if content type is wrong" do
+      stub_request(:get, "http://example.com/example.csv").to_return(:status => 200, :headers=>{"Content-Type" => "text/html"}, :body => File.read(File.join(File.dirname(__FILE__),'..','features','fixtures','valid.csv')))
+      validator = Csvlint::Validator.new("http://example.com/example.csv")
+      expect( validator.header? ).to eql(true)
+      expect( validator.errors.size ).to eql(2)
+      expect( validator.errors[0].type).to eql(:wrong_content_type)
+      expect( validator.errors[1].type).to eql(:undeclared_header)
+      expect( validator.info_messages.size ).to eql(0)
+    end
+
   end
   
   context "when validating headers" do
@@ -109,13 +132,13 @@ describe Csvlint::Validator do
       validator = Csvlint::Validator.new("http://example.com/example.csv")
       expect( validator.valid? ).to eql(false)   
     end  
-
-    it "should be an error if we have assumed a header, there is no dialect and content-type doesn't declare header" do
+    
+    it "should not be an error if we have assumed a header, there is no dialect and content-type doesn't declare header, as we assume header=present" do
       stub_request(:get, "http://example.com/example.csv").to_return(:status => 200, :headers=>{"Content-Type" => "text/csv"}, :body => File.read(File.join(File.dirname(__FILE__),'..','features','fixtures','valid.csv')))
       validator = Csvlint::Validator.new("http://example.com/example.csv")
-      expect( validator.valid? ).to eql(false)   
-    end  
-        
+      expect( validator.valid? ).to eql(true)   
+    end
+
     it "should be valid if we have a dialect and the data is from the web" do
       stub_request(:get, "http://example.com/example.csv").to_return(:status => 200, :headers=>{"Content-Type" => "text/csv"}, :body => File.read(File.join(File.dirname(__FILE__),'..','features','fixtures','valid.csv')))
       #header defaults to true in csv dialect, so this is valid

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: csvlint
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - pezholio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-14 00:00:00.000000000 Z
+date: 2014-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mime-types
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: colorize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: open_uri_redirections
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -98,154 +98,154 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov-rcov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: spork
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-pride
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-expectations
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: CSV Validator
@@ -318,17 +318,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.2
 signing_key: 
 specification_version: 4
 summary: CSV Validator