csv_step_importer 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a36a92f9240a933980983aff9d079724cc44882cd914ed2d6c2b51c1fbb47cca
-  data.tar.gz: 57dbea48c65e11867605da9621029b5da65d6700ffda0f092dfbe0c00e5b2858
+  metadata.gz: 340c82c7b6f4e56a0092d5044971b9a2aa6e66739a045162afc0e12bf5da3345
+  data.tar.gz: 8691cb1d2f8402598b62210d20c742e6d1246a97915e2fd5a81bbbe9c5a7736a
 SHA512:
-  metadata.gz: 15157867c54bdd4d7868901c353667775f24a9b9ae5a34cc98659184bb52d0119f923cfa4577a4e6385b440da810c2fca4ba03ae2c1bce35cdf07d70045c6b98
-  data.tar.gz: 94f5eebbdc2fac03edcf0a18d3727bc0681f062a8f2cc631f201a8c2e94a2b97460fdb8370615f8dc262ae7e152de58dec77772a13a36ebe4685fd1cd02a0793
+  metadata.gz: 147a95d14716f92967a5059f6202e992b2a9f4a3316cf139cd11d02a669ea449051c2b2a61447e63c66cfd763957041a8c212e5edab72d419ef6628569fae0ed
+  data.tar.gz: 771576acb65c952f7837a9c9fed7bbb3444e06918d4a3384e06644a17f664f38450acc8f3ee1124ae87706c32de3813adc3c24637da221291d352dbf86556a41

data/CHANGELOG.md

@@ -129,3 +129,8 @@ See lib/csv_step_importer/file.rb for more options
 
 - ImportableModel's finder_keys method now defaults to composite_key_columns
 - ImportableModel's Importer (uses ActiveRecord::Import) now raises an exception if the import fails
+
+## 2018-09-11 Version 0.11.1
+### Added
+### Changed
+- Fixed `composite_key_columns` filter functionality

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    csv_step_importer (0.11.0)
+    csv_step_importer (0.11.1)
       activemodel
       activerecord-import
       activesupport

data/README.md

@@ -7,6 +7,10 @@ It depends on
 - [zdennis/activerecord-import](https://github.com/zdennis/activerecord-import)
 - [GitHub - tilo/smarter_csv](https://github.com/tilo/smarter_csv)
 
+## Sample Application (Thanks to @vochicong)
+
+[vochicong/csv_step_importer_sample](https://github.com/vochicong/csv_step_importer_sample)
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/lib/csv_step_importer/loader.rb

@@ -6,7 +6,7 @@ module CSVStepImporter
   class Loader < CSVStepImporter::Node
     def initialize(file_class: CSVStepImporter::File, chunk_class: CSVStepImporter::Chunk, **attributes)
       super **attributes.slice(:parent, :children, :env)
-      add_children attributes[:path] ? file_class.new( **attributes.merge!(chunk_class: chunk_class) ) : chunk_class.new( **attributes )
+      add_children attributes[:path] ? file_class.new(**attributes.merge!(chunk_class: chunk_class)) : chunk_class.new(**attributes)
     end
   end
 end

data/lib/csv_step_importer/model/dao.rb

@@ -60,7 +60,7 @@ module CSVStepImporter
       end
 
       # retrieve a dao for a different model using the same CSV row. This is useful e.g. if you use the reflector to get ids of related data
-      def dao_for model:, pluralize: false
+      def dao_for(model:, pluralize: false)
         row.cache[model.cache_key(pluralize: pluralize)]
       end
 
@@ -74,7 +74,7 @@ module CSVStepImporter
       end
 
       # unlink this dao from the row and replace it with a different dao
-      def unlink! replace_with: nil
+      def unlink!(replace_with: nil)
         cached_daos = row.cache[model.cache_key(pluralize: true)]
 
         # remove from cache with pluralized key

data/lib/csv_step_importer/model/model.rb

@@ -21,8 +21,8 @@ module CSVStepImporter
       # Configuration
       #########################################################
 
-      def self.cache_key pluralize: false
-        key = name.underscore.gsub('/', '_')
+      def self.cache_key(pluralize: false)
+        key = name.underscore.gsub("/", "_")
         (pluralize ? key.pluralize : key.singularize).to_sym
       end
 
@@ -79,14 +79,14 @@ module CSVStepImporter
       def filter_daos!
         unique_daos = {}
 
-        daos.delete_if do |dao|
-          hash = dao.value.slice(composite_key_columns).hash
-          should_delete = (unique_daos[hash] ||= dao) == dao
+        daos.keep_if do |dao|
+          hash = dao.value.slice(*composite_key_columns).hash
+          keep = (unique_daos[hash] ||= dao) == dao
 
           # unlink to be deleted dao and add a link to
-          dao.unlink! replace_with: unique_daos[hash] unless should_delete
+          dao.unlink! replace_with: unique_daos[hash] unless keep
 
-          should_delete
+          keep
         end
       end
 

data/lib/csv_step_importer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CSVStepImporter
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: csv_step_importer
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Christian-Manuel Butzke