csv_model 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ccb22507d47dc2e7db940efdbb20d6366de3fb94
-  data.tar.gz: b7c9bf17cfac53e97271d63f6d3ea78634b2f8f6
+  metadata.gz: b2c3dcb21cddf9d14f4d44336770c35d737c4165
+  data.tar.gz: 96510b317ed2ec88d19ad86a51ee15c1b1c5c8ce
 SHA512:
-  metadata.gz: 05ee82ff370463e138682ac77425d21e3dff73b6a876c4588a681a0efe45069936ce0b03d823f75ef086d0334ffd99cba8a80706b58341ed2336bba0a6f6492a
-  data.tar.gz: 31679c8cc0fc3314c9b27512940e1a2590997245791a41f33173c63887ea04d5a26b20c391621e795772130e81569676511dba30242dc8345365c193b8000cd9
+  metadata.gz: 565a7e1407cdcbbedcea280b6cf1cc63e050954275fd87b9c45e6b4073b69463aefc49baa77df3809f134259a69164ca6c95415e877fd8c40e4ed6e1e89a3de9
+  data.tar.gz: 90f26d172765c9b1e28f49cd85045f753c896b41d6ca77fc4fe47e9b9bbe5aa5ba5f0e41cd4225c778eec950eb6df5e4f11af60f1e66fc088e39fd930d82c970

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    csv_model (0.2.0)
+    csv_model (0.2.1)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -8,3 +8,10 @@ csv_model
 TODO: ability to have multiple alternate primary keys
 
 active_record?
+
+
+gem build csv_model.gemspec
+gem push csv_model-0.2.1.gem
+
+gem install csv_model-0.2.1.gem
+gem uninstall csv_model -v 0.2.0

data/lib/csv_model/header_row.rb

@@ -25,7 +25,7 @@ module CSVModel
     end
 
     def errors
-      duplicate_column_errors + illegal_column_errors + missing_column_errors + missing_key_column_errors
+      (duplicate_column_errors + illegal_column_errors + missing_column_errors + missing_key_column_errors).uniq
     end
 
     def has_column?(key)
@@ -170,7 +170,7 @@ module CSVModel
     end
 
     def primary_key_column_errors
-      missing_primary_key_column_names.collect { |name| "Missing primary key column #{name}" }
+      missing_primary_key_column_names.collect { |name| "Missing column #{name}" }
     end
 
     def primary_key_column_keys

data/lib/csv_model/version.rb

@@ -1,3 +1,3 @@
 module CSVModel
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/csv_model/header_row_spec.rb

@@ -106,7 +106,12 @@ describe CSVModel::HeaderRow do
 
     it "returns required column message when header is missing required primary key columns" do
       subject = described_class.new(data, primary_key: ["Column Two"])
-      expect(subject.errors).to eq(["Missing primary key column Column Two"])
+      expect(subject.errors).to eq(["Missing column Column Two"])
+    end
+
+    it "returns single message when column is missing required and primary key" do
+      subject = described_class.new(data, primary_key: ["Column Two"], required_columns: ["Column Two"])
+      expect(subject.errors).to eq(["Missing column Column Two"])
     end
 
     it "returns empty array when header is missing required primary key column but alternate is available" do
@@ -116,7 +121,7 @@ describe CSVModel::HeaderRow do
 
     it "returns required column message when header is missing required primary key and alternate is not available " do
       subject = described_class.new(data, primary_key: ["Column Two"], alternate_primary_key: ["Column Three"])
-      expect(subject.errors).to eq(["Missing primary key column Column Two"])
+      expect(subject.errors).to eq(["Missing column Column Two"])
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: csv_model
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Matthew Chadwick