csv2avro 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4102328d73046f50036d1a35848142d0d23e50dc
-  data.tar.gz: d7f59e943fd02106579e9f25b6bc5480e5243b03
+  metadata.gz: 3dd5ca9e046d1e46a845614350ad1e0e2dcdd8a6
+  data.tar.gz: 0c7eefec78b9293b6f1ed954fb22b5ec6b6506ba
 SHA512:
-  metadata.gz: e1e6e26a916c6beb65c25395e062fa8f45037171fcfc624798fb68417f257ac761fdb6ffd560dda251bee89953be59399f3e66ee0ce612e405cf352862cd4d30
-  data.tar.gz: e94c31792b3113edb64dfc1e72cb24868af3a446469df2ada734d6ef0210992c5739ad26ba485832fcfc37204193d1bbde59155df98a18c34b644cf65aac50f6
+  metadata.gz: abbed521cda772e04453d95ec559f37e1e45b84f1fbe46e600e5a1ec0333abdbf28978b31946a451ab87701de4af089787f68b316262152bb00f6d9ceefe1048
+  data.tar.gz: 683f680b56c5c06f0217ca5c6f2ff384b228435175327d746545601636844755a5832cf904c420f004bcc4a0cbb4d751eaf1ddeefe4eeeaa334c6418b8633a02

data/CHANGELOG.md

@@ -3,6 +3,11 @@
 All notable changes to this project are documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.0.2 (2015-06-29; [compare](https://github.com/sspinc/csv2avro/compare/1.0.1...1.0.2))
+
+### Fixed
+ * Continue on parsing errors
+
 ## 1.0.1 (2015-06-12; [compare](https://github.com/sspinc/csv2avro/compare/1.0.0...1.0.1))
 
 ### Fixed

data/csv2avro.gemspec

@@ -6,8 +6,8 @@ require 'csv2avro/version'
 Gem::Specification.new do |spec|
   spec.name          = "csv2avro"
   spec.version       = CSV2Avro::VERSION
-  spec.authors       = ["Peter Ableda"]
-  spec.email         = ["scotty@secretsaucepartners.com"]
+  spec.authors       = ["Peter Ableda", "Peter Marton"]
+  spec.email         = ["scotty@secretsaucepartners.com", "martonpe@secretsaucepartners.com"]
   spec.summary       = %q{Convert CSV files to Avro}
   spec.description   = %q{Convert CSV files to Avro like a boss.}
   spec.homepage      = ""

data/lib/csv2avro/converter.rb

@@ -17,7 +17,13 @@ class CSV2Avro
     end
 
     def convert
-      csv.each do |row|
+      while not csv.eof? do
+        begin
+          row = csv.shift
+        rescue CSV::MalformedCSVError
+          @error_writer.puts("line #{line_number}: Unable to parse")
+          next
+        end
         hash = row.to_hash
 
         add_defaults_to_hash!(hash) if @options[:write_defaults]
@@ -33,10 +39,7 @@ class CSV2Avro
           end
         end
       end
-
       @writer.flush
-    rescue CSV::MalformedCSVError
-      @error_writer.puts("line #{line_number}: Unable to parse")
     end
 
     private

data/lib/csv2avro/version.rb

@@ -1,3 +1,3 @@
 class CSV2Avro
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/csv2avro_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe CSV2Avro do
     subject(:converter) { CSV2Avro.new(options) }
 
     it 'should write errors to STDERR' do
-      expect { converter.convert }.to output("line 4: Missing value at name\nline 5: Unable to parse\n").to_stderr
+      expect { converter.convert }.to output("line 4: Missing value at name\nline 7: Unable to parse\n").to_stderr
     end
 
     it 'should have a bad row' do
@@ -24,7 +24,9 @@ RSpec.describe CSV2Avro do
         expect(AvroReader.new(file).read).to eq(
           [
             { 'id'=>1, 'name'=>'dresses',     'description'=>'Dresses' },
-            { 'id'=>2, 'name'=>'female-tops', 'description'=>nil }
+            { 'id'=>2, 'name'=>'female-tops', 'description'=>nil },
+            { 'id'=>4, 'name'=>'male-tops',   'description'=>"Male Tops\nand Male Shirts"},
+            { 'id'=>6, 'name'=>'male-shoes', 'description'=>'Male Shoes'}
           ]
         )
       end

data/spec/support/data.csv

@@ -1,5 +1,8 @@
 id,name,description
-1,dresses,"Dresses"
-2,female-tops,
-3,,"Bras"
-4,male-tops,"Male Tops""
+1,dresses,Dresses
+"2","female-tops",
+"3",,"Bras"
+"4","male-tops","Male Tops
+and Male Shirts"
+"5","female-shoes","\"Shoes\" for women"
+"6","male-shoes","Male Shoes"

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: csv2avro
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Peter Ableda
+- Peter Marton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-12 00:00:00.000000000 Z
+date: 2015-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -97,6 +98,7 @@ dependencies:
 description: Convert CSV files to Avro like a boss.
 email:
 - scotty@secretsaucepartners.com
+- martonpe@secretsaucepartners.com
 executables:
 - csv2avro
 extensions: []