csstats 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ecb9899a0509a548c484782f274c9a2977b85e9f
-  data.tar.gz: 35da68649b1d7dc15d54caaceed2b394b8482552
+  metadata.gz: d6872b7c03f06e7dd770c35a07cd90aaed879ecd
+  data.tar.gz: 3834dbf6a0af008ce011d01f182e72c8249fe1a5
 SHA512:
-  metadata.gz: c092e09b2b2174c8fe65c487d9ae2e5896be3339b54f130fa0da9b81302376abc50dd18cc51a1392866daefd7d13f824b61956c8d93a0832d814607ca9f3eb2b
-  data.tar.gz: ae13b4f5c2b321b47e8d91faa62f5826221d9e526b92f0e6ee064f8182a5a1860900f19a88e5c93deeda9a5f05462be63b3cdb3f810638a7ea2b9e4768619c42
+  metadata.gz: d2ef9f0ac0f3cfbd024eb17f3ae4bad43ca8cf81a715a39c8114744aea8f244a671a5896c231f83895fb42fe3b3c1829f4a8daa5215303f6b3192504c357d87b
+  data.tar.gz: 593d29515df36cef84ea29e4e3141b659982b24b6b90a513fb92cccf5254b5a620415a0156a5d1ec31ad17420cfaa15f9d19527581c644b74ba1e4e149046093

data/.gitignore

@@ -16,4 +16,4 @@ test/tmp
 test/version_tmp
 tmp
 bin/test.rb
-.DS_Store
+.DS_Store

data/.rspec

@@ -1,3 +1,3 @@
 --color
 --fail-fast
---order random
+--order random

data/.travis.yml

@@ -4,4 +4,4 @@ rvm:
   - rbx-19mode
   - 1.9.2
   - 1.9.3
-  - 2.0.0
+  - 2.0.0

data/Gemfile

@@ -8,4 +8,4 @@ group :test do
   gem 'simplecov', require: false
 end
 
-gemspec
+gemspec

data/README.md

@@ -44,7 +44,9 @@ You can find player by specified name.
 
 ```ruby
 stats = CSstats.new(path: 'csstats.dat')
-stats.search_by_name('nick')
+player_stats = stats.search_by_name('nick')
+
+puts player_stats.kills
 ```
 
 ## Supported Ruby Versions
@@ -67,4 +69,4 @@ See [LICENSE][] for details.
 [codeclimate]: https://codeclimate.com/github/jpalumickas/csstats
 
 [amxx]: http://www.amxmodx.org/
-[license]: LICENSE.md
+[license]: LICENSE.md

data/Rakefile

@@ -5,4 +5,4 @@ require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
 task test: :spec
-task default: :spec
+task default: :spec

data/csstats.gemspec

@@ -21,4 +21,4 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'hashie', '~> 2.0'
 
   gem.version = CSstats::VERSION
-end
+end

data/lib/csstats.rb

@@ -7,9 +7,9 @@ module CSstats
     # Alias for CSstats::Handler.new
     #
     # Returns CSstats::Handler
-    def new(options={})
+    def new(options = {})
       CSstats::Handler.new(options)
     end
 
   end
-end
+end

data/lib/csstats/error.rb

@@ -1,3 +1,3 @@
 module CSstats
   class Error < StandardError; end
-end
+end

data/lib/csstats/handler.rb

@@ -2,30 +2,29 @@ require 'hashie/mash'
 
 module CSstats
   class Handler
-    attr_accessor :path, :players, :fileversion, :position
+    attr_reader :path, :players
 
-    # Initialize file.
+    # Public: Initialize file.
     #
-    # Options:
-    #   path - The String of csstats.dat file.
-    #   maxplayers - The Integer of how many players to return.
+    # options - The Hash options:
+    #   :path       - The String of csstats.dat file path (required).
+    #   :maxplayers - The Integer of how many players to return (optional).
     #
     # Returns nothing.
-    def initialize(options={})
+    def initialize(options = {})
       @path = options[:path]
       @players = []
-      @fileversion = 0x00
-      @position = 1
+
       maxplayers = options[:maxplayers] || 0
 
       return if @path.nil?
 
-      handle = File.new(@path, "r")
+      handle = File.new(@path, 'r')
 
-      @fileversion = read_short_data(handle);
+      @file_version = read_short_data(handle)
 
       i = 0
-      while (!handle.eof? && (maxplayers == 0 || i < maxplayers))
+      while !handle.eof? && (maxplayers == 0 || i < maxplayers)
         player = read_player(handle)
         if player
           player['rank'] = i + 1
@@ -35,15 +34,15 @@ module CSstats
       end
     end
 
-    # Read player information from file.
+    # Internal: Read player information from file.
     #
     # handle - The File which was opened for reading data.
     #
-    # Returns The Hash (Mash) of player information.
+    # Returns The Mash of player information.
     def read_player(handle)
-      length = read_short_data(handle);
+      length = read_short_data(handle)
 
-      return nil if (length == 0)
+      return nil if length == 0
 
       mash = Hashie::Mash.new
 
@@ -74,57 +73,57 @@ module CSstats
       mash.leftleg = read_int_data(handle)
       mash.rightleg = read_int_data(handle)
 
-      mash.acc = mash.hits / mash.shots * 100
-      mash.eff = mash.kills / (mash.kills + mash.deaths) * 100
+      mash.acc = mash.hits.to_f / mash.shots.to_f * 100
+      mash.eff = mash.kills.to_f / (mash.kills.to_f + mash.deaths.to_f) * 100
 
       read_int_data(handle) # 0x00000000
 
-      return mash
+      mash
     end
 
-    # Get the 32bit integer from file.
+    # Internal: Get the 32bit integer from file.
     #
     # handle - The File which was opened for reading data.
     #
-    # Returns the integer.
+    # Returns the Integer.
     def read_int_data(handle)
       data = handle.read(4)
-      raise CSstats::Error, "Cannot read int data." unless data
-      return data.unpack("V").first
+      raise CSstats::Error, 'Cannot read int data.' unless data
+      data.unpack('V').first
     end
 
-    # Get the 16bit integer from file.
+    # Internal: Get the 16bit integer from file.
     #
     # handle - The File which was opened for reading data.
     #
-    # Returns the integer.
+    # Returns the Integer.
     def read_short_data(handle)
       data = handle.read(2)
-      raise CSstats::Error, "Cannot read short data." unless data
-      return data.unpack("v").first
+      raise CSstats::Error, 'Cannot read short data.' unless data
+      data.unpack('v').first
     end
 
-    # Get the string from file.
+    # Internal: Get the String from file.
     #
     # handle - The File which was opened for reading data.
-    # len - length of string to read.
+    # len    - The Integer length of string to read.
     #
-    # Returns the string.
+    # Returns the String.
     def read_string_data(handle, length)
       data = handle.read(length)
-      raise CSstats::Error, "Cannot read string data." unless data
+      raise CSstats::Error, 'Cannot read string data.' unless data
       data = data.strip
-      return data
+      data
     end
 
-    # Get the player information of specified id.
+    # Internal: Get the player information of specified id.
     #
     # id - The Integer of player id.
     #
-    # Returns the Hash of player information.
+    # Returns the Mash of player information.
     def player(id)
-      unless (@players[id-1].nil?)
-        @players[id-1]
+      unless @players[id - 1].nil?
+        @players[id - 1]
       end
     end
 
@@ -139,10 +138,10 @@ module CSstats
     #
     # name - The String of player name.
     #
-    # Returns the Hash of player information.
+    # Returns the Mash of player information.
     def search_by_name(name)
       @players.each do |player|
-        return player if (name == player.nick)
+        return player if name == player.nick
       end
     end
   end

data/lib/csstats/version.rb

@@ -1,3 +1,3 @@
 module CSstats
-  VERSION = "1.0.1" unless defined?(CSstats::VERSION)
+  VERSION = '1.0.2' unless defined?(CSstats::VERSION)
 end

data/spec/csstats/handler_spec.rb

@@ -6,17 +6,17 @@ describe CSstats::Handler do
     @handler = CSstats::Handler.new(path: csstats_file, maxplayers: 15)
   end
 
-  it "should return corrent players count" do
+  it 'should return corrent players count' do
     expect(@handler.players_count).to eq 15
   end
 
-  it "should return correct player data" do
-    expect(@handler.player(2).nick).to eq "CHMARSON"
+  it 'should return correct player data' do
+    expect(@handler.player(2).nick).to eq 'CHMARSON'
   end
 
-  it "should return searched player" do
-    player = @handler.search_by_name("CHMARSON")
-    expect(player.nick).to eq "CHMARSON"
+  it 'should return searched player' do
+    player = @handler.search_by_name('CHMARSON')
+    expect(player.nick).to eq 'CHMARSON'
   end
 
-end
+end

data/spec/csstats_spec.rb

@@ -2,10 +2,10 @@ require 'spec_helper'
 
 describe CSstats do
 
-  describe ".new" do
-    it "is a CSstats::Handler" do
+  describe '.new' do
+    it 'is a CSstats::Handler' do
       expect(CSstats.new).to be_a CSstats::Handler
     end
   end
 
-end
+end

data/spec/spec_helper.rb

@@ -17,6 +17,6 @@ RSpec.configure do |config|
 end
 
 def csstats_file
-  fixtures = File.expand_path("../fixtures", __FILE__)
+  fixtures = File.expand_path('../fixtures', __FILE__)
   File.new(fixtures + '/csstats.dat').path
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: csstats
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Justas Palumickas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-03 00:00:00.000000000 Z
+date: 2013-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler