crystalmeta 0.9.3 → 0.9.4

data/CHANGELOG.markdown

@@ -1,3 +1,8 @@
+### 0.9.4 2013-02-28
+
+* Fix bugs with displaying tags: a tag key name should be `property` for OpenGraph & `name` for anything else, value should be called `content`
+* Remove default value for `twitter:url` — it has an OpenGraph fallback to `og:url`
+
 ### 0.9.3 2013-02-03
 
 * Fix interpolation bug

data/lib/crystal/options_for_controller.rb

@@ -27,8 +27,7 @@ module Crystal
 
     def default_options
       HashWithStringifyKeys.new(
-        :'og:url'      => url,
-        :'twitter:url' => url
+        :'og:url' => url
       )
     end
 

data/lib/crystal/tag.rb

@@ -1,5 +1,9 @@
 module Crystal
   class Tag < Struct.new(:name, :value)
+    def name_key
+      name.starts_with?('og:') ? :property : :name
+    end
+
     def value_for_context(context)
       case
       when asset?

data/lib/crystal/version.rb

@@ -1,3 +1,3 @@
 module Crystal
-  VERSION = '0.9.3'
+  VERSION = '0.9.4'
 end

data/lib/crystal/view_helpers.rb

@@ -6,7 +6,7 @@ module Crystal
 
     def meta_tags(pattern = //)
       meta.tags_by_pattern(pattern).map{|t|
-        tag(:meta, :property => t.name, :value => t.value_for_context(self))
+        tag(:meta, t.name_key => t.name, :content => t.value_for_context(self))
       }.join("\n").html_safe
     end
   end

data/spec/dummy/config/locales/en.yml

@@ -7,6 +7,7 @@ en:
       og:image: imdb.jpg
       og:type: article
       fb:app_id: 115109575169727
+      twitter:card: summary
 
     movies:
       _defaults:

data/spec/features/meta_tags_spec.rb

@@ -2,11 +2,11 @@ require 'spec_helper'
 
 describe 'meta tags' do
   def meta_tags(pattern = //)
-    all('meta').select{|meta| pattern === meta[:property]}
+    all('meta').select{|meta| pattern === meta[:property] || pattern === meta[:name] }
   end
 
   def value_for(pattern = //)
-    meta_tags(pattern).first[:value]
+    meta_tags(pattern).first[:content]
   end
 
   def title
@@ -26,6 +26,10 @@ describe 'meta tags' do
       value_for('og:image').should == '/images/rock.jpg'
     end
 
+    it 'include og:image from locale' do
+      value_for('twitter:card').should == 'summary'
+    end
+
     it 'include og:type from controller defaults' do
       value_for('og:type').should == 'video.movie'
     end

data/spec/unit/tag_spec.rb

@@ -4,8 +4,14 @@ describe Crystal::Tag do
   subject { Crystal::Tag.new('og:title', 'Caesar must die') }
   its(:name) {should == 'og:title'}
   its(:value) {should == 'Caesar must die'}
+  its(:name_key) { should == :property }
 
-  context '#value_for_context' do
+  context 'for twitter' do
+    subject { Crystal::Tag.new('twitter:title', 'Caesar must die') }
+    its(:name_key) { should == :name  }
+  end
+
+  describe '#value_for_context' do
     let(:context) { double }
 
     it 'returns asset path if asset' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: crystalmeta
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-04 00:00:00.000000000 Z
+date: 2013-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails