cryptocoin_payable 1.4.3 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ffd352ef2d7415e0067feda15e957525a0efe5b3
-  data.tar.gz: 103ff28a0a31e61d518d998c83cb0c4ddec2722e
+  metadata.gz: 2e8ee910240c9364019d58075f3822390414af89
+  data.tar.gz: 630fe67e170cfc62acc2553208a9165a88635b65
 SHA512:
-  metadata.gz: '09ea60a77c02fb244dcf93153c3965ed550308582c061abac853d93d2548088192e7b7dd15072881b3429133211762d3bd18e252f4779121fd0fe8fb32fcf66e'
-  data.tar.gz: d8b165ea4394ed9ad72afe866e90ce37884f4b663890a0f3230d5b43b2d41a092dc4cf27814802600cdf5734caee7c3c3f142a5200d7bf56b4728cb88c9d9d1f
+  metadata.gz: 5d2a3eac566f31ee6d26e82d73560b053ffb552c44cc83e6946971489be2c3a86ab26bd24cf99537b6ede0231d88c7049a9df0faeefdf899e81e86fc9b17d613
+  data.tar.gz: aa54453fe746d2543baed91ba8a59d65d95afe3a19c4031ce113024783a88606ceb4d8fbc03decf405c1c9a9512f617865d2ef5fa9acc4f702e0b7f7148426a9

data/bin/console

@@ -2,6 +2,7 @@
 
 require 'bundler/setup'
 require 'cryptocoin_payable'
+require 'cryptocoin_payable/orm/activerecord'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

data/features/step_definitions/coin_payment_steps.rb

@@ -24,8 +24,8 @@ Given(/^a payment is made for (\d+) percent$/) do |percentage|
     [{
       transaction_hash: SecureRandom.uuid,
       block_hash: '00000000000000606aa74093ed91d657192a3772732ee4d99a7b7be8075eafa2',
-      block_time: DateTime.iso8601('2017-12-26T21:38:44.000+00:00'),
-      estimated_time: DateTime.iso8601('2017-12-26T21:30:19.858+00:00'),
+      block_time: Time.iso8601('2017-12-26T21:38:44.000+00:00'),
+      estimated_time: Time.iso8601('2017-12-26T21:30:19.858+00:00'),
       estimated_value: @coin_amount_due * (percentage.to_f / 100.0),
       confirmations: 1
     }]

data/lib/cryptocoin_payable/adapters/base.rb

@@ -77,11 +77,11 @@ module CryptocoinPayable
       end
 
       def parse_timestamp(timestamp)
-        timestamp.nil? ? nil : DateTime.strptime(timestamp.to_s, '%s')
+        timestamp.nil? ? nil : Time.strptime(timestamp.to_s, '%s')
       end
 
       def parse_time(time)
-        time.nil? ? nil : DateTime.iso8601(time)
+        time.nil? ? nil : Time.iso8601(time)
       end
 
       private

data/lib/cryptocoin_payable/adapters.rb

@@ -2,22 +2,28 @@ module CryptocoinPayable
   module Adapters
     def self.for(coin_type)
       case coin_type.to_sym
-      when :eth
-        ethereum_adapter
+      when :bch
+        bitcoin_cash_adapter
       when :btc
         bitcoin_adapter
+      when :eth
+        ethereum_adapter
       else
         raise "Invalid coin type #{coin_type}"
       end
     end
 
-    def self.ethereum_adapter
-      @ethereum_adapter ||= Ethereum.new
+    def self.bitcoin_cash_adapter
+      @bitcoin_cash_adapter ||= BitcoinCash.new
     end
 
     def self.bitcoin_adapter
       @bitcoin_adapter ||= Bitcoin.new
     end
+
+    def self.ethereum_adapter
+      @ethereum_adapter ||= Ethereum.new
+    end
   end
 end
 

data/lib/cryptocoin_payable/coin_payment.rb

@@ -21,6 +21,7 @@ module CryptocoinPayable
     enum coin_type: %i[
       btc
       eth
+      bch
     ]
 
     state_machine :state, initial: :pending do

data/lib/cryptocoin_payable/currency_conversion.rb

@@ -6,6 +6,7 @@ module CryptocoinPayable
     enum coin_type: %i[
       btc
       eth
+      bch
     ]
   end
 end

data/lib/cryptocoin_payable/version.rb

@@ -1,3 +1,3 @@
 module CryptocoinPayable
-  VERSION = '1.4.3'.freeze
+  VERSION = '1.4.4'.freeze
 end

data/spec/acceptance/adapters/bitcoin_cash_spec.rb

@@ -10,8 +10,8 @@ describe CryptocoinPayable::Adapters::BitcoinCash, :vcr do
         {
           transaction_hash: '10d9d3927a21d90c573a5fbbb347f409af37219ceb93f7475d6c4cca4231d29f',
           block_hash: '0000000000000000015493ab50fde669130f9b64f0918031a5b6dcc44f14698f',
-          block_time: DateTime.iso8601('2018-10-12T07:28:21.000000000+00:00'),
-          estimated_time: DateTime.iso8601('2018-10-12T07:28:21.000000000+00:00'),
+          block_time: Time.iso8601('2018-10-12T07:28:21.000000000+00:00'),
+          estimated_time: Time.iso8601('2018-10-12T07:28:21.000000000+00:00'),
           estimated_value: 4_128_450,
           confirmations: 2
         }

data/spec/acceptance/adapters/bitcoin_spec.rb

@@ -8,16 +8,16 @@ describe CryptocoinPayable::Adapters::Bitcoin, :vcr do
         {
           transaction_hash: '5bdeaf7829148d7e0e1e7b5233512a2c5ae54ef7ccbc8e68b2f85b7e49c917a0',
           block_hash: '0000000000000000048e8ea3fdd2c3a59ddcbcf7575f82cb96ce9fd17da9f2f4',
-          block_time: DateTime.iso8601('2016-09-13T15:41:00.000000000+00:00'),
-          estimated_time: be_within(1.day).of(DateTime.iso8601('2016-09-13T15:41:00.000000000+00:00')),
+          block_time: Time.iso8601('2016-09-13T15:41:00.000000000+00:00'),
+          estimated_time: be_within(1.day).of(Time.iso8601('2016-09-13T15:41:00.000000000+00:00')),
           estimated_value: 499_000_000,
           confirmations: 116_077
         },
         {
           transaction_hash: 'e7bcdb13d9c903973bd8a740054d4c056a559bae67d4e8f6d0a42b4bab552623',
           block_hash: '000000000000000001af27feb303ad97af81a5882157f166781784c639f8e896',
-          block_time: DateTime.iso8601('2016-09-13T15:22:42.000000000+00:00'),
-          estimated_time: be_within(1.day).of(DateTime.iso8601('2016-09-13T15:22:42.000000000+00:00')),
+          block_time: Time.iso8601('2016-09-13T15:22:42.000000000+00:00'),
+          estimated_time: be_within(1.day).of(Time.iso8601('2016-09-13T15:22:42.000000000+00:00')),
           estimated_value: 1_000_000,
           confirmations: 116_080
         }

data/spec/acceptance/adapters/ethereum_spec.rb

@@ -9,7 +9,7 @@ describe CryptocoinPayable::Adapters::Ethereum, :vcr do
           transaction_hash: '0xa88b799514e9621962e3d0de25e7e0bc7a123e33085f322c7acdb99cc2585c6d',
           block_hash: '0x752c50e426f65820f5bf6fd49acbb08d79464f8e7e8ea5b77e2299b69fd6398b',
           block_time: nil,
-          estimated_time: be_within(1.day).of(DateTime.iso8601('2018-07-05T12:58:33.000000000+07:00')),
+          estimated_time: be_within(1.day).of(Time.iso8601('2018-07-05T12:58:33.000000000+07:00')),
           estimated_value: 33_753_640_000_000_000,
           confirmations: 569_771
         },
@@ -17,7 +17,7 @@ describe CryptocoinPayable::Adapters::Ethereum, :vcr do
           transaction_hash: '0xb325a8cf241f332bca92c7f715987e4d34be9a6b3bb78d2425c83086b4aced26',
           block_hash: '0x1c2b73a16fd8c4d25feeccaa2f0bf5c82b8f415f1beaf4d34aaf870daf89689d',
           block_time: nil,
-          estimated_time: be_within(1.day).of(DateTime.iso8601('2018-07-05T13:35:07.000000000+07:00')),
+          estimated_time: be_within(1.day).of(Time.iso8601('2018-07-05T13:35:07.000000000+07:00')),
           estimated_value: 2_190_144_444_444_444,
           confirmations: 569_629
         },
@@ -25,7 +25,7 @@ describe CryptocoinPayable::Adapters::Ethereum, :vcr do
           transaction_hash: '0xcd874917be5ad177e7ebd88b5c4a7d4283796e00e43345da5b63fb4f78130b37',
           block_hash: '0x4ce71d11146445f123680ea9beba7db968b04dc675caddf60248c9d9d6f5739e',
           block_time: nil,
-          estimated_time: be_within(1.day).of(DateTime.iso8601('2018-07-05T13:55:53.000000000+07:00')),
+          estimated_time: be_within(1.day).of(Time.iso8601('2018-07-05T13:55:53.000000000+07:00')),
           estimated_value: 1_007_518_888_888_888,
           confirmations: 569_549
         },
@@ -33,7 +33,7 @@ describe CryptocoinPayable::Adapters::Ethereum, :vcr do
           transaction_hash: '0x799ec2aaafbddbc2e746334f96f59f6127dec62e5693480576db351aaf840bfb',
           block_hash: '0xc1361b19b2266e2259ac433b9e18b4fbc81339304988bbc62dd93aa24fac6449',
           block_time: nil,
-          estimated_time: be_within(1.day).of(DateTime.iso8601('2018-08-26T16:05:44.000000000+07:00')),
+          estimated_time: be_within(1.day).of(Time.iso8601('2018-08-26T16:05:44.000000000+07:00')),
           estimated_value: 15_678_420_000_000_000,
           confirmations: 261_969
         }

data/spec/acceptance/coin_payment_spec.rb

@@ -0,0 +1,19 @@
+require 'active_record'
+require 'cryptocoin_payable'
+require 'cryptocoin_payable/orm/activerecord'
+
+describe CryptocoinPayable::CoinPayment do
+  context 'when creating a Bitcoin Cash payment' do
+    subject { CryptocoinPayable::CoinPayment.new(coin_type: :bch, reason: 'test', price: 1) }
+
+    it 'can save a payment' do
+      expect { subject.save! }.not_to raise_error
+    end
+
+    it 'can update the coin amount due' do
+      subject.update_coin_amount_due
+      expect(subject.coin_amount_due).to eq(100_000_000)
+      expect(subject.coin_conversion).to eq(1)
+    end
+  end
+end

data/spec/acceptance/commands/payment_processor_spec.rb

@@ -9,8 +9,8 @@ describe CryptocoinPayable::PaymentProcessor do
       transactions << {
         transaction_hash: Digest::SHA2.new(256).hexdigest(i.to_s),
         block_hash: '0000000000000000048e8ea3fdd2c3a59ddcbcf7575f82cb96ce9fd17da9f2f4',
-        block_time: DateTime.iso8601('2016-09-13T15:41:00.000000000+00:00'),
-        estimated_time: DateTime.iso8601('2016-09-13T15:41:00.000000000+00:00'),
+        block_time: Time.iso8601('2016-09-13T15:41:00.000000000+00:00'),
+        estimated_time: Time.iso8601('2016-09-13T15:41:00.000000000+00:00'),
         estimated_value: 499_000_000,
         confirmations: 116_077
       }
@@ -23,7 +23,6 @@ describe CryptocoinPayable::PaymentProcessor do
     after(:all) { GC.enable }
 
     before do
-      CryptocoinPayable::CurrencyConversion.create!(coin_type: :btc, currency: 1, price: 1)
       adapter = CryptocoinPayable::Adapters.bitcoin_adapter
       allow(adapter).to receive(:fetch_transactions) { build_fake_transactions_data }
     end

data/spec/acceptance/commands/pricing_processor_spec.rb

@@ -6,12 +6,6 @@ describe CryptocoinPayable::PricingProcessor, vcr: true do
       # Ensure we have a stale payment.
       Timecop.freeze(3.days.from_now)
 
-      CryptocoinPayable::CurrencyConversion.create!(
-        coin_type: :btc,
-        currency: 1,
-        price: 1
-      )
-
       CryptocoinPayable::CoinPayment.create!(
         state: :pending,
         coin_type: :btc,

data/spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/returns_zero_estimated_value_for_zero-value_transactions.yml

@@ -0,0 +1,70 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://blockexplorer.com/api/txs/?address=1PKKkNRPPfPjrPiufHzuLFX2gMAVJbcN8H
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Thu, 08 Nov 2018 17:34:48 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - BE=f6fe53688c017ff7; path=/
+      - __cfduid=dd04ba3e33bea3f20633eebd13320dc081541698486; expires=Fri, 08-Nov-19
+        17:34:46 GMT; path=/; domain=.blockexplorer.com; HttpOnly; Secure
+      X-Powered-By:
+      - Express
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET, HEAD, PUT, POST, OPTIONS
+      Access-Control-Allow-Headers:
+      - Origin, X-Requested-With, Content-Type, Accept, Content-Length, Cache-Control,
+        cf-connecting-ip
+      Cache-Control:
+      - public, max-age=30
+      X-Content-Type-Options:
+      - nosniff
+      Etag:
+      - W/"10a9-4+a9umI+STIlOj3adv7w8ZfOGog"
+      Vary:
+      - Accept-Encoding
+      Cf-Cache-Status:
+      - BYPASS
+      Expect-Ct:
+      - max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
+      Server:
+      - cloudflare
+      Cf-Ray:
+      - 4769cad68b06a49d-PNH
+    body:
+      encoding: ASCII-8BIT
+      string: '{"pagesTotal":1,"txs":[{"txid":"1c085fb7180d35736dae4d1526f18c71fb551173c7471a70251bff88d38d559d","version":1,"locktime":0,"vin":[{"txid":"5dd89fb2f9a2adfe6f4918db6a203b7c8c91c25c7cb0cd9bfb8a250e3c25abdd","vout":0,"sequence":4294967295,"n":0,"scriptSig":{"hex":"483045022100b029679930b80ce4c067b9c903571c6a935983d7beecaeb902ad1fffa9dba21502204e542e193b74acf68ab17cb13f821d339244aea9cb339bede4b195b3c3b35c6c0121028005d0d0b1c96d549f0eb5e18fb9f7b35ed5a28fb2f3c55842ab9dc9a9218976","asm":"3045022100b029679930b80ce4c067b9c903571c6a935983d7beecaeb902ad1fffa9dba21502204e542e193b74acf68ab17cb13f821d339244aea9cb339bede4b195b3c3b35c6c[ALL]
+        028005d0d0b1c96d549f0eb5e18fb9f7b35ed5a28fb2f3c55842ab9dc9a9218976"},"addr":"1PKKkNRPPfPjrPiufHzuLFX2gMAVJbcN8H","valueSat":55965,"value":0.00055965,"doubleSpentTxID":null},{"txid":"5dd89fb2f9a2adfe6f4918db6a203b7c8c91c25c7cb0cd9bfb8a250e3c25abdd","vout":1,"sequence":4294967295,"n":1,"scriptSig":{"hex":"473044022048fad34851bc49c267386186df590ac12390172669f5612b2c28dc09d517223c02203fe2ecf934c10cfaa3d27d1e739ec3413fd16612ba16eaa15ba7a2cfbf0b3a790121034994bba249dc54ed3651595dab6c5c6e3c177032495e00a3fe53874adf565a34","asm":"3044022048fad34851bc49c267386186df590ac12390172669f5612b2c28dc09d517223c02203fe2ecf934c10cfaa3d27d1e739ec3413fd16612ba16eaa15ba7a2cfbf0b3a79[ALL]
+        034994bba249dc54ed3651595dab6c5c6e3c177032495e00a3fe53874adf565a34"},"addr":"15Gmaq5M8cMD4mAy1Gh6dVtnoDX3XAazwf","valueSat":503191,"value":0.00503191,"doubleSpentTxID":null}],"vout":[{"value":"0.00062184","n":0,"scriptPubKey":{"hex":"a91484fd6a85eb6cb335e0b8641717f3cf7f392f897587","asm":"OP_HASH160
+        84fd6a85eb6cb335e0b8641717f3cf7f392f8975 OP_EQUAL","addresses":["3DpChXQfjya6zQdUcgpA5tQFfqv9KgRXMP"],"type":"scripthash"},"spentTxId":"0a4c5507fe17f62d698f4ad30843909320770fd5b7159a925a0df289ed77c38e","spentIndex":1,"spentHeight":547179},{"value":"0.00495855","n":1,"scriptPubKey":{"hex":"76a9142edbf57347f7f56a2975c4c5c147680a781e32a988ac","asm":"OP_DUP
+        OP_HASH160 2edbf57347f7f56a2975c4c5c147680a781e32a9 OP_EQUALVERIFY OP_CHECKSIG","addresses":["15Gmaq5M8cMD4mAy1Gh6dVtnoDX3XAazwf"],"type":"pubkeyhash"},"spentTxId":"6f4f788586ba84ec1bea20b0063fff671c39f85a246b161188980fd13d8203f3","spentIndex":0,"spentHeight":547444}],"blockhash":"00000000000000000008d05a3b4530691dcfe048fa046bc1c95cbf7ae6c60ff0","blockheight":547177,"confirmations":2057,"time":1540413667,"blocktime":1540413667,"valueOut":0.00558039,"size":371,"valueIn":0.00559156,"fees":0.00001117},{"txid":"5dd89fb2f9a2adfe6f4918db6a203b7c8c91c25c7cb0cd9bfb8a250e3c25abdd","version":1,"locktime":0,"vin":[{"txid":"040d0d19654c2fa3e5dbea6654849339261c0bc5f4540173bf87ad0c9d1b2726","vout":1,"sequence":4294967295,"n":0,"scriptSig":{"hex":"483045022100d74af226278b3eaa850f12ccbbdc005796da6172b4b4664d1769586a361982a60220227b54175f2989cbceb4795997381c4b7a3f99d579431bf74294fcde8317ac8c0121034994bba249dc54ed3651595dab6c5c6e3c177032495e00a3fe53874adf565a34","asm":"3045022100d74af226278b3eaa850f12ccbbdc005796da6172b4b4664d1769586a361982a60220227b54175f2989cbceb4795997381c4b7a3f99d579431bf74294fcde8317ac8c[ALL]
+        034994bba249dc54ed3651595dab6c5c6e3c177032495e00a3fe53874adf565a34"},"addr":"15Gmaq5M8cMD4mAy1Gh6dVtnoDX3XAazwf","valueSat":559835,"value":0.00559835,"doubleSpentTxID":null}],"vout":[{"value":"0.00055965","n":0,"scriptPubKey":{"hex":"76a914f4c9e785dbe753f59b98c082d793b2e1312c558788ac","asm":"OP_DUP
+        OP_HASH160 f4c9e785dbe753f59b98c082d793b2e1312c5587 OP_EQUALVERIFY OP_CHECKSIG","addresses":["1PKKkNRPPfPjrPiufHzuLFX2gMAVJbcN8H"],"type":"pubkeyhash"},"spentTxId":"1c085fb7180d35736dae4d1526f18c71fb551173c7471a70251bff88d38d559d","spentIndex":0,"spentHeight":547177},{"value":"0.00503191","n":1,"scriptPubKey":{"hex":"76a9142edbf57347f7f56a2975c4c5c147680a781e32a988ac","asm":"OP_DUP
+        OP_HASH160 2edbf57347f7f56a2975c4c5c147680a781e32a9 OP_EQUALVERIFY OP_CHECKSIG","addresses":["15Gmaq5M8cMD4mAy1Gh6dVtnoDX3XAazwf"],"type":"pubkeyhash"},"spentTxId":"1c085fb7180d35736dae4d1526f18c71fb551173c7471a70251bff88d38d559d","spentIndex":1,"spentHeight":547177}],"blockhash":"0000000000000000001e7b7b2bf28d3e3813e0a37354f95288fe05fa18a0bc8a","blockheight":547126,"confirmations":2108,"time":1540380059,"blocktime":1540380059,"valueOut":0.00559156,"size":226,"valueIn":0.00559835,"fees":0.00000679}]}'
+    http_version: 
+  recorded_at: Thu, 08 Nov 2018 17:34:53 GMT
+recorded_with: VCR 4.0.0

data/spec/fixtures/vcr_cassettes/CryptocoinPayable_PricingProcessor/when_updating_stale_payments/can_update.yml

@@ -1,5 +1,106 @@
 ---
 http_interactions:
+- request:
+    method: get
+    uri: https://api.coinbase.com/v2/prices/BCH-USD/spot
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Thu, 08 Nov 2018 17:53:56 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Content-Length:
+      - '81'
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - __cfduid=d5f901b0febd4880997885e4cdc0882561541699635; expires=Fri, 08-Nov-19
+        17:53:55 GMT; path=/; domain=.coinbase.com; HttpOnly
+      Cache-Control:
+      - public, max-age=30
+      Content-Disposition:
+      - attachment; filename=response.json
+      Content-Security-Policy:
+      - 'default-src ''self'' https://www.coinbase.com; child-src ''self'' https://www.coinbase.com
+        https://*.online-metrix.net https://*.wpstn.com https://netverify.com https://platform.twitter.com
+        https://www.google.com/recaptcha/ https://cdn.plaid.com/link/ https://*.doubleclick.net/
+        blob: https://coinbase.ada.support; connect-src ''self'' https://www.coinbase.com
+        https://api.coinbase.com https://api.mixpanel.com https://*.online-metrix.net
+        https://api.cloudinary.com https://ott9.wpstn.com/live https://api.amplitude.com/
+        static.coinbase.com wss://ws.coinbase.com wss://ws.coinbase.com:443 https://www.coinbase.com/api
+        https://coinbase.ada.support/api/; font-src ''self'' https://www.coinbase.com
+        https://assets.coinbase.com/ static.coinbase.com; img-src ''self'' data: https://www.coinbase.com
+        https://images.coinbase.com https://exceptions.coinbase.com https://coinbase-uploads.s3.amazonaws.com
+        https://s3.amazonaws.com/app-public/ https://maps.gstatic.com https://ssl.google-analytics.com
+        https://www.google.com https://maps.googleapis.com https://csi.gstatic.com
+        https://www.google-analytics.com https://res.cloudinary.com https://secure.gravatar.com
+        https://i2.wp.com https://*.online-metrix.net https://assets.coinbase.com/
+        https://hexagon-analytics.com https://api.mixpanel.com https://cb-brand.s3.amazonaws.com
+        https://googleads.g.doubleclick.net https://stats.g.doubleclick.net/r/collect
+        blob: static.coinbase.com https://d124s1zbdqkqqe.cloudfront.net https://www.facebook.com/tr;
+        media-src ''self'' https://www.coinbase.com blob:; object-src ''self'' data:
+        blob: https://www.coinbase.com https://cdn.siftscience.com https://*.online-metrix.net
+        https://www.gstatic.com https://www.google.com/recaptcha/api/; script-src
+        ''self'' ''unsafe-inline'' ''unsafe-eval'' https://www.coinbase.com https://cdn.siftscience.com
+        https://*.newrelic.com https://bam.nr-data.net https://*.google-analytics.com
+        https://www.google.com https://www.gstatic.com https://*.online-metrix.net
+        https://code.jquery.com https://chart.googleapis.com https://maps.googleapis.com
+        https://maps.gstatic.com https://netverify.com https://ajax.cloudflare.com
+        https://cdn.plaid.com/link/v2/stable/ https://www.googletagmanager.com/gtag/js
+        https://www.googletagmanager.com/gtm.js https://www.googleadservices.com https://googleads.g.doubleclick.net
+        https://assets.coinbase.com/ static.coinbase.com; style-src ''self'' ''unsafe-inline''
+        https://www.coinbase.com https://assets.coinbase.com/ static.coinbase.com;
+        report-uri /csp-report'
+      Etag:
+      - W/"b660661171f1c14502e61d57793828bd"
+      Expect-Ct:
+      - enforce; max-age=86400; report-uri="https://coinbase.report-uri.io/r/default/ct/reportOnly"
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      Strict-Transport-Security:
+      - max-age=31536000; includeSubDomains; preload
+      Vary:
+      - Origin,Accept-Encoding
+      X-Content-Type-Options:
+      - nosniff
+      X-Download-Options:
+      - noopen
+      X-Frame-Options:
+      - DENY
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      X-Powered-By:
+      - Proof-of-Work
+      X-Request-Id:
+      - 875e27b8-fda6-465f-b629-d783863ee485
+      X-Xss-Protection:
+      - 1; mode=block
+      Cf-Cache-Status:
+      - HIT
+      Expires:
+      - Thu, 08 Nov 2018 17:54:26 GMT
+      Server:
+      - cloudflare
+      Cf-Ray:
+      - 4769e6e35bd0a491-PNH
+    body:
+      encoding: ASCII-8BIT
+      string: '{"data":{"base":"BCH","currency":"USD","amount":"587.97"}}'
+    http_version: 
+  recorded_at: Sun, 11 Nov 2018 17:54:00 GMT
 - request:
     method: get
     uri: https://api.coinbase.com/v2/prices/BTC-USD/spot
@@ -19,16 +120,16 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Mon, 22 Oct 2018 12:03:43 GMT
+      - Thu, 08 Nov 2018 17:53:57 GMT
       Content-Type:
       - application/json; charset=utf-8
-      Transfer-Encoding:
-      - chunked
+      Content-Length:
+      - '82'
       Connection:
       - keep-alive
       Set-Cookie:
-      - __cfduid=d3e71f70698fb0777476e87de15b925f71540209823; expires=Tue, 22-Oct-19
-        12:03:43 GMT; path=/; domain=.coinbase.com; HttpOnly
+      - __cfduid=d04b2b46c8cd0d0c16375884efe5462451541699636; expires=Fri, 08-Nov-19
+        17:53:56 GMT; path=/; domain=.coinbase.com; HttpOnly
       Cache-Control:
       - public, max-age=30
       Content-Disposition:
@@ -65,7 +166,7 @@ http_interactions:
         https://www.coinbase.com https://assets.coinbase.com/ static.coinbase.com;
         report-uri /csp-report'
       Etag:
-      - W/"50113d3b29ac6ba037f591afa45666d5"
+      - W/"4f5f2ad82a3963f92662806d45ab3edf"
       Expect-Ct:
       - enforce; max-age=86400; report-uri="https://coinbase.report-uri.io/r/default/ct/reportOnly"
       Referrer-Policy:
@@ -85,22 +186,22 @@ http_interactions:
       X-Powered-By:
       - Proof-of-Work
       X-Request-Id:
-      - c4a1f140-cfaf-4fd5-b690-c8cbd93cdf98
+      - d16c1c0c-26ea-4fc7-a1ef-b02abfa8bf80
       X-Xss-Protection:
       - 1; mode=block
       Cf-Cache-Status:
       - HIT
       Expires:
-      - Mon, 22 Oct 2018 12:04:13 GMT
+      - Thu, 08 Nov 2018 17:54:27 GMT
       Server:
       - cloudflare
       Cf-Ray:
-      - 46dbd2859e5549a9-BKK
+      - 4769e6ea49b4a485-PNH
     body:
       encoding: ASCII-8BIT
-      string: '{"data":{"base":"BTC","currency":"USD","amount":"6399.36"}}'
+      string: '{"data":{"base":"BTC","currency":"USD","amount":"6424.00"}}'
     http_version: 
-  recorded_at: Thu, 25 Oct 2018 12:03:55 GMT
+  recorded_at: Sun, 11 Nov 2018 17:54:00 GMT
 - request:
     method: get
     uri: https://api.coinbase.com/v2/prices/ETH-USD/spot
@@ -120,7 +221,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Mon, 22 Oct 2018 12:03:45 GMT
+      - Thu, 08 Nov 2018 17:53:59 GMT
       Content-Type:
       - application/json; charset=utf-8
       Content-Length:
@@ -128,8 +229,8 @@ http_interactions:
       Connection:
       - keep-alive
       Set-Cookie:
-      - __cfduid=d3e71f70698fb0777476e87de15b925f71540209823; expires=Tue, 22-Oct-19
-        12:03:43 GMT; path=/; domain=.coinbase.com; HttpOnly
+      - __cfduid=d233c228c665e49647bb663088827d07f1541699638; expires=Fri, 08-Nov-19
+        17:53:58 GMT; path=/; domain=.coinbase.com; HttpOnly
       Cache-Control:
       - public, max-age=30
       Content-Disposition:
@@ -166,7 +267,7 @@ http_interactions:
         https://www.coinbase.com https://assets.coinbase.com/ static.coinbase.com;
         report-uri /csp-report'
       Etag:
-      - W/"efc1bc8e6732bdf6cba86c542ae05a3f"
+      - W/"3f88f9ab53d68d44e3364543ddfdb274"
       Expect-Ct:
       - enforce; max-age=86400; report-uri="https://coinbase.report-uri.io/r/default/ct/reportOnly"
       Referrer-Policy:
@@ -186,20 +287,20 @@ http_interactions:
       X-Powered-By:
       - Proof-of-Work
       X-Request-Id:
-      - 12c5f4dc-a501-4d49-80f7-3bb02d826bfa
+      - bc27a504-585e-4550-98f5-a71b699a954b
       X-Xss-Protection:
       - 1; mode=block
       Cf-Cache-Status:
       - HIT
       Expires:
-      - Mon, 22 Oct 2018 12:04:15 GMT
+      - Thu, 08 Nov 2018 17:54:29 GMT
       Server:
       - cloudflare
       Cf-Ray:
-      - 46dbd286cf8849a9-BKK
+      - 4769e6f1aa45a4af-PNH
     body:
       encoding: ASCII-8BIT
-      string: '{"data":{"base":"ETH","currency":"USD","amount":"201.96"}}'
+      string: '{"data":{"base":"ETH","currency":"USD","amount":"211.81"}}'
     http_version: 
-  recorded_at: Thu, 25 Oct 2018 12:03:55 GMT
+  recorded_at: Sun, 11 Nov 2018 17:54:00 GMT
 recorded_with: VCR 4.0.0

data/spec/spec_helper.rb

@@ -107,6 +107,14 @@ RSpec.configure do |config|
 
     ActiveRecord::Base.establish_connection(adapter: 'postgresql', database: 'cryptocoin_payable_test')
     create_tables
+
+    CryptocoinPayable::CurrencyConversion.coin_types.keys.each do |coin_type|
+      CryptocoinPayable::CurrencyConversion.create!(
+        coin_type: coin_type,
+        currency: 1,
+        price: 1
+      )
+    end
   end
 
   config.after(:suite) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cryptocoin_payable
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.4.4
 platform: ruby
 authors:
 - Jonathan Salis
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-25 00:00:00.000000000 Z
+date: 2018-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -339,6 +339,7 @@ files:
 - spec/acceptance/adapters/bitcoin_cash_spec.rb
 - spec/acceptance/adapters/bitcoin_spec.rb
 - spec/acceptance/adapters/ethereum_spec.rb
+- spec/acceptance/coin_payment_spec.rb
 - spec/acceptance/commands/payment_processor_spec.rb
 - spec/acceptance/commands/pricing_processor_spec.rb
 - spec/dummy/README.rdoc
@@ -393,6 +394,7 @@ files:
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/gives_zero_instead_of_null_for_zero-value_transactions.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/handles_nil.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/raises_an_error_when_an_invalid_address_is_passed.yml
+- spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/returns_zero_estimated_value_for_zero-value_transactions.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/when_the_Block_Explorer_API_fails/falls_back_to_using_the_BlockCypher_API.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_BitcoinCash/gets_an_empty_result_when_no_transactions_found.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_BitcoinCash/gets_transactions_for_a_given_address.yml
@@ -438,6 +440,7 @@ test_files:
 - spec/acceptance/adapters/bitcoin_cash_spec.rb
 - spec/acceptance/adapters/bitcoin_spec.rb
 - spec/acceptance/adapters/ethereum_spec.rb
+- spec/acceptance/coin_payment_spec.rb
 - spec/acceptance/commands/payment_processor_spec.rb
 - spec/acceptance/commands/pricing_processor_spec.rb
 - spec/dummy/README.rdoc
@@ -492,6 +495,7 @@ test_files:
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/gives_zero_instead_of_null_for_zero-value_transactions.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/handles_nil.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/raises_an_error_when_an_invalid_address_is_passed.yml
+- spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/returns_zero_estimated_value_for_zero-value_transactions.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_Bitcoin/when_the_Block_Explorer_API_fails/falls_back_to_using_the_BlockCypher_API.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_BitcoinCash/gets_an_empty_result_when_no_transactions_found.yml
 - spec/fixtures/vcr_cassettes/CryptocoinPayable_Adapters_BitcoinCash/gets_transactions_for_a_given_address.yml