cryptocoin_payable 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c3867dfc765979dddbc44fcf5a30053f471617a7
-  data.tar.gz: cba3d5294ca03e57c77b33244347c15f17120ad2
+  metadata.gz: 88f7a3d37e5fea6dfc2e08eec657a47c1c21e300
+  data.tar.gz: e17ae020453e6ccb0fff510f33dd11752f1869c9
 SHA512:
-  metadata.gz: cc4d8b23700581add301880b52ccda3a8b82fd09d779b86d40b28921bdeaf5db2952f9148a80d0d7c5b883aebe6c8532b2fe0715672c0f166e64c3972e1e3b4e
-  data.tar.gz: 84c47803e89ee7f761fce0b33cdf0080a7f0d575064c31b4246eb7e2e08df6e63a5d52a17a39fc510704e8997df13c4c27666366d59fcc736e930d2bf0902973
+  metadata.gz: ddcf94b0a53ea8dd77207c4d2827ca277bbd8e952b68bbb41b55ffa31849ff4167b4f2e6d6321ad811c506a0be13ca091e4cb546d02d93f32df13e2987077f5a
+  data.tar.gz: 1dfe1240bc30c549041c6664785860320330dc1f179408b4383beca9fd4f466efaa225aaa9c644b4eef0900559eae69b8373be05150f7e2e2ba659872333027c

data/.travis.yml

@@ -1,8 +1,6 @@
 language: ruby
 
 rvm:
-  - 2.0
-  - 2.1
   - 2.2
   - 2.3
   - 2.4

data/README.md

@@ -1,4 +1,5 @@
 [![Gem Version](https://badge.fury.io/rb/cryptocoin_payable.svg)](https://badge.fury.io/rb/cryptocoin_payable)
+[![Build Status](https://travis-ci.com/mhluska/cryptocoin_payable.svg?branch=master)](https://travis-ci.com/mhluska/cryptocoin_payable)
 
 # Cryptocoin Payable
 

data/cryptocoin_payable.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
   spec.required_rubygems_version = '>= 1.3.6'
+  spec.required_ruby_version = '>= 2.2.0'
 
   spec.add_development_dependency 'activerecord', '~> 5.1'
   spec.add_development_dependency 'bundler', '~> 1.15'

data/lib/cryptocoin_payable/adapters/ethereum.rb

@@ -67,7 +67,7 @@ module CryptocoinPayable
           tx_hash: transaction['hash'],
           block_hash: transaction['block_hash'],
           block_time: nil, # Not supported
-          estimated_tx_time: Time.at(transaction['timeStamp'].to_i).iso8601,
+          estimated_tx_time: parse_timestamp(transaction['timeStamp']),
           estimated_tx_value: transaction['value'].to_i, # Units here are 'Wei'
           confirmations: transaction['confirmations'].to_i
         }

data/lib/cryptocoin_payable/version.rb

@@ -1,3 +1,3 @@
 module CryptocoinPayable
-  VERSION = '1.0.1'.freeze
+  VERSION = '1.1.0'.freeze
 end

data/spec/acceptance/adapters/ethereum_spec.rb

@@ -2,16 +2,14 @@ require 'active_record'
 require 'cryptocoin_payable'
 
 describe CryptocoinPayable::Adapters::Ethereum, :vcr do
-  it 'gets transactions for a given address' do
-    response = subject.fetch_transactions('0xfc8cfb26c31931572e65e450f7fa498bcc11651c')
-
-    expect(response).to eq(
+  def expect_transaction_result(response)
+    expect(response).to match_array(
       [
         {
           tx_hash: '0xa88b799514e9621962e3d0de25e7e0bc7a123e33085f322c7acdb99cc2585c6d',
           block_hash: '0x752c50e426f65820f5bf6fd49acbb08d79464f8e7e8ea5b77e2299b69fd6398b',
           block_time: nil,
-          estimated_tx_time: '2018-07-05T12:58:33+07:00',
+          estimated_tx_time: be_within(1.day).of(DateTime.iso8601('2018-07-05T12:58:33.000000000+07:00')),
           estimated_tx_value: 33_753_640_000_000_000,
           confirmations: 569_771
         },
@@ -19,7 +17,7 @@ describe CryptocoinPayable::Adapters::Ethereum, :vcr do
           tx_hash: '0xb325a8cf241f332bca92c7f715987e4d34be9a6b3bb78d2425c83086b4aced26',
           block_hash: '0x1c2b73a16fd8c4d25feeccaa2f0bf5c82b8f415f1beaf4d34aaf870daf89689d',
           block_time: nil,
-          estimated_tx_time: '2018-07-05T13:35:07+07:00',
+          estimated_tx_time: be_within(1.day).of(DateTime.iso8601('2018-07-05T13:35:07.000000000+07:00')),
           estimated_tx_value: 2_190_144_444_444_444,
           confirmations: 569_629
         },
@@ -27,7 +25,7 @@ describe CryptocoinPayable::Adapters::Ethereum, :vcr do
           tx_hash: '0xcd874917be5ad177e7ebd88b5c4a7d4283796e00e43345da5b63fb4f78130b37',
           block_hash: '0x4ce71d11146445f123680ea9beba7db968b04dc675caddf60248c9d9d6f5739e',
           block_time: nil,
-          estimated_tx_time: '2018-07-05T13:55:53+07:00',
+          estimated_tx_time: be_within(1.day).of(DateTime.iso8601('2018-07-05T13:55:53.000000000+07:00')),
           estimated_tx_value: 1_007_518_888_888_888,
           confirmations: 569_549
         },
@@ -35,7 +33,7 @@ describe CryptocoinPayable::Adapters::Ethereum, :vcr do
           tx_hash: '0x799ec2aaafbddbc2e746334f96f59f6127dec62e5693480576db351aaf840bfb',
           block_hash: '0xc1361b19b2266e2259ac433b9e18b4fbc81339304988bbc62dd93aa24fac6449',
           block_time: nil,
-          estimated_tx_time: '2018-08-26T16:05:44+07:00',
+          estimated_tx_time: be_within(1.day).of(DateTime.iso8601('2018-08-26T16:05:44.000000000+07:00')),
           estimated_tx_value: 15_678_420_000_000_000,
           confirmations: 261_969
         }
@@ -43,6 +41,11 @@ describe CryptocoinPayable::Adapters::Ethereum, :vcr do
     )
   end
 
+  it 'gets transactions for a given address' do
+    response = subject.fetch_transactions('0xfc8cfb26c31931572e65e450f7fa498bcc11651c')
+    expect_transaction_result(response)
+  end
+
   it 'gets an empty result when no transactions found' do
     response = subject.fetch_transactions('0x772fDD41BFB34C9903B253322baccdbE2C10851e')
     expect(response).to eq([])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cryptocoin_payable
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Jonathan Salis
@@ -345,7 +345,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="