crypto_arbitrer 0.0.2 → 0.0.3

data/lib/crypto_arbitrer/spec_helper.rb

@@ -0,0 +1,20 @@
+module CryptoArbitrer
+  module SpecHelper
+    def stub_crypto_arbitrer_get(url, mock_name)
+      stub_request(:get, url)
+        .to_return(body: open(File.expand_path("../../../spec/mocks/#{mock_name}", __FILE__)).read)
+    end
+    def mock_crypto_arbitrer_requests!
+      stub_crypto_arbitrer_get("http://www.eldolarblue.net/getDolarBlue.php?as=json", 'dolarblue.json')
+      stub_crypto_arbitrer_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
+      stub_crypto_arbitrer_get('http://www.dolarparalelo.org/', 'dolarparalelo.html')
+      %w(ltc nmc nvc trc ppc ftc cnc).each do |crypto|
+        stub_crypto_arbitrer_get("https://btc-e.com/exchange/#{crypto}_btc", "btce_#{crypto}_btc.html")
+      end
+      %w(uyu brl clp sgd eur).each do |currency|
+        stub_crypto_arbitrer_get("http://rate-exchange.appspot.com/currency?from=usd&to=#{currency}",
+          "rate_exchange_usd_#{currency}.json")
+      end
+    end
+  end
+end

data/lib/crypto_arbitrer/version.rb

@@ -1,3 +1,3 @@
 module CryptoArbitrer
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/crypto_arbitrer.rb

@@ -1,4 +1,5 @@
 require "crypto_arbitrer/version"
+require "crypto_arbitrer/spec_helper"
 require "json"
 require "open-uri"
 
@@ -159,7 +160,7 @@ module CryptoArbitrer
     # @param force [Boolean] Ignore the cache (does not read from it, and does not write to it). Defaults to false.
     # @return [{'buy' => Float, 'sell' => Float}] The buy and sell prices
     def self.fetch(from,to, force = false)
-      new.fetch(from, to, force)
+      new.fetch(from.downcase, to.downcase, force)
     end
 
   protected

data/spec/base_spec.rb

@@ -1,25 +1,14 @@
 require_relative '../lib/crypto_arbitrer.rb'
 require 'webmock/rspec'
 require 'csv'
+RSpec.configure do |config|
+  config.include CryptoArbitrer::SpecHelper
+end
 
 describe CryptoArbitrer::Base do
-  def stub_get(url, mock_name)
-    stub_request(:get, url)
-      .to_return(body: open(File.expand_path("../mocks/#{mock_name}", __FILE__)).read)
-  end
-
   describe 'when matching corpus of conversion rates' do
     before :each do
-      stub_get("http://www.eldolarblue.net/getDolarBlue.php?as=json", 'dolarblue.json')
-      stub_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
-      stub_get('http://www.dolarparalelo.org/', 'dolarparalelo.html')
-      %w(ltc nmc nvc trc ppc ftc cnc).each do |crypto|
-        stub_get("https://btc-e.com/exchange/#{crypto}_btc", "btce_#{crypto}_btc.html")
-      end
-      %w(uyu brl clp sgd eur).each do |currency|
-        stub_get("http://rate-exchange.appspot.com/currency?from=usd&to=#{currency}",
-          "rate_exchange_usd_#{currency}.json")
-      end
+      mock_crypto_arbitrer_requests!
     end
     
     CSV.read(File.expand_path('../conversions.csv', __FILE__), 'r').each do |from, to, buy, sell|
@@ -52,26 +41,26 @@ describe CryptoArbitrer::Base do
   end
   
   it 'hits dolarblue for usd to ars rate' do
-    stub = stub_get("http://www.eldolarblue.net/getDolarBlue.php?as=json", 'dolarblue.json')
+    stub = stub_crypto_arbitrer_get("http://www.eldolarblue.net/getDolarBlue.php?as=json", 'dolarblue.json')
     subject.fetch_usd_ars
     stub.should have_been_requested
   end
   
   it 'hits mt.gox for the btc to usd rate' do
-    stub = stub_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
+    stub = stub_crypto_arbitrer_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
     subject.fetch_btc_usd
     stub.should have_been_requested
   end
 
   it 'hits dolarparalelo for venezuelan bolivar' do
-    stub = stub_get('http://www.dolarparalelo.org/', 'dolarparalelo.html')
+    stub = stub_crypto_arbitrer_get('http://www.dolarparalelo.org/', 'dolarparalelo.html')
     subject.fetch_usd_vef
     stub.should have_been_requested
   end
 
   it 'hits mt.gox and dolarblue for the btc to ars rate' do
-    stub_ars = stub_get("http://www.eldolarblue.net/getDolarBlue.php?as=json", 'dolarblue.json')
-    stub_btc = stub_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
+    stub_ars = stub_crypto_arbitrer_get("http://www.eldolarblue.net/getDolarBlue.php?as=json", 'dolarblue.json')
+    stub_btc = stub_crypto_arbitrer_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
     subject.fetch_btc_ars
     stub_ars.should have_been_requested
     stub_btc.should have_been_requested
@@ -79,7 +68,7 @@ describe CryptoArbitrer::Base do
   
   %w(ltc nmc nvc trc ppc ftc cnc).each do |currency|
     it "hits btc-e for the #{currency} to btc rate" do
-      stub = stub_get("https://btc-e.com/exchange/#{currency}_btc", "btce_#{currency}_btc.html")
+      stub = stub_crypto_arbitrer_get("https://btc-e.com/exchange/#{currency}_btc", "btce_#{currency}_btc.html")
       subject.fetch(currency, 'btc')
       subject.fetch('btc', currency)
       stub.should have_been_requested.twice
@@ -88,7 +77,7 @@ describe CryptoArbitrer::Base do
 
   %w(uyu brl clp sgd eur).each do |currency|
     it "hits rate-exchange for the #{currency} to usd rate" do
-      stub = stub_get("http://rate-exchange.appspot.com/currency?from=usd&to=#{currency}",
+      stub = stub_crypto_arbitrer_get("http://rate-exchange.appspot.com/currency?from=usd&to=#{currency}",
         "rate_exchange_usd_#{currency}.json")
       subject.fetch('usd', currency)
       subject.fetch(currency, 'usd')
@@ -98,7 +87,7 @@ describe CryptoArbitrer::Base do
   
   describe 'when caching remote calls' do
     it 'does not cache anything by default' do
-      stub = stub_get("http://www.eldolarblue.net/getDolarBlue.php?as=json", 'dolarblue.json')
+      stub = stub_crypto_arbitrer_get("http://www.eldolarblue.net/getDolarBlue.php?as=json", 'dolarblue.json')
       2.times{ subject.fetch('usd', 'ars') }
       stub.should have_been_requested.twice
     end
@@ -106,7 +95,7 @@ describe CryptoArbitrer::Base do
     it 'caches when a cache_backend has been set, stops caching afterwards' do
       cache = {}
       subject.class.cache_backend = lambda {|from, to, block| cache[[from,to]] ||= block.call }
-      stub = stub_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
+      stub = stub_crypto_arbitrer_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
       subject.fetch('btc', 'usd')
       cache[['btc','usd']].should be_a(Hash)
       subject.fetch('btc', 'usd')
@@ -119,7 +108,7 @@ describe CryptoArbitrer::Base do
     it 'does not cache for low level calls' do
       cache = {}
       subject.class.cache_backend = lambda {|from, to, block| cache[key] ||= block.call }
-      stub = stub_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
+      stub = stub_crypto_arbitrer_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
       subject.fetch_btc_usd
       subject.fetch_btc_usd
       stub.should have_been_requested.twice
@@ -128,7 +117,7 @@ describe CryptoArbitrer::Base do
     it 'does not cache when using a force argument' do
       cache = {}
       subject.class.cache_backend = lambda {|from, to, block| cache[key] ||= block.call }
-      stub = stub_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
+      stub = stub_crypto_arbitrer_get('http://data.mtgox.com/api/2/BTCUSD/money/ticker_fast', 'mtgox.json')
       subject.fetch('btc', 'usd', true)
       subject.fetch('btc', 'usd', true)
       stub.should have_been_requested.twice

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: crypto_arbitrer
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-21 00:00:00.000000000 Z
+date: 2013-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -109,6 +109,7 @@ files:
 - Rakefile
 - crypto_arbitrer.gemspec
 - lib/crypto_arbitrer.rb
+- lib/crypto_arbitrer/spec_helper.rb
 - lib/crypto_arbitrer/version.rb
 - spec/base_spec.rb
 - spec/conversions.csv