crispy 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aeabc7281ef6034dc9561bf66275b5a96646ec7e
-  data.tar.gz: 0d59f9c8a70531346cfc064724520b0703511d7f
+  metadata.gz: c3f5cac13b6c7c9ab3d1a02c14d7c4aab8d49a37
+  data.tar.gz: 0d3a8f30a788ca7b6f65656e2d754500edfed384
 SHA512:
-  metadata.gz: 10e249a572a5a3ac6e17aaf6a0bc537472467157a788c7a1fb1f3014764f6266fb1ac32ea453a6ecebe4284372302833680ab07ee94248ca54e60357b9b55f82
-  data.tar.gz: 65fcd4b0434c4ca977a47439864cabf6133fa3a7e29d26494cd464cfadafdbafec6ee8136b8a8fb8545faeb297766dbc0e3150935911aaeace032a7ce23cd6fa
+  metadata.gz: 18e6deacab79ac272ae87429c086e1f087209f237c428c1fd5f4a5e23fe58b02d583df118d8534692d79d03a167024f0559f266d8f4851cab6bbe25377d956f2
+  data.tar.gz: 831d33b2b1878255f2396b2f2d14175569e5a6e5ad17d8d81a97864f27b93d69e8cadf7ce58b90ac070bfd973170ce5556bbc028a8679a4a22c3911d4e208e27

data/ChangeLog.md

@@ -1,7 +1,12 @@
+# 0.3.3 (2015.3.27)
+
+- Fix Bug: Causes a crash when some of `@spies_to_reset` gets GCed just before `reinitialize`. [3a1ce2d](https://github.com/igrep/crispy/commit/3a1ce2dfc25ba48d07505b6ed1d7125f393e9579)
+- Enhancement: raise error when given some non spied object (or class) by mistake. [4719652](https://github.com/igrep/crispy/commit/4719652d35292749b76fd2531bfec83a4d383a66 )
+
 # 0.3.2 (2015.1.11)
 
 - New Feature: `spied_instances?`. [#28](https://github.com/igrep/crispy/pull/28)
-- Enhancement only for developers of crispy: reduce the number of gems we install by `bundle install`.
+- Enhancement: only for developers of crispy: reduce the number of gems we install by `bundle install`.
 - Refactor: minor changes. [`701a051`](https://github.com/igrep/crispy/commit/701a051d3910e8b9f0470c0f3e9cb81ed643f8af)
 
 # 0.3.1 (2015.1.3)

data/lib/crispy.rb

@@ -24,10 +24,14 @@ module Crispy
 
   def spy object
     object.__CRISPY_SPY__
+  rescue ::NoMethodError
+    object_string = object.inspect rescue 'object' # BasicObject can't inspect!
+    raise ::Crispy::CrispyError, "#{object_string} is not spied!"
   end
 
   def spy_of_instances klass
-    ::Crispy::CrispyInternal::ClassSpy.of_target(klass)
+    ::Crispy::CrispyInternal::ClassSpy.of_target(klass) \
+      || raise(::Crispy::CrispyError, "#{klass} does not have its instances spied!")
   end
 
   def stub_const full_const_name, value
@@ -43,4 +47,7 @@ module Crispy
     !!::Crispy::CrispyInternal::ClassSpy.of_target(klass)
   end
 
+  class CrispyError < ::Exception
+  end
+
 end

data/lib/crispy/crispy_internal/spy.rb

@@ -49,9 +49,12 @@ module Crispy
 
       def self.reset_all
         # get rid of spies of GCed objects
-        @spies_to_reset.select! {|spy| spy.weakref_alive? }
-
-        @spies_to_reset.each {|spy| spy.reinitialize }
+        @spies_to_reset.select! do|spy|
+          if alive = spy.weakref_alive?
+            spy.reinitialize
+          end
+          alive
+        end
       end
 
     end

data/lib/crispy/version.rb

@@ -1,3 +1,3 @@
 module Crispy
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

data/test/test_crispy.rb

@@ -49,7 +49,7 @@ class TestCrispy < MiniTest::Test
       'method to stub 3 (before stubbed)'
     end
 
-    def private_foo a
+    def private_foo _
       :private_foo
     end
     private :private_foo
@@ -204,6 +204,10 @@ class TestCrispy < MiniTest::Test
       assert_equal(:stubbed2, @object.method_to_stub2)
     end
 
+    def test_spy_raises_an_error_given_non_spied_object
+      assert_raises(::Crispy::CrispyError){ spy(ObjectClass.new) }
+    end
+
   end
 
   class TestCrispySpyIntoClass < TestCrispy
@@ -259,6 +263,10 @@ class TestCrispy < MiniTest::Test
       assert_equal 1, spy(ObjectClass).count_received(:stubbed_method1)
     end
 
+    def test_spy_of_instances_raises_an_error_given_non_spied_instances_object
+      assert_raises(::Crispy::CrispyError){ spy_of_instances(Class.new) }
+    end
+
   end
 
   class TestCrispySpyIntoInstances < TestCrispy

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: crispy
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Yuji Yamamoto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-11 00:00:00.000000000 Z
+date: 2015-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler