creditsafe 0.6.3 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e5e6b555edb6131078c45308e06860adbfb18afdf8326eccedf0e3b40bf12d32
-  data.tar.gz: 04e6caab6be667db17b3d2f0dea79c610b2b3e2972066cdbb0d97fdbaf65b9d4
+  metadata.gz: b8b73972a559fa2c2a39d2aa8155fe6369c9cefa3285502c9a21d34536bae3c6
+  data.tar.gz: ff09f26c803fdba79e4bc33bb0af3b8dfd3098d0d280c81532edbbfe08e3dc9a
 SHA512:
-  metadata.gz: dd71392a827914caf224daf0d4d4f7b5b99628e7f08679e93cdea57ab2d91893931cd0942b8c8fc1f5e0b2942cd375193fb80d883f41068cdc24871148e38ab0
-  data.tar.gz: 4f430154fc5c8d6414426f92f75b09dc340bd9506abd9899cd7711eaeda28aaf4f98ce4f5a0ace1758e11bcc024bf93c7207f97ff8a1a448d2a187af4fdcba89
+  metadata.gz: 123929e34d1a1c6f5069164a4c4d2824cdcad775a4edd4b08af102b29e1f1721921d28a8cb33b8e45b9ad713b1e30e2c9e1baa7f9c270ee94a45282e8a0c160d
+  data.tar.gz: 91393f169e292ecb3e8e24a77bdd480fbafcc02a17ddd15c9d1d810e308e4fb5a1d05e39349a1229beaf18b43cc6bf977ff39932a911f817252bb4e2ac567562

data/.circleci/config.yml

@@ -1,17 +1,66 @@
-version: 2
+---
+version: 2.1
+
+references:
+  bundle_install: &bundle_install
+    run:
+      name: Bundle
+      command: |
+        gem install bundler --no-document && \
+        bundle config set no-cache 'true' && \
+        bundle config set jobs '4' && \
+        bundle config set retry '3' && \
+        bundle install
+
+  cache_bundle: &cache_bundle
+    save_cache:
+      key: bundle-<< parameters.ruby_version >>-{{ checksum "creditsafe.gemspec" }}-{{ checksum "Gemfile" }}
+      paths:
+        - vendor/bundle
+
+  restore_bundle: &restore_bundle
+    restore_cache:
+      key: bundle-<< parameters.ruby_version >>-{{ checksum "creditsafe.gemspec" }}-{{ checksum "Gemfile" }}
+
+  steps: &steps
+    - checkout
+    - *restore_bundle
+    - *bundle_install
+    - *cache_bundle
+    - run:
+        name: Run specs
+        command: |
+          circleci tests glob "spec/**/*_spec.rb"
+          bundle exec rspec $(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings) --profile --format progress --format RspecJunitFormatter -o /tmp/circle_artifacts/rspec.xml
+    - run:
+        name: "Rubocop"
+        command: bundle exec rubocop --extra-details --display-style-guide --parallel --force-exclusion
+    - store_artifacts:
+        path: /tmp/circle_artifacts/
+    - store_test_results:
+        path: /tmp/circle_artifacts/
+
+  ruby_versions: &ruby_versions
+    - "2.7"
+    - "3.0"
+
 jobs:
-  build:
-    working_directory: ~/creditsafe-ruby
+  test_and_lint:
+    working_directory: /mnt/ramdisk
+    parameters:
+      ruby_version:
+        type: string
     docker:
-      - image: ruby:2.5
-    steps:
-      - checkout
-      - restore_cache:
-          key: bundler-v1-{{ checksum "creditsafe.gemspec" }}-{{ checksum ".ruby-version" }}
-      - run: bundle install --path vendor/bundle
-      - save_cache:
-          key: bundler-v1-{{ checksum "creditsafe.gemspec" }}-{{ checksum ".ruby-version" }}
-          paths:
-            - "vendor/bundle"
-      - run: bundle exec rubocop
-      - run: bundle exec rspec --format RspecJunitFormatter
+      - image: cimg/ruby:<< parameters.ruby_version >>
+        environment:
+          CIRCLE_TEST_REPORTS: /tmp/circle_artifacts/
+    steps: *steps
+
+workflows:
+  version: 2
+  tests:
+    jobs:
+      - test_and_lint:
+          matrix:
+            parameters:
+              ruby_version: *ruby_versions

data/.github/dependabot.yml

@@ -0,0 +1,17 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: daily
+  open-pull-requests-limit: 10
+  ignore:
+  - dependency-name: webmock
+    versions:
+    - 3.11.1
+    - 3.11.2
+    - 3.11.3
+    - 3.12.0
+  - dependency-name: pry
+    versions:
+    - 0.14.0

data/.rubocop.yml

@@ -10,5 +10,9 @@ RSpec/ExampleLength:
 RSpec/MultipleExpectations:
   Max: 2
 
+AllCops:
+  TargetRubyVersion: 2.7
+  NewCops: enable
+
 RSpec/ImplicitBlockExpectation:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.5.6
+3.0.2

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## v0.7.0, 5 October 2021
+
+- Rename Constants::Country to Creditsafe::Country, to avoid polluting other namespaces
+- Update dependencies: activesupport, excon
+- Downgrade savon
+- Require Ruby 2.7+
+
 ## v0.6.3, 18 December 2019
 
 - Update dependencies: excon

data/creditsafe.gemspec

@@ -12,23 +12,24 @@ Gem::Specification.new do |spec|
   spec.summary       = "Ruby client for the Creditsafe SOAP API"
   spec.homepage      = "https://github.com/gocardless/creditsafe-ruby"
   spec.license       = "MIT"
+  spec.required_ruby_version = ">= 2.7.0"
 
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "activesupport", "~> 5.2"
-  spec.add_runtime_dependency "excon", "~> 0.71"
-  spec.add_runtime_dependency "savon", "~> 2.12"
+  spec.add_runtime_dependency "activesupport"
+  spec.add_runtime_dependency "excon", "~> 0.85"
+  spec.add_runtime_dependency "savon", "~> 2.11"
 
   spec.add_development_dependency "compare-xml", "~> 0.66"
-  spec.add_development_dependency "gc_ruboconfig", "~> 2.3.14"
-  spec.add_development_dependency "pry", "~> 0.12.2"
+  spec.add_development_dependency "gc_ruboconfig", "~> 2.28"
+  spec.add_development_dependency "pry", "~> 0.14"
   spec.add_development_dependency "rspec", "~> 3.8"
   spec.add_development_dependency "rspec-its", "~> 1.3"
-  spec.add_development_dependency "rspec_junit_formatter", "~> 0.4.1"
-  spec.add_development_dependency "rubocop", "~> 0.61.1"
-  spec.add_development_dependency "rubocop-rspec", "~> 1.35"
-  spec.add_development_dependency "timecop", "~> 0.9.1"
-  spec.add_development_dependency "webmock", "~> 3.7.2"
+  spec.add_development_dependency "rspec_junit_formatter", "~> 0.4"
+  spec.add_development_dependency "rubocop", "~> 1.20"
+  spec.add_development_dependency "rubocop-rspec", "~> 2.4"
+  spec.add_development_dependency "timecop", "~> 0.9"
+  spec.add_development_dependency "webmock", "~> 3.14"
 end

data/lib/creditsafe/client.rb

@@ -87,14 +87,14 @@ module Creditsafe
       response = client.call(message_type, message: message)
       handle_message_for_response(response)
       notification_payload[:response] = response.body
-    rescue Excon::Errors::Timeout => raw_error
-      notification_payload[:error] = handle_error(raw_error)
+    rescue Excon::Errors::Timeout => e
+      notification_payload[:error] = handle_error(e)
       raise TimeoutError
-    rescue Excon::Errors::BadGateway => raw_error
-      notification_payload[:error] = handle_error(raw_error)
+    rescue Excon::Errors::BadGateway => e
+      notification_payload[:error] = handle_error(e)
       raise BadGatewayError
-    rescue => raw_error
-      processed_error = handle_error(raw_error)
+    rescue => e
+      processed_error = handle_error(e)
       notification_payload[:error] = processed_error
       raise processed_error
     ensure

data/lib/creditsafe/{constants.rb → country.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module Constants
+module Creditsafe
   module Country
     AUSTRALIA                 = "AU"
     AUSTRIA                   = "AT"

data/lib/creditsafe/errors.rb

@@ -4,14 +4,20 @@ module Creditsafe
   class Error < StandardError; end
 
   class HttpError < Error; end
+
   class ApiError < Error; end
 
   class TimeoutError < HttpError; end
+
   class BadGatewayError < HttpError; end
 
   class DataError < ApiError; end
+
   class AccountError < ApiError; end
+
   class RequestError < ApiError; end
+
   class ProcessingError < ApiError; end
+
   class UnknownApiError < ApiError; end
 end

data/lib/creditsafe/messages.rb

@@ -31,7 +31,7 @@ module Creditsafe
       end
     end
 
-    # rubocop:disable Metrics/LineLength
+    # rubocop:disable Layout/LineLength
     NO_RESULTS                    = Message.new(code: "010101", message: "No results")
     TOO_MANY_RESULTS              = Message.new(code: "010102", message: "Too many results")
     REPORT_UNAVAILABLE            = Message.new(code: "010103", message: "Report unavailable", error: true)
@@ -54,7 +54,7 @@ module Creditsafe
     OTHER_ERROR                   = Message.new(code: "040102", message: "Other", error: true)
     DATA_SERVICE_PROBLEMS         = Message.new(code: "040103", message: "Data service access problems", error: true)
     DATA_SERVICE_INVALID_RESPONSE = Message.new(code: "040104", message: "Data service invalid response", error: true)
-    # rubocop:enable Metrics/LineLength
+    # rubocop:enable Layout/LineLength
 
     ALL = [
       NO_RESULTS,

data/lib/creditsafe/request/find_company.rb

@@ -2,7 +2,7 @@
 
 require "creditsafe/match_type"
 require "creditsafe/namespace"
-require "creditsafe/constants"
+require "creditsafe/country"
 
 module Creditsafe
   module Request
@@ -77,7 +77,6 @@ module Creditsafe
 
       # rubocop:disable Metrics/CyclomaticComplexity
       # rubocop:disable Metrics/MethodLength
-      # rubocop:disable Metrics/PerceivedComplexity
       # rubocop:disable Metrics/AbcSize
       def check_search_criteria(search_criteria)
         if search_criteria[:country_code].nil?
@@ -97,13 +96,12 @@ module Creditsafe
           raise ArgumentError, "Postal code is only supported for German searches"
         end
 
-        if search_criteria[:vat_number] && !Constants::Country::VAT_NUMBER_SUPPORTED.
+        if search_criteria[:vat_number] && !Creditsafe::Country::VAT_NUMBER_SUPPORTED.
             include?(search_criteria[:country_code])
           raise ArgumentError, "VAT number is not supported in this country"
         end
       end
       # rubocop:enable Metrics/AbcSize
-      # rubocop:enable Metrics/PerceivedComplexity
       # rubocop:enable Metrics/MethodLength
       # rubocop:enable Metrics/CyclomaticComplexity
 

data/lib/creditsafe/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Creditsafe
-  VERSION = "0.6.3"
+  VERSION = "0.7.0"
 end

data/spec/creditsafe/client_spec.rb

@@ -154,7 +154,7 @@ RSpec.describe(Creditsafe::Client) do
         vat_number: vat_number,
         city: city,
         postal_code: postal_code,
-      }.reject { |_, v| v.nil? }
+      }.compact
     end
 
     let(:find_company) { client.find_company(search_criteria) }

metadata

@@ -1,57 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: creditsafe
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.7.0
 platform: ruby
 authors:
 - GoCardless Engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-18 00:00:00.000000000 Z
+date: 2021-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.71'
+        version: '0.85'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.71'
+        version: '0.85'
 - !ruby/object:Gem::Dependency
   name: savon
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '2.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '2.11'
 - !ruby/object:Gem::Dependency
   name: compare-xml
   requirement: !ruby/object:Gem::Requirement
@@ -72,28 +72,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.14
+        version: '2.28'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.14
+        version: '2.28'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.2
+        version: '0.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.2
+        version: '0.14'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -128,71 +128,71 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.1
+        version: '0.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.1
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.61.1
+        version: '1.20'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.61.1
+        version: '1.20'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.35'
+        version: '2.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.35'
+        version: '2.4'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.1
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.1
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.2
+        version: '3.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.2
-description: 
+        version: '3.14'
+description:
 email:
 - engineering@gocardless.com
 executables: []
@@ -200,6 +200,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".github/dependabot.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -213,7 +214,7 @@ files:
 - data/creditsafe-test.xml
 - lib/creditsafe.rb
 - lib/creditsafe/client.rb
-- lib/creditsafe/constants.rb
+- lib/creditsafe/country.rb
 - lib/creditsafe/errors.rb
 - lib/creditsafe/match_type.rb
 - lib/creditsafe/messages.rb
@@ -239,7 +240,7 @@ homepage: https://github.com/gocardless/creditsafe-ruby
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -247,16 +248,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
-signing_key: 
+rubygems_version: 3.2.22
+signing_key:
 specification_version: 4
 summary: Ruby client for the Creditsafe SOAP API
 test_files: