credit_card_validations 6.1.0 → 6.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b8d3e090e222ece5a4532b931d8bfedf9a4ac73e2c924e09c6c2d465364c3ca
-  data.tar.gz: 10f9892d010c271806dcbce9c26178a3318873ae3b925c719e6e496a529bc89b
+  metadata.gz: 80528d2245ce569ed3b865c186f272d37581606a90ca679e391da8abfd3f003b
+  data.tar.gz: 85100246c15156a33e7c491988edcfddc171f26e63dc38dd4783636becb5912a
 SHA512:
-  metadata.gz: e4bc9ea274ed6cf155c6185b36bca6a99c28fcf7f73634b4679c0ffe2103b953fad46f8595dc82a76ba559358554d968faccdfe511c4666395c718e4296abfe8
-  data.tar.gz: 9c7dd57ab21943def16202b67a50494713cfc46c30c6b2cf6f11208d81c9ee721edf48e3ada864a7abdb081c2f14990ec905504b4db9920b209bdb3fdbb665a7
+  metadata.gz: 276527c57560abaad1216c80bc76e0e57861337ded7451902e5c872800eaaf7deb00b89d1426adbea3100702ff100179a3a16232728bf541242e3002303c3ffd
+  data.tar.gz: b3ae52f16663e2acf0a6133f170c2f3d73e13aaa1814f7fc4e165d5d93f6282ef4751e8e79f43d174d1ff6f5708c5a3da28aa82180917eecef85df86b09c7111

data/.github/workflows/build.yml

@@ -15,6 +15,7 @@ jobs:
         - '3.0'
         - 3.1
         - 3.2
+        - 3.3
         rails:
         - '6.1.5'
         - '7.0.2.3'

data/Changelog.md

@@ -1,3 +1,10 @@
+# 6.2.0
+  * support ruby 3.3
+  * more accurate brand matching using matched prefix length
+  
+# 6.1.0
+  * support rails 7.1
+
 # 6.0.0
   * changes to discover branch
   * allows to configure usage of own yaml brands file 

data/lib/credit_card_validations/detector.rb

@@ -28,8 +28,14 @@ module CreditCardValidations
     def valid_number?(*keys)
       selected_brands = keys.blank? ? self.brands : resolve_keys(*keys)
       if selected_brands.any?
+        matched_brands = []
         selected_brands.each do |key, brand|
-          return key if matches_brand?(brand)
+          match_data = matches_brand?(brand)
+          matched_brands << {brand: key, matched_prefix_length: match_data.to_s.length} if match_data
+        end
+
+        if matched_brands.present?
+          return matched_brands.sort{|a, b| a[:matched_prefix_length] <=> b[:matched_prefix_length]}.last[:brand]
         end
       end
       nil
@@ -64,8 +70,8 @@ module CreditCardValidations
       rules.each do |rule|
         if (options[:skip_luhn] || valid_luhn?) &&
             rule[:length].include?(number.length) &&
-            number.match(rule[:regexp])
-          return true
+            match_data = number.match(rule[:regexp])
+          return match_data
         end
       end
       false

data/lib/credit_card_validations/version.rb

@@ -1,3 +1,3 @@
 module CreditCardValidations
-  VERSION = '6.1.0'
+  VERSION = '6.2.0'
 end

data/spec/credit_card_validations_spec.rb

@@ -170,6 +170,28 @@ describe CreditCardValidations do
           end
         end
       end
+
+      describe 'Add kortimilli rule' do
+        let(:kortimilli_number) { '505827028341713' }
+
+        it 'before invoke add_brand credit card behaves like maestro' do
+          expect(detector(kortimilli_number).valid?(:maestro)).must_equal true
+          expect(detector(kortimilli_number).maestro?).must_equal true
+          expect(detector(kortimilli_number).brand).must_equal :maestro
+        end
+
+        describe 'after adding wider prefix for kortimilli' do
+          before do
+            CreditCardValidations::Detector.add_brand(:kortimilli, length: 15, prefixes: '505827028')
+          end
+
+          it 'should validate number as kortimilli' do
+            expect(detector(kortimilli_number).valid?(:kortimilli)).must_equal true
+            expect(detector(kortimilli_number).kortimilli?).must_equal true
+            expect(detector(kortimilli_number).brand).must_equal :kortimilli
+          end
+        end
+      end
     end
 
     describe 'plugins' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_validations
 version: !ruby/object:Gem::Version
-  version: 6.1.0
+  version: 6.2.0
 platform: ruby
 authors:
 - Igor
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-30 00:00:00.000000000 Z
+date: 2024-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -167,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.4.22
 signing_key:
 specification_version: 4
 summary: gem should be used for credit card numbers validation, card brands detections,