credit_card_validations 1.4.1 → 1.4.2

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    NjAyN2VjODkxNmY1OWVhM2M2YjlhYTk0ZTE4ZDQ4Y2NkNjhkZGI0Ng==
+  data.tar.gz: !binary |-
+    NTM3MTY2NzdmYzBiODZiNTk0ODAyMzYxZTEyMDkwM2IwNGI2NTc5NA==
+SHA512:
+  metadata.gz: !binary |-
+    YzY2Y2QwNTA2ZTc2NTFlNmM0NmNhYzBjZTUwNmFkNDU4MTY0YjIzMjBiNmUw
+    MTA1M2Y5ZGY2OWVjZTQxOTJmNDg1NjAxYTdkYWViODYxNTM2OWIwNjQwMDEz
+    MTE3MzViOTdjNzQwNmJiYjA4YWRlNmQyMDk3NGFjMDY5NDAxOWQ=
+  data.tar.gz: !binary |-
+    YWQ0OGIyODBhMmU0ZmM1ZGVkYzBjODA0Y2U1MTA4NzBiMmY0YzFmOWZiMTU2
+    ZmMxZTM2YWE5OTk0M2I3Mzg1NTA0MjIzYjc2NTQ0N2E5NGNhZTRjYjY4N2Fj
+    MjcyNDhmNjhhNmQ1Yzg2ZWFmM2JjODhlOWRlYzQ1MzYzY2JjNjU=

data/.travis.yml

@@ -2,5 +2,4 @@ language: ruby
 rvm:
   - 1.9.3
   - jruby-19mode
-  - rbx-19mode
   - 2.0.0

data/README.md

@@ -96,3 +96,6 @@ for all known brands
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+
+

data/credit_card_validations.gemspec

@@ -11,17 +11,19 @@ Gem::Specification.new do |gem|
   gem.description   = %q{A ruby gem for validating credit card numbers (a port of ZF2 Zend\Validator\CreditCard)}
   gem.summary       = "gem for credit card numbers validation, card brands detections"
   gem.homepage      = "https://github.com/Fivell/credit_card_validations"
-
+  gem.license     = 'MIT'
+  
   gem.files         = `git ls-files`.split($/)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency "activemodel", ">= 3.0", "< 4.1"
-  gem.add_dependency "activesupport", ">= 3.0", "< 4.1"
 
-  gem.add_development_dependency "test-unit"
-  gem.add_development_dependency "mocha"
-  gem.add_development_dependency 'rake'
+  gem.add_dependency "activemodel", ">= 3.0", "<= 4.2"
+  gem.add_dependency "activesupport", ">= 3.0", "<= 4.2"
+
+  gem.add_development_dependency "test-unit",'~> 2.5'
+  gem.add_development_dependency "mocha", '~> 0.12'
+  gem.add_development_dependency 'rake', '~> 10'
 
 end

data/lib/credit_card_validations/card_rules.rb

@@ -1,62 +1,60 @@
 module CreditCardValidations
   module CardRules
     ########  most used brands #########
-
-
-    VISA = [
-        {length: [16], prefixes: ['4']}
-    ]
-    MASTERCARD = [
-        {length: [16], prefixes: ['51', '52', '53', '54', '55']}
-    ]
-    ######## other brands ########
-    AMEX = [
-        {length: [15], prefixes: ['34', '37']}
-    ]
-
-    DINERS = [
-        {length: [14], prefixes: ['300', '301', '302', '303', '304', '305', '36']},
-    ]
-
-    #There are Diners Club (North America) cards that begin with 5. These are a joint venture between Diners Club and MasterCard, and are processed like a MasterCard
-    DINERS_US = [
-        {length: [16], prefixes: ['54', '55']}
-    ]
-
-    DISCOVER = [
-        {length: [16], prefixes: ['6011', '622126', '622127', '622128', '622129', '62213',
-                                '62214', '62215', '62216', '62217', '62218', '62219',
-                                '6222', '6223', '6224', '6225', '6226', '6227', '6228',
-                                '62290', '62291', '622920', '622921', '622922', '622923',
-                                '622924', '622925', '644', '645', '646', '647', '648',
-                                '649', '65']}
-    ]
-
-    JCB = [
-        {length: [16], prefixes: ['3528', '3529', '353', '354', '355', '356', '357', '358']}
-    ]
-
-
-    LASER = [
-        {length: [16, 17, 18, 19], prefixes: ['6304', '6706', '6771', '6709']}
-    ]
-
-    MAESTRO = [
-        {length: [12, 13, 14, 15, 16, 17, 18, 19], prefixes: ['5018', '5020', '5038', '6304', '6759', '6761', '6762','6763', '6764', '6765', '6766']}
-    ]
-
-    SOLO = [
-        {length: [16, 18, 19], prefixes: ['6334', '6767']}
-    ]
-
-    UNIONPAY = [
-        {length: [16, 17, 18, 19], prefixes: ['620', '621', '623', '625', '626'], skip_validation: true}
-    ]
-
-    DANKROT = [
-       {length: [16], prefixes: ['5019']}
-    ]
-
-
+    mattr_accessor :rules
+
+    self.rules = {
+        visa: [
+            {length: [16], prefixes: ['4']}
+        ],
+        mastercard: [
+            {length: [16], prefixes: ['51', '52', '53', '54', '55']}
+        ],
+        ######## other brands ########
+        amex: [
+            {length: [15], prefixes: ['34', '37']}
+        ],
+
+        diners: [
+            {length: [14], prefixes: ['300', '301', '302', '303', '304', '305', '36']},
+        ],
+
+        #There are Diners Club (North America) cards that begin with 5. These are a joint venture between Diners Club and MasterCard, and are processed like a MasterCard
+        # will be removed in next major version
+
+        diners_us: [
+            {length: [16], prefixes: ['54', '55']}
+        ],
+
+        discover: [
+            {length: [16], prefixes: ['6011', '644', '645', '646', '647', '648',
+                                      '649', '65']}
+        ],
+
+        jcb: [
+            {length: [16], prefixes: ['3528', '3529', '353', '354', '355', '356', '357', '358']}
+        ],
+
+
+        laser: [
+            {length: [16, 17, 18, 19], prefixes: ['6304', '6706', '6771', '6709']}
+        ],
+
+        maestro: [
+            {length: [12, 13, 14, 15, 16, 17, 18, 19], prefixes: ['5018', '5020', '5038', '6304', '6759', '6761', '6762', '6763', '6764', '6765', '6766']}
+        ],
+
+        solo: [
+            {length: [16, 18, 19], prefixes: ['6334', '6767']}
+        ],
+        # Luhn validation are skipped for union pay cards because they have unknown generation algoritm
+        unionpay: [
+            {length: [16, 17, 18, 19], prefixes: ['622', '624', '625', '626', '628'], skip_validation: true}
+        ],
+
+        dankrot: [
+            {length: [16], prefixes: ['5019']}
+        ],
+    }
   end
 end

data/lib/credit_card_validations/detector.rb

@@ -62,9 +62,9 @@ module CreditCardValidations
       end
     end
 
-    CardRules.constants.each do |const_name|
-      CardRules.const_get(const_name).each do |const_value|
-        self.add_rule(const_name.to_s.downcase.to_sym , const_value[:length], const_value[:prefixes], const_value[:skip_validation])
+    CardRules.rules.each do |name, rules|
+       rules.each do |rule_value|
+        self.add_rule(name, rule_value[:length], rule_value[:prefixes], rule_value[:skip_validation])
       end
 
     end

data/lib/credit_card_validations/version.rb

@@ -1,3 +1,3 @@
 module CreditCardValidations
-  VERSION = "1.4.1"
+  VERSION = "1.4.2"
 end

data/test/credit_card_validations_test.rb

@@ -15,71 +15,71 @@ class CreditCardValidationsTest < Test::Unit::TestCase
     validates :number, credit_card_number: {brands: [:amex, :maestro]}
   end
 
-
-
-class CreditCardModelAny
+  class CreditCardModelAny
     attr_accessor :number
     include ActiveModel::Validations
     validates :number, presence: true, credit_card_number: true
-end
-
+  end
 
   def initialize name
     super name
     @test_numbers = {
-        visa: '4012 8888 8888 1881',
-        mastercard: '5274 5763 9425 9961',
-        diners: '3020 4169 3226 43',
-        amex: '3782 8224 6310 005',
-        discover: '6011 1111 1111 1117',
-        maestro: '6759 6498 2643 8453',
-        jcb: '3575 7591 5225 4876',
-        solo: '6767 6222 2222 2222 222',
-        unionpay: '6264-1852-1292-2132-067',
-        dankrot: '5019717010103742'
-
+      visa:       ['4012 8888 8888 1881','4111111111111111'],
+      mastercard: ['5274 5763 9425 9961', '5555-5555-5555-4444'],
+      diners:     ['3020 4169 3226 43', '30569309025904'],
+      amex:       ['3782 8224 6310 005', '371449635398431'],
+      discover:   ['6011 1111 1111 1117','6011000990139424'],
+      maestro:    ['6759 6498 2643 8453'],
+      jcb:        ['3575 7591 5225 4876', '3566002020360505' ],
+      solo:       ['6767 6222 2222 2222 222'],
+      unionpay:   ['6264-1852-1292-2132-067', '6288997715452584', '6269 9920 5813 4322'],
+      dankrot:    ['5019717010103742']
     }
   end
-
+  
   def test_card_brand_detection
     @test_numbers.each do |key, value|
-      assert_equal key, detector(value).brand
-      assert detector(value).send("#{key}?")
+      value.each do |card_number|
+        assert detector(card_number).send("#{key}?")
+        assert_equal key, detector(card_number).brand
+      end
     end
   end
-
+  
   def test_card_brand_is_nil_if_credit_card_invalid
     assert_nil detector('1111111111111111').brand
   end
-
+  
   def test_card_brand_detection_with_restriction
     @test_numbers.slice(:visa, :mastercard).each do |key, value|
-      assert_equal key, detector(value).brand(:visa, :mastercard)
+      assert_equal key, detector(value.first).brand(:visa, :mastercard)
     end
-
+    
     @test_numbers.except(:visa, :mastercard).each do |key, value|
-      assert_nil detector(value).brand(:visa, :mastercard)
+      assert_nil detector(value.first).brand(:visa, :mastercard)
     end
   end
-
+  
   def test_card_valid_method
     @test_numbers.each do |key, value|
-      assert detector(value).valid?(key)
-      assert detector(value).valid?
+      value.each do |card_number|
+        assert detector(card_number).valid?(key)
+        assert detector(card_number).valid?
+      end
     end
     assert !detector('1111111111111111').valid?
   end
 
 
   def test_card_particular_brand_valid
-    assert !detector(@test_numbers[:visa]).valid?(:mastercard)
-    assert !detector(@test_numbers[:mastercard]).valid?(:visa)
+    assert !detector(@test_numbers[:visa].first).valid?(:mastercard)
+    assert !detector(@test_numbers[:mastercard].first).valid?(:visa)
   end
 
 
   def test_card_particular_brands_valid
-    assert detector(@test_numbers[:visa]).valid?(:mastercard, :visa)
-    assert !detector(@test_numbers[:visa]).valid?(:mastercard, :amex)
+    assert detector(@test_numbers[:visa].first).valid?(:mastercard, :visa)
+    assert !detector(@test_numbers[:visa].first).valid?(:mastercard, :amex)
   end
 
   #add rules which were not present before
@@ -96,11 +96,11 @@ end
 
   def test_active_model_validator
      cc = CreditCardModel.new
-     cc.number = @test_numbers[:maestro]
+     cc.number = @test_numbers[:maestro].first
      assert cc.valid?
 
      cc = CreditCardModel.new
-     cc.number = @test_numbers[:mastercard]
+     cc.number = @test_numbers[:mastercard].first
      assert !cc.valid?
      assert cc.errors[:number].include?(cc.errors.generate_message(:number, :invalid))
 
@@ -108,33 +108,31 @@ end
     cc = CreditCardModelAny.new
     cc.number='1'
     assert !cc.valid?
-    cc.number = @test_numbers[:mastercard]
+    cc.number = @test_numbers[:mastercard].first
     assert cc.valid?
 
   end
 
   def test_string_extension
     require 'credit_card_validations/string'
-    assert_equal  @test_numbers[:mastercard].credit_card_brand, :mastercard
-    assert  @test_numbers[:mastercard].valid_credit_card_brand?(:mastercard)
-    assert !@test_numbers[:mastercard].valid_credit_card_brand?(:visa, :amex)
+    assert_equal  @test_numbers[:mastercard].first.credit_card_brand, :mastercard
+    assert  @test_numbers[:mastercard].first.valid_credit_card_brand?(:mastercard)
+    assert !@test_numbers[:mastercard].first.valid_credit_card_brand?(:visa, :amex)
   end
 
 
   def test_skip_validation
-    d = detector(@test_numbers[:unionpay])
+    d = detector(@test_numbers[:unionpay].first)
+
     d.expects(:valid_luhn?).never
     assert d.valid?(:unionpay)
 
-    d = detector(@test_numbers[:unionpay])
     d.expects(:valid_luhn?).once
     assert !d.valid?(:visa)
 
-    d = detector(@test_numbers[:unionpay])
     d.expects(:valid_luhn?).never
     assert d.valid?(:unionpay, :visa)
 
-    d = detector(@test_numbers[:unionpay])
     d.expects(:valid_luhn?).once
     assert d.valid?(:visa, :unionpay)
   end

metadata

@@ -1,108 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_validations
 version: !ruby/object:Gem::Version
-  version: 1.4.1
-  prerelease: 
+  version: 1.4.2
 platform: ruby
 authors:
 - Igor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-10 00:00:00.000000000 Z
+date: 2014-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - <=
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - <=
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - <=
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - <=
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '10'
 description: A ruby gem for validating credit card numbers (a port of ZF2 Zend\Validator\CreditCard)
 email:
 - fedoronchuk@gmail.com
@@ -126,28 +115,28 @@ files:
 - lib/credit_card_validations/version.rb
 - test/credit_card_validations_test.rb
 homepage: https://github.com/Fivell/credit_card_validations
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.2.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: gem for credit card numbers validation, card brands detections
 test_files:
 - test/credit_card_validations_test.rb