credit_card_validations 1.1.1 → 1.1.2

data/.travis.yml

@@ -0,0 +1,8 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 1.9.2
+  - jruby-19mode
+  - rbx-19mode
+  - ruby-head
+  - jruby-head

data/README.md

@@ -1,7 +1,7 @@
 # CreditCardValidations
 
 Gem adds validator  to check whether or not a given number actually falls within the ranges of possible numbers prior to performing such verification, and, as such, CreditCardValidations simply verifies that the credit card number provided is well-formed.
-This is a port of Zend Framework `Zend\Validator\CreditCard` .
+
 
 ## Build status
 [![Build Status](https://travis-ci.org/Fivell/credit_card_validations.png)](https://travis-ci.org/Fivell/credit_card_validations)
@@ -74,7 +74,7 @@ only for certain brads
 	class CreditCardModel
   		attr_accessor :number
   		include ActiveModel::Validations
-  		validates :number, presence: true, credit_card_number: {brands: [:amex, :maestro]}
+  		validates :number, credit_card_number: {brands: [:amex, :maestro]}
 	end
 	
 for all known brands

data/credit_card_validations.gemspec

@@ -17,8 +17,8 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  gem.add_dependency('activemodel', '~> 3.0')
-  gem.add_dependency('activesupport', '~> 3.0')
+  gem.add_dependency "activemodel", ">= 3.0", "< 4.1"
+  gem.add_dependency "activesupport", ">= 3.0", "< 4.1"
 
   gem.add_development_dependency "test-unit"
   gem.add_development_dependency 'rake'

data/lib/active_model/credit_card_number_validator.rb

@@ -4,7 +4,7 @@ module ActiveModel
 
       def validate_each(record, attribute, value)
         brands = options.fetch(:brands) 
-        record.errors[attribute] << (options[:message] || "is not valid") unless credit_card_valid?(value, Array.wrap(brands))
+        record.errors.add(attribute) unless credit_card_valid?(value, brands == :any ? [] : Array.wrap(brands) )
       end
 
       def credit_card_valid?(number, brands = [])

data/lib/credit_card_validations/detector.rb

@@ -6,7 +6,7 @@ module CreditCardValidations
     attr_reader :number
 
     def initialize(number)
-      @number = number.to_s.delete(' ')
+      @number = number.to_s.tr('- ','')
     end
 
     # credit card number

data/lib/credit_card_validations/version.rb

@@ -1,3 +1,3 @@
 module CreditCardValidations
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/test/credit_card_validations_test.rb

@@ -11,7 +11,7 @@ class CreditCardValidationsTest < Test::Unit::TestCase
   class CreditCardModel
     attr_accessor :number
     include ActiveModel::Validations
-    validates :number, presence: true, credit_card_number: {brands: [:amex, :maestro]}
+    validates :number, credit_card_number: {brands: [:amex, :maestro]}
   end
 
   def initialize name
@@ -20,12 +20,12 @@ class CreditCardValidationsTest < Test::Unit::TestCase
         visa: '4012 8888 8888 1881',
         mastercard: '5274 5763 9425 9961',
         diners: '3020 4169 3226 43',
-        amex: '3400 0000 0000 009',
+        amex: '3782 8224 6310 005',
         discover: '6011 1111 1111 1117',
         maestro: '6759 6498 2643 8453',
         jcb: '3575 7591 5225 4876',
         solo: '6767 6222 2222 2222 222',
-        unionpay: '6264185212922132067',
+        unionpay: '6264-1852-1292-2132-067',
 
     }
   end
@@ -74,11 +74,14 @@ class CreditCardValidationsTest < Test::Unit::TestCase
   end
 
   def test_active_model_validator
+     cc = CreditCardModel.new
+     cc.number = @test_numbers[:maestro]
+     assert cc.valid?
+      
      cc = CreditCardModel.new
      cc.number = @test_numbers[:mastercard]
      assert !cc.valid?
-     cc.number = @test_numbers[:amex]
-     assert cc.valid?     
+     assert cc.errors[:number].include?(cc.errors.generate_message(:number, :invalid))
   end
   
   def test_string_extension

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_validations
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,33 +9,39 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-23 00:00:00.000000000 Z
+date: 2013-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
-  requirement: &70129509894700 !ruby/object:Gem::Requirement
+  requirement: &70126777364960 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70129509894700
+  version_requirements: *70126777364960
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70129509900380 !ruby/object:Gem::Requirement
+  requirement: &70126777364180 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '3.0'
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70129509900380
+  version_requirements: *70126777364180
 - !ruby/object:Gem::Dependency
   name: test-unit
-  requirement: &70129509896480 !ruby/object:Gem::Requirement
+  requirement: &70126777363520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +49,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70129509896480
+  version_requirements: *70126777363520
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70129509904920 !ruby/object:Gem::Requirement
+  requirement: &70126777363040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +60,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70129509904920
+  version_requirements: *70126777363040
 description: A ruby gem for validating credit card numbers (a port of ZF2 Zend\Validator\CreditCard)
 email:
 - fedoronchuk@gmail.com
@@ -62,6 +68,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md