credit_card_type_field 1.5 → 2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5cdc65dfb777071aaebf63bc2f66b46d666f4efe
-  data.tar.gz: 3ca67eda3f99b8ee73305b41aacdfcc3d0afe72f
+  metadata.gz: 5c1ebdcf64f856f20831709ee43bd00f41bb0bd4
+  data.tar.gz: 73e9733ca24c878a9e1e7849ea626e17fc211d17
 SHA512:
-  metadata.gz: ff022c024e0cc487c9a8913d863c2d7a4a86f3e08aebd0a0c881425edc7c858faa882e84413f9a629661fdc5d9f98b8b2731608c815ac2f24269202d77ea0081
-  data.tar.gz: 2753f314dcf327468fe0f09e8262da089b4d0b7fcf34477231ddfae7b5adc9917bd29aa1488e2b5f6a9e4888651b0edf3a556872f377a4e16bf1e1ba55d2adbf
+  metadata.gz: adb97ef9e5c6e4f9349cc8108f5569503e663cc6f931091f51986610bddad7efc649ba71ceb4a0b1e8e634b694dfe34b9bb5e8ec0f30a90eda6b712bbb7d3a3e
+  data.tar.gz: 66ad4162d949facec49f1fa34884698150b3656c4fe3a7fa14fd9d9432d7b0f5001b6df6087f96245bf4c3017b9a9f244a9b2b5346d9f16103a03d9606aa26f2

data/Gemfile

@@ -7,4 +7,5 @@ gem 'simple_form'
 # gem 'formtastic'
 # gem 'formtastic-bootstrap'
 gem 'rake'
-gem 'rails', '~> 3.2.0'
+gem 'rails', '~> 3.2.0'
+gem 'selenium-webdriver', '2.25.0'

data/README.md

@@ -38,12 +38,12 @@ Support form_for and simple_form_for. Examples:
   <% end %>
 ```
 
-Specify the credit card number name and supported credit card types:
+Specify the credit card number name and supported credit card types. Target is the field that you input the credit card number.
 
 ```ruby
   <%= form_for @credit_card do |f| %>
     <%= f.text_field :card_no %>
-    <%= f.credit_card_type_field :card_type, card_number_field_name: 'card_no', accept_types: %w(visa master) %>
+    <%= f.credit_card_type_field :card_type, card_number_field_name: 'card_no', accept_types: %w(visa master), data: {target: '#card_no'} %>
   <% end %>
 ```
 
@@ -51,7 +51,6 @@ Done! CreditCardTypeField gem will add javascript keyup event listening to the c
 credit card is according to the credit card number. At present, only visa master american_express diners_club are supported. 
 
 ## TODO
-  add credit_card_type_tag
   
   add DEMO
 

data/lib/credit_card_type_field/version.rb

@@ -1,3 +1,3 @@
 module CreditCardField
-  VERSION = "1.5"
+  VERSION = "2.0"
 end

data/lib/credit_card_type_field/view_helper.rb

@@ -3,42 +3,28 @@ module CreditCardTypeField
 
     module FormHelper
       def credit_card_type_field(method, options = {})
-        append_js = options[:js].nil? ? true : options[:js]
-        options[:card_number_field_name] ||= 'credit_card_no'
-        field_name = "#{@object_name}\\\\[#{options[:card_number_field_name]}\\\\]"
+        raise 'please specify data target' unless options.has_key?(:data)
         options[:accept_types] ||= %w(visa master american_express diners_club)
         html = '<ul class="credit-card-type clearfix">'.html_safe
         options[:accept_types].each {|type| html << "<li class=\"icon #{type} #{'active' if self.object.try(method) == type}\">#{type.camelize}</li>".html_safe }
         html << %Q(<li class="icon not_valid #{'active' unless self.object.try(method)}">Invalid Card</li>
                 <li class="hint not_valid"><strong>Not a Valid Credit Card Number</strong></li>
               </ul>).html_safe
-        html << hidden_field(method, rel: 'credit-card-type')
-        html << %Q(
-          <script>
-            $('input[rel=credit-card-type]').closest('form').find('input[name=#{field_name}]').keyup(CreditCardField.keyup);
-          </script>
-          ).html_safe if append_js
+        html << hidden_field(method, rel: 'credit-card-type', data: options[:data])
         html
       end
     end
 
     module FormTagHelper
       def credit_card_type_field_tag(name, value = nil, options = {})
-        append_js = options[:js].nil? ? true : options[:js]
-        options[:card_number_field_name] ||= 'credit_card_no'
-        field_name = options[:card_number_field_name]
+        raise 'please specify data target' unless options.has_key?(:data)
         options[:accept_types] ||= %w(visa master american_express diners_club)
         html = '<ul class="credit-card-type clearfix">'.html_safe
         options[:accept_types].each {|type| html << "<li class=\"icon #{type} #{'active' if value == type}\">#{type.camelize}</li>".html_safe }
         html << %Q(<li class="icon not_valid">Invalid Card</li>
                 <li class="hint not_valid"><strong>Not a Valid Credit Card Number</strong></li>
               </ul>).html_safe
-        html << hidden_field_tag(name, value, rel: 'credit-card-type')
-        html << %Q(
-          <script>
-            $('input[rel=credit-card-type]').closest('form').find('input[name=#{field_name}]').keyup(CreditCardField.keyup);
-          </script>
-          ).html_safe if append_js
+        html << hidden_field_tag(name, value, rel: 'credit-card-type', data: options[:data])
         html
       end
     end

data/spec/dummy/app/views/credit_cards/new.html.erb

@@ -1,14 +1,14 @@
 <%= form_for @credit_card, html: {id: 'credit-card-form1'} do |f| %>
   <%= f.text_field :credit_card_no, id: 'card-no-1' %>
-  <%= f.credit_card_type_field :card_type %>  
+  <%= f.credit_card_type_field :card_type, data: {target: '#card-no-1'} %>  
 <% end %>
 
 <%= form_for @credit_card, html: {id: 'credit-card-form2'} do |f| %>
   <%= f.text_field :card_number, id: 'card-no-2' %>
-  <%= f.credit_card_type_field :card_type, card_number_field_name: 'card_number' %>  
+  <%= f.credit_card_type_field :card_type, data: {target: '#card-no-1'} %>  
 <% end %>
 
 <%= form_tag '', id: 'credit-card-form3' do %>
   <%= text_field_tag 'credit_card_no', '', id: 'card-no-3' %>
-  <%= credit_card_type_field_tag('credit_card_type') %>
+  <%= credit_card_type_field_tag('credit_card_type', data: {target: '#card-no-1'}) %>
 <% end %>

data/vendor/assets/javascripts/credit_card_type_field.js.coffee

@@ -13,11 +13,11 @@ class @CreditCardType
     return 'diners_club' if dinerCard.test(@card_number)
     'not_valid'
 
-window.CreditCardField = {
-  keyup: (e)->
+$ ->
+  target = $('input[rel=credit-card-type]').data('target')
+  $('input[rel=credit-card-type]').closest('form').find(target).keyup (e) ->
     cardType = new CreditCardType($(this).val()).cardType()
     form = $(this).closest('form')
     form.find(".credit-card-type li").removeClass('active')
     form.find(".credit-card-type .#{cardType}").addClass('active')
-    form.find('input[rel=credit-card-type]').val(cardType)
-}
+    form.find('input[rel=credit-card-type]').val(cardType)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_type_field
 version: !ruby/object:Gem::Version
-  version: '1.5'
+  version: '2.0'
 platform: ruby
 authors:
 - benzhang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-19 00:00:00.000000000 Z
+date: 2013-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake