credit_card_reader 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 25652666d81a1835bf29cd6a983a9fc322e2a1a9
-  data.tar.gz: cc701ab6c58564283892fa7d784c9d3d20aeb4ba
+  metadata.gz: 1794dfb54305bf2be7ec839bd9531a521fdd6f1d
+  data.tar.gz: 4eeeccdee89f446db658a4a51e4f8376edc37042
 SHA512:
-  metadata.gz: 6715549d6c7dabd68a6d173ccdc2664324700a14f26c19686ead07deccd833e4f080c00fa34adf97310e767b044db51a8dcb36aaec6458ebbaab2dbcfb190f3e
-  data.tar.gz: b008f056c54c073a10b527ff38f246d30cf6126f014aa58e1a1b96974f469f83044a34195a09068d24bdf15939d6c5785390dd2b43f64b0390acdb13519f80c5
+  metadata.gz: fa86b7f9f948a78b19c443bb1ad45d84a46ead76126561870e6bed99189bc7a8e9a58017967324b61afab5b7263d40280bc30223f279ed3371663f5dda9148b8
+  data.tar.gz: a9e94e6e859c40ae392c80529722c1e8ff784e5bddb39644651681b85d7ae9bd483da8acb4abdb36024fb0004786324fd66e64dfc3a21154906d46192939786b

data/Gemfile

@@ -1,6 +1,11 @@
 source 'https://rubygems.org'
 
+group :development do
+  gem 'pry'
+end
+
 group :test do
+  gem 'rspec', '~> 3.0'
   gem 'simplecov', require: false
   gem "codeclimate-test-reporter", require: nil
 end

data/credit_card_reader.gemspec

@@ -14,6 +14,5 @@ Gem::Specification.new do |s|
   s.files = `git ls-files`.split($/)
   s.require_paths = ['lib']
 
-  s.add_development_dependency "pry", "~> 0.10.0"
-  s.add_development_dependency 'rspec', '~> 3.0', '>= 3.0.0'
+  s.add_runtime_dependency "luhn-check", "~> 0.0.5"
 end

data/lib/credit_card_reader.rb

@@ -1,3 +1,5 @@
+require 'luhn'
+
 require 'credit_card_reader/detector'
 require 'credit_card_reader/result'
 require 'credit_card_reader/version'

data/lib/credit_card_reader/detector.rb

@@ -17,7 +17,8 @@ module CreditCardReader
     }
 
     def detect(number)
-      Result.new(brand: detect_brand(number))
+      valid = ::Luhn.valid?(number.to_i) # luhn-check gem requires Fixnum type
+      Result.new(number: number, brand: detect_brand(number), valid: valid)
     end
 
     private

data/lib/credit_card_reader/result.rb

@@ -1,9 +1,14 @@
 module CreditCardReader
   class Result
-    attr_reader :brand
+    attr_reader :brand, :valid
 
     def initialize(options)
       @brand = options[:brand]
+      @valid = options[:valid]
+    end
+
+    def valid?
+      valid
     end
   end
 end

data/lib/credit_card_reader/version.rb

@@ -1,6 +1,6 @@
 module CreditCardReader
   MAJOR = 0
   MINOR = 0
-  PATCH = 2
+  PATCH = 3
   VERSION = [MAJOR, MINOR, PATCH].join('.').freeze
 end

data/spec/credit_card_reader/detector_spec.rb

@@ -2,14 +2,14 @@ require 'spec_helper'
 
 describe CreditCardReader::Detector do
   describe "#detect" do
-    subject { described_class.new.detect(number) }
+    let(:detector) { described_class.new }
 
     shared_examples "a detect result" do |brand, number|
       context "with #{brand}" do
         let(:number) { number }
 
-        it { should be_a CreditCardReader::Result }
-        it { expect(subject.brand).to eq brand }
+        it { expect(detector.detect(number)).to be_a CreditCardReader::Result }
+        it { expect(detector.detect(number).brand).to eq brand }
       end
     end
 

data/spec/credit_card_reader/result_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe CreditCardReader::Result do
+  describe "#valid?" do
+    it "returns true with valid is true" do
+      result = described_class.new(brand: "brand", valid: true)
+
+      expect(result.valid?).to be_truthy
+    end
+
+    it "returns false with valid is false" do
+      result = described_class.new(brand: "brand", valid: false)
+
+      expect(result.valid?).to be_falsey
+    end
+  end
+end

metadata

@@ -1,49 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: credit_card_reader
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Masahiro Saito
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-03 00:00:00.000000000 Z
+date: 2015-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: luhn-check
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.0
-  type: :development
+        version: 0.0.5
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.0
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.0.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 0.0.5
 description: Detect credit card information
 email:
 - camelmasa@gmail.com
@@ -62,6 +42,7 @@ files:
 - lib/credit_card_reader/result.rb
 - lib/credit_card_reader/version.rb
 - spec/credit_card_reader/detector_spec.rb
+- spec/credit_card_reader/result_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/camelmasa/credit_card_reader
 licenses: